coreboot-gerrit January 2021

coreboot-gerrit@coreboot.org

1 participants
6507 discussions

Change in coreboot[master]: mb/clevo/cml-u: Rework Kconfig
by Felix Singer (Code Review) 05 Jan '21

05 Jan '21

Hello build bot (Jenkins), Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/49025 to look at the new patch set (#5). Change subject: mb/clevo/cml-u: Rework Kconfig ...................................................................... mb/clevo/cml-u: Rework Kconfig Rework Kconfig file so that each variant has its own config option with their specific selects / configuration and move common selects to a seperate config option, which is used as base for each variant. Built clevo/l140cu with BUILD_TIMELESS=1, coreboot.rom remains the same. Change-Id: I1f5b6f535597149f28dd8c8322acc2e988f11505 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/clevo/cml-u/Kconfig M src/mainboard/clevo/cml-u/Kconfig.name 2 files changed, 11 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/49025/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/49025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f5b6f535597149f28dd8c8322acc2e988f11505 Gerrit-Change-Number: 49025 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/clevo/l140cu: Add vboot support
by Michael Niewöhner (Code Review) 05 Jan '21

05 Jan '21

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46602 ) Change subject: mb/clevo/l140cu: Add vboot support ...................................................................... Patch Set 6: (2 comments) https://review.coreboot.org/c/coreboot/+/46602/5//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/46602/5//COMMIT_MSG@15 PS5, Line 15: the filenames look odd to me: - vboot-ro is ok - vboot-roa should be vboot-ro-rwa - vboot-roab should be vboot-ro-rwab if you don't agree, just mark as resolved https://review.coreboot.org/c/coreboot/+/46602/5/src/mainboard/clevo/cml-u/… File src/mainboard/clevo/cml-u/variants/l140cu/fmds/vboot-roab.fmd: https://review.coreboot.org/c/coreboot/+/46602/5/src/mainboard/clevo/cml-u/… PS5, Line 33: COREBOOT(CBFS) 0xc00000-0x3df000-0x3df000-0x82000-0x4000-0x800-0x40-0x7c0-0xef000 = 0x2cc000 FW_MAIN_A(CBFS) and FW_MAIN_B(CBFS) are 0x3befc0 shouldn't they be equal? -- To view, visit https://review.coreboot.org/c/coreboot/+/46602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibb5e93eb55ece5b0e0d91b1a374d33e259c65cac Gerrit-Change-Number: 46602 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 05 Jan 2021 01:14:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/intel: add PC10 residency counter MSR
by Nico Huber (Code Review) 05 Jan '21

05 Jan '21

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49044 ) Change subject: cpu/intel: add PC10 residency counter MSR ...................................................................... Patch Set 2: > The PC10 residency MSR is not generic,it will not apply for generation before glodmont, and start from 4th gene in core. Also not supported yet in xeon yet. But the implemented here seems okay. What kind of Xeon do you mean? -- To view, visit https://review.coreboot.org/c/coreboot/+/49044 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6f74861502d4a9f872b2bbbab2e5f1925a14c4d Gerrit-Change-Number: 49044 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jan 2021 00:53:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/siemens/chili: Rework Kconfig
by Felix Singer (Code Review) 05 Jan '21

05 Jan '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49063 ) Change subject: mb/siemens/chili: Rework Kconfig ...................................................................... mb/siemens/chili: Rework Kconfig Rework Kconfig file so that each variant has its own config option with their specific selects / configuration and move common selects to a seperate config option, which is used as base for each variant. Built chili/base with BUILD_TIMELESS=1, coreboot.rom remains the same. Change-Id: I5e2a09db80232457b2f78ad9b100c468d281f753 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/siemens/chili/Kconfig M src/mainboard/siemens/chili/Kconfig.name 2 files changed, 20 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/49063/1 diff --git a/src/mainboard/siemens/chili/Kconfig b/src/mainboard/siemens/chili/Kconfig index fda571d..10133d0 100644 --- a/src/mainboard/siemens/chili/Kconfig +++ b/src/mainboard/siemens/chili/Kconfig @@ -1,29 +1,37 @@ # SPDX-License-Identifier: GPL-2.0-only -if BOARD_SIEMENS_CHILI_BASE || BOARD_SIEMENS_CHILI_CHILI - -config BOARD_SPECIFIC_OPTIONS - def_bool y +config BOARD_SIEMENS_CHILI_COMMON + def_bool n select BOARD_ROMSIZE_KB_32768 select DRIVERS_I2C_GENERIC select DRIVERS_I2C_HID - select DRIVERS_I2C_LM96000 if BOARD_SIEMENS_CHILI_CHILI - select DRIVERS_UART_8250IO if BOARD_SIEMENS_CHILI_BASE select EC_ACPI select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE select INTEL_GMA_HAVE_VBT - select INTEL_LPSS_UART_FOR_CONSOLE if BOARD_SIEMENS_CHILI_CHILI select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_LPC_TPM select MAINBOARD_HAS_TPM2 select MAINBOARD_USES_IFD_GBE_REGION - select SMBIOS_PROVIDED_BY_MOBO if BOARD_SIEMENS_CHILI_CHILI select SOC_INTEL_CANNONLAKE_PCH_H select SOC_INTEL_COFFEELAKE - select SOC_INTEL_COMMON_BLOCK_HDA_VERB if BOARD_SIEMENS_CHILI_CHILI - select SECUNET_DMI if BOARD_SIEMENS_CHILI_CHILI + +config BOARD_SIEMENS_CHILI_BASE_OPTIONS + bool + select BOARD_SIEMENS_CHILI_COMMON + select DRIVERS_UART_8250IO + +config BOARD_SIEMENS_CHILI_CHILI_OPTIONS + bool + select BOARD_SIEMENS_CHILI_COMMON + select DRIVERS_I2C_LM96000 + select INTEL_LPSS_UART_FOR_CONSOLE + select SMBIOS_PROVIDED_BY_MOBO + select SOC_INTEL_COMMON_BLOCK_HDA_VERB + select SECUNET_DMI + +if BOARD_SIEMENS_CHILI_COMMON config MAINBOARD_DIR string diff --git a/src/mainboard/siemens/chili/Kconfig.name b/src/mainboard/siemens/chili/Kconfig.name index ac4e31e..1c8dab5 100644 --- a/src/mainboard/siemens/chili/Kconfig.name +++ b/src/mainboard/siemens/chili/Kconfig.name @@ -4,6 +4,8 @@ config BOARD_SIEMENS_CHILI_BASE bool "-> Base board" + select BOARD_SIEMENS_CHILI_BASE_OPTIONS config BOARD_SIEMENS_CHILI_CHILI bool "-> Chili (AiO)" + select BOARD_SIEMENS_CHILI_CHILI_OPTIONS -- To view, visit https://review.coreboot.org/c/coreboot/+/49063 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e2a09db80232457b2f78ad9b100c468d281f753 Gerrit-Change-Number: 49063 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

3 4

Change in coreboot[master]: mb/kontron/bsl6: Rework Kconfig
by Felix Singer (Code Review) 05 Jan '21

05 Jan '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49061 ) Change subject: mb/kontron/bsl6: Rework Kconfig ...................................................................... mb/kontron/bsl6: Rework Kconfig Rework Kconfig file so that each variant has its own config option with their specific selects / configuration and move common selects to a seperate config option, which is used as base for each variant. Built kontron/boxer26 with BUILD_TIMELESS=1, coreboot.rom remains the same. Change-Id: I08bd68aa2f98f93b8c5daf1ab2f3c1bbce521c53 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/kontron/bsl6/Kconfig M src/mainboard/kontron/bsl6/Kconfig.name 2 files changed, 17 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/49061/1 diff --git a/src/mainboard/kontron/bsl6/Kconfig b/src/mainboard/kontron/bsl6/Kconfig index 437c5a3..fd52d3e 100644 --- a/src/mainboard/kontron/bsl6/Kconfig +++ b/src/mainboard/kontron/bsl6/Kconfig @@ -1,15 +1,12 @@ # SPDX-License-Identifier: GPL-2.0-only -if BOARD_KONTRON_BSL6 || BOARD_SIEMENS_BOXER26 - -config BOARD_SPECIFIC_OPTIONS - def_bool y +config BOARD_KONTRON_BSL6_COMMON + def_bool n select BOARD_ROMSIZE_KB_16384 select SOC_INTEL_SKYLAKE select SKYLAKE_SOC_PCH_H select EXCLUDE_NATIVE_SD_INTERFACE select NO_FADT_8042 - select HAVE_ACPI_RESUME if BOARD_KONTRON_BSL6 select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT @@ -17,8 +14,19 @@ select EC_KONTRON_KEMPLD select MAINBOARD_HAS_LIBGFXINIT select DRIVERS_I2C_NCT7802Y - select DRIVERS_I2C_LM96000 if BOARD_SIEMENS_BOXER26 - select SECUNET_DMI if BOARD_SIEMENS_BOXER26 + +config BOARD_KONTRON_BSL6_OPTIONS + bool + select BOARD_KONTRON_BSL6_COMMON + select HAVE_ACPI_RESUME + +config BOARD_KONTRON_BOXER26_OPTIONS + bool + select BOARD_KONTRON_BSL6_COMMON + select DRIVERS_I2C_LM96000 + select SECUNET_DMI + +if BOARD_KONTRON_BSL6_COMMON config MAINBOARD_DIR string diff --git a/src/mainboard/kontron/bsl6/Kconfig.name b/src/mainboard/kontron/bsl6/Kconfig.name index 0f0577e..90bf1c4 100644 --- a/src/mainboard/kontron/bsl6/Kconfig.name +++ b/src/mainboard/kontron/bsl6/Kconfig.name @@ -1,5 +1,7 @@ config BOARD_KONTRON_BSL6 bool "COMe-bSL6" + select BOARD_KONTRON_BSL6_OPTIONS config BOARD_SIEMENS_BOXER26 bool "COMe-bSL6 on Siemens/Boxer26" + select BOARD_KONTRON_BOXER26_OPTIONS -- To view, visit https://review.coreboot.org/c/coreboot/+/49061 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I08bd68aa2f98f93b8c5daf1ab2f3c1bbce521c53 Gerrit-Change-Number: 49061 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

2 2

Change in coreboot[master]: mb/clevo/l140cu: Move FSP-M config hook to mainboard level
by Michael Niewöhner (Code Review) 05 Jan '21

05 Jan '21

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49077 ) Change subject: mb/clevo/l140cu: Move FSP-M config hook to mainboard level ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/c/coreboot/+/49077/4/src/mainboard/clevo/cml-u/… File src/mainboard/clevo/cml-u/romstage.c: https://review.coreboot.org/c/coreboot/+/49077/4/src/mainboard/clevo/cml-u/… PS4, Line 6: ry_init_params(FSPM_UPD *memupd) : { : variant_configure_fspm(memupd); : } : do we really want to create this redirection hell before it's really needed? as long as we have no code that runs for all variants in cml-u/romstage.c it doesn't hurt to have a romstage.c for each variant -- To view, visit https://review.coreboot.org/c/coreboot/+/49077 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic161f83cb629b1e70ca670e10975a25bc0949656 Gerrit-Change-Number: 49077 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jan 2021 00:11:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/clevo/cml-u: Rework Kconfig
by Felix Singer (Code Review) 05 Jan '21

05 Jan '21

Hello build bot (Jenkins), Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/49025 to look at the new patch set (#4). Change subject: mb/clevo/cml-u: Rework Kconfig ...................................................................... mb/clevo/cml-u: Rework Kconfig Rework Kconfig file so that each variant has its own config option with their specific selects / configuration and move common selects to a seperate config option, which is used as base for each variant. Built clevo/l140cu with BUILD_TIMELESS=1, coreboot.rom remains the same. Change-Id: I1f5b6f535597149f28dd8c8322acc2e988f11505 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/clevo/cml-u/Kconfig M src/mainboard/clevo/cml-u/Kconfig.name 2 files changed, 11 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/49025/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/49025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f5b6f535597149f28dd8c8322acc2e988f11505 Gerrit-Change-Number: 49025 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/clevo/l140cu: Add vboot support
by Felix Singer (Code Review) 05 Jan '21

05 Jan '21

Hello build bot (Jenkins), Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/46602 to look at the new patch set (#6). Change subject: mb/clevo/l140cu: Add vboot support ...................................................................... mb/clevo/l140cu: Add vboot support Add proper vboot configuration and add fmap files for the following partition schemes: * read-only * read-only + updateable A partition * read-only + updateable A/B partition All partition schemes were tested and are working. Change-Id: Ibb5e93eb55ece5b0e0d91b1a374d33e259c65cac Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/clevo/cml-u/Kconfig A src/mainboard/clevo/cml-u/variants/l140cu/fmds/vboot-ro.fmd A src/mainboard/clevo/cml-u/variants/l140cu/fmds/vboot-roa.fmd A src/mainboard/clevo/cml-u/variants/l140cu/fmds/vboot-roab.fmd 4 files changed, 108 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/46602/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/46602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibb5e93eb55ece5b0e0d91b1a374d33e259c65cac Gerrit-Change-Number: 46602 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/kontron/mal10: Remove unnecessary includes
by Felix Singer (Code Review) 05 Jan '21

05 Jan '21

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48144 ) Change subject: mb/kontron/mal10: Remove unnecessary includes ...................................................................... mb/kontron/mal10: Remove unnecessary includes Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: Ibc6833d9256800d0e50651cac18a4e81ddbe6895 --- M src/mainboard/kontron/mal10/ramstage.c M src/mainboard/kontron/mal10/romstage.c 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/48144/1 diff --git a/src/mainboard/kontron/mal10/ramstage.c b/src/mainboard/kontron/mal10/ramstage.c index 87ead15..f03006a 100644 --- a/src/mainboard/kontron/mal10/ramstage.c +++ b/src/mainboard/kontron/mal10/ramstage.c @@ -3,7 +3,6 @@ #include <device/device.h> #include <soc/ramstage.h> #include <carrier/gpio.h> -#include <stddef.h> static void init_mainboard(void *chip_info) { diff --git a/src/mainboard/kontron/mal10/romstage.c b/src/mainboard/kontron/mal10/romstage.c index 9f1d7eb..dba78f7 100644 --- a/src/mainboard/kontron/mal10/romstage.c +++ b/src/mainboard/kontron/mal10/romstage.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <string.h> #include <soc/romstage.h> #include <FspmUpd.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/48144 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc6833d9256800d0e50651cac18a4e81ddbe6895 Gerrit-Change-Number: 48144 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

3 10

Change in coreboot[master]: mb/system76/oryp5: Add System76 Oryx Pro 5
by Tim Crawford (Code Review) 05 Jan '21

05 Jan '21

Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47892 ) Change subject: mb/system76/oryp5: Add System76 Oryx Pro 5 ...................................................................... Patch Set 5: (3 comments) https://review.coreboot.org/c/coreboot/+/47892/2/src/mainboard/system76/ory… File src/mainboard/system76/oryp5/devicetree.cb: https://review.coreboot.org/c/coreboot/+/47892/2/src/mainboard/system76/ory… PS2, Line 26: register "SaGv" = "SaGv_Enabled" > I'm not sure if this has any effect on Halo What's Halo? Is there a way I can verify that? https://review.coreboot.org/c/coreboot/+/47892/3/src/mainboard/system76/ory… File src/mainboard/system76/oryp5/devicetree.cb: https://review.coreboot.org/c/coreboot/+/47892/3/src/mainboard/system76/ory… PS3, Line 87: subsystemid 0x1558 0x95e6 inherit > Values in static.c are correct. […] FSP integration guide only lists the registers with abbreviated names. Passing a custom SiSsidTablePtr prevents FSP from writing the default values (this is explained much better in the TGL guide). https://review.coreboot.org/c/coreboot/+/47892/2/src/mainboard/system76/ory… File src/mainboard/system76/oryp5/hda_verb.c: https://review.coreboot.org/c/coreboot/+/47892/2/src/mainboard/system76/ory… PS2, Line 25: // Enable DMIC microphone on ALC1220 : 0x02050036, : 0x02042a6a, > What does the microphone have to do with beep? Jeremy got these magic numbers from the Windows driver, and putting them here happens to make the DMIC work. So I suppose just convenience? There seems to be several boards doing this (using pc_beep_verbs for init verbs). -- To view, visit https://review.coreboot.org/c/coreboot/+/47892 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iae6e530dcd52df3642cdfe74b65bfff5aa0dd402 Gerrit-Change-Number: 47892 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 04 Jan 2021 23:51:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Tim Crawford <tcrawford(a)system76.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2021