Hello build bot (Jenkins), Martin Roth, Patrick Georgi, Caveh Jalali, Tim Wawrzynczak, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48948
to look at the new patch set (#6).
Change subject: mb/google/volteer: Copano: Update SPD table
......................................................................
mb/google/volteer: Copano: Update SPD table
Add memory table to "mem_list_variant.txt", and command to generate files:
go run ./util/spd_tools/lp4x/gen_part_id.go src/soc/intel/tigerlake/spd src/mainboard/google/volteer/variants/copano/memory/ src/mainboard/google/volteer/variants/copano/memory/mem_list_variant.txt
DRAM Part Name ID to assign
MT53D512M64D4NW-046 WT:F 0 (0000)
H9HCNNNCRMBLPR-NEE 0 (0000)
MT53D1G64D4NW-046 WT:A 1 (0001)
H9HCNNNFBMBLPR-NEE 2 (0010)
BUG=b:175896481
firmware-volteer-13672.B-main
TEST=emerge-volteer coreboot
Signed-off-by: hao_chou <hao_chou(a)pegatron.corp-partner.google.com>
Change-Id: I2ace17e8fff12d3f5de15a35f609265d8b6ed6b2
---
A src/mainboard/google/volteer/variants/copano/Makefile.inc
A src/mainboard/google/volteer/variants/copano/memory.c
M src/mainboard/google/volteer/variants/copano/memory/Makefile.inc
M src/mainboard/google/volteer/variants/copano/memory/dram_id.generated.txt
M src/mainboard/google/volteer/variants/copano/memory/mem_list_variant.txt
5 files changed, 71 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/48948/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/48948
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ace17e8fff12d3f5de15a35f609265d8b6ed6b2
Gerrit-Change-Number: 48948
Gerrit-PatchSet: 6
Gerrit-Owner: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Hao Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48951 )
Change subject: mb/google/volteer: Add GPIO to copano support
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48951/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48951/5//COMMIT_MSG@12
PS5, Line 12: BRANCH=none
> BRANCH=firmware-volteer-13672. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/48951
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e0f730c9865ed77c7071245b071315a9c6ea4c8
Gerrit-Change-Number: 48951
Gerrit-PatchSet: 6
Gerrit-Owner: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 05 Jan 2021 09:02:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-MessageType: comment
Hello build bot (Jenkins), Martin Roth, Patrick Georgi, Caveh Jalali, Tim Wawrzynczak, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48951
to look at the new patch set (#6).
Change subject: mb/google/volteer: Add GPIO to copano support
......................................................................
mb/google/volteer: Add GPIO to copano support
Add support for gpio driver for copano
BUG=b:175896481
BRANCH=firmware-volteer-13672.B-main
TEST=emerge-volteer coreboot
Signed-off-by: hao_chou <hao_chou(a)pegatron.corp-partner.google.com>
Change-Id: I1e0f730c9865ed77c7071245b071315a9c6ea4c8
---
M src/mainboard/google/volteer/variants/copano/Makefile.inc
A src/mainboard/google/volteer/variants/copano/gpio.c
2 files changed, 233 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/48951/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/48951
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e0f730c9865ed77c7071245b071315a9c6ea4c8
Gerrit-Change-Number: 48951
Gerrit-PatchSet: 6
Gerrit-Owner: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), Martin Roth, Patrick Georgi, Caveh Jalali, Tim Wawrzynczak, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48948
to look at the new patch set (#5).
Change subject: mb/google/volteer: Copano: Update SPD table
......................................................................
mb/google/volteer: Copano: Update SPD table
Add memory table to "mem_list_variant.txt", and command to generate files:
go run ./util/spd_tools/lp4x/gen_part_id.go src/soc/intel/tigerlake/spd src/mainboard/google/volteer/variants/copano/memory/ src/mainboard/google/volteer/variants/copano/memory/mem_list_variant.txt
DRAM Part Name ID to assign
MT53D512M64D4NW-046 WT:F 0 (0000)
H9HCNNNCRMBLPR-NEE 0 (0000)
MT53D1G64D4NW-046 WT:A 1 (0001)
H9HCNNNFBMBLPR-NEE 2 (0010)
BUG=b:175896481
BRANCH=firmware-volteer-13672.B-main
TEST=emerge-volteer coreboot
Signed-off-by: hao_chou <hao_chou(a)pegatron.corp-partner.google.com>
Change-Id: I2ace17e8fff12d3f5de15a35f609265d8b6ed6b2
---
A src/mainboard/google/volteer/variants/copano/Makefile.inc
A src/mainboard/google/volteer/variants/copano/memory.c
M src/mainboard/google/volteer/variants/copano/memory/Makefile.inc
M src/mainboard/google/volteer/variants/copano/memory/dram_id.generated.txt
M src/mainboard/google/volteer/variants/copano/memory/mem_list_variant.txt
5 files changed, 71 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/48948/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/48948
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ace17e8fff12d3f5de15a35f609265d8b6ed6b2
Gerrit-Change-Number: 48948
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), Patrick Georgi, Caveh Jalali, Tim Wawrzynczak, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48952
to look at the new patch set (#5).
Change subject: mb/google/volteer: Update copano device tree
......................................................................
mb/google/volteer: Update copano device tree
Update device tree override to match schematics.
BUG=b:175896481
BRANCH=firmware-volteer-13672.B-main
TEST=emerge-volteer coreboot
Signed-off-by: hao_chou <hao_chou(a)pegatron.corp-partner.google.com>
Change-Id: I1fb006d750bb2d670885ec8ccc627436c5078072
---
M src/mainboard/google/volteer/variants/copano/overridetree.cb
1 file changed, 207 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/48952/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/48952
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1fb006d750bb2d670885ec8ccc627436c5078072
Gerrit-Change-Number: 48952
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Hao Chou <hao_chou(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48799 )
Change subject: soc/intel/apl,mb/*: move LPC/eSPI pad configuration to boards
......................................................................
Patch Set 9: Code-Review+1
I have tested the patch on mc_apl5 and it looks good to me.
--
To view, visit https://review.coreboot.org/c/coreboot/+/48799
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I61717d9ddc57b174c6a2e31f950c22ad0b276f5d
Gerrit-Change-Number: 48799
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Tue, 05 Jan 2021 08:35:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48670 )
Change subject: [UNTESTED] mb/ocp/tiogapass: correct "POST complete" pad initial value
......................................................................
Patch Set 18:
> Patch Set 18: Code-Review+1
>
> The GPIO can be pulled low
I meant to say CB:48671 can pull low the GPIO, this change can initialize it to high.
--
To view, visit https://review.coreboot.org/c/coreboot/+/48670
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I82fbda1caba9163ba3b2e38f494a0cefa27e657f
Gerrit-Change-Number: 48670
Gerrit-PatchSet: 18
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jingle Hsu <jingle_hsu(a)wiwynn.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 05 Jan 2021 08:11:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48671 )
Change subject: [UNTESTED] mb/ocp/tiogapass: replace "POST complete" mb code with driver functionality
......................................................................
Patch Set 18: Code-Review+1
The GPIO can be pulled low
--
To view, visit https://review.coreboot.org/c/coreboot/+/48671
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7503dec4e72810db8dfe74f72638b466a3d66748
Gerrit-Change-Number: 48671
Gerrit-PatchSet: 18
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jingle Hsu <jingle_hsu(a)wiwynn.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 05 Jan 2021 08:07:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment