Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49345 )
Change subject: mb/google/octopus/Kconfig: Remove space saving options
......................................................................
mb/google/octopus/Kconfig: Remove space saving options
28e61f "device: Use __pci_0_00_0_config in config_of_soc()"
significantly reduced the size of the bootblock. This make the space
saving options, required to make to bootblock fit in the 32K SOC
limit, unnecessary.
TESTED: with configs/config.google_octopus_spi_flash_console the .text
size is 0x29c8 bytes which is still well below the 0x8000 SOC limit.
Change-Id: I208211d30cc2805113a16a02cdab957b8c584c92
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/mainboard/google/octopus/Kconfig
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/49345/1
diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig
index 7e8e277..355cf0b 100644
--- a/src/mainboard/google/octopus/Kconfig
+++ b/src/mainboard/google/octopus/Kconfig
@@ -25,8 +25,6 @@
select MAINBOARD_HAS_TPM2
select GOOGLE_SMBIOS_MAINBOARD_VERSION
select NO_BOOTBLOCK_CONSOLE
- select NO_FMAP_CACHE
- select NO_CBFS_MCACHE
if BOARD_GOOGLE_BASEBOARD_OCTOPUS
--
To view, visit https://review.coreboot.org/c/coreboot/+/49345
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I208211d30cc2805113a16a02cdab957b8c584c92
Gerrit-Change-Number: 49345
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newchange
Attention is currently required from: Nico Huber, Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49291 )
Change subject: soc/intel/adl: Add new Kconfig ENABLE_DISPLAY_OVER_DGPU for ADLRVP with DG
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/intel/adlrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/49291/comment/0482267b_eb43ef24
PS2, Line 192: #if CONFIG(ENABLE_DISPLAY_OVER_DGPU)
> I don't think this works as you intend it to. Are you really seeing device . […]
Hah, it would be nice if it worked, but these are just comments in the devicetree 😉
File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/49291/comment/86b1daf8_11b0a199
PS2, Line 247: def_bool n
This doesn't have a prompt.
--
To view, visit https://review.coreboot.org/c/coreboot/+/49291
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibbe9c8c4d77018de83815d7d203284b1fbc0da58
Gerrit-Change-Number: 49291
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Tue, 12 Jan 2021 09:22:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Gerrit-MessageType: comment