coreboot-gerrit January 2021

coreboot-gerrit@coreboot.org

1 participants
6504 discussions

Change in coreboot[master]: nb/intel/sandybridge: Remove wrong and nonsense condition
by Nico Huber (Code Review) 12 Jan '21

12 Jan '21

Attention is currently required from: Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49318 ) Change subject: nb/intel/sandybridge: Remove wrong and nonsense condition ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/49318/comment/e7858d18_7712bff6 PS1, Line 10: comment that says the opposite My fall-back interpretation of the comment was that it applies if all `pi_coding` are non-negative (then `cmd_delay == 0`). -- To view, visit https://review.coreboot.org/c/coreboot/+/49318 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I509f0f6304bfb3e033c0c3ecd1dd5c9645e004b2 Gerrit-Change-Number: 49318 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 12 Jan 2021 11:46:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86: Use wildcard for mb/smihandler.c
by Kyösti Mälkki (Code Review) 12 Jan '21

12 Jan '21

Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/49247 to look at the new patch set (#4). Change subject: arch/x86: Use wildcard for mb/smihandler.c ...................................................................... arch/x86: Use wildcard for mb/smihandler.c Change-Id: I306f8cd74af62c0cd30f445d20c47f774f122481 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/arch/x86/Makefile.inc M src/mainboard/dell/optiplex_9010/Makefile.inc M src/mainboard/google/auron/Makefile.inc M src/mainboard/google/beltino/Makefile.inc M src/mainboard/google/brya/Makefile.inc M src/mainboard/google/butterfly/Makefile.inc R src/mainboard/google/butterfly/smihandler.c M src/mainboard/google/cyan/Makefile.inc M src/mainboard/google/dedede/Makefile.inc M src/mainboard/google/deltaur/Makefile.inc M src/mainboard/google/drallion/Makefile.inc M src/mainboard/google/eve/Makefile.inc M src/mainboard/google/fizz/Makefile.inc M src/mainboard/google/glados/Makefile.inc M src/mainboard/google/hatch/Makefile.inc M src/mainboard/google/jecht/Makefile.inc M src/mainboard/google/kahlee/Makefile.inc M src/mainboard/google/link/Makefile.inc R src/mainboard/google/link/smihandler.c M src/mainboard/google/octopus/Makefile.inc M src/mainboard/google/poppy/Makefile.inc M src/mainboard/google/rambi/Makefile.inc R src/mainboard/google/rambi/smihandler.c M src/mainboard/google/reef/Makefile.inc M src/mainboard/google/sarien/Makefile.inc M src/mainboard/google/slippy/Makefile.inc M src/mainboard/google/stout/Makefile.inc R src/mainboard/google/stout/smihandler.c M src/mainboard/google/volteer/Makefile.inc M src/mainboard/google/zork/Makefile.inc M src/mainboard/hp/pavilion_m6_1035dx/Makefile.inc R src/mainboard/hp/pavilion_m6_1035dx/smihandler.c M src/mainboard/intel/adlrvp/Makefile.inc M src/mainboard/intel/baskingridge/Makefile.inc R src/mainboard/intel/baskingridge/smihandler.c D src/mainboard/intel/coffeelake_rvp/Makefile.inc M src/mainboard/intel/dcp847ske/Makefile.inc M src/mainboard/intel/glkrvp/Makefile.inc M src/mainboard/intel/jasperlake_rvp/Makefile.inc M src/mainboard/intel/kblrvp/Makefile.inc M src/mainboard/intel/kunimitsu/Makefile.inc M src/mainboard/intel/strago/Makefile.inc M src/mainboard/intel/tglrvp/Makefile.inc M src/mainboard/lenovo/g505s/Makefile.inc R src/mainboard/lenovo/g505s/smihandler.c M src/mainboard/lenovo/l520/Makefile.inc M src/mainboard/lenovo/s230u/Makefile.inc M src/mainboard/lenovo/t410/Makefile.inc M src/mainboard/lenovo/t420/Makefile.inc M src/mainboard/lenovo/t420s/Makefile.inc M src/mainboard/lenovo/t430/Makefile.inc M src/mainboard/lenovo/t430s/Makefile.inc M src/mainboard/lenovo/t440p/Makefile.inc M src/mainboard/lenovo/t520/Makefile.inc M src/mainboard/lenovo/t530/Makefile.inc M src/mainboard/lenovo/x1_carbon_gen1/Makefile.inc M src/mainboard/lenovo/x201/Makefile.inc M src/mainboard/lenovo/x220/Makefile.inc M src/mainboard/lenovo/x230/Makefile.inc M src/mainboard/packardbell/ms2290/Makefile.inc 60 files changed, 3 insertions(+), 100 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/49247/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/49247 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I306f8cd74af62c0cd30f445d20c47f774f122481 Gerrit-Change-Number: 49247 Gerrit-PatchSet: 4 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: ACPI: Move common GNVS fields
by Kyösti Mälkki (Code Review) 12 Jan '21

12 Jan '21

Attention is currently required from: Damien Zammit, Kyösti Mälkki, Alexander Couzens, Patrick Rudolph. Hello build bot (Jenkins), Damien Zammit, Angel Pons, Alexander Couzens, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/49273 to look at the new patch set (#2). Change subject: ACPI: Move common GNVS fields ...................................................................... ACPI: Move common GNVS fields Change-Id: Ib5f06416b23196b7227ccd5814162925c31c084b Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/cpu/x86/mp_init.c M src/mainboard/acer/g43t-am3/acpi_tables.c M src/mainboard/asus/p5qc/acpi_tables.c M src/mainboard/asus/p5ql-em/acpi_tables.c M src/mainboard/emulation/qemu-q35/acpi_tables.c M src/mainboard/gigabyte/ga-g41m-es2l/acpi_tables.c M src/mainboard/intel/dg43gt/acpi_tables.c M src/mainboard/lenovo/t400/acpi_tables.c M src/mainboard/lenovo/x200/acpi_tables.c M src/mainboard/roda/rk9/acpi_tables.c M src/southbridge/intel/bd82x6x/lpc.c M src/southbridge/intel/i82801gx/lpc.c M src/southbridge/intel/ibexpeak/lpc.c M src/southbridge/intel/lynxpoint/lpc.c 14 files changed, 4 insertions(+), 50 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/49273/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/49273 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib5f06416b23196b7227ccd5814162925c31c084b Gerrit-Change-Number: 49273 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Damien Zammit Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mainboards: Drop GNVS cmap and cmbp
by Kyösti Mälkki (Code Review) 12 Jan '21

12 Jan '21

Attention is currently required from: Damien Zammit, Evgeny Zinoviev, Alexander Couzens, Patrick Rudolph. Hello build bot (Jenkins), Patrick Georgi, Damien Zammit, Angel Pons, Evgeny Zinoviev, Alexander Couzens, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/49274 to look at the new patch set (#2). Change subject: mainboards: Drop GNVS cmap and cmbp ...................................................................... mainboards: Drop GNVS cmap and cmbp Functionality depends of CMAP and CMBP references inside board specific ASL implementation. Only roda/rk9 and roda/rk886ex has that. Change-Id: I4da8292375cb589d67dc68496b1e81971bc2a61f Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- D src/mainboard/apple/macbook21/acpi_tables.c M src/mainboard/asrock/g41c-gs/acpi_tables.c M src/mainboard/asus/p5qc/acpi_tables.c M src/mainboard/asus/p5ql-em/acpi_tables.c M src/mainboard/asus/p5qpl-am/acpi_tables.c M src/mainboard/emulation/qemu-q35/acpi_tables.c M src/mainboard/foxconn/g41s-k/acpi_tables.c M src/mainboard/getac/p470/acpi_tables.c M src/mainboard/gigabyte/ga-g41m-es2l/acpi_tables.c D src/mainboard/ibase/mb899/acpi_tables.c M src/mainboard/intel/dg41wv/acpi_tables.c M src/mainboard/intel/dg43gt/acpi_tables.c D src/mainboard/kontron/986lcd-m/acpi_tables.c M src/mainboard/lenovo/t400/acpi_tables.c M src/mainboard/lenovo/t60/acpi_tables.c M src/mainboard/lenovo/thinkcentre_a58/acpi_tables.c M src/mainboard/lenovo/x200/acpi_tables.c M src/mainboard/lenovo/x60/acpi_tables.c 18 files changed, 0 insertions(+), 83 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/49274/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/49274 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4da8292375cb589d67dc68496b1e81971bc2a61f Gerrit-Change-Number: 49274 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Damien Zammit Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: nb/intel/sandybridge: Fix programming command timings
by Nico Huber (Code Review) 12 Jan '21

12 Jan '21

Attention is currently required from: Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49287 ) Change subject: nb/intel/sandybridge: Fix programming command timings ...................................................................... Patch Set 1: (1 comment) File src/northbridge/intel/sandybridge/raminit_common.c: https://review.coreboot.org/c/coreboot/+/49287/comment/697c5b43_ee5d66fd PS1, Line 939: /* : * Compute command phase shift as the most negative CCC setting : * across all ranks. Use zero if none of the values is negative. : */ : FOR_ALL_POPULATED_RANKS { : cmd_delay = MAX(cmd_delay, -ctrl->timings[channel][slotrank].pi_coding); : } : > The `if (cmd_delay == 0) {` check is nonsense, and clock needs to be offset by `ctrl->pi_code_offset […] Those two differences were also my conclusion. I wasn't sure though, as I was staring at the code for over an hour before I figured that out (not just this change, but I also wanted to be sure what changed since the original code). -- To view, visit https://review.coreboot.org/c/coreboot/+/49287 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I33b2271803e6fa3d8e625bfe5a830152cab2b9d4 Gerrit-Change-Number: 49287 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 12 Jan 2021 11:36:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/boten: Update gpio config for boten
by Stanley Wu (Code Review) 12 Jan '21

12 Jan '21

Attention is currently required from: Henry Sun, Paul Menzel, Karthik Ramasubramanian. Stanley Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49348 ) Change subject: mb/google/dedede/var/boten: Update gpio config for boten ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/49348/comment/9489e79b_7708a4cc PS1, Line 7: mb/google/dedede/var/boten: Update gpio config for boten. > Please remove the dot/period at the end of the commit message summary. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/49348 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf25674efa2336bde98c5abaff278484fd71ea8b Gerrit-Change-Number: 49348 Gerrit-PatchSet: 2 Gerrit-Owner: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Allen Cheng <allen.cheng(a)lcfc.corp-partner.google.com> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Peichao Wang <pwang12(a)lenovo.corp-partner.google.com> Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com> Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 12 Jan 2021 11:26:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/boten: Update gpio config for boten
by Stanley Wu (Code Review) 12 Jan '21

12 Jan '21

Attention is currently required from: Henry Sun, Stanley Wu, Karthik Ramasubramanian. Hello build bot (Jenkins), Henry Sun, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/49348 to look at the new patch set (#2). Change subject: mb/google/dedede/var/boten: Update gpio config for boten ...................................................................... mb/google/dedede/var/boten: Update gpio config for boten Correct GPIO settings as below reason: 1. GPP_G7 not being used but set to NF. 2. GPP_B7 should configure as WWAN SAR detect ODL, but set to NC 3. GPP_C22 and GPP_C23 is set to NC but internal pull down to 20K BUG=b:177283756 BRANCH=dedede TEST=emerge-dedede coreboot chromeos-bootimage and boot into emmc Change-Id: Idf25674efa2336bde98c5abaff278484fd71ea8b Signed-off-by: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/boten/gpio.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/49348/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/49348 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idf25674efa2336bde98c5abaff278484fd71ea8b Gerrit-Change-Number: 49348 Gerrit-PatchSet: 2 Gerrit-Owner: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Allen Cheng <allen.cheng(a)lcfc.corp-partner.google.com> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Peichao Wang <pwang12(a)lenovo.corp-partner.google.com> Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com> Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: sb/intel: Select ACPI_SOC_NVS where suitable
by Kyösti Mälkki (Code Review) 12 Jan '21

12 Jan '21

Attention is currently required from: Kyösti Mälkki. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/49344 to look at the new patch set (#2). Change subject: sb/intel: Select ACPI_SOC_NVS where suitable ...................................................................... sb/intel: Select ACPI_SOC_NVS where suitable Change-Id: Ia9ec853ff7f5e7908f7e8fc179ac27d0da08e19d Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/acpi/nvs.c M src/drivers/amd/agesa/Makefile.inc D src/drivers/amd/agesa/nvs.c M src/lib/hardwaremain.c M src/mainboard/acer/g43t-am3/acpi_tables.c M src/mainboard/apple/macbook21/acpi_tables.c M src/mainboard/apple/macbook21/smihandler.c M src/mainboard/apple/macbookair4_2/gnvs.c M src/mainboard/asrock/b75pro3-m/acpi_tables.c M src/mainboard/asrock/b85m_pro4/acpi_tables.c M src/mainboard/asrock/g41c-gs/acpi_tables.c M src/mainboard/asus/p5qc/acpi_tables.c M src/mainboard/asus/p5ql-em/acpi_tables.c M src/mainboard/asus/p5qpl-am/acpi_tables.c M src/mainboard/asus/p8h61-m_lx3_r2_0/acpi_tables.c M src/mainboard/asus/p8h61-m_pro/acpi_tables.c M src/mainboard/asus/p8z77-m_pro/acpi_tables.c M src/mainboard/asus/p8z77-v_lx2/acpi_tables.c M src/mainboard/compulab/intense_pc/acpi_tables.c M src/mainboard/dell/optiplex_9010/acpi_tables.c M src/mainboard/emulation/qemu-q35/acpi_tables.c M src/mainboard/foxconn/g41s-k/acpi_tables.c M src/mainboard/getac/p470/acpi_tables.c M src/mainboard/getac/p470/smihandler.c M src/mainboard/gigabyte/ga-b75m-d3h/acpi_tables.c M src/mainboard/gigabyte/ga-g41m-es2l/acpi_tables.c M src/mainboard/google/beltino/acpi_tables.c M src/mainboard/google/beltino/smihandler.c M src/mainboard/google/butterfly/acpi_tables.c M src/mainboard/google/butterfly/mainboard_smi.c M src/mainboard/google/link/acpi_tables.c M src/mainboard/google/link/mainboard_smi.c M src/mainboard/google/parrot/acpi_tables.c M src/mainboard/google/parrot/smihandler.c M src/mainboard/google/slippy/acpi_tables.c M src/mainboard/google/slippy/smihandler.c M src/mainboard/google/stout/acpi_tables.c M src/mainboard/google/stout/mainboard_smi.c M src/mainboard/hp/compaq_8200_elite_sff/acpi_tables.c M src/mainboard/hp/folio_9480m/acpi_tables.c M src/mainboard/hp/snb_ivb_laptops/acpi_tables.c M src/mainboard/hp/z220_sff_workstation/acpi_tables.c M src/mainboard/ibase/mb899/acpi_tables.c M src/mainboard/intel/baskingridge/acpi_tables.c M src/mainboard/intel/baskingridge/mainboard_smi.c M src/mainboard/intel/dcp847ske/acpi_tables.c M src/mainboard/intel/dg41wv/acpi_tables.c M src/mainboard/intel/dg43gt/acpi_tables.c M src/mainboard/intel/emeraldlake2/acpi_tables.c M src/mainboard/intel/emeraldlake2/smihandler.c M src/mainboard/kontron/986lcd-m/acpi_tables.c M src/mainboard/kontron/ktqm77/acpi_tables.c M src/mainboard/lenovo/l520/acpi_tables.c M src/mainboard/lenovo/s230u/acpi_tables.c M src/mainboard/lenovo/t400/acpi_tables.c M src/mainboard/lenovo/t410/acpi_tables.c M src/mainboard/lenovo/t410/smihandler.c M src/mainboard/lenovo/t420/acpi_tables.c M src/mainboard/lenovo/t420s/acpi_tables.c M src/mainboard/lenovo/t430/acpi_tables.c M src/mainboard/lenovo/t430s/acpi_tables.c M src/mainboard/lenovo/t440p/acpi_tables.c M src/mainboard/lenovo/t520/acpi_tables.c M src/mainboard/lenovo/t530/acpi_tables.c M src/mainboard/lenovo/t60/acpi_tables.c M src/mainboard/lenovo/t60/smihandler.c M src/mainboard/lenovo/thinkcentre_a58/acpi_tables.c M src/mainboard/lenovo/x131e/acpi_tables.c M src/mainboard/lenovo/x1_carbon_gen1/acpi_tables.c M src/mainboard/lenovo/x200/acpi_tables.c M src/mainboard/lenovo/x201/acpi_tables.c M src/mainboard/lenovo/x201/smihandler.c M src/mainboard/lenovo/x220/acpi_tables.c M src/mainboard/lenovo/x230/acpi_tables.c M src/mainboard/lenovo/x60/acpi_tables.c M src/mainboard/lenovo/x60/smihandler.c M src/mainboard/msi/ms7707/acpi_tables.c M src/mainboard/packardbell/ms2290/smihandler.c M src/mainboard/roda/rk886ex/acpi_tables.c M src/mainboard/roda/rk9/acpi_tables.c M src/mainboard/roda/rk9/smihandler.c M src/mainboard/roda/rv11/acpi_tables.c M src/mainboard/samsung/lumpy/acpi_tables.c M src/mainboard/samsung/lumpy/smihandler.c M src/mainboard/samsung/stumpy/acpi_tables.c M src/mainboard/samsung/stumpy/smihandler.c M src/mainboard/sapphire/pureplatinumh61/acpi_tables.c M src/mainboard/supermicro/x9scl/acpi_tables.c M src/soc/amd/cezanne/Kconfig M src/southbridge/intel/bd82x6x/Kconfig M src/southbridge/intel/bd82x6x/Makefile.inc R src/southbridge/intel/bd82x6x/include/soc/nvs.h M src/southbridge/intel/bd82x6x/lpc.c M src/southbridge/intel/bd82x6x/smihandler.c M src/southbridge/intel/i82371eb/acpi_tables.c M src/southbridge/intel/i82801dx/fadt.c M src/southbridge/intel/i82801gx/Kconfig M src/southbridge/intel/i82801gx/Makefile.inc R src/southbridge/intel/i82801gx/include/soc/nvs.h M src/southbridge/intel/i82801gx/lpc.c M src/southbridge/intel/i82801gx/smihandler.c M src/southbridge/intel/i82801ix/Kconfig M src/southbridge/intel/i82801ix/Makefile.inc R src/southbridge/intel/i82801ix/include/soc/nvs.h M src/southbridge/intel/i82801ix/lpc.c M src/southbridge/intel/i82801ix/smihandler.c M src/southbridge/intel/i82801jx/Kconfig M src/southbridge/intel/i82801jx/Makefile.inc R src/southbridge/intel/i82801jx/include/soc/nvs.h M src/southbridge/intel/i82801jx/lpc.c M src/southbridge/intel/i82801jx/smihandler.c M src/southbridge/intel/ibexpeak/Kconfig M src/southbridge/intel/ibexpeak/Makefile.inc R src/southbridge/intel/ibexpeak/include/soc/nvs.h M src/southbridge/intel/ibexpeak/lpc.c M src/southbridge/intel/ibexpeak/smihandler.c M src/southbridge/intel/lynxpoint/Kconfig M src/southbridge/intel/lynxpoint/Makefile.inc M src/southbridge/intel/lynxpoint/acpi.c R src/southbridge/intel/lynxpoint/include/soc/nvs.h M src/southbridge/intel/lynxpoint/lpc.c M src/southbridge/intel/lynxpoint/serialio.c M src/southbridge/intel/lynxpoint/smihandler.c 123 files changed, 121 insertions(+), 180 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/49344/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/49344 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia9ec853ff7f5e7908f7e8fc179ac27d0da08e19d Gerrit-Change-Number: 49344 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: ChromeOS: Refactor SMBIOS type0 bios_version()
by Kyösti Mälkki (Code Review) 12 Jan '21

12 Jan '21

Attention is currently required from: Lance Zhao. Hello Lance Zhao, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/49281 to look at the new patch set (#2). Change subject: ChromeOS: Refactor SMBIOS type0 bios_version() ...................................................................... ChromeOS: Refactor SMBIOS type0 bios_version() Pointer to an empty string (filled with spaces) is stored inside GNVS. Rearrange things to avoid having <chromeos/gnvs.h> in SMBIOS code. Change-Id: I9405afbea29b896488b4cdd6dd32c4db686fe48c Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/acpi/chromeos-gnvs.c M src/arch/x86/smbios.c M src/include/smbios.h 3 files changed, 20 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/49281/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/49281 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9405afbea29b896488b4cdd6dd32c4db686fe48c Gerrit-Change-Number: 49281 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/adl: Add new Kconfig ENABLE_DISPLAY_OVER_DGPU for ADLRVP wi...
by Paul Menzel (Code Review) 12 Jan '21

12 Jan '21

Attention is currently required from: Nico Huber, Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49291 ) Change subject: soc/intel/adl: Add new Kconfig ENABLE_DISPLAY_OVER_DGPU for ADLRVP with DG ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/49291/comment/90af3d86_0b1ace2b PS2, Line 11: enable enabled https://review.coreboot.org/c/coreboot/+/49291/comment/6ce71229_109658db PS2, Line 13: Pre-OS pre-OS https://review.coreboot.org/c/coreboot/+/49291/comment/b9657b1a_a1483244 PS2, Line 14: DGPU when mainboard user selects ENABLE_DISPLAY_OVER_DGPU. What payload is used? -- To view, visit https://review.coreboot.org/c/coreboot/+/49291 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibbe9c8c4d77018de83815d7d203284b1fbc0da58 Gerrit-Change-Number: 49291 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 12 Jan 2021 10:55:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2021