coreboot-gerrit January 2021

coreboot-gerrit@coreboot.org

1 participants
6504 discussions

Change in coreboot[master]: soc/intel/adl: Add new Kconfig ENABLE_DISPLAY_OVER_DGPU for ADLRVP wi...
by Subrata Banik (Code Review) 12 Jan '21

12 Jan '21

Attention is currently required from: Nico Huber, Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Angel Pons, Patrick Rudolph. Hello build bot (Jenkins), Nico Huber, Furquan Shaikh, Tim Wawrzynczak, Angel Pons, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/49291 to look at the new patch set (#3). Change subject: soc/intel/adl: Add new Kconfig ENABLE_DISPLAY_OVER_DGPU for ADLRVP with DG ...................................................................... soc/intel/adl: Add new Kconfig ENABLE_DISPLAY_OVER_DGPU for ADLRVP with DG This ENABLE_DISPLAY_OVER_DGPU Kconfig will allow ADLRVP to work with DG over PCIE to get display. Also ensure to turn off running IGD initialization using FSP GOP when ENABLE_DISPLAY_OVER_DGPU is enabled. TEST=Able to get depthcharge pre-OS splash screen with AMD Radeon RX 5700 PCI-E DGPU when mainboard user selects ENABLE_DISPLAY_OVER_DGPU. Change-Id: Ibbe9c8c4d77018de83815d7d203284b1fbc0da58 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/alderlake/Kconfig M src/soc/intel/alderlake/acpi.c M src/soc/intel/alderlake/fsp_params.c M src/soc/intel/alderlake/romstage/fsp_params.c 4 files changed, 39 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/49291/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/49291 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibbe9c8c4d77018de83815d7d203284b1fbc0da58 Gerrit-Change-Number: 49291 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/adl: Add new Kconfig ENABLE_DISPLAY_OVER_DGPU for ADLRVP wi...
by Subrata Banik (Code Review) 12 Jan '21

12 Jan '21

Attention is currently required from: Nico Huber, Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Angel Pons, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49291 ) Change subject: soc/intel/adl: Add new Kconfig ENABLE_DISPLAY_OVER_DGPU for ADLRVP with DG ...................................................................... Patch Set 2: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/49291/comment/45ad524a_0d9773c6 PS2, Line 11: enable > enabled Ack https://review.coreboot.org/c/coreboot/+/49291/comment/d9d7e8a9_91ca76e5 PS2, Line 13: Pre-OS > pre-OS Ack https://review.coreboot.org/c/coreboot/+/49291/comment/a7f2cb6e_238bcac0 PS2, Line 14: DGPU when mainboard user selects ENABLE_DISPLAY_OVER_DGPU. > What payload is used? Ack File src/mainboard/intel/adlrvp/devicetree.cb: https://review.coreboot.org/c/coreboot/+/49291/comment/5ec0256d_6ca10286 PS2, Line 192: #if CONFIG(ENABLE_DISPLAY_OVER_DGPU) > Hah, it would be nice if it worked, but these are just comments in the devicetree 😉 Ack File src/soc/intel/alderlake/Kconfig: https://review.coreboot.org/c/coreboot/+/49291/comment/8c72eedf_720a7dbb PS2, Line 247: def_bool n > This doesn't have a prompt. Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/49291 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibbe9c8c4d77018de83815d7d203284b1fbc0da58 Gerrit-Change-Number: 49291 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 12 Jan 2021 12:43:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86: Use wildcard for mb/smihandler.c
by Kyösti Mälkki (Code Review) 12 Jan '21

12 Jan '21

Attention is currently required from: Kyösti Mälkki. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/49247 to look at the new patch set (#5). Change subject: arch/x86: Use wildcard for mb/smihandler.c ...................................................................... arch/x86: Use wildcard for mb/smihandler.c Change-Id: I306f8cd74af62c0cd30f445d20c47f774f122481 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/arch/x86/Makefile.inc M src/mainboard/dell/optiplex_9010/Makefile.inc M src/mainboard/google/auron/Makefile.inc M src/mainboard/google/beltino/Makefile.inc M src/mainboard/google/brya/Makefile.inc M src/mainboard/google/butterfly/Makefile.inc R src/mainboard/google/butterfly/smihandler.c M src/mainboard/google/cyan/Makefile.inc M src/mainboard/google/dedede/Makefile.inc M src/mainboard/google/deltaur/Makefile.inc M src/mainboard/google/drallion/Makefile.inc M src/mainboard/google/eve/Makefile.inc M src/mainboard/google/fizz/Makefile.inc M src/mainboard/google/glados/Makefile.inc M src/mainboard/google/hatch/Makefile.inc M src/mainboard/google/jecht/Makefile.inc M src/mainboard/google/kahlee/Makefile.inc M src/mainboard/google/link/Makefile.inc R src/mainboard/google/link/smihandler.c M src/mainboard/google/octopus/Makefile.inc M src/mainboard/google/poppy/Makefile.inc M src/mainboard/google/rambi/Makefile.inc R src/mainboard/google/rambi/smihandler.c M src/mainboard/google/reef/Makefile.inc M src/mainboard/google/sarien/Makefile.inc M src/mainboard/google/slippy/Makefile.inc M src/mainboard/google/stout/Makefile.inc R src/mainboard/google/stout/smihandler.c M src/mainboard/google/volteer/Makefile.inc M src/mainboard/google/zork/Makefile.inc M src/mainboard/hp/pavilion_m6_1035dx/Makefile.inc R src/mainboard/hp/pavilion_m6_1035dx/smihandler.c M src/mainboard/intel/adlrvp/Makefile.inc M src/mainboard/intel/baskingridge/Makefile.inc R src/mainboard/intel/baskingridge/smihandler.c M src/mainboard/intel/dcp847ske/Makefile.inc M src/mainboard/intel/glkrvp/Makefile.inc M src/mainboard/intel/jasperlake_rvp/Makefile.inc M src/mainboard/intel/kblrvp/Makefile.inc M src/mainboard/intel/kunimitsu/Makefile.inc M src/mainboard/intel/strago/Makefile.inc M src/mainboard/intel/tglrvp/Makefile.inc M src/mainboard/lenovo/g505s/Makefile.inc R src/mainboard/lenovo/g505s/smihandler.c M src/mainboard/lenovo/l520/Makefile.inc M src/mainboard/lenovo/s230u/Makefile.inc M src/mainboard/lenovo/t410/Makefile.inc M src/mainboard/lenovo/t420/Makefile.inc M src/mainboard/lenovo/t420s/Makefile.inc M src/mainboard/lenovo/t430/Makefile.inc M src/mainboard/lenovo/t430s/Makefile.inc M src/mainboard/lenovo/t440p/Makefile.inc M src/mainboard/lenovo/t520/Makefile.inc M src/mainboard/lenovo/t530/Makefile.inc M src/mainboard/lenovo/x1_carbon_gen1/Makefile.inc M src/mainboard/lenovo/x201/Makefile.inc M src/mainboard/lenovo/x220/Makefile.inc M src/mainboard/lenovo/x230/Makefile.inc M src/mainboard/packardbell/ms2290/Makefile.inc 59 files changed, 3 insertions(+), 81 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/49247/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/49247 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I306f8cd74af62c0cd30f445d20c47f774f122481 Gerrit-Change-Number: 49247 Gerrit-PatchSet: 5 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: nb/intel/sandybridge: Fix handling of clock timing
by Angel Pons (Code Review) 12 Jan '21

12 Jan '21

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49319 ) Change subject: nb/intel/sandybridge: Fix handling of clock timing ...................................................................... Patch Set 1: (1 comment) File src/northbridge/intel/sandybridge/raminit_common.c: https://review.coreboot.org/c/coreboot/+/49319/comment/46a057d9_86ab1708 PS1, Line 948: if (cmd_delay < 0) { : printk(BIOS_ERR, "C%d command delay underflow: %d\n", channel, cmd_delay); : cmd_delay = 0; : } > Just before I forget to mention it (the added check below reminded me): This is dead […] Yes, I got rid of it in the follow-up -- To view, visit https://review.coreboot.org/c/coreboot/+/49319 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I375adf84142079f341b060fba5e79ce4dcb002be Gerrit-Change-Number: 49319 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 12 Jan 2021 12:27:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/sandybridge: Remove wrong and nonsense condition
by Angel Pons (Code Review) 12 Jan '21

12 Jan '21

Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49318 ) Change subject: nb/intel/sandybridge: Remove wrong and nonsense condition ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/49318/comment/b62083a3_a83b58a7 PS1, Line 10: comment that says the opposite > My fall-back interpretation of the comment was that it applies if all […] Argh, let me revise it again... -- To view, visit https://review.coreboot.org/c/coreboot/+/49318 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I509f0f6304bfb3e033c0c3ecd1dd5c9645e004b2 Gerrit-Change-Number: 49318 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Tue, 12 Jan 2021 12:25:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/sandybridge: Clarify command timing calculation
by Nico Huber (Code Review) 12 Jan '21

12 Jan '21

Attention is currently required from: Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49320 ) Change subject: nb/intel/sandybridge: Clarify command timing calculation ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/49320 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I714d3cf57d0f62376a1107af63bcd761f952bc3a Gerrit-Change-Number: 49320 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 12 Jan 2021 12:10:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/sandybridge: Fix handling of clock timing
by Nico Huber (Code Review) 12 Jan '21

12 Jan '21

1 0

Change in coreboot[master]: nb/intel/sandybridge: Fix handling of clock timing
by Nico Huber (Code Review) 12 Jan '21

12 Jan '21

Attention is currently required from: Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49319 ) Change subject: nb/intel/sandybridge: Fix handling of clock timing ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/49319/comment/6fc25f14_17a0b346 PS1, Line 15: and `pi_code_offset` is always positive If this is the case, it could be declared unsigned and we could remove the check. File src/northbridge/intel/sandybridge/raminit_common.c: https://review.coreboot.org/c/coreboot/+/49319/comment/e0cc52f6_42825954 PS1, Line 948: if (cmd_delay < 0) { : printk(BIOS_ERR, "C%d command delay underflow: %d\n", channel, cmd_delay); : cmd_delay = 0; : } Just before I forget to mention it (the added check below reminded me): This is dead code. The loop right above can only grow `cmd_delay` above 0. -- To view, visit https://review.coreboot.org/c/coreboot/+/49319 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I375adf84142079f341b060fba5e79ce4dcb002be Gerrit-Change-Number: 49319 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 12 Jan 2021 12:07:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/cbfstool: unbreak compilation on FreeBSD
by Arthur Heymans (Code Review) 12 Jan '21

12 Jan '21

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49314 ) Change subject: util/cbfstool: unbreak compilation on FreeBSD ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/49314 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3433e4c9269880d3202dd494e5b2e962757a6b87 Gerrit-Change-Number: 49314 Gerrit-PatchSet: 1 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 12 Jan 2021 12:05:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/cbfstool: unbreak compilation on FreeBSD
by Idwer Vollering (Code Review) 12 Jan '21

12 Jan '21

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49314 ) Change subject: util/cbfstool: unbreak compilation on FreeBSD ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Well... in my defense I did check the FreeBSD man page (https://www.freebsd.org/cgi/man. […] Correct. So I had a look outside OS territory: https://github.com/freebsd/freebsd-ports/search?q=__BSD_VISIBLE -- To view, visit https://review.coreboot.org/c/coreboot/+/49314 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3433e4c9269880d3202dd494e5b2e962757a6b87 Gerrit-Change-Number: 49314 Gerrit-PatchSet: 1 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 12 Jan 2021 11:59:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2021