Attention is currently required from: Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49319 )
Change subject: nb/intel/sandybridge: Fix handling of clock timing ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49319/comment/6fc25f14_17a0b346 PS1, Line 15: and `pi_code_offset` is always positive If this is the case, it could be declared unsigned and we could remove the check.
File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/49319/comment/e0cc52f6_42825954 PS1, Line 948: if (cmd_delay < 0) { : printk(BIOS_ERR, "C%d command delay underflow: %d\n", channel, cmd_delay); : cmd_delay = 0; : } Just before I forget to mention it (the added check below reminded me): This is dead code. The loop right above can only grow `cmd_delay` above 0.