Attention is currently required from: Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49287 )
Change subject: nb/intel/sandybridge: Fix programming command timings ......................................................................
Patch Set 1:
(1 comment)
File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/49287/comment/697c5b43_ee5d66fd PS1, Line 939: /* : * Compute command phase shift as the most negative CCC setting : * across all ranks. Use zero if none of the values is negative. : */ : FOR_ALL_POPULATED_RANKS { : cmd_delay = MAX(cmd_delay, -ctrl->timings[channel][slotrank].pi_coding); : } :
The `if (cmd_delay == 0) {` check is nonsense, and clock needs to be offset by `ctrl->pi_code_offset […]
Those two differences were also my conclusion. I wasn't sure though, as I was staring at the code for over an hour before I figured that out (not just this change, but I also wanted to be sure what changed since the original code).