Change in coreboot[master]: arch/x86/smbios: Update SMBIOS type 17 type detail

[Tim Chu (Code Review)]

Tim Chu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49347 )

Change subject: arch/x86/smbios: Update SMBIOS type 17 type detail
......................................................................

arch/x86/smbios: Update SMBIOS type 17 type detail

Update SMBIOS type 17 type detail. Define this field by module type.

Tested=Execute "dmidecode -t 17" to check type detail is correct.

Signed-off-by: Tim Chu 
Change-Id: I6700056edad5db2b86f6da526329b1343b026385
---
M src/arch/x86/smbios.c
1 file changed, 7 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/49347/1

diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c
index aaf989d..f1d11ba 100644
--- a/src/arch/x86/smbios.c
+++ b/src/arch/x86/smbios.c
@@ -303,17 +303,22 @@
    case SPD_RDIMM:
    case SPD_MINI_RDIMM:
    	t->form_factor = MEMORY_FORMFACTOR_RIMM;
+		t->type_detail = MEMORY_TYPE_DETAIL_REGISTERED;
+		break;
+	case SPD_MICRO_DIMM:
+		t->form_factor = MEMORY_FORMFACTOR_DIMM;
    	break;
    case SPD_UDIMM:
-	case SPD_MICRO_DIMM:
    case SPD_MINI_UDIMM:
    	t->form_factor = MEMORY_FORMFACTOR_DIMM;
+		t->type_detail = MEMORY_TYPE_DETAIL_UNBUFFERED;
    	break;
    case SPD_SODIMM:
    	t->form_factor = MEMORY_FORMFACTOR_SODIMM;
    	break;
    default:
    	t->form_factor = MEMORY_FORMFACTOR_UNKNOWN;
+		t->type_detail = MEMORY_TYPE_DETAIL_UNKNOWN;
    	break;
    }

@@ -331,7 +336,7 @@
    t->maximum_voltage = dimm->vdd_voltage;

/* Synchronous = 1 */
-	t->type_detail = MEMORY_TYPE_DETAIL_SYNCHRONOUS;
+	t->type_detail |= MEMORY_TYPE_DETAIL_SYNCHRONOUS;
    /* no handle for error information */
    t->memory_error_information_handle = 0xFFFE;
    t->attributes = dimm->rank_per_dimm;