Hello Jes Klinke, build bot (Jenkins), Vadim Bendebury, Tim Wawrzynczak, Christian Walter, Duncan Laurie,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45232
to look at the new patch set (#3).
Change subject: drivers/spi/tpm: Improve error checking
......................................................................
drivers/spi/tpm: Improve error checking
This adds error checking in paths that previously ignored TPM
communication errors. We hit this case occasionally during "Checking
cr50 for pending updates"; previously we would go down this path and
eventually time out using MAX_STATUS_TIMEOUT, which is 2 minutes.
Now, we detect the failure and return with an error indication instead
of timing out after a long time. The root cause of the communication
error is an open issue.
BUG=b:168090038
TEST=booted on volteer, observed error handling when
"Checking cr50 for pending updates" fails.
Signed-off-by: Caveh Jalali <caveh(a)chromium.org>
Change-Id: Ia8a1202000abce1857ee694b06b1478e6b045069
---
M src/drivers/spi/tpm/tpm.c
1 file changed, 39 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/45232/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/45232
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8a1202000abce1857ee694b06b1478e6b045069
Gerrit-Change-Number: 45232
Gerrit-PatchSet: 3
Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org>
Gerrit-Reviewer: Jes Klinke <jbk(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Vadim Bendebury <vbendeb(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
Hello Douglas Anderson, Philip Chen,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/45225
to review the following change.
Change subject: trogdor: Strappings_update_final3.1_second_thisistherealone.patch
......................................................................
trogdor: Strappings_update_final3.1_second_thisistherealone.patch
Apparently what I thought was lazor-rev2 is actually lazor-rev3 and
nobody is really sure what lazor-rev4 is going to be at this point or
how we proceed from there. What seems to be somewhat agreed upon is that
for now all Lazor revisions use the "old" GPIO mapping and it's not very
clear if that's ever going to change for Lazor, so let's take the
revision restriction out from Lazor for now.
Signed-off-by: Julius Werner <jwerner(a)chromium.org>
Change-Id: I4939ccfd8464da6e72b5e01a58489b8c80f5b4df
---
M src/mainboard/google/trogdor/boardid.c
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/45225/1
diff --git a/src/mainboard/google/trogdor/boardid.c b/src/mainboard/google/trogdor/boardid.c
index f60dddbe..edde164 100644
--- a/src/mainboard/google/trogdor/boardid.c
+++ b/src/mainboard/google/trogdor/boardid.c
@@ -16,11 +16,12 @@
return id;
}
-/* Whether a revision was built before or after the great pin migration of August 2020. */
+/* Some boards/revisions use one GPIO mapping and others use another. There's no real rhyme or
+ reason to it. Don't try to think about it too much... */
static bool use_old_pins(void)
{
return ((CONFIG(BOARD_GOOGLE_TROGDOR) && board_id() < 2) ||
- (CONFIG(BOARD_GOOGLE_LAZOR) && board_id() < 3) ||
+ CONFIG(BOARD_GOOGLE_LAZOR) ||
(CONFIG(BOARD_GOOGLE_POMPOM) && board_id() < 1));
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/45225
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4939ccfd8464da6e72b5e01a58489b8c80f5b4df
Gerrit-Change-Number: 45225
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Douglas Anderson <dianders(a)chromium.org>
Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org>
Gerrit-MessageType: newchange
Hello Felix Singer, build bot (Jenkins), Nico Huber, Patrick Georgi, Jeremy Soller, Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43652
to look at the new patch set (#29).
Change subject: mb/system76/lemp9: gpio: convert gpio.h to a cleaner format
......................................................................
mb/system76/lemp9: gpio: convert gpio.h to a cleaner format
This converts gpio.h to a compacter, cleaner format by keeping gpios in
a single line, where possible.
Test: images built with TIMELESS do not differ.
Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de>
Change-Id: I9054274dc4c8942935b6a4789bfc1547dd3d4017
---
M src/mainboard/system76/lemp9/gpio.h
1 file changed, 222 insertions(+), 504 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/43652/29
--
To view, visit https://review.coreboot.org/c/coreboot/+/43652
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9054274dc4c8942935b6a4789bfc1547dd3d4017
Gerrit-Change-Number: 43652
Gerrit-PatchSet: 29
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset