Change in coreboot[master]: mb/google/kukui: add willow memory mapping table

[Sheng-Liang Pan (Code Review)]

Sheng-Liang Pan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44981 )

Change subject: mb/google/kukui: add willow memory mapping table
......................................................................

mb/google/kukui: add willow memory mapping table

add memory mapping table for willow
index#0  Samsung K4UBE3D4AA-MGCR 4GB
index#2  Micron MT53E1G32D4NQ-4GB
index#10 Hynix H9HCNNNCPMMLXR-NEE-4GB

BUG=b:160288021
BRANCH=kukui
TEST=emerge-jacuzzi coreboot

Signed-off-by: Pan Sheng-Liang 
Change-Id: I5068af12585c098772c3027dcd633723851d4e5f
---
M src/mainboard/google/kukui/Kconfig
M src/mainboard/google/kukui/sdram_configs.c
2 files changed, 7 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/44981/1

diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig
index 01247ca..1abdf83 100644
--- a/src/mainboard/google/kukui/Kconfig
+++ b/src/mainboard/google/kukui/Kconfig
@@ -74,6 +74,7 @@
 config BOARD_SDRAM_TABLE_OFFSET
    hex
    default 0x10 if BOARD_GOOGLE_BURNET || BOARD_GOOGLE_ESCHE
+	default 0x20 if BOARD_GOOGLE_WILLOW
    default 0x0

endif
diff --git a/src/mainboard/google/kukui/sdram_configs.c b/src/mainboard/google/kukui/sdram_configs.c
index 1f9e6bb..4b66a66 100644
--- a/src/mainboard/google/kukui/sdram_configs.c
+++ b/src/mainboard/google/kukui/sdram_configs.c
@@ -30,6 +30,12 @@
    [0x13] = "sdram-lpddr4x-K4UBE3D4AA-MGCL-4GB",
    [0x14] = "sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB",
    [0x16] = "sdram-lpddr4x-MT53E2G32D4NQ-046-8GB",
+
+	/* Table for willow, offset = 0x20 */
+	[0x20] = "sdram-lpddr4x-K4UBE3D4AA-MGCR-4GB",
+	[0x22] = "sdram-lpddr4x-MT53E1G32D4NQ-4GB",
+	[0x2a] = "sdram-lpddr4x-H9HCNNNCPMMLXR-NEE-4GB",
+
 };

static struct sdram_params params;

[Sheng-Liang Pan (Code Review)]

Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44981 )

Change subject: mb/google/kukui: add willow memory mapping table
......................................................................

Patch Set 1: Code-Review+1

Change in coreboot[master]: mb/google/kukui: add memory in standard mapping table for willow

[Sheng-Liang Pan (Code Review)]

Hello Hung-Te Lin, build bot (Jenkins), Chen-Tsung Hsieh, KU-TENG HSU,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44981

to look at the new patch set (#2).

Change subject: mb/google/kukui: add memory in standard mapping table for willow
......................................................................

mb/google/kukui: add memory in standard mapping table for willow

add memory in mapping table for willow
index#0  Samsung K4UBE3D4AA-MGCR 4GB

BUG=b:160288021
BRANCH=kukui
TEST=emerge-jacuzzi coreboot

Signed-off-by: Pan Sheng-Liang 
Change-Id: I5068af12585c098772c3027dcd633723851d4e5f
---
M src/mainboard/google/kukui/sdram_configs.c
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/44981/2

Change in coreboot[master]: mb/google/kukui: add memory in standard mapping table for willow

[Sheng-Liang Pan (Code Review)]

Hello Hung-Te Lin, build bot (Jenkins), Chen-Tsung Hsieh, KU-TENG HSU,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44981

to look at the new patch set (#3).

Change subject: mb/google/kukui: add memory in standard mapping table for willow
......................................................................

mb/google/kukui: add memory in standard mapping table for willow

add memory in mapping table for willow
index#0  Samsung K4UBE3D4AA-MGCR 4GB

BUG=b:160288021
BRANCH=kukui
TEST=emerge-jacuzzi coreboot

Signed-off-by: Pan Sheng-Liang 
Change-Id: I5068af12585c098772c3027dcd633723851d4e5f
---
M src/mainboard/google/kukui/sdram_configs.c
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/44981/3

Change in coreboot[master]: mb/google/kukui: add memory in standard mapping table for willow

[Sheng-Liang Pan (Code Review)]

Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44981 )

Change subject: mb/google/kukui: add memory in standard mapping table for willow
......................................................................

Patch Set 3: Code-Review+1

Change in coreboot[master]: mb/google/kukui: add memory in standard mapping table for willow

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44981 )

Change subject: mb/google/kukui: add memory in standard mapping table for willow
......................................................................

Patch Set 3: Code-Review+2

Change in coreboot[master]: mb/google/kukui: add memory in standard mapping table

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#4) to the change originally created by Sheng-Liang Pan. ( https://review.coreboot.org/c/coreboot/+/44981 )

Change subject: mb/google/kukui: add memory in standard mapping table
......................................................................

mb/google/kukui: add memory in standard mapping table

Add memory module in mapping table:
Index#0:  Samsung K4UBE3D4AA-MGCR 4GB

BUG=b:160288021
BRANCH=kukui
TEST=emerge-jacuzzi coreboot

Signed-off-by: Pan Sheng-Liang 
Change-Id: I5068af12585c098772c3027dcd633723851d4e5f
---
M src/mainboard/google/kukui/sdram_configs.c
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/44981/4

Change in coreboot[master]: mb/google/kukui: add memory in standard mapping table

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44981 )

Change subject: mb/google/kukui: add memory in standard mapping table
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44981/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/44981/4//COMMIT_MSG@7 
PS4, Line 7: mb/google/kukui: add memory in standard mapping table
Maybe:
> Support Samsung K4UBE3D4AA-MGCR 4GB

or
> Add new Samsung memory to standard mapping table

Change in coreboot[master]: mb/google/kukui: support new memory module

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#5) to the change originally created by Sheng-Liang Pan. ( https://review.coreboot.org/c/coreboot/+/44981 )

Change subject: mb/google/kukui: support new memory module
......................................................................

mb/google/kukui: support new memory module

Support Samsung K4UBE3D4AA-MGCR 4GB

BUG=b:160288021
BRANCH=kukui
TEST=emerge-jacuzzi coreboot

Signed-off-by: Pan Sheng-Liang 
Change-Id: I5068af12585c098772c3027dcd633723851d4e5f
---
M src/mainboard/google/kukui/sdram_configs.c
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/44981/5

Change in coreboot[master]: mb/google/kukui: support new memory module

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44981 )

Change subject: mb/google/kukui: support new memory module
......................................................................

Patch Set 5: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/44981/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/44981/4//COMMIT_MSG@7 
PS4, Line 7: mb/google/kukui: add memory in standard mapping table
> Maybe: […]

As there is space, I’d prefer Samsung in the summary too, but that’s subjective.

Change in coreboot[master]: mb/google/kukui: support new memory module

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44981 )

Change subject: mb/google/kukui: support new memory module
......................................................................

Patch Set 6: -Code-Review

this is an empty change now given https://review.coreboot.org/c/coreboot/+/45101 is merged. Please abandon it.

Change in coreboot[master]: mb/google/kukui: support new memory module

[Sheng-Liang Pan (Code Review)]

Sheng-Liang Pan has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44981 )

Change subject: mb/google/kukui: support new memory module
......................................................................

Abandoned