Change in coreboot[master]: device: Fix incompatible-pointer-types while calling pci_dev_request_...
Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45122 )
Change subject: device: Fix incompatible-pointer-types while calling pci_dev_request_bus_master ......................................................................
device: Fix incompatible-pointer-types while calling pci_dev_request_bus_master
Signed-off-by: Subrata Banik subrata.banik@intel.com Change-Id: I3b1ce85b8db1ddf9ac860415edbe64694b91b3d1 --- M src/include/device/pci.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/45122/1
diff --git a/src/include/device/pci.h b/src/include/device/pci.h index ec3d45e..6e28cb7 100644 --- a/src/include/device/pci.h +++ b/src/include/device/pci.h @@ -133,7 +133,7 @@ #if ENV_PCI_SIMPLE_DEVICE void pci_dev_request_bus_master(pci_devfn_t dev) #else -void pci_dev_request_bus_master(const struct device *dev) +void pci_dev_request_bus_master(struct device *dev) #endif /* ENV_PCI_SIMPLE_DEVICE */ { if (CONFIG(PCI_ALLOW_BUS_MASTER))
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45122 )
Change subject: device: Fix incompatible-pointer-types while calling pci_dev_request_bus_master ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45122/1/src/include/device/pci.h File src/include/device/pci.h:
https://review.coreboot.org/c/coreboot/+/45122/1/src/include/device/pci.h@13... PS1, Line 136: void pci_dev_request_bus_master(struct device *dev) Where is this function implemented, called from? I can’t find it in current coreboot master branch (4.12-2567-gb3ced6a67b, soc/intel/alderlake/bootblock: Do initial SoC commit till bootblock).
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45122 )
Change subject: device: Fix incompatible-pointer-types while calling pci_dev_request_bus_master ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45122/1/src/include/device/pci.h File src/include/device/pci.h:
https://review.coreboot.org/c/coreboot/+/45122/1/src/include/device/pci.h@13... PS1, Line 136: void pci_dev_request_bus_master(struct device *dev)
Where is this function implemented, called from? I can’t find it in current coreboot master branch ( […]
Paul, see this CL https://review.coreboot.org/c/coreboot/+/44512/6 which is using this function and error due to that is also here : https://qa.coreboot.org/job/coreboot-gerrit/140717/testReport/junit/board/ch...
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45122 )
Change subject: device: Fix incompatible-pointer-types while calling pci_dev_request_bus_master ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45122/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45122/1//COMMIT_MSG@7 PS1, Line 7: device: Fix incompatible-pointer-types while calling pci_dev_request_bus_master Please mention that the build error happens when using `pci_dev_request_bus_master` as part of device ops
Hello Felix Singer, build bot (Jenkins), Tim Wawrzynczak, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45122
to look at the new patch set (#2).
Change subject: device: Fix incompatible-pointer-types build error ......................................................................
device: Fix incompatible-pointer-types build error
The build error `incompatible-pointer-types` occurs while using `pci_dev_request_bus_master` as part of device ops
Signed-off-by: Subrata Banik subrata.banik@intel.com Change-Id: I3b1ce85b8db1ddf9ac860415edbe64694b91b3d1 --- M src/include/device/pci.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/45122/2
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45122 )
Change subject: device: Fix incompatible-pointer-types build error ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45122/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45122/1//COMMIT_MSG@7 PS1, Line 7: device: Fix incompatible-pointer-types while calling pci_dev_request_bus_master
Please mention that the build error happens when using `pci_dev_request_bus_master` as part of devic […]
Thanks Angel
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45122 )
Change subject: device: Fix incompatible-pointer-types build error ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45122/1/src/include/device/pci.h File src/include/device/pci.h:
https://review.coreboot.org/c/coreboot/+/45122/1/src/include/device/pci.h@13... PS1, Line 136: void pci_dev_request_bus_master(struct device *dev)
Paul, see this CL https://review.coreboot.org/c/coreboot/+/44512/6 which is using this function […]
Ack
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45122 )
Change subject: device: Fix incompatible-pointer-types build error ......................................................................
Patch Set 2:
Angel, is this good now?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45122 )
Change subject: device: Fix incompatible-pointer-types build error ......................................................................
Patch Set 2: Code-Review+2
Patch Set 2:
Angel, is this good now?
LGTM
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45122 )
Change subject: device: Fix incompatible-pointer-types build error ......................................................................
Patch Set 2:
Patch Set 2: Code-Review+2
Patch Set 2:
Angel, is this good now?
LGTM
Thanks Angel
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45122 )
Change subject: device: Fix incompatible-pointer-types build error ......................................................................
Patch Set 2:
IDK that this is necessary, I agree with the statements made in the follower patch, that it should be the payload that is setting bus master or not; if coreboot does not need the device to perform that function, then let the payload do it.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45122 )
Change subject: device: Fix incompatible-pointer-types build error ......................................................................
Patch Set 2:
Patch Set 2:
IDK that this is necessary, I agree with the statements made in the follower patch, that it should be the payload that is setting bus master or not; if coreboot does not need the device to perform that function, then let the payload do it.
For now, we can use `pci_dev_request_bus_master`. Its behavior can be controlled through Kconfig. When we know for sure where bus master is required, we can then clean up.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45122 )
Change subject: device: Fix incompatible-pointer-types build error ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
IDK that this is necessary, I agree with the statements made in the follower patch, that it should be the payload that is setting bus master or not; if coreboot does not need the device to perform that function, then let the payload do it.
For now, we can use `pci_dev_request_bus_master`. Its behavior can be controlled through Kconfig. When we know for sure where bus master is required, we can then clean up.
Tim, any open for this ?
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45122 )
Change subject: device: Fix incompatible-pointer-types build error ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
Patch Set 2:
IDK that this is necessary, I agree with the statements made in the follower patch, that it should be the payload that is setting bus master or not; if coreboot does not need the device to perform that function, then let the payload do it.
For now, we can use `pci_dev_request_bus_master`. Its behavior can be controlled through Kconfig. When we know for sure where bus master is required, we can then clean up.
Tim, any open for this ?
Go for it for now, but I just think the whole bus mastering things (in general) needs a little more thought
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45122 )
Change subject: device: Fix incompatible-pointer-types build error ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
Patch Set 2:
Patch Set 2:
IDK that this is necessary, I agree with the statements made in the follower patch, that it should be the payload that is setting bus master or not; if coreboot does not need the device to perform that function, then let the payload do it.
For now, we can use `pci_dev_request_bus_master`. Its behavior can be controlled through Kconfig. When we know for sure where bus master is required, we can then clean up.
Tim, any open for this ?
Go for it for now, but I just think the whole bus mastering things (in general) needs a little more thought
Sure Tim, may be we can discuss more here CB:44512
Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45122 )
Change subject: device: Fix incompatible-pointer-types build error ......................................................................
device: Fix incompatible-pointer-types build error
The build error `incompatible-pointer-types` occurs while using `pci_dev_request_bus_master` as part of device ops
Signed-off-by: Subrata Banik subrata.banik@intel.com Change-Id: I3b1ce85b8db1ddf9ac860415edbe64694b91b3d1 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45122 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/include/device/pci.h 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/include/device/pci.h b/src/include/device/pci.h index ec3d45e..6e28cb7 100644 --- a/src/include/device/pci.h +++ b/src/include/device/pci.h @@ -133,7 +133,7 @@ #if ENV_PCI_SIMPLE_DEVICE void pci_dev_request_bus_master(pci_devfn_t dev) #else -void pci_dev_request_bus_master(const struct device *dev) +void pci_dev_request_bus_master(struct device *dev) #endif /* ENV_PCI_SIMPLE_DEVICE */ { if (CONFIG(PCI_ALLOW_BUS_MASTER))
-
Angel Pons (Code Review) -
Paul Menzel (Code Review)
-
Subrata Banik (Code Review)
-
Tim Wawrzynczak (Code Review)