Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45122 )
Change subject: device: Fix incompatible-pointer-types build error ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
Patch Set 2:
IDK that this is necessary, I agree with the statements made in the follower patch, that it should be the payload that is setting bus master or not; if coreboot does not need the device to perform that function, then let the payload do it.
For now, we can use `pci_dev_request_bus_master`. Its behavior can be controlled through Kconfig. When we know for sure where bus master is required, we can then clean up.
Tim, any open for this ?
Go for it for now, but I just think the whole bus mastering things (in general) needs a little more thought