Patch Set 2:

Patch Set 2:

Patch Set 2:

Patch Set 2:

IDK that this is necessary, I agree with the statements made in the follower patch, that it should be the payload that is setting bus master or not; if coreboot does not need the device to perform that function, then let the payload do it.

For now, we can use `pci_dev_request_bus_master`. Its behavior can be controlled through Kconfig. When we know for sure where bus master is required, we can then clean up.

Tim, any open for this ?

Go for it for now, but I just think the whole bus mastering things (in general) needs a little more thought

Sure Tim, may be we can discuss more here CB:44512

View Change

To view, visit change 45122. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b1ce85b8db1ddf9ac860415edbe64694b91b3d1
Gerrit-Change-Number: 45122
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Subrata Banik <subi.banik@gmail.com>
Gerrit-Comment-Date: Fri, 11 Sep 2020 03:12:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment