coreboot-gerrit September 2020

coreboot-gerrit@coreboot.org

1 participants
2628 discussions

Change in coreboot[master]: mb/system76/lemp9: use the newly added CNL GPIOs
by Michael Niewöhner (Code Review) 18 Sep '20

18 Sep '20

Hello Felix Singer, build bot (Jenkins), Nico Huber, Maxim Polyakov, Jeremy Soller, Paul Menzel, Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/45489 to look at the new patch set (#4). Change subject: mb/system76/lemp9: use the newly added CNL GPIOs ...................................................................... mb/system76/lemp9: use the newly added CNL GPIOs This adds the new CNL GPIOs, added in commits 1c2b1b9 and 5d1a328. Change-Id: I0a42f8af1da5d767add751cc24907bc8b12294f2 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/mainboard/system76/lemp9/gpio.h 1 file changed, 60 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/45489/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/45489 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0a42f8af1da5d767add751cc24907bc8b12294f2 Gerrit-Change-Number: 45489 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/system76/lemp9: convert GPP_D9 macro to shorter macro
by Michael Niewöhner (Code Review) 18 Sep '20

18 Sep '20

Hello Felix Singer, build bot (Jenkins), Maxim Polyakov, Jeremy Soller, Paul Menzel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/45488 to look at the new patch set (#4). Change subject: mb/system76/lemp9: convert GPP_D9 macro to shorter macro ...................................................................... mb/system76/lemp9: convert GPP_D9 macro to shorter macro Convert PAD_CFG_GPI_SCI(..., INVERT) to PAD_CFG_GPI_SCI_LOW(...) to make the comment stand in line with the others. Change-Id: I147c82d738623bff54122ad5ef8ece028c562cab Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/mainboard/system76/lemp9/gpio.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/45488/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/45488 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I147c82d738623bff54122ad5ef8ece028c562cab Gerrit-Change-Number: 45488 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/system76/lemp9: move LPC options to the devicetree
by Michael Niewöhner (Code Review) 18 Sep '20

18 Sep '20

Hello Felix Singer, build bot (Jenkins), Jeremy Soller, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/45496 to look at the new patch set (#6). Change subject: mb/system76/lemp9: move LPC options to the devicetree ...................................................................... mb/system76/lemp9: move LPC options to the devicetree Change-Id: I7b7acdc51c848541fb39926bc8de1115c026dd05 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 9 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/45496/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/45496 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b7acdc51c848541fb39926bc8de1115c026dd05 Gerrit-Change-Number: 45496 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/system76/lemp9: drop USE_LEGACY_8254_TIMER
by Michael Niewöhner (Code Review) 18 Sep '20

18 Sep '20

Hello Felix Singer, build bot (Jenkins), Jeremy Soller, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/45509 to look at the new patch set (#2). Change subject: mb/system76/lemp9: drop USE_LEGACY_8254_TIMER ...................................................................... mb/system76/lemp9: drop USE_LEGACY_8254_TIMER Drop USE_LEGACY_8254_TIMER, since it's not required, despite the comment. Test: Boot EFI GRUB2 from TianoCore payload. Change-Id: I5ce4f5168586bf305969b2e24b6ee895c8552749 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/mainboard/system76/lemp9/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/45509/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/45509 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5ce4f5168586bf305969b2e24b6ee895c8552749 Gerrit-Change-Number: 45509 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/system76/lemp9: correct CBFS_SIZE
by Michael Niewöhner (Code Review) 18 Sep '20

18 Sep '20

Hello Felix Singer, Jeremy Soller, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/45504 to look at the new patch set (#2). Change subject: mb/system76/lemp9: correct CBFS_SIZE ...................................................................... mb/system76/lemp9: correct CBFS_SIZE The BIOS region size is 0xc00000, not 0xa00000. Correct this. Change-Id: I88cb0d4b9a590a32672054aa0db7f9a92070ff6d Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/mainboard/system76/lemp9/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/45504/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/45504 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88cb0d4b9a590a32672054aa0db7f9a92070ff6d Gerrit-Change-Number: 45504 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/system76/lemp9: enable SATA ALPM capability
by Michael Niewöhner (Code Review) 18 Sep '20

18 Sep '20

Hello Felix Singer, build bot (Jenkins), Jeremy Soller, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/45492 to look at the new patch set (#3). Change subject: mb/system76/lemp9: enable SATA ALPM capability ...................................................................... mb/system76/lemp9: enable SATA ALPM capability Enable SATA Link Power Management capability to be able to save power. TEST: /sys/class/scsi_host/host*/link_power_management_policy exists. Change-Id: I88de28cfb266af3fcd6e498a08a24b46c992cb9d Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/45492/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/45492 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88de28cfb266af3fcd6e498a08a24b46c992cb9d Gerrit-Change-Number: 45492 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/system76/lemp9: drop disabled options from devicetree
by Michael Niewöhner (Code Review) 18 Sep '20

18 Sep '20

Hello Felix Singer, build bot (Jenkins), Jeremy Soller, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/45491 to look at the new patch set (#3). Change subject: mb/system76/lemp9: drop disabled options from devicetree ...................................................................... mb/system76/lemp9: drop disabled options from devicetree Drop all options with zero-value, since they already default to 0. Change-Id: I2a1a91778e83dc49c6dcf2d518cd3591f7ec4cfa Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 0 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/45491/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/45491 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a1a91778e83dc49c6dcf2d518cd3591f7ec4cfa Gerrit-Change-Number: 45491 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: lint: check for misuse of Kconfig SUBSYSTEM_*_ID
by Michael Niewöhner (Code Review) 18 Sep '20

18 Sep '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45513 ) Change subject: lint: check for misuse of Kconfig SUBSYSTEM_*_ID ...................................................................... Patch Set 1: Code-Review-1 -- To view, visit https://review.coreboot.org/c/coreboot/+/45513 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I21c021c718154f1396f795a555af47a76d6efe03 Gerrit-Change-Number: 45513 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Elyes HAOUAS Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 18 Sep 2020 07:34:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/mipi_camera: Add support for dynamic SSDT generation
by Furquan Shaikh (Code Review) 18 Sep '20

18 Sep '20

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45172 ) Change subject: drivers/intel/mipi_camera: Add support for dynamic SSDT generation ...................................................................... Patch Set 9: Code-Review-1 I don't think this is the way we want to move forward with handling of SSFC. We should utilize the infrastructure we already have for fw_config to enable SSFC as well. There is some discussion going on internally about SSFC. Karthik is planning to follow up on this. -- To view, visit https://review.coreboot.org/c/coreboot/+/45172 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6a5aa6c313c026871e55bc6d067b44de4c1f1afe Gerrit-Change-Number: 45172 Gerrit-PatchSet: 9 Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: Andy Yeh <andy.yeh(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Chiasheng Lee <chiasheng.lee(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jett Rink <jettrink(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: ShawnX Tu <shawnx.tu(a)intel.com> Gerrit-Reviewer: Tomasz Figa <tfiga(a)google.com> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Henry Sun <henrysun(a)google.com> Gerrit-CC: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Fri, 18 Sep 2020 07:29:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/mipi_camera: Add support for dynamic SSDT generation
by Sugnan Prabhu S (Code Review) 18 Sep '20

18 Sep '20

Hello Patrick Georgi, Rizwan Qureshi, Jett Rink, Chiasheng Lee, Balaji Manigandan, Andy Yeh, Paul Fagerburg, Patrick Rudolph, Tomasz Figa, ShawnX Tu, Varshit B Pandya, Martin Roth, Chen Wisley, Justin TerAvest, Marco Chen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/45172 to look at the new patch set (#9). Change subject: drivers/intel/mipi_camera: Add support for dynamic SSDT generation ...................................................................... drivers/intel/mipi_camera: Add support for dynamic SSDT generation This change updates mipi_camera driver to handle SSDT dynamically based on the camera configuration returned by the mainboard. It implements a weak function get_camera_config, which is expected to be overridden by mainboard and returns a camera configuration that includes the IPU and sensors details. A board which can support multiple camera configurations can implement get_camera_config to return a camera configuration based on the value set in the SSFC of CBI EEPROM memory. Using this change multiple i2c camera combinations with different I2C address can be tested with a single image. BUG=b:167938257 Change-Id: I6a5aa6c313c026871e55bc6d067b44de4c1f1afe Signed-off-by: Shawn Tu <shawnx.tu(a)intel.com> Signed-off-by: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> --- M src/drivers/intel/mipi_camera/Kconfig M src/drivers/intel/mipi_camera/Makefile.inc M src/drivers/intel/mipi_camera/camera.c A src/drivers/intel/mipi_camera/camera_sku.c A src/drivers/intel/mipi_camera/camera_sku.h 5 files changed, 146 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/45172/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/45172 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6a5aa6c313c026871e55bc6d067b44de4c1f1afe Gerrit-Change-Number: 45172 Gerrit-PatchSet: 9 Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: Andy Yeh <andy.yeh(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Chiasheng Lee <chiasheng.lee(a)intel.com> Gerrit-Reviewer: Jett Rink <jettrink(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: ShawnX Tu <shawnx.tu(a)intel.com> Gerrit-Reviewer: Tomasz Figa <tfiga(a)google.com> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-CC: Henry Sun <henrysun(a)google.com> Gerrit-CC: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2020