Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45607 )
Change subject: util/abuild/abuild: Do not check out submodules
......................................................................
util/abuild/abuild: Do not check out submodules
This force-downloads the qc_blobs repository, whose license is then
automatically accepted. This may also cause race conditions with git.
Change-Id: Id760172289abbe4d5ad5f230c9f1d3e1ab3908ec
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
---
M util/abuild/abuild
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/45607/1
diff --git a/util/abuild/abuild b/util/abuild/abuild
index 7561495..2ba2f72 100755
--- a/util/abuild/abuild
+++ b/util/abuild/abuild
@@ -794,8 +794,6 @@
echo | xargs -P ${cpus:-0} -n 1 echo 2>/dev/null >/dev/null && USE_XARGS=1
fi
-git submodule update --checkout --init
-
if [ "$USE_XARGS" = "0" ]; then
test "$MAKEFLAGS" == "" && test "$cpus" != "" && export MAKEFLAGS="-j $cpus"
export MAKEFLAGS="$MAKEFLAGS UPDATED_SUBMODULES=1" # no need to re-download
--
To view, visit https://review.coreboot.org/c/coreboot/+/45607
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id760172289abbe4d5ad5f230c9f1d3e1ab3908ec
Gerrit-Change-Number: 45607
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newchange
Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33742
Change subject: Documentation: Fix spelling of *assumptions*
......................................................................
Documentation: Fix spelling of *assumptions*
Change-Id: I36e0e713647cfc0d25e6b4ead81aa212be530afb
Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de>
---
M Documentation/arch/x86/index.md
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/33742/1
diff --git a/Documentation/arch/x86/index.md b/Documentation/arch/x86/index.md
index 0d8acf1..b4ad5c8 100644
--- a/Documentation/arch/x86/index.md
+++ b/Documentation/arch/x86/index.md
@@ -17,7 +17,7 @@
The following features enhance x86_64 support:
* The CPU supports 1GiB hugepages
-## Assuptions for ARCH_ROMSTAGE_X86_64 reference implementation
+## Assumptions for ARCH_ROMSTAGE_X86_64 reference implementation
* 0-4GiB are identity mapped as WB
* Memory above 4GiB isn't accessible
* pagetables reside in CAR area `_pagetables`
@@ -38,7 +38,7 @@
* 0-4GiB are identity mapped as WB
* page tables reside in heap
-## Assuptions for ARCH_RAMSTAGE_X86_64 reference implementation
+## Assumptions for ARCH_RAMSTAGE_X86_64 reference implementation
* pagetable are stored in fixed size heap area, initialized by assembly code
* Memory above 4GiB is not accessible
--
To view, visit https://review.coreboot.org/c/coreboot/+/33742
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36e0e713647cfc0d25e6b4ead81aa212be530afb
Gerrit-Change-Number: 33742
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newchange
Hello Michael Niewöhner, Patrick Rudolph,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/41784
to review the following change.
Change subject: util/supermicro: Always include commonlib/bsd/compiler.h
......................................................................
util/supermicro: Always include commonlib/bsd/compiler.h
We rely on `compiler.h` for definitions like `__packed`. Without it,
`smcbiosinfo.c` simply declared a global struct with that name, but
nothing was packed.
Change-Id: Ide055317115fc374a63812bcd3791445ca4f2dcc
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M util/supermicro/Makefile.inc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/41784/1
diff --git a/util/supermicro/Makefile.inc b/util/supermicro/Makefile.inc
index 1aa5bcb..316cb48 100644
--- a/util/supermicro/Makefile.inc
+++ b/util/supermicro/Makefile.inc
@@ -1,9 +1,11 @@
+TOOLCPPFLAGS += -include $(top)/src/commonlib/bsd/include/commonlib/bsd/compiler.h
+
SMCBIOSINFOTOOL:= $(objutil)/supermicro/smcbiosinfo
$(SMCBIOSINFOTOOL): $(dir)/smcbiosinfo/smcbiosinfo.c
printf " HOSTCC Creating SMCBIOSINFO tool\n"
mkdir -p $(objutil)/supermicro
- $(HOSTCC) $< -o $@
+ $(HOSTCC) $(TOOLCPPFLAGS) $< -o $@
ifeq ($(CONFIG_VENDOR_SUPERMICRO),y)
ifneq ($(call strip_quotes, $(CONFIG_SUPERMICRO_BOARDID)),)
--
To view, visit https://review.coreboot.org/c/coreboot/+/41784
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide055317115fc374a63812bcd3791445ca4f2dcc
Gerrit-Change-Number: 41784
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newchange