coreboot-gerrit August 2020

coreboot-gerrit@coreboot.org

1 participants
2457 discussions

Change in coreboot[master]: nb/intel/sandybridge: Deduplicate PCIEXBAR decoding
by Arthur Heymans (Code Review) 03 Aug '20

03 Aug '20

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44122 ) Change subject: nb/intel/sandybridge: Deduplicate PCIEXBAR decoding ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/44122 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I35bede573ef2635c54123f9e553003577ecd0ea7 Gerrit-Change-Number: 44122 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 03 Aug 2020 20:07:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/sandybridge: Refactor `get_pcie_bar`
by Arthur Heymans (Code Review) 03 Aug '20

03 Aug '20

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44121 ) Change subject: nb/intel/sandybridge: Refactor `get_pcie_bar` ...................................................................... Patch Set 4: Code-Review+1 (2 comments) https://review.coreboot.org/c/coreboot/+/44121/4/src/northbridge/intel/sand… File src/northbridge/intel/sandybridge/northbridge.c: https://review.coreboot.org/c/coreboot/+/44121/4/src/northbridge/intel/sand… PS4, Line 50: return 0; It might be personal preference but I think return 1 on error is more common. https://review.coreboot.org/c/coreboot/+/44121/4/src/northbridge/intel/sand… PS4, Line 143: decode_pcie_bar if this return an 'error' it should probably die given the pci mmconfig accesses done pretty much everywhere -- To view, visit https://review.coreboot.org/c/coreboot/+/44121 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id1c2cfbcac1a798d046beced790930511dc97972 Gerrit-Change-Number: 44121 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 03 Aug 2020 20:05:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/haswell: Deduplicate PCIEXBAR decoding
by Arthur Heymans (Code Review) 03 Aug '20

03 Aug '20

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44120 ) Change subject: nb/intel/haswell: Deduplicate PCIEXBAR decoding ...................................................................... Patch Set 4: Code-Review+2 (1 comment) https://review.coreboot.org/c/coreboot/+/44120/4/src/northbridge/intel/hasw… File src/northbridge/intel/haswell/northbridge.c: https://review.coreboot.org/c/coreboot/+/44120/4/src/northbridge/intel/hasw… PS4, Line 35: 1024 * 1024 Unrelated but MiB -- To view, visit https://review.coreboot.org/c/coreboot/+/44120 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If04ca3467bb067b28605a3acccb8bda325735999 Gerrit-Change-Number: 44120 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 03 Aug 2020 20:02:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/gm45: Deduplicate PCIEXBAR decoding
by Arthur Heymans (Code Review) 03 Aug '20

03 Aug '20

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44118 ) Change subject: nb/intel/gm45: Deduplicate PCIEXBAR decoding ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/44118 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4d005290355e30e6fdaae3e8e092891fddfbe4fc Gerrit-Change-Number: 44118 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 03 Aug 2020 20:00:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/**/{devicetree,overridetree}.cb: Indent with tabs
by Arthur Heymans (Code Review) 03 Aug '20

03 Aug '20

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44113 ) Change subject: mb/**/{devicetree,overridetree}.cb: Indent with tabs ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/44113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3d61f5210d21d9613fc50b47b90af71f544169a Gerrit-Change-Number: 44113 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Aug 2020 19:51:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: temporary patch for CPX-SP ww24 release
by Jonathan Zhang (Code Review) 03 Aug '20

03 Aug '20

Jonathan Zhang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42335 ) Change subject: drivers/intel/fsp2_0: temporary patch for CPX-SP ww24 release ...................................................................... drivers/intel/fsp2_0: temporary patch for CPX-SP ww24 release CPX-SP ww release upgraded FSP version fronm 2.1 to 2.2. This patch will be discarded once CB:41728 is merged, at which time CPX-SP soc needs to select PLATFORM_USES_FSP2_2. Signed-off-by: Jonathan Zhang <jonzhang(a)fb.com> Change-Id: I6580549b3c28c9f05fda595b4845c6f4728ef529 --- M src/drivers/intel/fsp2_0/util.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/42335/1 diff --git a/src/drivers/intel/fsp2_0/util.c b/src/drivers/intel/fsp2_0/util.c index a00b684..7b40deb 100644 --- a/src/drivers/intel/fsp2_0/util.c +++ b/src/drivers/intel/fsp2_0/util.c @@ -20,7 +20,7 @@ if (read32(raw_hdr + 4) != FSP_HDR_LEN) { printk(BIOS_ALERT, "FSP header has invalid length\n"); - return false; +// return false; } return true; -- To view, visit https://review.coreboot.org/c/coreboot/+/42335 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6580549b3c28c9f05fda595b4845c6f4728ef529 Gerrit-Change-Number: 42335 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 1

Change in coreboot[master]: mb/**/{devicetree,overridetree}.cb: Indent with tabs
by Angel Pons (Code Review) 03 Aug '20

03 Aug '20

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44113 ) Change subject: mb/**/{devicetree,overridetree}.cb: Indent with tabs ...................................................................... Patch Set 3: > Patch Set 3: Code-Review+2 > > could we also add indent-checking (linting) for *.cb files too to help prevent this in the future? I don't know much about how jenkins is set up. I think it should be doable, but I don't know much about checkpatch to know for sure. -- To view, visit https://review.coreboot.org/c/coreboot/+/44113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3d61f5210d21d9613fc50b47b90af71f544169a Gerrit-Change-Number: 44113 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Aug 2020 19:09:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/skylake: acpi: drop HWP's dependency on EIST
by Paul Menzel (Code Review) 03 Aug '20

03 Aug '20

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44137 ) Change subject: soc/intel/skylake: acpi: drop HWP's dependency on EIST ...................................................................... Patch Set 3: (2 comments) https://review.coreboot.org/c/coreboot/+/44137/3//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/44137/3//COMMIT_MSG@14 PS3, Line 14: it's its https://review.coreboot.org/c/coreboot/+/44137/3//COMMIT_MSG@21 PS3, Line 21: relation to the current workload. On what device? -- To view, visit https://review.coreboot.org/c/coreboot/+/44137 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I93d888ddce7b54e91b54e5b4fdd4d9cf16630eda Gerrit-Change-Number: 44137 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Matt Delco <delco(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 03 Aug 2020 18:40:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer/*/gpio.c: add GPP_D16 to early_gpio_table
by Nick Vaccaro (Code Review) 03 Aug '20

03 Aug '20

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44117 ) Change subject: mb/google/volteer/*/gpio.c: add GPP_D16 to early_gpio_table ...................................................................... Patch Set 1: This is missing changes for baseboard, Halvor, and Trondo. They each export their own early_gpio_table under certain conditions. -- To view, visit https://review.coreboot.org/c/coreboot/+/44117 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icf5e770f540e5d1e27b40f270bb004f4196bc7be Gerrit-Change-Number: 44117 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 03 Aug 2020 18:26:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer: pull-up GPP_D16 instead of driving it
by Nick Vaccaro (Code Review) 03 Aug '20

03 Aug '20

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44116 ) Change subject: mb/google/volteer: pull-up GPP_D16 instead of driving it ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/44116 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I096d76ec12b7c3afaf02e621fd301b6704913d5d Gerrit-Change-Number: 44116 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 03 Aug 2020 18:20:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2020