HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44404 )
Change subject: xeon_sp/cpx: Enable ACPI P-state support
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44404/8/src/soc/intel/xeon_sp/cpx/…
File src/soc/intel/xeon_sp/cpx/Kconfig:
https://review.coreboot.org/c/coreboot/+/44404/8/src/soc/intel/xeon_sp/cpx/…
PS8, Line 75: config CPU_BCLK_MHZ
: int
: default 100
:
: select CACHE_MRC_SETTINGS
that gives:
src/soc/intel/xeon_sp/cpx/Kconfig:79:warning: config symbol 'CPU_BCLK_MHZ' uses select, but is not boolean or tristate
--
To view, visit https://review.coreboot.org/c/coreboot/+/44404
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3bf3ad7f82fbf196a2134a8138b10176fc8be2cc
Gerrit-Change-Number: 44404
Gerrit-PatchSet: 8
Gerrit-Owner: Jingle Hsu <jingle_hsu(a)wiwynn.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Tue, 18 Aug 2020 15:44:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43420 )
Change subject: Documentation: Discuss how we use language
......................................................................
Patch Set 2: Code-Review+1
+2, but I'd like to hear other people's opinions on this topic.
--
To view, visit https://review.coreboot.org/c/coreboot/+/43420
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44fa30af538c78760821401c8d3c52029d95b72b
Gerrit-Change-Number: 43420
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Tue, 18 Aug 2020 13:43:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment