mail.coreboot.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
List overview
Download
coreboot-gerrit
August 2020
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
coreboot-gerrit@coreboot.org
1 participants
2457 discussions
Start a n
N
ew thread
Change in coreboot[master]: src/drivers: Add missing <{stddef,stdint}.h>
by HAOUAS Elyes (Code Review)
20 Aug '20
20 Aug '20
HAOUAS Elyes has uploaded this change for review. (
https://review.coreboot.org/c/coreboot/+/43968
) Change subject: src/drivers: Add missing <{stddef,stdint}.h> ...................................................................... src/drivers: Add missing <{stddef,stdint}.h> Change-Id: I4f7699c18c82c39af3c9741105150bb6d9599781 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/drivers/amd/agesa/state_machine.c M src/drivers/aspeed/common/aspeed_coreboot.h M src/drivers/crb/tis.c M src/drivers/crb/tpm.c M src/drivers/crb/tpm.h M src/drivers/generic/cbfs-serial/cbfs-serial.c M src/drivers/gfx/generic/generic.c M src/drivers/i2c/designware/dw_i2c.c M src/drivers/i2c/designware/dw_i2c.h M src/drivers/i2c/tpm/tis.c M src/drivers/i2c/tpm/tpm.h M src/drivers/intel/fsp1_1/fsp_relocate.c M src/drivers/intel/fsp1_1/mma_core.c M src/drivers/intel/fsp1_1/vbt.c M src/drivers/intel/fsp2_0/debug.c M src/drivers/intel/fsp2_0/hob_display.c M src/drivers/intel/fsp2_0/include/fsp/debug.h M src/drivers/intel/fsp2_0/mma_core.c M src/drivers/intel/fsp2_0/upd_display.c M src/drivers/intel/gma/acpi.c M src/drivers/intel/gma/vbt.c M src/drivers/pc80/tpm/tis.c M src/drivers/secunet/dmi/smbios.c M src/drivers/spi/bitbang.c M src/drivers/spi/spi_flash_internal.h M src/drivers/spi/spi_sdcard.c M src/drivers/spi/sst.c M src/drivers/spi/tpm/tis.c M src/drivers/spi/tpm/tpm.c 29 files changed, 53 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/43968/1 diff --git a/src/drivers/amd/agesa/state_machine.c b/src/drivers/amd/agesa/state_machine.c index 606a66f..01431b7 100644 --- a/src/drivers/amd/agesa/state_machine.c +++ b/src/drivers/amd/agesa/state_machine.c @@ -5,6 +5,7 @@ #include <acpi/acpi.h> #include <bootstate.h> #include <cbfs.h> +#include <stddef.h> #include <timestamp.h> #include <northbridge/amd/agesa/state_machine.h> diff --git a/src/drivers/aspeed/common/aspeed_coreboot.h b/src/drivers/aspeed/common/aspeed_coreboot.h index 3f740b2..57e3ec2 100644 --- a/src/drivers/aspeed/common/aspeed_coreboot.h +++ b/src/drivers/aspeed/common/aspeed_coreboot.h @@ -4,6 +4,7 @@ #define _ASPEED_COREBOOT_ #include <delay.h> +#include <stddef.h> #include <stdlib.h> #include <stdint.h> #include <string.h> diff --git a/src/drivers/crb/tis.c b/src/drivers/crb/tis.c index 9d12690..9359ac7 100644 --- a/src/drivers/crb/tis.c +++ b/src/drivers/crb/tis.c @@ -5,6 +5,8 @@ #include <acpi/acpigen.h> #include <device/device.h> #include <drivers/intel/ptt/ptt.h> +#include <stddef.h> +#include <stdint.h> #include "tpm.h" #include "chip.h" diff --git a/src/drivers/crb/tpm.c b/src/drivers/crb/tpm.c index 6436725..7c7f8e0 100644 --- a/src/drivers/crb/tpm.c +++ b/src/drivers/crb/tpm.c @@ -19,6 +19,8 @@ #include <string.h> #include <soc/pci_devs.h> #include <device/pci_ops.h> +#include <stddef.h> +#include <stdint.h> #include "tpm.h" diff --git a/src/drivers/crb/tpm.h b/src/drivers/crb/tpm.h index 449d02f..9c0effd 100644 --- a/src/drivers/crb/tpm.h +++ b/src/drivers/crb/tpm.h @@ -3,6 +3,10 @@ /* CRB driver */ /* address of locality 0 (CRB) */ + +#include <stddef.h> +#include <stdint.h> + #define TPM_CRB_BASE_ADDRESS CONFIG_CRB_TPM_BASE_ADDRESS #define CRB_REG(LOCTY, REG) \ diff --git a/src/drivers/generic/cbfs-serial/cbfs-serial.c b/src/drivers/generic/cbfs-serial/cbfs-serial.c index 2e3e37d..78ab0d5 100644 --- a/src/drivers/generic/cbfs-serial/cbfs-serial.c +++ b/src/drivers/generic/cbfs-serial/cbfs-serial.c @@ -3,6 +3,7 @@ #include <cbfs.h> #include <device/device.h> #include <smbios.h> +#include <stddef.h> #include <string.h> diff --git a/src/drivers/gfx/generic/generic.c b/src/drivers/gfx/generic/generic.c index 546f30b..621482b 100644 --- a/src/drivers/gfx/generic/generic.c +++ b/src/drivers/gfx/generic/generic.c @@ -5,6 +5,7 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> +#include <stddef.h> #include "chip.h" diff --git a/src/drivers/i2c/designware/dw_i2c.c b/src/drivers/i2c/designware/dw_i2c.c index 00865e3..f690c9c 100644 --- a/src/drivers/i2c/designware/dw_i2c.c +++ b/src/drivers/i2c/designware/dw_i2c.c @@ -6,8 +6,11 @@ #include <device/device.h> #include <device/i2c_bus.h> #include <device/i2c_simple.h> +#include <stddef.h> +#include <stdint.h> #include <string.h> #include <timer.h> + #include "dw_i2c.h" /* Use a ~10ms timeout for various operations */ diff --git a/src/drivers/i2c/designware/dw_i2c.h b/src/drivers/i2c/designware/dw_i2c.h index 45f305e..a69173c 100644 --- a/src/drivers/i2c/designware/dw_i2c.h +++ b/src/drivers/i2c/designware/dw_i2c.h @@ -5,6 +5,7 @@ #include <device/device.h> #include <device/i2c.h> +#include <stddef.h> #include <stdint.h> #if CONFIG(DRIVERS_I2C_DESIGNWARE_DEBUG) diff --git a/src/drivers/i2c/tpm/tis.c b/src/drivers/i2c/tpm/tis.c index 217d8c6..33071ab 100644 --- a/src/drivers/i2c/tpm/tis.c +++ b/src/drivers/i2c/tpm/tis.c @@ -10,6 +10,7 @@ #include <endian.h> #include <lib.h> #include <security/tpm/tis.h> +#include <stddef.h> #include "tpm.h" diff --git a/src/drivers/i2c/tpm/tpm.h b/src/drivers/i2c/tpm/tpm.h index eb4fef1..56af45e 100644 --- a/src/drivers/i2c/tpm/tpm.h +++ b/src/drivers/i2c/tpm/tpm.h @@ -12,6 +12,7 @@ #ifndef __DRIVERS_TPM_SLB9635_I2C_TPM_H__ #define __DRIVERS_TPM_SLB9635_I2C_TPM_H__ +#include <stddef.h> #include <stdint.h> enum tpm_timeout { diff --git a/src/drivers/intel/fsp1_1/fsp_relocate.c b/src/drivers/intel/fsp1_1/fsp_relocate.c index d078f59..11a2655 100644 --- a/src/drivers/intel/fsp1_1/fsp_relocate.c +++ b/src/drivers/intel/fsp1_1/fsp_relocate.c @@ -4,6 +4,8 @@ #include <cbmem.h> #include <commonlib/fsp.h> #include <fsp/util.h> +#include <stddef.h> +#include <stdint.h> int fsp_relocate(struct prog *fsp_relocd, const struct region_device *fsp_src) { diff --git a/src/drivers/intel/fsp1_1/mma_core.c b/src/drivers/intel/fsp1_1/mma_core.c index 6e50373..9f41674 100644 --- a/src/drivers/intel/fsp1_1/mma_core.c +++ b/src/drivers/intel/fsp1_1/mma_core.c @@ -4,6 +4,7 @@ #include <fsp/util.h> #include <fsp/romstage.h> #include <fsp/soc_binding.h> +#include <stddef.h> #define FSP_MMA_RESULTS_GUID { 0x8f4e928, 0xf5f, 0x46d4, \ { 0x84, 0x10, 0x47, 0x9f, 0xda, 0x27, 0x9d, 0xb6 } } diff --git a/src/drivers/intel/fsp1_1/vbt.c b/src/drivers/intel/fsp1_1/vbt.c index 88f14ee..52cba1a 100644 --- a/src/drivers/intel/fsp1_1/vbt.c +++ b/src/drivers/intel/fsp1_1/vbt.c @@ -6,6 +6,8 @@ #include <fsp/ramstage.h> #include <fsp/util.h> #include <lib.h> +#include <stddef.h> +#include <stdint.h> /* Locate VBT and pass it to FSP GOP */ void load_vbt(uint8_t s3_resume, SILICON_INIT_UPD *params) diff --git a/src/drivers/intel/fsp2_0/debug.c b/src/drivers/intel/fsp2_0/debug.c index 3d66587..731d344 100644 --- a/src/drivers/intel/fsp2_0/debug.c +++ b/src/drivers/intel/fsp2_0/debug.c @@ -4,6 +4,8 @@ #include <console/streams.h> #include <cpu/x86/mtrr.h> #include <fsp/util.h> +#include <stddef.h> +#include <stdint.h> asmlinkage size_t fsp_write_line(uint8_t *buffer, size_t number_of_bytes) { diff --git a/src/drivers/intel/fsp2_0/hob_display.c b/src/drivers/intel/fsp2_0/hob_display.c index f21ebfe..e955e2e 100644 --- a/src/drivers/intel/fsp2_0/hob_display.c +++ b/src/drivers/intel/fsp2_0/hob_display.c @@ -2,6 +2,8 @@ #include <console/console.h> #include <fsp/util.h> +#include <stddef.h> +#include <stdint.h> struct hob_type_name { uint16_t type; diff --git a/src/drivers/intel/fsp2_0/include/fsp/debug.h b/src/drivers/intel/fsp2_0/include/fsp/debug.h index e3d1918..9408d37 100644 --- a/src/drivers/intel/fsp2_0/include/fsp/debug.h +++ b/src/drivers/intel/fsp2_0/include/fsp/debug.h @@ -4,6 +4,8 @@ #define _FSP2_0_DEBUG_H_ #include <fsp/util.h> +#include <stddef.h> +#include <stdint.h> /* FSP debug API */ void fsp_debug_before_memory_init(fsp_memory_init_fn memory_init, diff --git a/src/drivers/intel/fsp2_0/mma_core.c b/src/drivers/intel/fsp2_0/mma_core.c index c19b299..94b9a08 100644 --- a/src/drivers/intel/fsp2_0/mma_core.c +++ b/src/drivers/intel/fsp2_0/mma_core.c @@ -3,6 +3,8 @@ #include <console/console.h> #include <fsp/util.h> #include <fsp/soc_binding.h> +#include <stddef.h> +#include <stdint.h> static const uint8_t mma_results_uuid[16] = { 0x28, 0xe9, 0xf4, 0x08, 0x5f, 0x0f, 0xd4, 0x46, diff --git a/src/drivers/intel/fsp2_0/upd_display.c b/src/drivers/intel/fsp2_0/upd_display.c index 63d6e60..032bb2c 100644 --- a/src/drivers/intel/fsp2_0/upd_display.c +++ b/src/drivers/intel/fsp2_0/upd_display.c @@ -3,6 +3,8 @@ #include <console/console.h> #include <fsp/util.h> #include <lib.h> +#include <stddef.h> +#include <stdint.h> void fsp_display_upd_value(const char *name, size_t size, uint64_t old, uint64_t new) diff --git a/src/drivers/intel/gma/acpi.c b/src/drivers/intel/gma/acpi.c index 4a89bb9..fd78255 100644 --- a/src/drivers/intel/gma/acpi.c +++ b/src/drivers/intel/gma/acpi.c @@ -4,6 +4,7 @@ #include <acpi/acpigen.h> #include <string.h> #include "i915.h" +#include <stddef.h> void drivers_intel_gma_displays_ssdt_generate(const struct i915_gpu_controller_info *conf) diff --git a/src/drivers/intel/gma/vbt.c b/src/drivers/intel/gma/vbt.c index b42c52d..dd85592 100644 --- a/src/drivers/intel/gma/vbt.c +++ b/src/drivers/intel/gma/vbt.c @@ -5,6 +5,8 @@ #include <string.h> #include <device/pci.h> #include <drivers/intel/gma/opregion.h> +#include <stddef.h> +#include <stdint.h> #include "i915.h" #include "intel_bios.h" diff --git a/src/drivers/pc80/tpm/tis.c b/src/drivers/pc80/tpm/tis.c index 27d238c..fe93796 100644 --- a/src/drivers/pc80/tpm/tis.c +++ b/src/drivers/pc80/tpm/tis.c @@ -21,6 +21,9 @@ #include <console/console.h> #include <security/tpm/tis.h> #include <device/pnp.h> +#include <stddef.h> +#include <stdint.h> + #include "chip.h" #define PREFIX "lpc_tpm: " diff --git a/src/drivers/secunet/dmi/smbios.c b/src/drivers/secunet/dmi/smbios.c index f407b51..265b5ad 100644 --- a/src/drivers/secunet/dmi/smbios.c +++ b/src/drivers/secunet/dmi/smbios.c @@ -9,6 +9,7 @@ #include <device/device.h> #include <device/i2c_bus.h> #include <smbios.h> +#include <stddef.h> #include "eeprom.h" diff --git a/src/drivers/spi/bitbang.c b/src/drivers/spi/bitbang.c index 168ec64..54a91c5 100644 --- a/src/drivers/spi/bitbang.c +++ b/src/drivers/spi/bitbang.c @@ -3,6 +3,8 @@ #include <console/console.h> #include <delay.h> #include <spi_bitbang.h> +#include <stddef.h> +#include <stdint.h> /* Set to 1 to dump all SPI transfers to the UART. */ #define TRACE 0 diff --git a/src/drivers/spi/spi_flash_internal.h b/src/drivers/spi/spi_flash_internal.h index b4d39b3..fa99723 100644 --- a/src/drivers/spi/spi_flash_internal.h +++ b/src/drivers/spi/spi_flash_internal.h @@ -7,6 +7,9 @@ #ifndef SPI_FLASH_INTERNAL_H #define SPI_FLASH_INTERNAL_H +#include <stddef.h> +#include <stdint.h> + /* Common commands */ #define CMD_READ_ID 0x9f diff --git a/src/drivers/spi/spi_sdcard.c b/src/drivers/spi/spi_sdcard.c index 5d0a71b..55be5dd 100644 --- a/src/drivers/spi/spi_sdcard.c +++ b/src/drivers/spi/spi_sdcard.c @@ -1,4 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ + #include <stdint.h> #include <string.h> #include <spi-generic.h> @@ -6,6 +7,7 @@ #include <crc_byte.h> #include <commonlib/helpers.h> #include <console/console.h> +#include <stddef.h> //#define SPI_SDCARD_DEBUG diff --git a/src/drivers/spi/sst.c b/src/drivers/spi/sst.c index 887380f..d721668 100644 --- a/src/drivers/spi/sst.c +++ b/src/drivers/spi/sst.c @@ -8,6 +8,8 @@ #include <commonlib/helpers.h> #include <spi_flash.h> #include <spi-generic.h> +#include <stddef.h> +#include <stdint.h> #include "spi_flash_internal.h" diff --git a/src/drivers/spi/tpm/tis.c b/src/drivers/spi/tpm/tis.c index 6849ea7..db74067 100644 --- a/src/drivers/spi/tpm/tis.c +++ b/src/drivers/spi/tpm/tis.c @@ -2,6 +2,8 @@ #include <console/console.h> #include <security/tpm/tis.h> +#include <stddef.h> +#include <stdint.h> #include "tpm.h" diff --git a/src/drivers/spi/tpm/tpm.c b/src/drivers/spi/tpm/tpm.c index 4263dce..5bbb8a6 100644 --- a/src/drivers/spi/tpm/tpm.c +++ b/src/drivers/spi/tpm/tpm.c @@ -19,6 +19,8 @@ #include <string.h> #include <timer.h> #include <security/tpm/tis.h> +#include <stddef.h> +#include <stdint.h> #include "tpm.h" -- To view, visit
https://review.coreboot.org/c/coreboot/+/43968
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f7699c18c82c39af3c9741105150bb6d9599781 Gerrit-Change-Number: 43968 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange
1
3
0
0
Change in coreboot[master]: sb/intel: Add missing '#include <stddef.h>'
by HAOUAS Elyes (Code Review)
20 Aug '20
20 Aug '20
HAOUAS Elyes has uploaded this change for review. (
https://review.coreboot.org/c/coreboot/+/43941
) Change subject: sb/intel: Add missing '#include <stddef.h>' ...................................................................... sb/intel: Add missing '#include <stddef.h>' size_t needs <stddef.h>. Change-Id: Ifb14124fcb2b6a7cbd7f172fe47b4016d159cf1d Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/southbridge/intel/bd82x6x/lpc.c M src/southbridge/intel/common/spi.c M src/southbridge/intel/lynxpoint/lpc.c 3 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/43941/1 diff --git a/src/southbridge/intel/bd82x6x/lpc.c b/src/southbridge/intel/bd82x6x/lpc.c index 2407d92..abf88f8 100644 --- a/src/southbridge/intel/bd82x6x/lpc.c +++ b/src/southbridge/intel/bd82x6x/lpc.c @@ -16,6 +16,7 @@ #include <acpi/acpigen.h> #include <cpu/x86/smm.h> #include <cbmem.h> +#include <stddef.h> #include <string.h> #include "chip.h" #include "pch.h" diff --git a/src/southbridge/intel/common/spi.c b/src/southbridge/intel/common/spi.c index 380940c..1ce2d9d 100644 --- a/src/southbridge/intel/common/spi.c +++ b/src/southbridge/intel/common/spi.c @@ -16,6 +16,7 @@ #include <device/pci.h> #include <spi_flash.h> #include <spi-generic.h> +#include <stddef.h> #include <timer.h> #include "spi.h" diff --git a/src/southbridge/intel/lynxpoint/lpc.c b/src/southbridge/intel/lynxpoint/lpc.c index 7082a79..1235fac 100644 --- a/src/southbridge/intel/lynxpoint/lpc.c +++ b/src/southbridge/intel/lynxpoint/lpc.c @@ -14,6 +14,7 @@ #include <acpi/acpi_gnvs.h> #include <cpu/x86/smm.h> #include <cbmem.h> +#include <stddef.h> #include <string.h> #include "chip.h" #include "nvs.h" -- To view, visit
https://review.coreboot.org/c/coreboot/+/43941
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifb14124fcb2b6a7cbd7f172fe47b4016d159cf1d Gerrit-Change-Number: 43941 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange
1
4
0
0
Change in coreboot[master]: src/device: Add missing <{stddef,stdint}.h>
by HAOUAS Elyes (Code Review)
20 Aug '20
20 Aug '20
HAOUAS Elyes has uploaded this change for review. (
https://review.coreboot.org/c/coreboot/+/43948
) Change subject: src/device: Add missing <{stddef,stdint}.h> ...................................................................... src/device: Add missing <{stddef,stdint}.h> Change-Id: I8e36640522490de47f347e7ff9f8736f681ab048 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/device/i2c_bus.c M src/device/mmio.c M src/device/oprom/x86emu/sys.c M src/device/pci_rom.c 4 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/43948/1 diff --git a/src/device/i2c_bus.c b/src/device/i2c_bus.c index a65cdad..155107b 100644 --- a/src/device/i2c_bus.c +++ b/src/device/i2c_bus.c @@ -5,6 +5,7 @@ #include <device/smbus.h> #include <device/i2c_bus.h> #include <commonlib/endian.h> +#include <stddef.h> struct bus *i2c_link(struct device *const dev) { diff --git a/src/device/mmio.c b/src/device/mmio.c index 8b08b9b..71da959 100644 --- a/src/device/mmio.c +++ b/src/device/mmio.c @@ -2,6 +2,8 @@ #include <assert.h> #include <device/mmio.h> +#include <stddef.h> +#include <stdint.h> /* Helper functions for various MMIO access patterns. */ diff --git a/src/device/oprom/x86emu/sys.c b/src/device/oprom/x86emu/sys.c index 06f240c..2fb426f 100644 --- a/src/device/oprom/x86emu/sys.c +++ b/src/device/oprom/x86emu/sys.c @@ -44,6 +44,9 @@ #include <x86emu/x86emu.h> #include <x86emu/regs.h> #include <device/oprom/include/io.h> +#include <stddef.h> +#include <stdint.h> + #include "debug.h" #include "prim_ops.h" diff --git a/src/device/pci_rom.c b/src/device/pci_rom.c index bb616d9..5758590 100644 --- a/src/device/pci_rom.c +++ b/src/device/pci_rom.c @@ -10,6 +10,8 @@ #include <cbfs.h> #include <cbmem.h> #include <acpi/acpigen.h> +#include <stddef.h> +#include <stdint.h> /* Rmodules don't like weak symbols. */ void __weak map_oprom_vendev_rev(u32 *vendev, u8 *rev) { return; } -- To view, visit
https://review.coreboot.org/c/coreboot/+/43948
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8e36640522490de47f347e7ff9f8736f681ab048 Gerrit-Change-Number: 43948 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange
1
2
0
0
Change in coreboot[master]: src/superio: Add missing <{stdbool,stdint}.h>
by HAOUAS Elyes (Code Review)
20 Aug '20
20 Aug '20
HAOUAS Elyes has uploaded this change for review. (
https://review.coreboot.org/c/coreboot/+/43954
) Change subject: src/superio: Add missing <{stdbool,stdint}.h> ...................................................................... src/superio: Add missing <{stdbool,stdint}.h> Change-Id: I7fb1a65278efa0fe8656d5d6ea8bf30161818ed6 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/superio/aspeed/ast2400/chip.h M src/superio/ite/common/env_ctrl_chip.h M src/superio/nuvoton/nct5104d/superio.c 3 files changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/43954/1 diff --git a/src/superio/aspeed/ast2400/chip.h b/src/superio/aspeed/ast2400/chip.h index 262f815..1634a34 100644 --- a/src/superio/aspeed/ast2400/chip.h +++ b/src/superio/aspeed/ast2400/chip.h @@ -3,6 +3,8 @@ #ifndef __SUPERIO_ASPEED__AST2400_CHIP_H__ #define __SUPERIO_ASPEED__AST2400_CHIP_H__ +#include <stdbool.h> + struct superio_aspeed_ast2400_config { /* On AST2500 only 1: ESPI, 0: LPC */ bool use_espi; diff --git a/src/superio/ite/common/env_ctrl_chip.h b/src/superio/ite/common/env_ctrl_chip.h index 6a027b9..e2aaec3 100644 --- a/src/superio/ite/common/env_ctrl_chip.h +++ b/src/superio/ite/common/env_ctrl_chip.h @@ -3,6 +3,9 @@ #ifndef SUPERIO_ITE_ENV_CTRL_CHIP_H #define SUPERIO_ITE_ENV_CTRL_CHIP_H +#include <stdbool.h> +#include <stdint.h> + #define ITE_EC_TMPIN_CNT 3 #if CONFIG(SUPERIO_ITE_ENV_CTRL_5FANS) diff --git a/src/superio/nuvoton/nct5104d/superio.c b/src/superio/nuvoton/nct5104d/superio.c index 3351ad9..db3d74d 100644 --- a/src/superio/nuvoton/nct5104d/superio.c +++ b/src/superio/nuvoton/nct5104d/superio.c @@ -3,6 +3,8 @@ #include <console/console.h> #include <device/pnp.h> #include <device/device.h> +#include <stdbool.h> +#include <stdint.h> #include <superio/conf_mode.h> #include "nct5104d.h" -- To view, visit
https://review.coreboot.org/c/coreboot/+/43954
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7fb1a65278efa0fe8656d5d6ea8bf30161818ed6 Gerrit-Change-Number: 43954 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange
2
3
0
0
Change in coreboot[master]: src/northbridge: Add missing <{stddef,stdint}|types>
by HAOUAS Elyes (Code Review)
20 Aug '20
20 Aug '20
HAOUAS Elyes has uploaded this change for review. (
https://review.coreboot.org/c/coreboot/+/43947
) Change subject: src/northbridge: Add missing <{stddef,stdint}|types> ...................................................................... src/northbridge: Add missing <{stddef,stdint}|types> Change-Id: I3d189080b770afa5e5478e4908b3340227948498 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/northbridge/amd/agesa/dimmSpd.h M src/northbridge/amd/pi/dimmSpd.h M src/northbridge/intel/gm45/memmap.c M src/northbridge/intel/haswell/memmap.c M src/northbridge/intel/haswell/northbridge.c M src/northbridge/intel/i945/memmap.c M src/northbridge/intel/ironlake/memmap.c M src/northbridge/intel/pineview/memmap.c M src/northbridge/intel/x4x/memmap.c 9 files changed, 15 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/43947/1 diff --git a/src/northbridge/amd/agesa/dimmSpd.h b/src/northbridge/amd/agesa/dimmSpd.h index dbcb106..aaa3ced 100644 --- a/src/northbridge/amd/agesa/dimmSpd.h +++ b/src/northbridge/amd/agesa/dimmSpd.h @@ -3,6 +3,8 @@ #ifndef _DIMMSPD_H_ #define _DIMMSPD_H_ +#include <stddef.h> + AGESA_STATUS AmdMemoryReadSPD (IN UINT32 Func, IN UINTN Data, IN OUT AGESA_READ_SPD_PARAMS *SpdData); diff --git a/src/northbridge/amd/pi/dimmSpd.h b/src/northbridge/amd/pi/dimmSpd.h index dbcb106..aaa3ced 100644 --- a/src/northbridge/amd/pi/dimmSpd.h +++ b/src/northbridge/amd/pi/dimmSpd.h @@ -3,6 +3,8 @@ #ifndef _DIMMSPD_H_ #define _DIMMSPD_H_ +#include <stddef.h> + AGESA_STATUS AmdMemoryReadSPD (IN UINT32 Func, IN UINTN Data, IN OUT AGESA_READ_SPD_PARAMS *SpdData); diff --git a/src/northbridge/intel/gm45/memmap.c b/src/northbridge/intel/gm45/memmap.c index 4fe3998..cafdb46 100644 --- a/src/northbridge/intel/gm45/memmap.c +++ b/src/northbridge/intel/gm45/memmap.c @@ -14,6 +14,7 @@ #include <program_loading.h> #include <cpu/intel/smm_reloc.h> #include "gm45.h" +#include <stddef.h> /* * Decodes used Graphics Mode Select (GMS) to kilobytes. diff --git a/src/northbridge/intel/haswell/memmap.c b/src/northbridge/intel/haswell/memmap.c index a86efeb..368fbb3 100644 --- a/src/northbridge/intel/haswell/memmap.c +++ b/src/northbridge/intel/haswell/memmap.c @@ -9,6 +9,9 @@ #include <cpu/x86/smm.h> #include <device/pci_ops.h> #include <cbmem.h> +#include <stddef.h> +#include <stdint.h> + #include "haswell.h" static uintptr_t smm_region_start(void) diff --git a/src/northbridge/intel/haswell/northbridge.c b/src/northbridge/intel/haswell/northbridge.c index ef7742e..864cd83 100644 --- a/src/northbridge/intel/haswell/northbridge.c +++ b/src/northbridge/intel/haswell/northbridge.c @@ -3,7 +3,6 @@ #include <commonlib/helpers.h> #include <console/console.h> #include <acpi/acpi.h> -#include <stdint.h> #include <delay.h> #include <cpu/intel/haswell/haswell.h> #include <device/device.h> @@ -12,6 +11,7 @@ #include <device/pci_ids.h> #include <device/pci_ops.h> #include <boot/tables.h> +#include <types.h> #include "chip.h" #include "haswell.h" diff --git a/src/northbridge/intel/i945/memmap.c b/src/northbridge/intel/i945/memmap.c index c92e466..4961d28 100644 --- a/src/northbridge/intel/i945/memmap.c +++ b/src/northbridge/intel/i945/memmap.c @@ -12,6 +12,7 @@ #include <cpu/x86/smm.h> #include <program_loading.h> #include <cpu/intel/smm_reloc.h> +#include <stddef.h> #include <stdint.h> /* Decodes TSEG region size to bytes. */ diff --git a/src/northbridge/intel/ironlake/memmap.c b/src/northbridge/intel/ironlake/memmap.c index 406b9a9..9d991bc 100644 --- a/src/northbridge/intel/ironlake/memmap.c +++ b/src/northbridge/intel/ironlake/memmap.c @@ -9,6 +9,9 @@ #include <cpu/x86/smm.h> #include <program_loading.h> #include <cpu/intel/smm_reloc.h> +#include <stddef.h> +#include <stdint.h> + #include "ironlake.h" static uintptr_t smm_region_start(void) diff --git a/src/northbridge/intel/pineview/memmap.c b/src/northbridge/intel/pineview/memmap.c index ad89aef..bf9ebc6b 100644 --- a/src/northbridge/intel/pineview/memmap.c +++ b/src/northbridge/intel/pineview/memmap.c @@ -12,6 +12,7 @@ #include <cpu/x86/mtrr.h> #include <cpu/x86/smm.h> #include <cpu/intel/smm_reloc.h> +#include <stddef.h> #include <stdint.h> u8 decode_pciebar(u32 *const base, u32 *const len) diff --git a/src/northbridge/intel/x4x/memmap.c b/src/northbridge/intel/x4x/memmap.c index ee1ec5e..97abafc 100644 --- a/src/northbridge/intel/x4x/memmap.c +++ b/src/northbridge/intel/x4x/memmap.c @@ -14,6 +14,7 @@ #include <northbridge/intel/x4x/x4x.h> #include <program_loading.h> #include <cpu/intel/smm_reloc.h> +#include <stddef.h> /** Decodes used Graphics Mode Select (GMS) to kilobytes. */ u32 decode_igd_memory_size(const u32 gms) -- To view, visit
https://review.coreboot.org/c/coreboot/+/43947
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3d189080b770afa5e5478e4908b3340227948498 Gerrit-Change-Number: 43947 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange
2
4
0
0
Change in coreboot[master]: src/superio: Add missing '#include <stddef.h>'
by HAOUAS Elyes (Code Review)
20 Aug '20
20 Aug '20
HAOUAS Elyes has uploaded this change for review. (
https://review.coreboot.org/c/coreboot/+/43942
) Change subject: src/superio: Add missing '#include <stddef.h>' ...................................................................... src/superio: Add missing '#include <stddef.h>' size_t needs <stddef.h>. Change-Id: Ic6ffeb3881ee581c5e5b5d614dfd6efda2e5b2c2 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/superio/aspeed/ast2400/superio.c M src/superio/smsc/sch5545/sch5545_emi.c M src/superio/smsc/sch5545/sch5545_emi.h 3 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/43942/1 diff --git a/src/superio/aspeed/ast2400/superio.c b/src/superio/aspeed/ast2400/superio.c index 4510c21..1c6e436 100644 --- a/src/superio/aspeed/ast2400/superio.c +++ b/src/superio/aspeed/ast2400/superio.c @@ -6,6 +6,8 @@ #include <pc80/keyboard.h> #include <superio/common/ssdt.h> #include <acpi/acpi.h> +#include <stddef.h> + #include "ast2400.h" #include "chip.h" diff --git a/src/superio/smsc/sch5545/sch5545_emi.c b/src/superio/smsc/sch5545/sch5545_emi.c index 2bb150c..8031129 100644 --- a/src/superio/smsc/sch5545/sch5545_emi.c +++ b/src/superio/smsc/sch5545/sch5545_emi.c @@ -5,6 +5,7 @@ #include <device/pnp.h> #include <device/pnp_def.h> #include <device/pnp_ops.h> +#include <stddef.h> #include <superio/conf_mode.h> #include "sch5545.h" diff --git a/src/superio/smsc/sch5545/sch5545_emi.h b/src/superio/smsc/sch5545/sch5545_emi.h index 2bf3a76..5b622de 100644 --- a/src/superio/smsc/sch5545/sch5545_emi.h +++ b/src/superio/smsc/sch5545/sch5545_emi.h @@ -3,6 +3,7 @@ #ifndef SUPERIO_SCH_5545_EMI_H #define SUPERIO_SCH_5545_EMI_H +#include <stddef.h> #include <stdlib.h> #include <stdint.h> -- To view, visit
https://review.coreboot.org/c/coreboot/+/43942
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic6ffeb3881ee581c5e5b5d614dfd6efda2e5b2c2 Gerrit-Change-Number: 43942 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange
3
9
0
0
Change in coreboot[master]: sb/intel: Include <stdint.h>
by HAOUAS Elyes (Code Review)
20 Aug '20
20 Aug '20
HAOUAS Elyes has uploaded this change for review. (
https://review.coreboot.org/c/coreboot/+/44203
) Change subject: sb/intel: Include <stdint.h> ...................................................................... sb/intel: Include <stdint.h> Those files only needs <stdint.h>. Change-Id: I1a027e9e5cae0759c2bd4f51da9094edbce7076b Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/southbridge/intel/bd82x6x/smihandler.c M src/southbridge/intel/common/pmutil.c M src/southbridge/intel/i82801gx/smihandler.c M src/southbridge/intel/i82801ix/smihandler.c M src/southbridge/intel/i82801jx/smihandler.c M src/southbridge/intel/ibexpeak/smihandler.c 6 files changed, 10 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/44203/1 diff --git a/src/southbridge/intel/bd82x6x/smihandler.c b/src/southbridge/intel/bd82x6x/smihandler.c index 8af1428..6aaef7b 100644 --- a/src/southbridge/intel/bd82x6x/smihandler.c +++ b/src/southbridge/intel/bd82x6x/smihandler.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <types.h> #include <arch/io.h> #include <device/pci_ops.h> #include <console/console.h> @@ -13,6 +12,7 @@ #include <cpu/intel/model_206ax/model_206ax.h> #include <southbridge/intel/common/pmutil.h> #include <southbridge/intel/common/finalize.h> +#include <stdint.h> #include "pch.h" #include "nvs.h" diff --git a/src/southbridge/intel/common/pmutil.c b/src/southbridge/intel/common/pmutil.c index d8196f8..10b756c 100644 --- a/src/southbridge/intel/common/pmutil.c +++ b/src/southbridge/intel/common/pmutil.c @@ -1,10 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <types.h> #include <console/console.h> #include <device/pci_def.h> #include <southbridge/intel/common/pmbase.h> #include <southbridge/intel/common/gpio.h> +#include <stdint.h> #include "pmutil.h" diff --git a/src/southbridge/intel/i82801gx/smihandler.c b/src/southbridge/intel/i82801gx/smihandler.c index 562dae3..6f63869 100644 --- a/src/southbridge/intel/i82801gx/smihandler.c +++ b/src/southbridge/intel/i82801gx/smihandler.c @@ -1,10 +1,11 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <types.h> #include <console/console.h> #include <cpu/x86/smm.h> #include <device/pci_def.h> #include <southbridge/intel/common/pmutil.h> +#include <stdint.h> + #include "i82801gx.h" /* I945 */ diff --git a/src/southbridge/intel/i82801ix/smihandler.c b/src/southbridge/intel/i82801ix/smihandler.c index 699f51f..b8bd738 100644 --- a/src/southbridge/intel/i82801ix/smihandler.c +++ b/src/southbridge/intel/i82801ix/smihandler.c @@ -1,10 +1,11 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <types.h> #include <console/console.h> #include <cpu/x86/smm.h> #include <device/pci_def.h> #include <southbridge/intel/common/pmutil.h> +#include <stdint.h> + #include "i82801ix.h" #include "nvs.h" diff --git a/src/southbridge/intel/i82801jx/smihandler.c b/src/southbridge/intel/i82801jx/smihandler.c index 16ec025..4b65de0 100644 --- a/src/southbridge/intel/i82801jx/smihandler.c +++ b/src/southbridge/intel/i82801jx/smihandler.c @@ -1,12 +1,12 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <types.h> #include <console/console.h> #include <cpu/x86/smm.h> #include <device/pci_def.h> #include <southbridge/intel/common/pmutil.h> -#include "i82801jx.h" +#include <stdint.h> +#include "i82801jx.h" #include "nvs.h" /* While we read PMBASE dynamically in case it changed, let's diff --git a/src/southbridge/intel/ibexpeak/smihandler.c b/src/southbridge/intel/ibexpeak/smihandler.c index 2bc31cf..b33d6f5 100644 --- a/src/southbridge/intel/ibexpeak/smihandler.c +++ b/src/southbridge/intel/ibexpeak/smihandler.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <types.h> #include <arch/io.h> #include <device/pci_ops.h> #include <console/console.h> @@ -11,8 +10,9 @@ #include <southbridge/intel/common/finalize.h> #include <southbridge/intel/common/pmbase.h> #include <southbridge/intel/ibexpeak/me.h> -#include "pch.h" +#include <stdint.h> +#include "pch.h" #include "nvs.h" /* We are using PCIe accesses for now -- To view, visit
https://review.coreboot.org/c/coreboot/+/44203
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1a027e9e5cae0759c2bd4f51da9094edbce7076b Gerrit-Change-Number: 44203 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange
1
1
0
0
Change in coreboot[master]: sb/amd/pi/hudson/smbus_spd.c: Add missing #include <stddef.h>
by HAOUAS Elyes (Code Review)
20 Aug '20
20 Aug '20
HAOUAS Elyes has uploaded this change for review. (
https://review.coreboot.org/c/coreboot/+/43940
) Change subject: sb/amd/pi/hudson/smbus_spd.c: Add missing #include <stddef.h> ...................................................................... sb/amd/pi/hudson/smbus_spd.c: Add missing #include <stddef.h> size_t needs <stddef.h>. Change-Id: I4f637be5e213fb5d4773b370ac6302b6ceee9ebc Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/southbridge/amd/pi/hudson/smbus_spd.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/43940/1 diff --git a/src/southbridge/amd/pi/hudson/smbus_spd.c b/src/southbridge/amd/pi/hudson/smbus_spd.c index 5a890bc..8443282 100644 --- a/src/southbridge/amd/pi/hudson/smbus_spd.c +++ b/src/southbridge/amd/pi/hudson/smbus_spd.c @@ -4,6 +4,7 @@ #include <console/console.h> #include <device/pci_def.h> #include <device/device.h> +#include <stddef.h> /* warning: Porting.h includes an open #pragma pack(1) */ #include <Porting.h> -- To view, visit
https://review.coreboot.org/c/coreboot/+/43940
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f637be5e213fb5d4773b370ac6302b6ceee9ebc Gerrit-Change-Number: 43940 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange
1
2
0
0
Change in coreboot[master]: src/include: Add missing <stdbool.h>
by HAOUAS Elyes (Code Review)
20 Aug '20
20 Aug '20
HAOUAS Elyes has uploaded this change for review. (
https://review.coreboot.org/c/coreboot/+/43955
) Change subject: src/include: Add missing <stdbool.h> ...................................................................... src/include: Add missing <stdbool.h> Include <types.h> when stddef, stdint and stdbool are needed. Change-Id: I31234b282b89ef1c5ebfe1693bf7f715be527a7c Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/include/acpi/acpi_pld.h M src/include/device/hypertransport_def.h M src/include/espi.h M src/include/fit.h M src/include/program_loading.h M src/include/spd_cache.h 6 files changed, 7 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/43955/1 diff --git a/src/include/acpi/acpi_pld.h b/src/include/acpi/acpi_pld.h index 5a7663c..e347834 100644 --- a/src/include/acpi/acpi_pld.h +++ b/src/include/acpi/acpi_pld.h @@ -4,6 +4,7 @@ #define __ACPI_ACPI_PLD_H__ #include <acpi/acpi.h> +#include <stdbool.h> #include <stdint.h> enum acpi_pld_panel { diff --git a/src/include/device/hypertransport_def.h b/src/include/device/hypertransport_def.h index a0b1a36..bed7fea 100644 --- a/src/include/device/hypertransport_def.h +++ b/src/include/device/hypertransport_def.h @@ -1,6 +1,8 @@ #ifndef DEVICE_HYPERTRANSPORT_DEF_H #define DEVICE_HYPERTRANSPORT_DEF_H +#include <stdbool.h> + #define HT_FREQ_200Mhz 0 #define HT_FREQ_300Mhz 1 #define HT_FREQ_400Mhz 2 diff --git a/src/include/espi.h b/src/include/espi.h index 4be8543..2dec646 100644 --- a/src/include/espi.h +++ b/src/include/espi.h @@ -3,6 +3,7 @@ #ifndef __ESPI_H__ #define __ESPI_H__ +#include <stdbool.h> #include <stdint.h> /* ESPI Slave Registers (Document # 327432-004 Revision 1.0 Chapter 7) */ diff --git a/src/include/fit.h b/src/include/fit.h index a1e970d..1aff4f1 100644 --- a/src/include/fit.h +++ b/src/include/fit.h @@ -4,11 +4,10 @@ #ifndef __LIB_FIT_H__ #define __LIB_FIT_H__ -#include <stddef.h> -#include <stdint.h> #include <device_tree.h> #include <list.h> #include <program_loading.h> +#include <types.h> struct fit_image_node { const char *name; diff --git a/src/include/program_loading.h b/src/include/program_loading.h index fae70ce..4b3a709 100644 --- a/src/include/program_loading.h +++ b/src/include/program_loading.h @@ -4,8 +4,7 @@ #include <bootmem.h> #include <commonlib/region.h> -#include <stdint.h> -#include <stddef.h> +#include <types.h> enum { /* Last segment of program. Can be used to take different actions for diff --git a/src/include/spd_cache.h b/src/include/spd_cache.h index 5465aad..a698e5d 100644 --- a/src/include/spd_cache.h +++ b/src/include/spd_cache.h @@ -4,8 +4,7 @@ #define __SPD_CACHE_H #include <spd_bin.h> -#include <stddef.h> -#include <stdint.h> +#include <types.h> #define SPD_CACHE_FMAP_NAME "RW_SPD_CACHE" #define SC_SPD_NUMS (CONFIG_DIMM_MAX) -- To view, visit
https://review.coreboot.org/c/coreboot/+/43955
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I31234b282b89ef1c5ebfe1693bf7f715be527a7c Gerrit-Change-Number: 43955 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange
1
2
0
0
Change in coreboot[master]: src/console: Add missing <{stddef,stdint}.h>
by HAOUAS Elyes (Code Review)
20 Aug '20
20 Aug '20
HAOUAS Elyes has uploaded this change for review. (
https://review.coreboot.org/c/coreboot/+/43966
) Change subject: src/console: Add missing <{stddef,stdint}.h> ...................................................................... src/console: Add missing <{stddef,stdint}.h> Change-Id: Ie8fe8d6c70b396498156767ae0c5b8567adf1b07 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/console/console.c M src/console/vsprintf.c M src/console/vtxprintf.c 3 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/43966/1 diff --git a/src/console/console.c b/src/console/console.c index bc9d918..3f170dc 100644 --- a/src/console/console.c +++ b/src/console/console.c @@ -9,6 +9,8 @@ #include <console/usb.h> #include <console/spi.h> #include <console/flash.h> +#include <stddef.h> +#include <stdint.h> void console_hw_init(void) { diff --git a/src/console/vsprintf.c b/src/console/vsprintf.c index d0c569b..f1d9dca 100644 --- a/src/console/vsprintf.c +++ b/src/console/vsprintf.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <console/vtxprintf.h> +#include <stddef.h> #include <string.h> #include <trace.h> diff --git a/src/console/vtxprintf.c b/src/console/vtxprintf.c index 273bc7e..2dd10d0 100644 --- a/src/console/vtxprintf.c +++ b/src/console/vtxprintf.c @@ -6,6 +6,7 @@ #include <console/vtxprintf.h> #include <ctype.h> +#include <stddef.h> #include <string.h> #include <stdint.h> -- To view, visit
https://review.coreboot.org/c/coreboot/+/43966
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie8fe8d6c70b396498156767ae0c5b8567adf1b07 Gerrit-Change-Number: 43966 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange
1
2
0
0
← Newer
1
...
158
159
160
161
162
163
164
...
246
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
Results per page:
10
25
50
100
200