coreboot-gerrit August 2020

coreboot-gerrit@coreboot.org

1 participants
2457 discussions

Change in coreboot[master]: soc/intel/tigerlake: Add FSP UPDs for minimum assertion widths
by Angel Pons (Code Review) 20 Aug '20

20 Aug '20

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44557 ) Change subject: soc/intel/tigerlake: Add FSP UPDs for minimum assertion widths ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/c/coreboot/+/44557/1/src/soc/intel/tigerlake/fs… File src/soc/intel/tigerlake/fsp_params.c: https://review.coreboot.org/c/coreboot/+/44557/1/src/soc/intel/tigerlake/fs… PS1, Line 118: assrt assert ? https://review.coreboot.org/c/coreboot/+/44557/1/src/soc/intel/tigerlake/fs… PS1, Line 204: EDS " : "spec nit: As far as I know, `EDS` means `External Design Specification`, so `EDS spec` would be `External Design Specification spec`, which is a bit redundant. -- To view, visit https://review.coreboot.org/c/coreboot/+/44557 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8180d95a2185c3786334e10613f47e77b7bc9d5f Gerrit-Change-Number: 44557 Gerrit-PatchSet: 1 Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 20 Aug 2020 07:31:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/jasperlake: Disable multiphase SI init
by Maulik V Vaghela (Code Review) 20 Aug '20

20 Aug '20

Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43816 ) Change subject: soc/intel/jasperlake: Disable multiphase SI init ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/43816 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d591b46c403e68ff0b41ac8f87c742ae774111e Gerrit-Change-Number: 43816 Gerrit-PatchSet: 9 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 20 Aug 2020 07:04:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/jasperlake: Select PLATFORM_USES_FSP2_2
by Maulik V Vaghela (Code Review) 20 Aug '20

20 Aug '20

Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43815 ) Change subject: soc/intel/jasperlake: Select PLATFORM_USES_FSP2_2 ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/43815 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia606ec26da93242ecdd602a9b3badbece5dcd034 Gerrit-Change-Number: 43815 Gerrit-PatchSet: 7 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 20 Aug 2020 07:03:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: vendorcode/intel/fsp: Add Jasper Lake FSP headers for FSP v2295
by Maulik V Vaghela (Code Review) 20 Aug '20

20 Aug '20

Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44415 ) Change subject: vendorcode/intel/fsp: Add Jasper Lake FSP headers for FSP v2295 ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/44415 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I569987427cccefc1c5015bdabb10b41f29f2624a Gerrit-Change-Number: 44415 Gerrit-PatchSet: 6 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 20 Aug 2020 07:03:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [test] test warning flag 'Wunused-function'
by HAOUAS Elyes (Code Review) 20 Aug '20

20 Aug '20

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44574 ) Change subject: [test] test warning flag 'Wunused-function' ...................................................................... [test] test warning flag 'Wunused-function' Change-Id: I5313c143de723771a9ae4a5a134490b4106a97e3 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/44574/1 diff --git a/Makefile.inc b/Makefile.inc index 9d27743..dd76a88 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -423,7 +423,7 @@ CFLAGS_common += -nostdlib -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes CFLAGS_common += -Wwrite-strings -Wredundant-decls -Wno-trigraphs -Wimplicit-fallthrough CFLAGS_common += -Wshadow -Wdate-time -Wtype-limits -Wvla -CFLAGS_common += -Wlogical-op -Wduplicated-cond -Wdangling-else +CFLAGS_common += -Wlogical-op -Wduplicated-cond -Wdangling-else -Wunused-function CFLAGS_common += -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer CFLAGS_common += -fstrict-aliasing -ffunction-sections -fdata-sections -fno-pie ifeq ($(CONFIG_COMPILER_GCC),y) -- To view, visit https://review.coreboot.org/c/coreboot/+/44574 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5313c143de723771a9ae4a5a134490b4106a97e3 Gerrit-Change-Number: 44574 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 1

Change in coreboot[master]: src/arch: Include <stdint.h>
by HAOUAS Elyes (Code Review) 20 Aug '20

20 Aug '20

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44201 ) Change subject: src/arch: Include <stdint.h> ...................................................................... src/arch: Include <stdint.h> Those file only needs <stdint.h>. Change-Id: I8a4d1801125dcf271a4580b5ff50107745d2892e Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/arch/arm/include/arch/clock.h M src/arch/arm64/include/bl31.h M src/arch/arm64/ramdetect.c 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/44201/1 diff --git a/src/arch/arm/include/arch/clock.h b/src/arch/arm/include/arch/clock.h index 9387757..22e5287 100644 --- a/src/arch/arm/include/arch/clock.h +++ b/src/arch/arm/include/arch/clock.h @@ -3,7 +3,7 @@ #ifndef __ARM_CLOCK_H_ #define __ARM_CLOCK_H_ -#include <types.h> +#include <stdint.h> void set_cntfrq(uint32_t); diff --git a/src/arch/arm64/include/bl31.h b/src/arch/arm64/include/bl31.h index bb99fcd..1f946e9 100644 --- a/src/arch/arm64/include/bl31.h +++ b/src/arch/arm64/include/bl31.h @@ -3,7 +3,7 @@ #ifndef __BL31_H__ #define __BL31_H__ -#include <types.h> +#include <stdint.h> #include <arm-trusted-firmware/include/export/lib/bl_aux_params/bl_aux_params_exp.h> diff --git a/src/arch/arm64/ramdetect.c b/src/arch/arm64/ramdetect.c index 2f6a1cd..deaf390 100644 --- a/src/arch/arm64/ramdetect.c +++ b/src/arch/arm64/ramdetect.c @@ -1,8 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ -#include <types.h> #include <device/mmio.h> #include <ramdetect.h> +#include <stdint.h> #include <arch/exception.h> #include <arch/transition.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/44201 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8a4d1801125dcf271a4580b5ff50107745d2892e Gerrit-Change-Number: 44201 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

2 4

Change in coreboot[master]: soc/samsung: Add missing <commonlib/helpers.h>
by HAOUAS Elyes (Code Review) 20 Aug '20

20 Aug '20

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44209 ) Change subject: soc/samsung: Add missing <commonlib/helpers.h> ...................................................................... soc/samsung: Add missing <commonlib/helpers.h> Use of 'KiB' needs <commonlib/helpers.h> header. Change-Id: If506786c80644e12549798ce5f7f6f5b8e4af348 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/samsung/exynos5250/include/soc/cpu.h M src/soc/samsung/exynos5420/include/soc/cpu.h 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/44209/1 diff --git a/src/soc/samsung/exynos5250/include/soc/cpu.h b/src/soc/samsung/exynos5250/include/soc/cpu.h index aa5a2e8..3c2cd77 100644 --- a/src/soc/samsung/exynos5250/include/soc/cpu.h +++ b/src/soc/samsung/exynos5250/include/soc/cpu.h @@ -3,6 +3,7 @@ #ifndef CPU_SAMSUNG_EXYNOS5250_CPU_H #define CPU_SAMSUNG_EXYNOS5250_CPU_H +#include <commonlib/helpers.h> #include <symbols.h> /* Base address registers */ diff --git a/src/soc/samsung/exynos5420/include/soc/cpu.h b/src/soc/samsung/exynos5420/include/soc/cpu.h index 6a22770..bddfd86 100644 --- a/src/soc/samsung/exynos5420/include/soc/cpu.h +++ b/src/soc/samsung/exynos5420/include/soc/cpu.h @@ -3,6 +3,7 @@ #ifndef CPU_SAMSUNG_EXYNOS5420_CPU_H #define CPU_SAMSUNG_EXYNOS5420_CPU_H +#include <commonlib/helpers.h> #include <symbols.h> #define EXYNOS5_SRAM_BASE 0x02020000 -- To view, visit https://review.coreboot.org/c/coreboot/+/44209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If506786c80644e12549798ce5f7f6f5b8e4af348 Gerrit-Change-Number: 44209 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

3 10

Change in coreboot[master]: src/cpu: Include <stdint.h>
by HAOUAS Elyes (Code Review) 20 Aug '20

20 Aug '20

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44202 ) Change subject: src/cpu: Include <stdint.h> ...................................................................... src/cpu: Include <stdint.h> Those files only needs <stdint.h>. Change-Id: I68c9d758a16c6a671a589a38558a19452752e537 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/cpu/intel/speedstep/acpi.c M src/cpu/intel/speedstep/speedstep.c M src/cpu/ti/am335x/bootblock.c M src/cpu/ti/am335x/uart.c 4 files changed, 4 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/44202/1 diff --git a/src/cpu/intel/speedstep/acpi.c b/src/cpu/intel/speedstep/acpi.c index 2beb890..1d8e9cf 100644 --- a/src/cpu/intel/speedstep/acpi.c +++ b/src/cpu/intel/speedstep/acpi.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <types.h> #include <console/console.h> #include <acpi/acpi.h> #include <acpi/acpigen.h> @@ -8,6 +7,7 @@ #include <cpu/intel/fsb.h> #include <cpu/intel/speedstep.h> #include <device/device.h> +#include <stdint.h> static int determine_total_number_of_cores(void) { diff --git a/src/cpu/intel/speedstep/speedstep.c b/src/cpu/intel/speedstep/speedstep.c index fba5df2..77494bb 100644 --- a/src/cpu/intel/speedstep/speedstep.c +++ b/src/cpu/intel/speedstep/speedstep.c @@ -1,11 +1,11 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <types.h> #include <string.h> #include <arch/cpu.h> #include <cpu/x86/msr.h> #include <console/console.h> #include <cpu/intel/speedstep.h> +#include <stdint.h> /** * @brief Gather speedstep limits for current processor diff --git a/src/cpu/ti/am335x/bootblock.c b/src/cpu/ti/am335x/bootblock.c index 985e1a1..293dd4b 100644 --- a/src/cpu/ti/am335x/bootblock.c +++ b/src/cpu/ti/am335x/bootblock.c @@ -1,9 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <types.h> - #include <arch/cache.h> #include <bootblock_common.h> +#include <stdint.h> void bootblock_soc_init(void) { diff --git a/src/cpu/ti/am335x/uart.c b/src/cpu/ti/am335x/uart.c index a882340..00c2f93 100644 --- a/src/cpu/ti/am335x/uart.c +++ b/src/cpu/ti/am335x/uart.c @@ -1,10 +1,10 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ -#include <types.h> #include <console/uart.h> #include <device/mmio.h> #include <boot/coreboot_tables.h> #include <cpu/ti/am335x/uart.h> +#include <stdint.h> #define EFR_ENHANCED_EN (1 << 4) #define FCR_FIFO_EN (1 << 0) -- To view, visit https://review.coreboot.org/c/coreboot/+/44202 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I68c9d758a16c6a671a589a38558a19452752e537 Gerrit-Change-Number: 44202 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 3

Change in coreboot[master]: src/drivers: Add missing '#include <{stdbool,stddef,stdint}.h>'
by HAOUAS Elyes (Code Review) 20 Aug '20

20 Aug '20

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43967 ) Change subject: src/drivers: Add missing '#include <{stdbool,stddef,stdint}.h>' ...................................................................... src/drivers: Add missing '#include <{stdbool,stddef,stdint}.h>' Include <types.h> when stddef, stdint and stdbool are needed. Change-Id: Ic251fe12777f03c4a14dd707be66f6e9223cd7df Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/drivers/aspeed/common/ast_dp501.c M src/drivers/aspeed/common/ast_drv.h M src/drivers/aspeed/common/ast_main.c M src/drivers/aspeed/common/ast_mode.c M src/drivers/aspeed/common/ast_mode_corebootfb.c M src/drivers/aspeed/common/ast_post.c M src/drivers/elog/elog.c M src/drivers/generic/gpio_keys/chip.h M src/drivers/i2c/generic/chip.h M src/drivers/i2c/generic/generic.c M src/drivers/i2c/max98373/chip.h M src/drivers/i2c/max98927/chip.h M src/drivers/intel/dptf/chip.h M src/drivers/intel/dptf/dptf.c M src/drivers/intel/fsp1_1/hob.c M src/drivers/intel/fsp1_1/include/fsp/romstage.h M src/drivers/intel/fsp1_1/raminit.c M src/drivers/intel/fsp1_1/romstage.c M src/drivers/intel/fsp2_0/hand_off_block.c M src/drivers/intel/fsp2_0/include/fsp/api.h M src/drivers/intel/mipi_camera/chip.h M src/drivers/intel/ptt/ptt.c M src/drivers/intel/ptt/ptt.h M src/drivers/ipmi/chip.h M src/drivers/lenovo/hybrid_graphics/hybrid_graphics.h M src/drivers/mrc_cache/mrc_cache.c M src/drivers/net/chip.h M src/drivers/ocp/dmi/smbios.c M src/drivers/spi/acpi/acpi.c M src/drivers/spi/acpi/chip.h M src/drivers/spi/boot_device_rw_nommap.c M src/drivers/spi/cbfs_spi.c M src/drivers/spi/spi-generic.c M src/drivers/spi/winbond.c M src/drivers/uart/acpi/acpi.c M src/drivers/uart/acpi/chip.h M src/drivers/usb/acpi/chip.h M src/drivers/usb/acpi/usb_acpi.c M src/drivers/usb/ehci_debug.c M src/drivers/usb/pci_xhci/pci_xhci.c M src/drivers/vpd/vpd.c 41 files changed, 63 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/43967/1 diff --git a/src/drivers/aspeed/common/ast_dp501.c b/src/drivers/aspeed/common/ast_dp501.c index 460b858..55fe845 100644 --- a/src/drivers/aspeed/common/ast_dp501.c +++ b/src/drivers/aspeed/common/ast_dp501.c @@ -7,6 +7,7 @@ */ #include <delay.h> +#include <types.h> #include "ast_drv.h" diff --git a/src/drivers/aspeed/common/ast_drv.h b/src/drivers/aspeed/common/ast_drv.h index e275108..bd3e4b2 100644 --- a/src/drivers/aspeed/common/ast_drv.h +++ b/src/drivers/aspeed/common/ast_drv.h @@ -5,6 +5,9 @@ #ifndef __AST_DRV_H__ #define __AST_DRV_H__ +#include <stdbool.h> +#include <stdint.h> + #include "aspeed_coreboot.h" #define PCI_CHIP_AST2000 0x2000 diff --git a/src/drivers/aspeed/common/ast_main.c b/src/drivers/aspeed/common/ast_main.c index 5143e6d..41b7e09 100644 --- a/src/drivers/aspeed/common/ast_main.c +++ b/src/drivers/aspeed/common/ast_main.c @@ -4,6 +4,7 @@ */ #include <delay.h> +#include <types.h> #include "ast_drv.h" #include "ast_dram_tables.h" diff --git a/src/drivers/aspeed/common/ast_mode.c b/src/drivers/aspeed/common/ast_mode.c index 465d886..3eb9ade 100644 --- a/src/drivers/aspeed/common/ast_mode.c +++ b/src/drivers/aspeed/common/ast_mode.c @@ -3,6 +3,9 @@ * Copied from Linux drivers/gpu/drm/ast/ast_mode.c * Please try to keep as close as possible to the upstream source. */ + +#include <types.h> + #include "ast_drv.h" #include "ast_tables.h" diff --git a/src/drivers/aspeed/common/ast_mode_corebootfb.c b/src/drivers/aspeed/common/ast_mode_corebootfb.c index 2a033a0..dbe6e6b 100644 --- a/src/drivers/aspeed/common/ast_mode_corebootfb.c +++ b/src/drivers/aspeed/common/ast_mode_corebootfb.c @@ -3,6 +3,8 @@ * Copied from Linux drivers/gpu/drm/ast/ast_mode.c */ #include <edid.h> +#include <stdbool.h> +#include <stdint.h> #include "ast_drv.h" diff --git a/src/drivers/aspeed/common/ast_post.c b/src/drivers/aspeed/common/ast_post.c index b3b7d61..2db99ea 100644 --- a/src/drivers/aspeed/common/ast_post.c +++ b/src/drivers/aspeed/common/ast_post.c @@ -3,6 +3,8 @@ #define COREBOOT_AST_FAILOVER_TIMEOUT 10000000 #include <delay.h> +#include <stdbool.h> +#include <stdint.h> #include "ast_drv.h" #include "ast_dram_tables.h" diff --git a/src/drivers/elog/elog.c b/src/drivers/elog/elog.c index 01fa9cc..00bc0e9 100644 --- a/src/drivers/elog/elog.c +++ b/src/drivers/elog/elog.c @@ -12,9 +12,10 @@ #include <post.h> #include <rtc.h> #include <smbios.h> -#include <stdint.h> #include <string.h> #include <elog.h> +#include <types.h> + #include "elog_internal.h" diff --git a/src/drivers/generic/gpio_keys/chip.h b/src/drivers/generic/gpio_keys/chip.h index a2ff59d..1198f88 100644 --- a/src/drivers/generic/gpio_keys/chip.h +++ b/src/drivers/generic/gpio_keys/chip.h @@ -4,6 +4,7 @@ #define __DRIVERS_GENERIC_GPIO_KEYS_H__ #include <acpi/acpi_device.h> +#include <stdbool.h> #include <stdint.h> /* Linux input type */ diff --git a/src/drivers/i2c/generic/chip.h b/src/drivers/i2c/generic/chip.h index 284c9d1..c290ae2 100644 --- a/src/drivers/i2c/generic/chip.h +++ b/src/drivers/i2c/generic/chip.h @@ -5,6 +5,7 @@ #include <acpi/acpi_device.h> #include <device/i2c_simple.h> +#include <stdbool.h> #define MAX_GENERIC_PROPERTY_LIST 10 diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c index 18fd55c..8cfae19 100644 --- a/src/drivers/i2c/generic/generic.c +++ b/src/drivers/i2c/generic/generic.c @@ -7,7 +7,10 @@ #include <device/device.h> #include <device/path.h> #include <gpio.h> +#include <stdbool.h> +#include <stddef.h> #include <string.h> + #include "chip.h" #if CONFIG(HAVE_ACPI_TABLES) diff --git a/src/drivers/i2c/max98373/chip.h b/src/drivers/i2c/max98373/chip.h index c184531..dbb103b 100644 --- a/src/drivers/i2c/max98373/chip.h +++ b/src/drivers/i2c/max98373/chip.h @@ -4,6 +4,7 @@ * Maxim MAX98373 audio codec devicetree bindings */ +#include <stdbool.h> #include <stdint.h> struct drivers_i2c_max98373_config { diff --git a/src/drivers/i2c/max98927/chip.h b/src/drivers/i2c/max98927/chip.h index fcdb9e0..c3ed785 100644 --- a/src/drivers/i2c/max98927/chip.h +++ b/src/drivers/i2c/max98927/chip.h @@ -3,6 +3,9 @@ /* * Maxim MAX98927 audio codec devicetree bindings */ + +#include <stdbool.h> + struct drivers_i2c_max98927_config { /* I2C Bus Frequency in Hertz (default 400kHz) */ unsigned int bus_speed; diff --git a/src/drivers/intel/dptf/chip.h b/src/drivers/intel/dptf/chip.h index db4c3ae..5ebd3ec 100644 --- a/src/drivers/intel/dptf/chip.h +++ b/src/drivers/intel/dptf/chip.h @@ -4,6 +4,8 @@ #define _DRIVERS_INTEL_DPTF_CHIP_H_ #include <acpi/acpigen_dptf.h> +#include <stdbool.h> +#include <stdint.h> #include <timer.h> /* for MSECS_PER_SEC */ #define DPTF_PASSIVE(src, tgt, tmp, prd) \ diff --git a/src/drivers/intel/dptf/dptf.c b/src/drivers/intel/dptf/dptf.c index 0f1cc9c..cb07310 100644 --- a/src/drivers/intel/dptf/dptf.c +++ b/src/drivers/intel/dptf/dptf.c @@ -3,6 +3,9 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> +#include <stdbool.h> +#include <stddef.h> + #include "chip.h" /* Generic DPTF participants have a PTYP field to distinguish them */ diff --git a/src/drivers/intel/fsp1_1/hob.c b/src/drivers/intel/fsp1_1/hob.c index 9a09cfd..d7cb9ce 100644 --- a/src/drivers/intel/fsp1_1/hob.c +++ b/src/drivers/intel/fsp1_1/hob.c @@ -5,6 +5,7 @@ #include <fsp/util.h> #include <ip_checksum.h> #include <string.h> +#include <types.h> /* Compares two EFI GUIDs. Returns true of the GUIDs match, false otherwise. */ static bool compare_guid(const EFI_GUID *guid1, const EFI_GUID *guid2) diff --git a/src/drivers/intel/fsp1_1/include/fsp/romstage.h b/src/drivers/intel/fsp1_1/include/fsp/romstage.h index c452f0b..aee7b02 100644 --- a/src/drivers/intel/fsp1_1/include/fsp/romstage.h +++ b/src/drivers/intel/fsp1_1/include/fsp/romstage.h @@ -3,8 +3,7 @@ #ifndef _COMMON_ROMSTAGE_H_ #define _COMMON_ROMSTAGE_H_ -#include <stddef.h> -#include <stdint.h> +#include <types.h> #include <memory_info.h> #include <fsp/car.h> #include <fsp/util.h> diff --git a/src/drivers/intel/fsp1_1/raminit.c b/src/drivers/intel/fsp1_1/raminit.c index dd08d77..c21d8b0 100644 --- a/src/drivers/intel/fsp1_1/raminit.c +++ b/src/drivers/intel/fsp1_1/raminit.c @@ -11,6 +11,7 @@ #include <lib.h> /* hexdump */ #include <string.h> #include <timestamp.h> +#include <types.h> void raminit(struct romstage_params *params) { diff --git a/src/drivers/intel/fsp1_1/romstage.c b/src/drivers/intel/fsp1_1/romstage.c index 46df1c8..62b6c16 100644 --- a/src/drivers/intel/fsp1_1/romstage.c +++ b/src/drivers/intel/fsp1_1/romstage.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <stddef.h> #include <acpi/acpi.h> #include <assert.h> #include <console/console.h> @@ -18,6 +17,7 @@ #include <stage_cache.h> #include <string.h> #include <timestamp.h> +#include <types.h> #include <vendorcode/google/chromeos/chromeos.h> static void raminit_common(struct romstage_params *params) diff --git a/src/drivers/intel/fsp2_0/hand_off_block.c b/src/drivers/intel/fsp2_0/hand_off_block.c index 44c91a2..9e9bf0f 100644 --- a/src/drivers/intel/fsp2_0/hand_off_block.c +++ b/src/drivers/intel/fsp2_0/hand_off_block.c @@ -6,8 +6,8 @@ #include <console/console.h> #include <fsp/api.h> #include <fsp/util.h> -#include <stdint.h> #include <string.h> +#include <types.h> #define HOB_HEADER_LEN 8 diff --git a/src/drivers/intel/fsp2_0/include/fsp/api.h b/src/drivers/intel/fsp2_0/include/fsp/api.h index d2c556f..3d33871 100644 --- a/src/drivers/intel/fsp2_0/include/fsp/api.h +++ b/src/drivers/intel/fsp2_0/include/fsp/api.h @@ -3,10 +3,9 @@ #ifndef _FSP2_0_API_H_ #define _FSP2_0_API_H_ -#include <stddef.h> -#include <stdint.h> #include <fsp/soc_binding.h> #include <soc/intel/common/mma.h> +#include <types.h> #define FSP_SUCCESS EFI_SUCCESS #define FSP_INVALID_PARAMETER EFI_INVALID_PARAMETER diff --git a/src/drivers/intel/mipi_camera/chip.h b/src/drivers/intel/mipi_camera/chip.h index d133f7d..3ad19c0 100644 --- a/src/drivers/intel/mipi_camera/chip.h +++ b/src/drivers/intel/mipi_camera/chip.h @@ -3,6 +3,7 @@ #ifndef __INTEL_MIPI_CAMERA_CHIP_H__ #define __INTEL_MIPI_CAMERA_CHIP_H__ +#include <stdbool.h> #include <stdint.h> #include <acpi/acpi_pld.h> diff --git a/src/drivers/intel/ptt/ptt.c b/src/drivers/intel/ptt/ptt.c index 67ed0ee..d3b956d 100644 --- a/src/drivers/intel/ptt/ptt.c +++ b/src/drivers/intel/ptt/ptt.c @@ -3,6 +3,8 @@ #include <soc/pci_devs.h> #include <device/pci_ops.h> #include <console/console.h> +#include <stdbool.h> +#include <stdint.h> #include "ptt.h" diff --git a/src/drivers/intel/ptt/ptt.h b/src/drivers/intel/ptt/ptt.h index b447d58..236cb69 100644 --- a/src/drivers/intel/ptt/ptt.h +++ b/src/drivers/intel/ptt/ptt.h @@ -14,4 +14,7 @@ * Checks if the Intel PTT is active. If PTT is active, returns true, * false otherwise. */ + +#include <stdbool.h> + bool ptt_active(void); diff --git a/src/drivers/ipmi/chip.h b/src/drivers/ipmi/chip.h index f561bcd..81befe8 100644 --- a/src/drivers/ipmi/chip.h +++ b/src/drivers/ipmi/chip.h @@ -3,6 +3,9 @@ #ifndef _IMPI_CHIP_H_ #define _IPMI_CHIP_H_ +#include <stdbool.h> +#include <stdint.h> + struct drivers_ipmi_config { u8 bmc_i2c_address; u8 have_nv_storage; diff --git a/src/drivers/lenovo/hybrid_graphics/hybrid_graphics.h b/src/drivers/lenovo/hybrid_graphics/hybrid_graphics.h index b5de8a8..d694865 100644 --- a/src/drivers/lenovo/hybrid_graphics/hybrid_graphics.h +++ b/src/drivers/lenovo/hybrid_graphics/hybrid_graphics.h @@ -3,6 +3,8 @@ #ifndef _DRIVERS_LENOVO_HYBRID_GRAPHICS_H_ #define _DRIVERS_LENOVO_HYBRID_GRAPHICS_H_ +#include <stdbool.h> + void early_hybrid_graphics(bool *enable_igd, bool *enable_peg); #endif /* _DRIVERS_LENOVO_HYBRID_GRAPHICS_CHIP_H_ */ diff --git a/src/drivers/mrc_cache/mrc_cache.c b/src/drivers/mrc_cache/mrc_cache.c index d567a20..4584855 100644 --- a/src/drivers/mrc_cache/mrc_cache.c +++ b/src/drivers/mrc_cache/mrc_cache.c @@ -12,6 +12,7 @@ #include <region_file.h> #include <security/vboot/vboot_common.h> #include <spi_flash.h> +#include <types.h> #include "mrc_cache.h" diff --git a/src/drivers/net/chip.h b/src/drivers/net/chip.h index 9b6a4e5..29936d2 100644 --- a/src/drivers/net/chip.h +++ b/src/drivers/net/chip.h @@ -3,6 +3,7 @@ #ifndef __DRIVERS_R8168_CHIP_H__ #define __DRIVERS_R8168_CHIP_H__ +#include <stdbool.h> #include <stdint.h> #include <acpi/acpi_device.h> diff --git a/src/drivers/ocp/dmi/smbios.c b/src/drivers/ocp/dmi/smbios.c index 4e54af0..b691eea 100644 --- a/src/drivers/ocp/dmi/smbios.c +++ b/src/drivers/ocp/dmi/smbios.c @@ -11,6 +11,7 @@ #include <soc/soc_util.h> #include <soc/cpu.h> #include <smbios.h> +#include <types.h> #include "ocp_dmi.h" diff --git a/src/drivers/spi/acpi/acpi.c b/src/drivers/spi/acpi/acpi.c index c0e776e..39784fe 100644 --- a/src/drivers/spi/acpi/acpi.c +++ b/src/drivers/spi/acpi/acpi.c @@ -7,7 +7,9 @@ #include <device/path.h> #include <device/spi.h> #include <spi-generic.h> +#include <stdbool.h> #include <string.h> + #include "chip.h" static int spi_acpi_get_bus(const struct device *dev) diff --git a/src/drivers/spi/acpi/chip.h b/src/drivers/spi/acpi/chip.h index 9849f17..3ea3827 100644 --- a/src/drivers/spi/acpi/chip.h +++ b/src/drivers/spi/acpi/chip.h @@ -3,6 +3,7 @@ #ifndef __SPI_ACPI_CHIP_H__ #define __SPI_ACPI_CHIP_H__ +#include <stdbool.h> #include <acpi/acpi_device.h> struct drivers_spi_acpi_config { diff --git a/src/drivers/spi/boot_device_rw_nommap.c b/src/drivers/spi/boot_device_rw_nommap.c index 58efc87..9352f22 100644 --- a/src/drivers/spi/boot_device_rw_nommap.c +++ b/src/drivers/spi/boot_device_rw_nommap.c @@ -3,7 +3,7 @@ #include <boot_device.h> #include <spi_flash.h> #include <spi-generic.h> -#include <stdint.h> +#include <types.h> static struct spi_flash sfg; static bool sfg_init_done; diff --git a/src/drivers/spi/cbfs_spi.c b/src/drivers/spi/cbfs_spi.c index 0034460..6248129 100644 --- a/src/drivers/spi/cbfs_spi.c +++ b/src/drivers/spi/cbfs_spi.c @@ -11,8 +11,8 @@ #include <spi_flash.h> #include <symbols.h> #include <cbmem.h> -#include <stdint.h> #include <timer.h> +#include <types.h> static struct spi_flash spi_flash_info; static bool spi_flash_init_done; diff --git a/src/drivers/spi/spi-generic.c b/src/drivers/spi/spi-generic.c index 597a22d..9ee231d 100644 --- a/src/drivers/spi/spi-generic.c +++ b/src/drivers/spi/spi-generic.c @@ -3,6 +3,7 @@ #include <assert.h> #include <commonlib/helpers.h> #include <spi-generic.h> +#include <stdbool.h> #include <stddef.h> #include <string.h> diff --git a/src/drivers/spi/winbond.c b/src/drivers/spi/winbond.c index e4151de..59377bd 100644 --- a/src/drivers/spi/winbond.c +++ b/src/drivers/spi/winbond.c @@ -6,6 +6,7 @@ #include <spi-generic.h> #include <delay.h> #include <lib.h> +#include <types.h> #include "spi_flash_internal.h" #include "spi_winbond.h" diff --git a/src/drivers/uart/acpi/acpi.c b/src/drivers/uart/acpi/acpi.c index f9d9d8f..268ff35 100644 --- a/src/drivers/uart/acpi/acpi.c +++ b/src/drivers/uart/acpi/acpi.c @@ -4,6 +4,7 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/path.h> +#include <stdbool.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/uart/acpi/chip.h b/src/drivers/uart/acpi/chip.h index 0311165..d5a3cf3 100644 --- a/src/drivers/uart/acpi/chip.h +++ b/src/drivers/uart/acpi/chip.h @@ -4,6 +4,7 @@ #define __DRIVERS_UART_ACPI_H__ #include <acpi/acpi_device.h> +#include <stdbool.h> struct drivers_uart_acpi_config { const char *hid; /* ACPI _HID (required) */ diff --git a/src/drivers/usb/acpi/chip.h b/src/drivers/usb/acpi/chip.h index 8cd9268..508dde5 100644 --- a/src/drivers/usb/acpi/chip.h +++ b/src/drivers/usb/acpi/chip.h @@ -6,6 +6,7 @@ #include <acpi/acpi_device.h> #include <acpi/acpi.h> #include <acpi/acpi_pld.h> +#include <stdbool.h> struct drivers_usb_acpi_config { const char *desc; diff --git a/src/drivers/usb/acpi/usb_acpi.c b/src/drivers/usb/acpi/usb_acpi.c index d33b7de..bf6b5d0 100644 --- a/src/drivers/usb/acpi/usb_acpi.c +++ b/src/drivers/usb/acpi/usb_acpi.c @@ -6,6 +6,8 @@ #include <console/console.h> #include <device/device.h> #include <device/path.h> +#include <stdbool.h> + #include "chip.h" static bool usb_acpi_add_gpios_to_crs(struct drivers_usb_acpi_config *cfg) diff --git a/src/drivers/usb/ehci_debug.c b/src/drivers/usb/ehci_debug.c index 5998172..ba7d761 100644 --- a/src/drivers/usb/ehci_debug.c +++ b/src/drivers/usb/ehci_debug.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <stdint.h> #include <console/console.h> #include <console/usb.h> #include <arch/io.h> @@ -8,6 +7,7 @@ #include <arch/symbols.h> #include <string.h> #include <cbmem.h> +#include <types.h> #include "ehci_debug.h" #include "usb_ch9.h" diff --git a/src/drivers/usb/pci_xhci/pci_xhci.c b/src/drivers/usb/pci_xhci/pci_xhci.c index a375f07..ed6ccb3 100644 --- a/src/drivers/usb/pci_xhci/pci_xhci.c +++ b/src/drivers/usb/pci_xhci/pci_xhci.c @@ -7,6 +7,7 @@ #include <device/pci_ids.h> #include <device/xhci.h> #include <stdlib.h> +#include <types.h> #define PCI_XHCI_CLASSCODE 0x0c0330 /* USB3.0 xHCI controller */ diff --git a/src/drivers/vpd/vpd.c b/src/drivers/vpd/vpd.c index c332a6e..079eb46 100644 --- a/src/drivers/vpd/vpd.c +++ b/src/drivers/vpd/vpd.c @@ -7,6 +7,7 @@ #include <program_loading.h> #include <string.h> #include <timestamp.h> +#include <types.h> #include "vpd.h" #include "vpd_decode.h" -- To view, visit https://review.coreboot.org/c/coreboot/+/43967 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic251fe12777f03c4a14dd707be66f6e9223cd7df Gerrit-Change-Number: 43967 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

2 9

Change in coreboot[master]: cpu/ti/am335x/header.c: Add missing <stddef.h>
by HAOUAS Elyes (Code Review) 20 Aug '20

20 Aug '20

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44208 ) Change subject: cpu/ti/am335x/header.c: Add missing <stddef.h> ...................................................................... cpu/ti/am335x/header.c: Add missing <stddef.h> 'offsetof' needs '<stddef.h>' header Change-Id: I02e2c381ba539ad38a99331e975d1cbcf4f65e0c Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/cpu/ti/am335x/header.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/44208/1 diff --git a/src/cpu/ti/am335x/header.c b/src/cpu/ti/am335x/header.c index 9edfdd0..9ed9937 100644 --- a/src/cpu/ti/am335x/header.c +++ b/src/cpu/ti/am335x/header.c @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ +#include <stddef.h> #include <stdint.h> #include <symbols.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/44208 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I02e2c381ba539ad38a99331e975d1cbcf4f65e0c Gerrit-Change-Number: 44208 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 3

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2020