Hello Varshit B Pandya, build bot (Jenkins), Matt Delco, Daniel Kang, Furquan Shaikh, Wonkyu Kim, Tim Wawrzynczak, Rizwan Qureshi, Tim Wawrzynczak, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41607
to look at the new patch set (#16).
Change subject: drivers/intel/mipi_camera: Generate SSDT for camera
......................................................................
drivers/intel/mipi_camera: Generate SSDT for camera
Some boards & variants are using raw ASL files to define the ACPI devices
and related properties required by Linux MIPI camera drivers. The
mipi_camera driver can provide a SSDB property, but it's missing some
properties (like _DEP, _DSD, PRT0 and EP00 etc.) needed for Linux drivers.
This change updates the mipi_camera driver so it can provide what's
required by Linux and expands the support for the IMGU and CIO2 devices.
BUG=None
BRANCH=None
TEST=Verified that the ACPI state generated by the driver (with appropriate
devicetree changes) is extremely comparible to what's generated by the ASL
files (with minor differences like some scope were split in to multiple
scopes unlike handwritten ASL).
Change-Id: I15979f345fb823df2560db269e902a1ea650b69e
Signed-off-by: Matt Delco <delco(a)chromium.org>
Signed-off-by: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
---
M src/drivers/intel/mipi_camera/camera.c
M src/drivers/intel/mipi_camera/chip.h
2 files changed, 667 insertions(+), 28 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/41607/16
--
To view, visit https://review.coreboot.org/c/coreboot/+/41607
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15979f345fb823df2560db269e902a1ea650b69e
Gerrit-Change-Number: 41607
Gerrit-PatchSet: 16
Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Reviewer: Daniel Kang <daniel.h.kang(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Matt Delco <delco(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Kiran2 Kumar <kiran2.kumar(a)intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
Hello Zheng Bao, Zheng Bao,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/42220
to review the following change.
Change subject: amd/picasso: set EXTINT on BSP only
......................................................................
amd/picasso: set EXTINT on BSP only
Tested on mandolin board, the error in dmesg
"do_IRQ: 1.55 No irq handler for vector"
has gone.
Change-Id: I38ed0abbdf9626a5fe96902fc8bcbb1d1b8aac31
Signed-off-by: Zheng Bao <zheng.bao(a)amd.com>
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M src/soc/amd/picasso/Kconfig
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/42220/1
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig
index e3d145d..003be94 100644
--- a/src/soc/amd/picasso/Kconfig
+++ b/src/soc/amd/picasso/Kconfig
@@ -367,6 +367,11 @@
help
Select this item to enable secure debug options in PSP.
+config LAPIC_EXTINT_ON_BSP_ONLY
+ def_bool y
+ help
+ Only set flag EXTINT on BSP.
+
endmenu
endif # SOC_AMD_PICASSO
--
To view, visit https://review.coreboot.org/c/coreboot/+/42220
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I38ed0abbdf9626a5fe96902fc8bcbb1d1b8aac31
Gerrit-Change-Number: 42220
Gerrit-PatchSet: 1
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: Zheng Bao <zheng.bao(a)amd.com>
Gerrit-MessageType: newchange
Hello Varshit B Pandya, build bot (Jenkins), Matt Delco, Daniel Kang, Furquan Shaikh, Wonkyu Kim, Tim Wawrzynczak, Rizwan Qureshi, Tim Wawrzynczak, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41607
to look at the new patch set (#14).
Change subject: drivers/intel/mipi_camera: Generate SSDT generation
......................................................................
drivers/intel/mipi_camera: Generate SSDT generation
Some boards & variants are using raw ASL files to define the ACPI devices
and related properties required by Linux MIPI camera drivers. The
mipi_camera driver can provide a SSDB property, but it's missing some
properties (like _DEP, _DSD, PRT0 and EP00 etc.) needed for Linux drivers.
This change updates the mipi_camera driver so it can provide what's
required by Linux and expands the support for the IMGU and CIO2 devices.
BUG=None
BRANCH=None
TEST=Verified that the ACPI state generated by the driver (with appropriate
devicetree changes) is extremely comparible to what's generated by the ASL
files (with minor differences like some scope were split in to multiple
scopes unlike handwritten ASL).
Change-Id: I15979f345fb823df2560db269e902a1ea650b69e
Signed-off-by: Matt Delco <delco(a)chromium.org>
Signed-off-by: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
---
M src/drivers/intel/mipi_camera/camera.c
M src/drivers/intel/mipi_camera/chip.h
2 files changed, 667 insertions(+), 28 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/41607/14
--
To view, visit https://review.coreboot.org/c/coreboot/+/41607
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15979f345fb823df2560db269e902a1ea650b69e
Gerrit-Change-Number: 41607
Gerrit-PatchSet: 14
Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Reviewer: Daniel Kang <daniel.h.kang(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Matt Delco <delco(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Kiran2 Kumar <kiran2.kumar(a)intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
Hello Varshit B Pandya, build bot (Jenkins), Matt Delco, Daniel Kang, Furquan Shaikh, Wonkyu Kim, Tim Wawrzynczak, Rizwan Qureshi, Tim Wawrzynczak, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41607
to look at the new patch set (#13).
Change subject: drivers/intel/mipi_camera: Generate SSDT generation
......................................................................
drivers/intel/mipi_camera: Generate SSDT generation
Some boards & variants are using raw ASL files to define the ACPI devices
and related properties required by Linux MIPI camera drivers. The
mipi_camera driver can provide a SSDB property, but it's missing some
properties (like _DEP, _DSD, PRT0 and EP00 etc.) needed for Linux drivers.
This change updates the mipi_camera driver so it can provide what's
required by Linux and expands the support for the IMGU and CIO2 devices.
BUG=None
BRANCH=None
TEST=Verified that the ACPI state generated by the driver (with appropriate
devicetree changes) is extremely comparible to what's generated by the ASL
files (with minor differences like some scope were split in to multiple
scopes unlike handwritten ASL).
Change-Id: I15979f345fb823df2560db269e902a1ea650b69e
Signed-off-by: Matt Delco <delco(a)chromium.org>
Signed-off-by: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
---
M src/drivers/intel/mipi_camera/camera.c
M src/drivers/intel/mipi_camera/chip.h
2 files changed, 659 insertions(+), 25 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/41607/13
--
To view, visit https://review.coreboot.org/c/coreboot/+/41607
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15979f345fb823df2560db269e902a1ea650b69e
Gerrit-Change-Number: 41607
Gerrit-PatchSet: 13
Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Reviewer: Daniel Kang <daniel.h.kang(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Matt Delco <delco(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Kiran2 Kumar <kiran2.kumar(a)intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
Hello Zheng Bao, Zheng Bao,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/42212
to review the following change.
Change subject: amd/common: Add the macro definition for patch level MSR
......................................................................
amd/common: Add the macro definition for patch level MSR
This MSR is used for detecting if the micro code is applied
successfully.
Change-Id: I060eb1a31f3358341ac0d5b9105e710c351f2ce8
Signed-off-by: Zheng Bao <zheng.bao(a)amd.com>
Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>
---
M src/include/cpu/amd/msr.h
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/42212/1
diff --git a/src/include/cpu/amd/msr.h b/src/include/cpu/amd/msr.h
index d23a4bd..606ea23 100644
--- a/src/include/cpu/amd/msr.h
+++ b/src/include/cpu/amd/msr.h
@@ -73,6 +73,7 @@
#define LS_CFG2_MSR 0xC001102D
#define IBS_OP_DATA3_MSR 0xC0011037
+#define MSR_PATCH_LEVEL 0x0000008B
#define CORE_PERF_BOOST_CTRL 0x15c
#endif /* CPU_AMD_MSR_H */
--
To view, visit https://review.coreboot.org/c/coreboot/+/42212
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I060eb1a31f3358341ac0d5b9105e710c351f2ce8
Gerrit-Change-Number: 42212
Gerrit-PatchSet: 1
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: Zheng Bao <zheng.bao(a)amd.com>
Gerrit-MessageType: newchange