coreboot-gerrit May 2020

coreboot-gerrit@coreboot.org

1 participants
2588 discussions

Change in coreboot[master]: soc/amd/picasso: fix iomap for ACPI_PM
by Aaron Durbin (Code Review) 06 May '20

06 May '20

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41128 ) Change subject: soc/amd/picasso: fix iomap for ACPI_PM ...................................................................... Patch Set 1: (1 comment) What about this CL? https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/… What's the real answer? I feel like we haven't root caused why this patch or the one above is needed. https://review.coreboot.org/c/coreboot/+/41128/1/src/soc/amd/picasso/includ… File src/soc/amd/picasso/include/soc/iomap.h: https://review.coreboot.org/c/coreboot/+/41128/1/src/soc/amd/picasso/includ… PS1, Line 69: /* HACK for dalboz - doc says 0x14 for GPE0_BLK */ We shouldn't reference a specific design in common code. -- To view, visit https://review.coreboot.org/c/coreboot/+/41128 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6adf71479c30f5b6751a21edc4bfa311ddbef5ec Gerrit-Change-Number: 41128 Gerrit-PatchSet: 1 Gerrit-Owner: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 May 2020 05:08:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/picasso: fix iomap for ACPI_PM
by Kangheui Won (Code Review) 06 May '20

06 May '20

Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41128 ) Change subject: soc/amd/picasso: fix iomap for ACPI_PM ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/41128 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6adf71479c30f5b6751a21edc4bfa311ddbef5ec Gerrit-Change-Number: 41128 Gerrit-PatchSet: 1 Gerrit-Owner: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Comment-Date: Thu, 07 May 2020 04:47:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common/block/lpc: Use standard pci_dev_ops_pci
by Furquan Shaikh (Code Review) 06 May '20

06 May '20

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41068 ) Change subject: soc/amd/common/block/lpc: Use standard pci_dev_ops_pci ...................................................................... soc/amd/common/block/lpc: Use standard pci_dev_ops_pci AMD common block LPC driver does not really need a custom ops_pci structure. This change drops the lops_pci and instead set .ops_pci to the default pci_dev_ops_pci. BUG=b:154445472 Change-Id: Ia06eed04097739c3e21dc13e056a2120ff5eb382 Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/soc/amd/common/block/lpc/lpc.c 1 file changed, 1 insertion(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/41068/1 diff --git a/src/soc/amd/common/block/lpc/lpc.c b/src/soc/amd/common/block/lpc/lpc.c index 0c98fcb..54befef 100644 --- a/src/soc/amd/common/block/lpc/lpc.c +++ b/src/soc/amd/common/block/lpc/lpc.c @@ -306,10 +306,6 @@ lpc_enable_childrens_resources(dev); } -static struct pci_operations lops_pci = { - .set_subsystem = pci_dev_set_subsystem, -}; - static struct device_operations lpc_ops = { .read_resources = lpc_read_resources, .set_resources = lpc_set_resources, @@ -318,7 +314,7 @@ .write_acpi_tables = southbridge_write_acpi_tables, .init = lpc_init, .scan_bus = scan_static_bus, - .ops_pci = &lops_pci, + .ops_pci = &pci_dev_ops_pci, }; static const unsigned short pci_device_ids[] = { -- To view, visit https://review.coreboot.org/c/coreboot/+/41068 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia06eed04097739c3e21dc13e056a2120ff5eb382 Gerrit-Change-Number: 41068 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-MessageType: newchange

4 4

Change in coreboot[master]: mb/google/volteer: add generic SPDs
by Nick Vaccaro (Code Review) 06 May '20

06 May '20

Hello build bot (Jenkins), Furquan Shaikh, Caveh Jalali, Duncan Laurie, Dossym Nurmukhanov, Srinidhi N Kaushik, Raj Astekar, Shreesh Chhabbi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/40463 to look at the new patch set (#20). Change subject: mb/google/volteer: add generic SPDs ...................................................................... mb/google/volteer: add generic SPDs Add SPDs created by Intel for different memory module options. NOTE: Renamed Intel's SPD_LPDDR4X_200b_2R_32Gb_QDP_4266.spd.hex to SPD_LPDDR4X_200b_2R_32Gb_87MinCAS_QDP_4267.spd.hex to remain consistent with regard to dram frequency in filename (speed is 4267, not 4266). BUG=b:147857288 TEST=none Change-Id: Ib4cd148e28efe458f2b312a7f1c5b6d71e8ef433 Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> --- A src/mainboard/google/volteer/spd/SPD_LPDDR4X_200b_1R_16Gb_DDP_3733.spd.hex A src/mainboard/google/volteer/spd/SPD_LPDDR4X_200b_1R_16Gb_DDP_4267.spd.hex A src/mainboard/google/volteer/spd/SPD_LPDDR4X_200b_2R_32Gb_87MinCAS_QDP_4267.spd.hex A src/mainboard/google/volteer/spd/SPD_LPDDR4X_200b_2R_32Gb_QDP_3733.spd.hex A src/mainboard/google/volteer/spd/SPD_LPDDR4X_200b_2R_32Gb_QDP_4267.spd.hex A src/mainboard/google/volteer/spd/SPD_LPDDR4X_200b_2R_64Gb_ODP_3733.spd.hex A src/mainboard/google/volteer/spd/SPD_LPDDR4X_200b_2R_64Gb_ODP_4267.spd.hex A src/mainboard/google/volteer/spd/SPD_LPDDR4X_556b_1R_32Gb_QDP_3733.spd.hex A src/mainboard/google/volteer/spd/SPD_LPDDR4X_556b_1R_32Gb_QDP_4267.spd.hex A src/mainboard/google/volteer/spd/SPD_LPDDR4X_556b_2R_48Gb_ODP_3733.spd.hex A src/mainboard/google/volteer/spd/SPD_LPDDR4X_556b_2R_48Gb_ODP_4267.spd.hex A src/mainboard/google/volteer/spd/SPD_LPDDR4X_556b_2R_64Gb_ODP_3733.spd.hex A src/mainboard/google/volteer/spd/SPD_LPDDR4X_556b_2R_64Gb_ODP_4267.spd.hex 13 files changed, 416 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/40463/20 -- To view, visit https://review.coreboot.org/c/coreboot/+/40463 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4cd148e28efe458f2b312a7f1c5b6d71e8ef433 Gerrit-Change-Number: 40463 Gerrit-PatchSet: 20 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Dossym Nurmukhanov <dossym(a)google.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Shreesh Chhabbi <shreesh.chhabbi(a)intel.corp-partner.google.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mainboard(s): drop redundant entries from Makefiles
by Michael Niewöhner (Code Review) 06 May '20

06 May '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41107 ) Change subject: mainboard(s): drop redundant entries from Makefiles ...................................................................... Uploaded patch set 6: New patch set was added with same tree, parent, and commit message as Patch Set 5. -- To view, visit https://review.coreboot.org/c/coreboot/+/41107 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1961646c5ed4ae6a1308ce0e8e15792970da4e0d Gerrit-Change-Number: 41107 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Wed, 06 May 2020 23:44:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mainboard(s): drop redundant entries from Makefiles
by Michael Niewöhner (Code Review) 06 May '20

06 May '20

Hello build bot (Jenkins), Philipp Hug, Patrick Georgi, Patrick Rudolph, Frans Hendriks, Tristan Corrick, Patrick Rudolph, Piotr Król, David Guckian, Michał Żygowski, Martin Roth, Christian Walter, Vanessa Eusebio, Alexander Couzens, Werner Zeh, ron minnich, Wim Vervoorn, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/41107 to look at the new patch set (#6). Change subject: mainboard(s): drop redundant entries from Makefiles ...................................................................... mainboard(s): drop redundant entries from Makefiles Drop redundant entries from mainboards' Makefiles that already get included implicitly like `romstage.c` and equivalents. Change-Id: I1961646c5ed4ae6a1308ce0e8e15792970da4e0d Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/mainboard/amd/inagua/Makefile.inc M src/mainboard/amd/olivehill/Makefile.inc M src/mainboard/amd/parmer/Makefile.inc M src/mainboard/amd/persimmon/Makefile.inc M src/mainboard/amd/south_station/Makefile.inc M src/mainboard/amd/thatcher/Makefile.inc M src/mainboard/amd/union_station/Makefile.inc D src/mainboard/aopen/dxplplusu/Makefile.inc M src/mainboard/asrock/b85m_pro4/Makefile.inc M src/mainboard/asrock/e350m1/Makefile.inc M src/mainboard/asrock/h110m/Makefile.inc M src/mainboard/asrock/h81m-hds/Makefile.inc M src/mainboard/asrock/imb-a180/Makefile.inc M src/mainboard/asus/am1i-a/Makefile.inc M src/mainboard/asus/f2a85-m/Makefile.inc M src/mainboard/asus/p2b/Makefile.inc M src/mainboard/bap/ode_e20XX/Makefile.inc M src/mainboard/biostar/a68n_5200/Makefile.inc M src/mainboard/biostar/am1ml/Makefile.inc M src/mainboard/cavium/cn8100_sff_evb/Makefile.inc M src/mainboard/elmex/pcm205400/Makefile.inc M src/mainboard/emulation/qemu-aarch64/Makefile.inc M src/mainboard/emulation/qemu-armv7/Makefile.inc M src/mainboard/emulation/qemu-power8/Makefile.inc M src/mainboard/emulation/qemu-q35/Makefile.inc M src/mainboard/emulation/qemu-riscv/Makefile.inc M src/mainboard/emulation/spike-riscv/Makefile.inc M src/mainboard/facebook/fbg1701/Makefile.inc M src/mainboard/facebook/monolith/Makefile.inc M src/mainboard/gizmosphere/gizmo2/Makefile.inc M src/mainboard/google/auron/Makefile.inc M src/mainboard/google/beltino/Makefile.inc M src/mainboard/google/cheza/Makefile.inc M src/mainboard/google/cyan/Makefile.inc M src/mainboard/google/cyan/variants/banon/Makefile.inc M src/mainboard/google/cyan/variants/celes/Makefile.inc M src/mainboard/google/cyan/variants/edgar/Makefile.inc M src/mainboard/google/cyan/variants/kefka/Makefile.inc M src/mainboard/google/cyan/variants/reks/Makefile.inc M src/mainboard/google/cyan/variants/relm/Makefile.inc M src/mainboard/google/cyan/variants/setzer/Makefile.inc M src/mainboard/google/cyan/variants/terra/Makefile.inc M src/mainboard/google/cyan/variants/ultima/Makefile.inc M src/mainboard/google/daisy/Makefile.inc M src/mainboard/google/dedede/Makefile.inc M src/mainboard/google/deltaur/Makefile.inc M src/mainboard/google/dragonegg/Makefile.inc M src/mainboard/google/drallion/Makefile.inc M src/mainboard/google/eve/Makefile.inc M src/mainboard/google/fizz/Makefile.inc M src/mainboard/google/fizz/variants/karma/Makefile.inc M src/mainboard/google/foster/Makefile.inc M src/mainboard/google/gale/Makefile.inc M src/mainboard/google/glados/Makefile.inc M src/mainboard/google/gru/Makefile.inc M src/mainboard/google/hatch/Makefile.inc M src/mainboard/google/hatch/variants/dratini/Makefile.inc M src/mainboard/google/hatch/variants/duffy/Makefile.inc M src/mainboard/google/hatch/variants/hatch/Makefile.inc M src/mainboard/google/hatch/variants/helios/Makefile.inc M src/mainboard/google/hatch/variants/jinlon/Makefile.inc M src/mainboard/google/hatch/variants/kaisa/Makefile.inc M src/mainboard/google/hatch/variants/kohaku/Makefile.inc M src/mainboard/google/hatch/variants/mushu/Makefile.inc M src/mainboard/google/hatch/variants/nightfury/Makefile.inc M src/mainboard/google/hatch/variants/puff/Makefile.inc M src/mainboard/google/jecht/Makefile.inc M src/mainboard/google/kahlee/Makefile.inc M src/mainboard/google/kahlee/variants/nuwani/Makefile.inc M src/mainboard/google/kahlee/variants/treeya/Makefile.inc M src/mainboard/google/kukui/Makefile.inc M src/mainboard/google/mistral/Makefile.inc M src/mainboard/google/nyan/Makefile.inc M src/mainboard/google/nyan_big/Makefile.inc M src/mainboard/google/nyan_blaze/Makefile.inc M src/mainboard/google/oak/Makefile.inc M src/mainboard/google/octopus/Makefile.inc M src/mainboard/google/octopus/variants/phaser/Makefile.inc M src/mainboard/google/peach_pit/Makefile.inc M src/mainboard/google/poppy/Makefile.inc M src/mainboard/google/poppy/variants/atlas/Makefile.inc M src/mainboard/google/poppy/variants/nami/Makefile.inc M src/mainboard/google/poppy/variants/nautilus/Makefile.inc M src/mainboard/google/poppy/variants/nocturne/Makefile.inc M src/mainboard/google/poppy/variants/rammus/Makefile.inc M src/mainboard/google/reef/Makefile.inc M src/mainboard/google/reef/variants/coral/Makefile.inc D src/mainboard/google/reef/variants/snappy/Makefile.inc M src/mainboard/google/sarien/Makefile.inc M src/mainboard/google/slippy/Makefile.inc M src/mainboard/google/smaug/Makefile.inc M src/mainboard/google/storm/Makefile.inc M src/mainboard/google/trogdor/Makefile.inc M src/mainboard/google/veyron/Makefile.inc M src/mainboard/google/veyron_mickey/Makefile.inc M src/mainboard/google/veyron_rialto/Makefile.inc M src/mainboard/google/volteer/Makefile.inc M src/mainboard/hp/abm/Makefile.inc M src/mainboard/intel/cannonlake_rvp/Makefile.inc D src/mainboard/intel/cedarisland_crb/Makefile.inc M src/mainboard/intel/coffeelake_rvp/Makefile.inc M src/mainboard/intel/dcp847ske/Makefile.inc M src/mainboard/intel/glkrvp/Makefile.inc M src/mainboard/intel/harcuvar/Makefile.inc M src/mainboard/intel/icelake_rvp/Makefile.inc M src/mainboard/intel/jasperlake_rvp/Makefile.inc M src/mainboard/intel/kblrvp/Makefile.inc M src/mainboard/intel/kunimitsu/Makefile.inc D src/mainboard/intel/leafhill/Makefile.inc M src/mainboard/intel/minnow3/Makefile.inc M src/mainboard/intel/saddlebrook/Makefile.inc M src/mainboard/intel/strago/Makefile.inc M src/mainboard/intel/tglrvp/Makefile.inc M src/mainboard/jetway/nf81-t56n-lf/Makefile.inc M src/mainboard/lenovo/l520/Makefile.inc M src/mainboard/lenovo/s230u/Makefile.inc M src/mainboard/lenovo/t400/Makefile.inc M src/mainboard/lenovo/t410/Makefile.inc M src/mainboard/lenovo/t420/Makefile.inc M src/mainboard/lenovo/t420s/Makefile.inc M src/mainboard/lenovo/t430/Makefile.inc M src/mainboard/lenovo/t430s/Makefile.inc M src/mainboard/lenovo/t440p/Makefile.inc M src/mainboard/lenovo/t520/Makefile.inc M src/mainboard/lenovo/t530/Makefile.inc M src/mainboard/lenovo/x1_carbon_gen1/Makefile.inc M src/mainboard/lenovo/x201/Makefile.inc M src/mainboard/lenovo/x220/Makefile.inc M src/mainboard/lenovo/x230/Makefile.inc M src/mainboard/libretrend/lt1000/Makefile.inc M src/mainboard/lippert/frontrunner-af/Makefile.inc M src/mainboard/lippert/toucan-af/Makefile.inc M src/mainboard/msi/ms7721/Makefile.inc D src/mainboard/ocp/sonorapass/Makefile.inc M src/mainboard/ocp/tiogapass/Makefile.inc M src/mainboard/opencellular/elgon/Makefile.inc M src/mainboard/packardbell/ms2290/Makefile.inc M src/mainboard/pcengines/apu1/Makefile.inc M src/mainboard/pcengines/apu2/Makefile.inc M src/mainboard/portwell/m107/Makefile.inc M src/mainboard/protectli/vault_bsw/Makefile.inc M src/mainboard/protectli/vault_kbl/Makefile.inc M src/mainboard/purism/librem_skl/Makefile.inc M src/mainboard/razer/blade_stealth_kbl/Makefile.inc M src/mainboard/roda/rk9/Makefile.inc M src/mainboard/scaleway/tagada/Makefile.inc M src/mainboard/siemens/mc_apl1/Makefile.inc M src/mainboard/siemens/mc_apl1/variants/mc_apl1/Makefile.inc M src/mainboard/siemens/mc_apl1/variants/mc_apl2/Makefile.inc M src/mainboard/siemens/mc_apl1/variants/mc_apl3/Makefile.inc M src/mainboard/siemens/mc_apl1/variants/mc_apl5/Makefile.inc M src/mainboard/siemens/mc_apl1/variants/mc_apl6/Makefile.inc M src/mainboard/sifive/hifive-unleashed/Makefile.inc M src/mainboard/supermicro/x10slm-f/Makefile.inc M src/mainboard/supermicro/x11-lga1151-series/Makefile.inc D src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Makefile.inc M src/mainboard/system76/lemp9/Makefile.inc M src/mainboard/ti/beaglebone/Makefile.inc M src/mainboard/up/squared/Makefile.inc 159 files changed, 3 insertions(+), 395 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/41107/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/41107 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1961646c5ed4ae6a1308ce0e8e15792970da4e0d Gerrit-Change-Number: 41107 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: arch/x86: handle ramstage.c by default in Make
by Michael Niewöhner (Code Review) 06 May '20

06 May '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41106 ) Change subject: arch/x86: handle ramstage.c by default in Make ...................................................................... Uploaded patch set 3: New patch set was added with same tree, parent, and commit message as Patch Set 2. -- To view, visit https://review.coreboot.org/c/coreboot/+/41106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibfc7d8eb97b4a98317cf6f76bbf1da56bc0c9afa Gerrit-Change-Number: 41106 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 May 2020 23:44:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86: handle ramstage.c by default in Make
by Michael Niewöhner (Code Review) 06 May '20

06 May '20

Hello build bot (Jenkins), Nico Huber, Martin Roth, Patrick Georgi, Matt DeVillier, Paul Menzel, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/41106 to look at the new patch set (#3). Change subject: arch/x86: handle ramstage.c by default in Make ...................................................................... arch/x86: handle ramstage.c by default in Make Some boards use `ramstage.c` instead of `mainboard.c`, some use both. Implicitly handle `ramstage.c` in mainboards' directories, too. Change-Id: Ibfc7d8eb97b4a98317cf6f76bbf1da56bc0c9afa Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/arch/x86/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/41106/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/41106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibfc7d8eb97b4a98317cf6f76bbf1da56bc0c9afa Gerrit-Change-Number: 41106 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: arch/x86: handle bootblock.c by default in Make
by Michael Niewöhner (Code Review) 06 May '20

06 May '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41105 ) Change subject: arch/x86: handle bootblock.c by default in Make ...................................................................... Uploaded patch set 5: Patch Set 4 was rebased. -- To view, visit https://review.coreboot.org/c/coreboot/+/41105 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62648bed633b5d9646bc3b943019191b4918f1dc Gerrit-Change-Number: 41105 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 May 2020 23:44:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/xeon_sp: make CPX ramstage.h common for CPX, SKX
by Michael Niewöhner (Code Review) 06 May '20

06 May '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41116 ) Change subject: soc/intel/xeon_sp: make CPX ramstage.h common for CPX, SKX ...................................................................... Uploaded patch set 3: Patch Set 2 was rebased. -- To view, visit https://review.coreboot.org/c/coreboot/+/41116 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9cd25edd167ec71ee98c7ffa4fa6f95ca73a75e9 Gerrit-Change-Number: 41116 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 May 2020 23:44:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2020