Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41128 )
Change subject: soc/amd/picasso: fix iomap for ACPI_PM ......................................................................
Patch Set 1:
(1 comment)
What about this CL? https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+...
What's the real answer? I feel like we haven't root caused why this patch or the one above is needed.
https://review.coreboot.org/c/coreboot/+/41128/1/src/soc/amd/picasso/include... File src/soc/amd/picasso/include/soc/iomap.h:
https://review.coreboot.org/c/coreboot/+/41128/1/src/soc/amd/picasso/include... PS1, Line 69: /* HACK for dalboz - doc says 0x14 for GPE0_BLK */ We shouldn't reference a specific design in common code.