coreboot-gerrit January 2020

coreboot-gerrit@coreboot.org

1 participants
1869 discussions

Change in coreboot[master]: device/Kconfig: make sure display can't be selected by accident
by Nico Huber (Code Review) 03 Jan '20

03 Jan '20

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36444 ) Change subject: device/Kconfig: make sure display can't be selected by accident ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/36444 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iec5a47f84b8c776a45edc6f4b31a03b9ac714b4e Gerrit-Change-Number: 36444 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Fri, 03 Jan 2020 13:46:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/pcengines/apu1/bootblock.c: Add possibility to redirect output to ...
by Michał Żygowski (Code Review) 03 Jan '20

03 Jan '20

Hello Patrick Rudolph, Piotr Król, Paul Menzel, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/29791 to look at the new patch set (#4). Change subject: mb/pcengines/apu1/bootblock.c: Add possibility to redirect output to COM2 ...................................................................... mb/pcengines/apu1/bootblock.c: Add possibility to redirect output to COM2 Enable COM2 port on SuperIO if UART index is 1. This change allows to use full RS232 COM1 port for different purposes when COM2 is selected as main port. TEST=flash coreboot with console on COM2 and observer output with UBS-TTL converter connected to COM2 header on PC Engines apu1 Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I1e72c5a43a302658f86dafd863e5a67580eae3e4 --- M src/mainboard/pcengines/apu1/bootblock.c M src/mainboard/pcengines/apu1/romstage.c 2 files changed, 6 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/29791/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/29791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e72c5a43a302658f86dafd863e5a67580eae3e4 Gerrit-Change-Number: 29791 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: usbdebug: Fix printk conversion
by Kyösti Mälkki (Code Review) 03 Jan '20

03 Jan '20

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38006 ) Change subject: usbdebug: Fix printk conversion ...................................................................... usbdebug: Fix printk conversion Change-Id: I0dba96004de264fe1faf5485fb677a6b05123bba Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/drivers/usb/ehci_debug.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/38006/1 diff --git a/src/drivers/usb/ehci_debug.c b/src/drivers/usb/ehci_debug.c index 318dfe7..b31b563 100644 --- a/src/drivers/usb/ehci_debug.c +++ b/src/drivers/usb/ehci_debug.c @@ -452,7 +452,7 @@ info->ehci_debug = ehci_bar + offset; info->ep_pipe[0].status |= DBGP_EP_NOT_PRESENT; - dprintk(BIOS_INFO, "ehci_bar: 0x%x debug_offset 0x%x\n", ehci_bar, offset); + dprintk(BIOS_INFO, "ehci_bar: 0x%zx debug_offset 0x%x\n", ehci_bar, offset); ehci_caps = (struct ehci_caps *)ehci_bar; ehci_regs = (struct ehci_regs *)(ehci_bar + -- To view, visit https://review.coreboot.org/c/coreboot/+/38006 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0dba96004de264fe1faf5485fb677a6b05123bba Gerrit-Change-Number: 38006 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newchange

3 8

Change in coreboot[master]: src/drivers/i2c: add i2c driver for Realtek 1308
by Paul Menzel (Code Review) 03 Jan '20

03 Jan '20

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37882 ) Change subject: src/drivers/i2c: add i2c driver for Realtek 1308 ...................................................................... Patch Set 2: (4 comments) https://review.coreboot.org/c/coreboot/+/37882/2//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/37882/2//COMMIT_MSG@9 PS2, Line 9: Adding Add https://review.coreboot.org/c/coreboot/+/37882/2//COMMIT_MSG@10 PS2, Line 10: 1. Please mention the datasheet name and revision you used for implementing this. 2. Did you use some existing code as template? https://review.coreboot.org/c/coreboot/+/37882/2/src/drivers/i2c/rt1308/chi… File src/drivers/i2c/rt1308/chip.h: https://review.coreboot.org/c/coreboot/+/37882/2/src/drivers/i2c/rt1308/chi… PS2, Line 26: uint32_t uid; Does the comment match? Please change the variable, as `uid` normally means *unique identifier*. Also, use bool if possible. https://review.coreboot.org/c/coreboot/+/37882/2/src/drivers/i2c/rt1308/rt1… File src/drivers/i2c/rt1308/rt1308.c: https://review.coreboot.org/c/coreboot/+/37882/2/src/drivers/i2c/rt1308/rt1… PS2, Line 104: Codec Is *amplifier* and *codec* the same? -- To view, visit https://review.coreboot.org/c/coreboot/+/37882 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie44fc8199f2153e18537023dfd92e0ce6a3ecb9c Gerrit-Change-Number: 37882 Gerrit-PatchSet: 2 Gerrit-Owner: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jairaj Arava <jairaj.arava(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Fri, 03 Jan 2020 12:51:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mainboard/google/puff: Missing GPP_E02 high assert
by Edward O'Callaghan (Code Review) 03 Jan '20

03 Jan '20

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37914 ) Change subject: mainboard/google/puff: Missing GPP_E02 high assert ...................................................................... mainboard/google/puff: Missing GPP_E02 high assert BUG=b:144809606 BRANCH=none TEST=none Change-Id: Ide3f89320d34b4ef622f4bc5fea4690396690750 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M src/mainboard/google/hatch/variants/puff/gpio.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/37914/1 diff --git a/src/mainboard/google/hatch/variants/puff/gpio.c b/src/mainboard/google/hatch/variants/puff/gpio.c index b8b54d3..3baf081 100644 --- a/src/mainboard/google/hatch/variants/puff/gpio.c +++ b/src/mainboard/google/hatch/variants/puff/gpio.c @@ -19,6 +19,8 @@ /* Early pad configuration in bootblock */ static const struct pad_config early_gpio_table[] = { + /* E2 : EN_PP_MST_OD */ + PAD_CFG_GPO(GPP_E2, 1, DEEP), /* B14 : GPP_B14_STRAP */ PAD_NC(GPP_B14, NONE), /* B22 : GPP_B22_STRAP */ -- To view, visit https://review.coreboot.org/c/coreboot/+/37914 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide3f89320d34b4ef622f4bc5fea4690396690750 Gerrit-Change-Number: 37914 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

1 1

Change in coreboot[master]: mainboard/google/puff: Avoid vboot early ec sync
by Edward O'Callaghan (Code Review) 03 Jan '20

03 Jan '20

Hello Edward O'Callaghan, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/37701 to review the following change. Change subject: mainboard/google/puff: Avoid vboot early ec sync ...................................................................... mainboard/google/puff: Avoid vboot early ec sync Puff's EC doesn't really support the 'EC_CMD_CHARGE_STATE' cmd because it doesn't have a charger IC on the board. BRANCH=none BUG=b:146165519 TEST=./util/abuild/abuild -p none -t google/hatch -x -a Change-Id: I1d396e164be38639095a0e6dd0602c6b11bf8eb2 Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M src/mainboard/google/hatch/Kconfig 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/37701/1 diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 98a0174..1904e41 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -127,6 +127,11 @@ config VBOOT select HAS_RECOVERY_MRC_CACHE select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN + +config VBOOT_LAPTOP + bool + default y if !BOARD_GOOGLE_PUFF + depends on VBOOT select VBOOT_EARLY_EC_SYNC select VBOOT_LID_SWITCH -- To view, visit https://review.coreboot.org/c/coreboot/+/37701 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1d396e164be38639095a0e6dd0602c6b11bf8eb2 Gerrit-Change-Number: 37701 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)google.com> Gerrit-MessageType: newchange

2 3

Change in coreboot[master]: mainboard/google/puff: Clean up Kconfig
by Edward O'Callaghan (Code Review) 03 Jan '20

03 Jan '20

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38098 ) Change subject: mainboard/google/puff: Clean up Kconfig ...................................................................... mainboard/google/puff: Clean up Kconfig Let the linker trim unused net driver symbols when unused in devicetree rather than being overly zealous in the Kconfig. BUG=b:146592075,146999042,146999043 BRANCH=none TEST=Boot to kernel. Ensure we have ip address and corresponding mac address with ifconfig. Ensure ethernet controller shows up with lspci. Change-Id: Ie98d0f9f9b77cb9ee4e52f6c95b68bcbdd94f2cc Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M src/mainboard/google/hatch/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/38098/1 diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 3427ced..783ec73 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -22,8 +22,8 @@ select MB_HAS_ACTIVE_HIGH_SD_PWR_ENABLE select SOC_INTEL_COMETLAKE select SYSTEM_TYPE_LAPTOP - select RT8168_GET_MAC_FROM_VPD if BOARD_GOOGLE_PUFF - select RT8168_SET_LED_MODE if BOARD_GOOGLE_PUFF + select RT8168_GET_MAC_FROM_VPD + select RT8168_SET_LED_MODE if BOARD_GOOGLE_BASEBOARD_HATCH -- To view, visit https://review.coreboot.org/c/coreboot/+/38098 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie98d0f9f9b77cb9ee4e52f6c95b68bcbdd94f2cc Gerrit-Change-Number: 38098 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

3 9

Change in coreboot[master]: soc/intel/tigerlake: Update GPIO config
by Shaunak Saha (Code Review) 03 Jan '20

03 Jan '20

Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37427 ) Change subject: soc/intel/tigerlake: Update GPIO config ...................................................................... Patch Set 13: I got the confirmation from the GPIO team regarding the EDS information. They said "index mapping should be identical (or set the same) for DW0, DW1 and DW2 – so the EDS is incorrect if DW2 still shows the old mapping". So we do not need any code modification for dealing with DW0,1 or 2 separately. -- To view, visit https://review.coreboot.org/c/coreboot/+/37427 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I585100375feee39b5a9105bdf6d9f5ca3a5bb2fa Gerrit-Change-Number: 37427 Gerrit-PatchSet: 13 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Venkata Krishna Nimmagadda Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Fri, 03 Jan 2020 05:53:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: device/early_smbus: Drop unused function parameter
by Kyösti Mälkki (Code Review) 03 Jan '20

03 Jan '20

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38051 ) Change subject: device/early_smbus: Drop unused function parameter ...................................................................... device/early_smbus: Drop unused function parameter Change-Id: I2d62c470c5389af3b10e47ca5e721b78ff16bc79 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/include/device/early_smbus.h M src/lib/spd_bin.c M src/soc/intel/common/block/smbus/smbuslib.c 3 files changed, 11 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/38051/1 diff --git a/src/include/device/early_smbus.h b/src/include/device/early_smbus.h index c2a2f67..015be67 100644 --- a/src/include/device/early_smbus.h +++ b/src/include/device/early_smbus.h @@ -49,8 +49,8 @@ #include <stdint.h> -u16 smbus_read_word(u32 smbus_dev, u8 addr, u8 offset); -u8 smbus_read_byte(u32 smbus_dev, u8 addr, u8 offset); -u8 smbus_write_byte(u32 smbus_dev, u8 addr, u8 offset, u8 value); +u16 smbus_read_word(u8 addr, u8 offset); +u8 smbus_read_byte(u8 addr, u8 offset); +u8 smbus_write_byte(u8 addr, u8 offset, u8 value); #endif /* DEVICE_EARLY_SMBUS_H */ diff --git a/src/lib/spd_bin.c b/src/lib/spd_bin.c index 71fe036..b022200 100644 --- a/src/lib/spd_bin.c +++ b/src/lib/spd_bin.c @@ -227,15 +227,15 @@ for (i = 0; i < SPD_PAGE_LEN; i += step) { if (CONFIG(SPD_READ_BY_WORD)) ((u16*)spd)[i / sizeof(uint16_t)] = - smbus_read_word(0, addr, i); + smbus_read_word(addr, i); else - spd[i] = smbus_read_byte(0, addr, i); + spd[i] = smbus_read_byte(addr, i); } } static void get_spd(u8 *spd, u8 addr) { - if (smbus_read_byte(0, addr, 0) == 0xff) { + if (smbus_read_byte(addr, 0) == 0xff) { printk(BIOS_INFO, "No memory dimm at address %02X\n", addr << 1); /* Make sure spd is zeroed if dimm doesn't exist. */ @@ -248,10 +248,10 @@ if (spd[SPD_DRAM_TYPE] == SPD_DRAM_DDR4 && CONFIG_DIMM_SPD_SIZE > SPD_PAGE_LEN) { /* Switch to page 1 */ - smbus_write_byte(0, SPD_PAGE_1, 0, 0); + smbus_write_byte(SPD_PAGE_1, 0, 0); smbus_read_spd(spd + SPD_PAGE_LEN, addr); /* Restore to page 0 */ - smbus_write_byte(0, SPD_PAGE_0, 0, 0); + smbus_write_byte(SPD_PAGE_0, 0, 0); } } diff --git a/src/soc/intel/common/block/smbus/smbuslib.c b/src/soc/intel/common/block/smbus/smbuslib.c index e2a0ed9..a8c2dad 100644 --- a/src/soc/intel/common/block/smbus/smbuslib.c +++ b/src/soc/intel/common/block/smbus/smbuslib.c @@ -178,17 +178,17 @@ return data; } -u16 smbus_read_word(u32 smbus_dev, u8 addr, u8 offset) +u16 smbus_read_word(u8 addr, u8 offset) { return smbus_read16(SMBUS_IO_BASE, addr, offset); } -u8 smbus_read_byte(u32 smbus_dev, u8 addr, u8 offset) +u8 smbus_read_byte(u8 addr, u8 offset) { return smbus_read8(SMBUS_IO_BASE, addr, offset); } -u8 smbus_write_byte(u32 smbus_dev, u8 addr, u8 offset, u8 value) +u8 smbus_write_byte(u8 addr, u8 offset, u8 value) { return smbus_write8(SMBUS_IO_BASE, addr, offset, value); } -- To view, visit https://review.coreboot.org/c/coreboot/+/38051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d62c470c5389af3b10e47ca5e721b78ff16bc79 Gerrit-Change-Number: 38051 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

2 2

Change in coreboot[master]: device/early_smbus: Remove unused prototypes
by Kyösti Mälkki (Code Review) 03 Jan '20

03 Jan '20

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38050 ) Change subject: device/early_smbus: Remove unused prototypes ...................................................................... device/early_smbus: Remove unused prototypes Change-Id: Iecc6591244781e092132a058fe888f3bdd78cc50 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/include/device/early_smbus.h 1 file changed, 0 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/38050/1 diff --git a/src/include/device/early_smbus.h b/src/include/device/early_smbus.h index 651dc18..c2a2f67 100644 --- a/src/include/device/early_smbus.h +++ b/src/include/device/early_smbus.h @@ -49,23 +49,8 @@ #include <stdint.h> -/** - * \brief printk macro for SMBus debugging - */ -#if CONFIG(DEBUG_SMBUS) -#define printsmbus(x, ...) printk(BIOS_DEBUG, x, ##__VA_ARGS__) -#else -#define printsmbus(x, ...) -#endif - -u32 smbus_get_device(void); -void smbus_reset(u32 smbus_dev); -int smbus_print_error(u32 smbus_dev, u8 host_status, int loops); -int smbus_is_busy(u32 smbus_dev); -int smbus_wait_until_ready(u32 smbus_dev); u16 smbus_read_word(u32 smbus_dev, u8 addr, u8 offset); u8 smbus_read_byte(u32 smbus_dev, u8 addr, u8 offset); u8 smbus_write_byte(u32 smbus_dev, u8 addr, u8 offset, u8 value); -void smbus_delay(void); #endif /* DEVICE_EARLY_SMBUS_H */ -- To view, visit https://review.coreboot.org/c/coreboot/+/38050 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iecc6591244781e092132a058fe888f3bdd78cc50 Gerrit-Change-Number: 38050 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newchange

2 2

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2020