Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34241 )
Change subject: util/abuild: Cleanup the missing_arches check
......................................................................
util/abuild: Cleanup the missing_arches check
This change adds the following improvements:
* Easier to read.
* Checks to see if .xcompile is complete. I chose to abort the whole
script since it would fail later anyway.
* Checks the make return code. This will catch if .xcompile is missing.
BUG=b:112267918
TEST=Modified my .xcompile and ran abuild and verified that
missing_arches got set correctly. Also deleted .xcompile and verified
there was a failure.
Change-Id: I7604d431f398fc0c80a857a0c7c21e164004cc99
Signed-off-by: Raul E Rangel <rrangel(a)chromium.org>
---
M util/abuild/abuild
1 file changed, 17 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/34241/1
diff --git a/util/abuild/abuild b/util/abuild/abuild
index abfedba..3a297c3 100755
--- a/util/abuild/abuild
+++ b/util/abuild/abuild
@@ -462,10 +462,25 @@
return
fi
+ local required_arches
+
required_arches=$(grep -E "^CONFIG_ARCH_(BOOTBLOCK|R.MSTAGE|VERSTAGE)" "$TARGET/${BUILD_NAME}/config.build" | \
sed "s,^CONFIG_ARCH_[^_]*_\([^=]*\)=.*$,\1," |sort -u |tr 'A-Z\n\r' 'a-z ')
- # shellcheck disable=SC2016,SC2059
- missing_arches=$(printf 'include .xcompile\nall: ; @echo $(foreach arch,'"$required_arches"',$(if $(filter $(arch),$(SUBARCH_SUPPORTED)),,$(arch)))' | $MAKE --no-print-directory -f -)
+
+ missing_arches="$($MAKE -f - REQUIRED_ARCHES="$required_arches" <<'EOF'
+include .xcompile
+.PHONY: missing_arches
+missing_arches:
+ $(if $(XCOMPILE_COMPLETE),,$(error .xcompile is invalid.))
+ @echo $(foreach arch,$(REQUIRED_ARCHES),$(if $(filter $(arch),$(SUBARCH_SUPPORTED)),,$(arch)))
+EOF
+)"
+ # shellcheck disable=SC2181
+ if [[ $? -ne 0 ]]; then
+ echo "Calculating missing_arches failed" >&2
+ exit 1
+ fi
+
if [ -n "$missing_arches" ]; then
printf "skipping %s because we're missing compilers for (%s)\n" "$BUILD_NAME" "$missing_arches"
return
--
To view, visit https://review.coreboot.org/c/coreboot/+/34241
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7604d431f398fc0c80a857a0c7c21e164004cc99
Gerrit-Change-Number: 34241
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org>
Gerrit-MessageType: newchange
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35003 )
Change subject: Split MAYBE_STATIC to _BSS and _NONZERO variants
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/35003
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80485ebac94b88c5864a949b17ad1dccdfda6a40
Gerrit-Change-Number: 35003
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 21 Aug 2019 21:58:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34976 )
Change subject: cpu/intel/car: Make stack guards more useful on C_ENV_BOOTBLOCK
......................................................................
cpu/intel/car: Make stack guards more useful on C_ENV_BOOTBLOCK
With C_ENVIRONMENT_BOOTBLOCK, CONFIG_DCACHE_BSP_STACK_SIZE needs to be
set to define a stack region that can be shared over all stages using
CAR. It makes sense to use that Kconfig option's value instead of a
hardcoded value.
This will result in less false positives when the stack size is big,
for instance with FSP using the coreboot stack.
Change-Id: I2ce1dda4d1f254e6c36de4d3fea26e12c34195ff
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/cpu/intel/car/romstage.c
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/34976/1
diff --git a/src/cpu/intel/car/romstage.c b/src/cpu/intel/car/romstage.c
index 89052d6..1816e80 100644
--- a/src/cpu/intel/car/romstage.c
+++ b/src/cpu/intel/car/romstage.c
@@ -20,8 +20,6 @@
#include <program_loading.h>
#include <timestamp.h>
-#define DCACHE_RAM_ROMSTAGE_STACK_SIZE 0x2000
-
static void romstage_main(unsigned long bist)
{
int i;
@@ -29,11 +27,13 @@
const u32 stack_guard = 0xdeadbeef;
u32 *stack_base;
u32 size;
+ const u32 max_dcache_stack_size = CONFIG_DCACHE_BSP_STACK_SIZE ?
+ CONFIG_DCACHE_BSP_STACK_SIZE : 0x2000;
/* Size of unallocated CAR. */
size = ALIGN_DOWN(_car_stack_size, 16);
- size = MIN(size, DCACHE_RAM_ROMSTAGE_STACK_SIZE);
+ size = MIN(size, max_dcache_stack_size);
if (size < DCACHE_RAM_ROMSTAGE_STACK_SIZE)
printk(BIOS_DEBUG, "Romstage stack size limited to 0x%x!\n",
size);
--
To view, visit https://review.coreboot.org/c/coreboot/+/34976
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ce1dda4d1f254e6c36de4d3fea26e12c34195ff
Gerrit-Change-Number: 34976
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newchange
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/15474 )
Change subject: AMD fam10: Remove HAVE_ACPI_RESUME support
......................................................................
Patch Set 13:
> Patch Set 13:
>
> Thanks! Although somebody on the mailing list just asked how to produce the logs, at least I can say it was not me who pulled the trigger :)
I won't be able to fix the relevant code in time, so I don't have a reason to block this. Plus, my fam10 stuff uses DDR2 so S3 wasn't there to begin with.
I might try to do something with a fam15 board I have: Gigabyte GA-F2A88XM-D3H + Athlon 760K CPU (socket FM2) + A88X Bolton-D4 FCH. But I don't have high hopes because of missing documentation (no board schematics, no SuperIO datasheet...)
--
To view, visit https://review.coreboot.org/c/coreboot/+/15474
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62bbba8cfe515b3cae413582ff8d062a20e6741b
Gerrit-Change-Number: 15474
Gerrit-PatchSet: 13
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Raptor Engineering Automated Test Stand <noreply(a)raptorengineeringinc.com>
Gerrit-Reviewer: Rudolf Marek <r.marek(a)assembler.cz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 21 Aug 2019 14:29:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment