Hello John Zhao,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/34249
to review the following change.
Change subject: cpu/x86: Initialize the argument value msr_index
......................................................................
cpu/x86: Initialize the argument value msr_index
Clang Static Analyzer version 8.0.0 treats the uninitialized argument
value msr_index as logic error in a function call. Just set msr_index
with 0 initially.
Change-Id: I051b290998207a1129ada06bb455f44c2d291975
Signed-off-by: John Zhao <john.zhao(a)intel.com>
---
M src/cpu/x86/mtrr/mtrr.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/34249/1
diff --git a/src/cpu/x86/mtrr/mtrr.c b/src/cpu/x86/mtrr/mtrr.c
index 98449d5..4dc71d6 100644
--- a/src/cpu/x86/mtrr/mtrr.c
+++ b/src/cpu/x86/mtrr/mtrr.c
@@ -321,6 +321,7 @@
fixed_mtrrs_expose_amd_rwdram();
+ memset(&msr_index, 0, sizeof(msr_index));
memset(&fixed_msrs, 0, sizeof(fixed_msrs));
msr_num = 0;
--
To view, visit https://review.coreboot.org/c/coreboot/+/34249
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I051b290998207a1129ada06bb455f44c2d291975
Gerrit-Change-Number: 34249
Gerrit-PatchSet: 1
Gerrit-Owner: John Zhao <john.zhao(a)intel.corp-partner.google.com>
Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com>
Gerrit-MessageType: newchange
Name of user not set #1002476 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34630 )
Change subject: mb/intel/minnowmax: Adding config for FSP_PACKAGE_DEFAULT
......................................................................
mb/intel/minnowmax: Adding config for FSP_PACKAGE_DEFAULT
Config VGA_BIOS is using FSP_PACKAGE_DEFAULT, so added config for the same.
Also updated the default path for config FSP_FILE according to the current coreboot directory structure.
Change-Id: Ifb1a92287ad5beea6559db0cd4cf66eeb0f46f95
Signed-off-by: Himanshu Sahdev <Coreboot(a)hcl.com>
---
M src/mainboard/intel/minnowmax/Kconfig
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/34630/1
diff --git a/src/mainboard/intel/minnowmax/Kconfig b/src/mainboard/intel/minnowmax/Kconfig
index ca24c92..0e3de50 100644
--- a/src/mainboard/intel/minnowmax/Kconfig
+++ b/src/mainboard/intel/minnowmax/Kconfig
@@ -37,7 +37,7 @@
config FSP_FILE
string
- default "../intel/fsp/baytrail/BAYTRAIL_FSP.fd"
+ default "3rdparty/fsp/BayTrailFspBinPkg/FspBin/BAYTRAIL_FSP.fd"
config CBFS_SIZE
hex
@@ -57,6 +57,10 @@
bool
default n
+config FSP_PACKAGE_DEFAULT
+ bool "Configure defaults for the Intel FSP package"
+ default n
+
config VGA_BIOS
bool
default y if FSP_PACKAGE_DEFAULT
--
To view, visit https://review.coreboot.org/c/coreboot/+/34630
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb1a92287ad5beea6559db0cd4cf66eeb0f46f95
Gerrit-Change-Number: 34630
Gerrit-PatchSet: 1
Gerrit-Owner: Name of user not set #1002476
Gerrit-MessageType: newchange
Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32989
Change subject: mb/pcengines/apu2: describe serial ports in ACPI
......................................................................
mb/pcengines/apu2: describe serial ports in ACPI
FreeBSD users had to manually configure serial ports on their
installations. Defining serial ports in ACPI save that effort.
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Change-Id: I0de4172a1884abbe9d625060a9045c9d71469e27
---
A src/mainboard/pcengines/apu2/acpi/superio.asl
M src/mainboard/pcengines/apu2/dsdt.asl
2 files changed, 68 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/32989/1
diff --git a/src/mainboard/pcengines/apu2/acpi/superio.asl b/src/mainboard/pcengines/apu2/acpi/superio.asl
new file mode 100644
index 0000000..c61e3d7
--- /dev/null
+++ b/src/mainboard/pcengines/apu2/acpi/superio.asl
@@ -0,0 +1,65 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2019 PC Engines Gmbh
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+Scope (\_SB.PCI0.LIBR) {
+
+ Device (COM1) {
+ Name (_HID, EISAID ("PNP0501"))
+ Name (_UID, 1)
+
+ Method (_STA, 0, NotSerialized) {
+ Return (0x0F)
+ }
+
+ Name (_CRS, ResourceTemplate ()
+ {
+ IO (Decode16, 0x03F8, 0x3F8, 0x08, 0x08)
+ IRQNoFlags () {4}
+ })
+
+ Name (_PRS, ResourceTemplate ()
+ {
+ StartDependentFn (0, 0) {
+ IO (Decode16, 0x03F8, 0x3F8, 0x08, 0x08)
+ IRQNoFlags () {4}
+ }
+ EndDependentFn ()
+ })
+ }
+
+ Device (COM2) {
+ Name (_HID, EISAID ("PNP0501"))
+ Name (_UID, 2)
+
+ Method (_STA, 0, NotSerialized) {
+ Return (0x0F)
+ }
+
+ Name (_CRS, ResourceTemplate ()
+ {
+ IO (Decode16, 0x02F8, 0x2F8, 0x08, 0x08)
+ IRQNoFlags () {3}
+ })
+
+ Name (_PRS, ResourceTemplate ()
+ {
+ StartDependentFn (0, 0) {
+ IO (Decode16, 0x02F8, 0x2F8, 0x08, 0x08)
+ IRQNoFlags () {3}
+ }
+ EndDependentFn ()
+ })
+ }
+}
\ No newline at end of file
diff --git a/src/mainboard/pcengines/apu2/dsdt.asl b/src/mainboard/pcengines/apu2/dsdt.asl
index 3bf0ed6..409f03d 100644
--- a/src/mainboard/pcengines/apu2/dsdt.asl
+++ b/src/mainboard/pcengines/apu2/dsdt.asl
@@ -81,5 +81,8 @@
/* Define the System Indicators for the platform */
#include "acpi/si.asl"
+
+ /* Super IO devices (COM ports) */
+ #include "acpi/superio.asl"
}
/* End of ASL file */
--
To view, visit https://review.coreboot.org/c/coreboot/+/32989
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0de4172a1884abbe9d625060a9045c9d71469e27
Gerrit-Change-Number: 32989
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-MessageType: newchange
Rizwan Qureshi has uploaded this change for review. ( https://review.coreboot.org/c/vboot/+/32679
Change subject: vboot: Fix build error related to VB2_SHARED_DATA_VERSION_MINOR
......................................................................
vboot: Fix build error related to VB2_SHARED_DATA_VERSION_MINOR
vboot fails to compile with the error
"error: comparison is always false due to limited range
of data type [-Werror=type-limits]"
since struct_version_minor is uint16_t and can never be less than
VB2_SHARED_DATA_VERSION_MINOR (0)
Signed-off-by: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Change-Id: I0e68981fbecafe7ba40e00ee657e82c024a89325
---
M firmware/2lib/2misc.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/vboot refs/changes/79/32679/1
diff --git a/firmware/2lib/2misc.c b/firmware/2lib/2misc.c
index 95cbae3..195a0f9 100644
--- a/firmware/2lib/2misc.c
+++ b/firmware/2lib/2misc.c
@@ -128,7 +128,7 @@
return VB2_ERROR_SHARED_DATA_MAGIC;
if (sd->struct_version_major != VB2_SHARED_DATA_VERSION_MAJOR ||
- sd->struct_version_minor < VB2_SHARED_DATA_VERSION_MINOR)
+ sd->struct_version_minor != VB2_SHARED_DATA_VERSION_MINOR)
return VB2_ERROR_SHARED_DATA_VERSION;
return VB2_SUCCESS;
--
To view, visit https://review.coreboot.org/c/vboot/+/32679
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: vboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e68981fbecafe7ba40e00ee657e82c024a89325
Gerrit-Change-Number: 32679
Gerrit-PatchSet: 1
Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-MessageType: newchange
Pablo Moyano has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34105 )
Change subject: payloads/external/GRUB2/Makefile: Add ./bootstrap to fix build
......................................................................
payloads/external/GRUB2/Makefile: Add ./bootstrap to fix build
At some point between Grub 2.02 and 2.04, something was added
and it refuses to build without it.
Change-Id: Ia8fca13fe58be55aa4569ff58bbfd76ab7a67cdd
Signed-off-by: Pablo <42.pablo.ms(a)gmail.com>
---
M payloads/external/GRUB2/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/34105/1
diff --git a/payloads/external/GRUB2/Makefile b/payloads/external/GRUB2/Makefile
index 31c4066..b036aeb 100644
--- a/payloads/external/GRUB2/Makefile
+++ b/payloads/external/GRUB2/Makefile
@@ -28,7 +28,7 @@
echo " CONFIG GRUB2 $(NAME-y)"
rm -rf grub2/build
mkdir grub2/build
- cd grub2 && ./autogen.sh
+ cd grub2 && ./bootstrap && ./autogen.sh
cd grub2/build && ../configure CC="$(HOSTCC)" LD="$(LD)" \
FREETYPE="pkg-config freetype2" BUILD_FREETYPE="pkg-config freetype2" \
TARGET_CC="$(CC)" TARGET_OBJCOPY="$(OBJCOPY)" TARGET_STRIP="$(STRIP)" \
--
To view, visit https://review.coreboot.org/c/coreboot/+/34105
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8fca13fe58be55aa4569ff58bbfd76ab7a67cdd
Gerrit-Change-Number: 34105
Gerrit-PatchSet: 1
Gerrit-Owner: Pablo Moyano <42.pablo.ms(a)gmail.com>
Gerrit-MessageType: newchange