Change in coreboot[master]: Signed-off-by: himanshu sahdev aka CunningLearner <sahdev.himan@gmail...

[HIMANSHU SAHDEV (Code Review)]

HIMANSHU SAHDEV has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34460 )


Change subject: Signed-off-by: himanshu sahdev aka CunningLearner <[e-mail]>
......................................................................

Signed-off-by: himanshu sahdev aka CunningLearner <[e-mail]>

payloads/libpayload: Fix libpayload directory path in sample libpayload Makefile

Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968
---
M payloads/libpayload/sample/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/34460/1

diff --git a/payloads/libpayload/sample/Makefile b/payloads/libpayload/sample/Makefile
index 5931d5e..5b55710 100644
--- a/payloads/libpayload/sample/Makefile
+++ b/payloads/libpayload/sample/Makefile
@@ -37,7 +37,7 @@
 
 CC := $(CC_$(ARCH-y))
 AS := $(AS_$(ARCH-y))
-LIBPAYLOAD_DIR := ../install/libpayload
+LIBPAYLOAD_DIR := ..
 XCC := CC="$(CC)" $(LIBPAYLOAD_DIR)/bin/lpgcc
 XAS := AS="$(AS)" $(LIBPAYLOAD_DIR)/bin/lpas
 CFLAGS := -Wall -Werror -Os

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/34460
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968
Gerrit-Change-Number: 34460
Gerrit-PatchSet: 1
Gerrit-Owner: HIMANSHU SAHDEV <[e-mail]>
Gerrit-MessageType: newchange

[HIMANSHU SAHDEV (Code Review)]

HIMANSHU SAHDEV has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34460 )

Change subject: Signed-off-by: himanshu sahdev aka CunningLearner <[e-mail]>
......................................................................


Patch Set 1:

Hello, I am newbie and this is just my start with coreboot and I wanted to learn a lot with the upcoming feedback. I would be happy to have you as a mentor. Thanks for your time and support.


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/34460
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968
Gerrit-Change-Number: 34460
Gerrit-PatchSet: 1
Gerrit-Owner: HIMANSHU SAHDEV <[e-mail]>
Gerrit-Reviewer: HIMANSHU SAHDEV <[e-mail]>
Gerrit-Reviewer: Julius Werner <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: Raul Rangel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Sat, 20 Jul 2019 14:08:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in coreboot[master]: payloads/libpayload: Fix libpayload directory path in sample libpaylo...

[HIMANSHU SAHDEV (Code Review)]

Hello Julius Werner, build bot (Jenkins), Raul Rangel, Patrick Georgi, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/34460

to look at the new patch set (#2).

Change subject: payloads/libpayload: Fix libpayload directory path in sample libpayload Makefile
......................................................................

payloads/libpayload: Fix libpayload directory path in sample libpayload Makefile

This CL allows building a sample libpayload.

Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968
Signed-off-by: himanshu sahdev aka CunningLearner <[e-mail]>
---
M payloads/libpayload/sample/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/34460/2
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/34460
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968
Gerrit-Change-Number: 34460
Gerrit-PatchSet: 2
Gerrit-Owner: HIMANSHU SAHDEV <[e-mail]>
Gerrit-Reviewer: HIMANSHU SAHDEV <[e-mail]>
Gerrit-Reviewer: Julius Werner <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: Raul Rangel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-MessageType: newpatchset

Change in coreboot[master]: payloads/libpayload: Fix libpayload directory path in sample libpaylo...

[HIMANSHU SAHDEV (Code Review)]

HIMANSHU SAHDEV has removed Raul Rangel from this change.  ( https://review.coreboot.org/c/coreboot/+/34460 )

Change subject: payloads/libpayload: Fix libpayload directory path in sample libpayload Makefile
......................................................................


Removed reviewer Raul Rangel.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/34460
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968
Gerrit-Change-Number: 34460
Gerrit-PatchSet: 2
Gerrit-Owner: HIMANSHU SAHDEV <[e-mail]>
Gerrit-Reviewer: HIMANSHU SAHDEV <[e-mail]>
Gerrit-Reviewer: Julius Werner <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Name of user not set #1002508
Gerrit-CC: PraveenX Hodagatta Pranesh <[e-mail]>
Gerrit-MessageType: deleteReviewer

Change in coreboot[master]: payloads/libpayload: Fix libpayload directory path in sample libpaylo...

[HIMANSHU SAHDEV (Code Review)]

HIMANSHU SAHDEV has removed Julius Werner from this change.  ( https://review.coreboot.org/c/coreboot/+/34460 )

Change subject: payloads/libpayload: Fix libpayload directory path in sample libpayload Makefile
......................................................................


Removed reviewer Julius Werner.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/34460
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968
Gerrit-Change-Number: 34460
Gerrit-PatchSet: 2
Gerrit-Owner: HIMANSHU SAHDEV <[e-mail]>
Gerrit-Reviewer: HIMANSHU SAHDEV <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Name of user not set #1002508
Gerrit-CC: PraveenX Hodagatta Pranesh <[e-mail]>
Gerrit-MessageType: deleteReviewer

Change in coreboot[master]: payloads/libpayload: Fix libpayload directory path in sample libpaylo...

[HIMANSHU SAHDEV (Code Review)]

HIMANSHU SAHDEV has removed Name of user not set #1002508 from this change.  ( https://review.coreboot.org/c/coreboot/+/34460 )

Change subject: payloads/libpayload: Fix libpayload directory path in sample libpayload Makefile
......................................................................


Removed reviewer null.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/34460
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968
Gerrit-Change-Number: 34460
Gerrit-PatchSet: 2
Gerrit-Owner: HIMANSHU SAHDEV <[e-mail]>
Gerrit-Reviewer: HIMANSHU SAHDEV <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: PraveenX Hodagatta Pranesh <[e-mail]>
Gerrit-MessageType: deleteReviewer

Change in coreboot[master]: payloads/libpayload: Fix libpayload directory path in sample libpaylo...

[HIMANSHU SAHDEV (Code Review)]

HIMANSHU SAHDEV has removed PraveenX Hodagatta Pranesh from this change.  ( https://review.coreboot.org/c/coreboot/+/34460 )

Change subject: payloads/libpayload: Fix libpayload directory path in sample libpayload Makefile
......................................................................


Removed reviewer PraveenX Hodagatta Pranesh.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/34460
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968
Gerrit-Change-Number: 34460
Gerrit-PatchSet: 2
Gerrit-Owner: HIMANSHU SAHDEV <[e-mail]>
Gerrit-Reviewer: HIMANSHU SAHDEV <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-MessageType: deleteReviewer

Change in coreboot[master]: payloads/libpayload: Fix libpayload directory path in sample libpaylo...

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34460 )

Change subject: payloads/libpayload: Fix libpayload directory path in sample libpayload Makefile
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/34460/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34460/2//COMMIT_MSG@7 
PS2, Line 7: payloads/libpayload
libpayload is enough as prefix.


https://review.coreboot.org/c/coreboot/+/34460/2//COMMIT_MSG@9 
PS2, Line 9: This CL allows building a sample libpayload.
What error do you get?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/34460
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968
Gerrit-Change-Number: 34460
Gerrit-PatchSet: 2
Gerrit-Owner: HIMANSHU SAHDEV <[e-mail]>
Gerrit-Reviewer: HIMANSHU SAHDEV <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Tue, 30 Jul 2019 16:06:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in coreboot[master]: payloads/libpayload: Fix libpayload directory path in sample libpaylo...

[HIMANSHU SAHDEV (Code Review)]

HIMANSHU SAHDEV has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34460 )

Change subject: payloads/libpayload: Fix libpayload directory path in sample libpayload Makefile
......................................................................


Patch Set 2:

(1 comment)

The path provided for lpgcc and lpas is wrong according to the current directory structure.

https://review.coreboot.org/c/coreboot/+/34460/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34460/2//COMMIT_MSG@9 
PS2, Line 9: This CL allows building a sample libpayload.
> What error do you get?
> /bin/sh: 1: ../install/libpayload/bin/lpgcc: not found
> Makefile:54: recipe for target 'hello.o' failed

Change in coreboot[master]: payloads/libpayload: Fix libpayload directory path in sample libpaylo...

[HIMANSHU SAHDEV (Code Review)]

HIMANSHU SAHDEV has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34460 )

Change subject: payloads/libpayload: Fix libpayload directory path in sample libpayload Makefile
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34460/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34460/2//COMMIT_MSG@7 
PS2, Line 7: payloads/libpayload
> libpayload is enough as prefix.
> Done

Change in coreboot[master]: libpayload: Fix libpayload directory path in sample libpayload Makefile

[HIMANSHU SAHDEV (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/34460

to look at the new patch set (#3).

Change subject: libpayload: Fix libpayload directory path in sample libpayload Makefile
......................................................................

libpayload: Fix libpayload directory path in sample libpayload Makefile

This CL allows building a sample libpayload.

Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968
Signed-off-by: Himanshu Sahdev aka CunningLearner <[e-mail]>
---
M payloads/libpayload/sample/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/34460/3
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/34460
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968
Gerrit-Change-Number: 34460
Gerrit-PatchSet: 3
Gerrit-Owner: HIMANSHU SAHDEV <[e-mail]>
Gerrit-Reviewer: HIMANSHU SAHDEV <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: newpatchset

Change in coreboot[master]: libpayload: Fix libpayload directory path in sample libpayload Makefile

[HIMANSHU SAHDEV (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/34460

to look at the new patch set (#5).

Change subject: libpayload: Fix libpayload directory path in sample libpayload Makefile
......................................................................

libpayload: Fix libpayload directory path in sample libpayload Makefile

This CL allows building a sample libpayload.

Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968
Signed-off-by: Himanshu Sahdev aka CunningLearner <[e-mail]>
---
M payloads/libpayload/sample/Makefile
1 file changed, 8 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/34460/5
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/34460
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968
Gerrit-Change-Number: 34460
Gerrit-PatchSet: 5
Gerrit-Owner: HIMANSHU SAHDEV <[e-mail]>
Gerrit-Reviewer: HIMANSHU SAHDEV <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: newpatchset

Change in coreboot[master]: libpayload: Fix libpayload directory path in sample libpayload Makefile

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34460 )

Change subject: libpayload: Fix libpayload directory path in sample libpayload Makefile
......................................................................


Patch Set 5: Code-Review+1


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/34460
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968
Gerrit-Change-Number: 34460
Gerrit-PatchSet: 5
Gerrit-Owner: HIMANSHU SAHDEV <[e-mail]>
Gerrit-Reviewer: HIMANSHU SAHDEV <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Wed, 31 Jul 2019 11:47:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in coreboot[master]: libpayload: Fix libpayload directory path in sample libpayload Makefile

[HIMANSHU SAHDEV (Code Review)]

Hello HAOUAS Elyes, Angel Pons, Paul Menzel, build bot (Jenkins), Martin Roth, Patrick Georgi, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/34460

to look at the new patch set (#7).

Change subject: libpayload: Fix libpayload directory path in sample libpayload Makefile
......................................................................

libpayload: Fix libpayload directory path in sample libpayload Makefile

This CL allows building a sample libpayload.
As a normal user if run make and not make install under libpayload gives
error when trying to build the sample libpayload.

Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968
Signed-off-by: Himanshu Sahdev aka CunningLearner <[e-mail]>
---
M payloads/libpayload/sample/Makefile
1 file changed, 8 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/34460/7
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/34460
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968
Gerrit-Change-Number: 34460
Gerrit-PatchSet: 7
Gerrit-Owner: HIMANSHU SAHDEV <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: HAOUAS Elyes <[e-mail]>
Gerrit-Reviewer: HIMANSHU SAHDEV <[e-mail]>
Gerrit-Reviewer: Martin Roth <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Nico Huber <[e-mail]>
Gerrit-MessageType: newpatchset

Change in coreboot[master]: libpayload: Fix libpayload directory path in sample libpayload Makefile

[Name of user not set (Code Review)]

Name of user not set #1002532 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34460 )

Change subject: libpayload: Fix libpayload directory path in sample libpayload Makefile
......................................................................


Patch Set 7: Code-Review+1

Yes, I am able to replicate the same.


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/34460
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968
Gerrit-Change-Number: 34460
Gerrit-PatchSet: 7
Gerrit-Owner: HIMANSHU SAHDEV <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: HAOUAS Elyes <[e-mail]>
Gerrit-Reviewer: HIMANSHU SAHDEV <[e-mail]>
Gerrit-Reviewer: Martin Roth <[e-mail]>
Gerrit-Reviewer: Name of user not set #1002532
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Nico Huber <[e-mail]>
Gerrit-Comment-Date: Mon, 12 Aug 2019 10:26:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[XS] Change in coreboot[master]: libpayload: Fix libpayload directory path in sample libpayload Makefile

[Martin L Roth (Code Review)]

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34460?usp=email )

Change subject: libpayload: Fix libpayload directory path in sample libpayload Makefile
......................................................................


Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/34460?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85ebfe14ee7f7f22462b79984a85f525f4276968
Gerrit-Change-Number: 34460
Gerrit-PatchSet: 7
Gerrit-Owner: Himanshu Sahdev <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Himanshu Sahdev <[e-mail]>
Gerrit-Reviewer: Julius Werner <[e-mail]>
Gerrit-Reviewer: Martin L Roth <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: Sourabh Kashyap
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-MessageType: abandon