mturney mturney has uploaded a new patch set (#35) to the change originally created by mturney mturney. ( https://review.coreboot.org/c/coreboot/+/29104 )
Change subject: sdm845: Port I2C driver
......................................................................
sdm845: Port I2C driver
Add I2C functionality in coreboot
Change-Id: Ifb76564d8a11427423dd14d8ba7c8c7d500ef346
Signed-off-by: Akash Asthana <akashast(a)codeaurora.org>
---
M src/mainboard/google/cheza/mainboard.c
M src/soc/qualcomm/sdm845/Makefile.inc
A src/soc/qualcomm/sdm845/i2c.c
A src/soc/qualcomm/sdm845/include/soc/i2c.h
M src/soc/qualcomm/sdm845/include/soc/qupv3_fw_config.h
M src/soc/qualcomm/sdm845/qupv3_fw_config.c
M src/soc/qualcomm/sdm845/spi_qup.c
7 files changed, 202 insertions(+), 25 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/29104/35
--
To view, visit https://review.coreboot.org/c/coreboot/+/29104
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb76564d8a11427423dd14d8ba7c8c7d500ef346
Gerrit-Change-Number: 29104
Gerrit-PatchSet: 35
Gerrit-Owner: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Reviewer: Akash Asthana <akashast(a)qualcomm.corp-partner.google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
mturney mturney has uploaded a new patch set (#55) to the change originally created by mturney mturney. ( https://review.coreboot.org/c/coreboot/+/27483 )
Change subject: sdm845: Add SPI QUP driver
......................................................................
sdm845: Add SPI QUP driver
This implements the SPI driver for the Qualcomm Universal Peripheral
(QUP) core.
Change-Id: I35061727d5ccc550eaeb06caef4524bc4cf25b54
Signed-off-by: Mukesh Savaliya <msavaliy(a)codeaurora.org>
Signed-off-by: Akash Asthana <akashast(a)codeaurora.org>
---
M src/mainboard/google/cheza/bootblock.c
M src/soc/qualcomm/sdm845/Makefile.inc
M src/soc/qualcomm/sdm845/bootblock.c
M src/soc/qualcomm/sdm845/include/soc/addressmap.h
A src/soc/qualcomm/sdm845/include/soc/qcom_qup_se.h
A src/soc/qualcomm/sdm845/include/soc/spi_qup_qcom.h
A src/soc/qualcomm/sdm845/qcom_qup_se.c
M src/soc/qualcomm/sdm845/spi.c
A src/soc/qualcomm/sdm845/spi_qup.c
9 files changed, 983 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/27483/55
--
To view, visit https://review.coreboot.org/c/coreboot/+/27483
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35061727d5ccc550eaeb06caef4524bc4cf25b54
Gerrit-Change-Number: 27483
Gerrit-PatchSet: 55
Gerrit-Owner: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Mukesh Savaliya <msavaliy(a)qualcomm.corp-partner.google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Vin Kamath <vink(a)codeaurora.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Akash Asthana <akashast(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset
Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33440 )
Change subject: superio/nuvoton/nct6776: Make Kconfig symbol dependent
......................................................................
superio/nuvoton/nct6776: Make Kconfig symbol dependent
The SUPERIO_NUVOTON_NCT6776_COM_A symbol should only be visible if
SUPERIO_NUVOTON_NCT6776 is selected as well.
Change-Id: I9c52d596080360bf3fc25265749ced66ec44f5dc
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33440
Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/superio/nuvoton/nct6776/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
build bot (Jenkins): Verified
Felix Held: Looks good to me, approved
diff --git a/src/superio/nuvoton/nct6776/Kconfig b/src/superio/nuvoton/nct6776/Kconfig
index 90d4d32..441692b 100644
--- a/src/superio/nuvoton/nct6776/Kconfig
+++ b/src/superio/nuvoton/nct6776/Kconfig
@@ -20,4 +20,5 @@
config SUPERIO_NUVOTON_NCT6776_COM_A
bool
+ depends on SUPERIO_NUVOTON_NCT6776
default n
--
To view, visit https://review.coreboot.org/c/coreboot/+/33440
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c52d596080360bf3fc25265749ced66ec44f5dc
Gerrit-Change-Number: 33440
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33440 )
Change subject: superio/nuvoton/nct6776: Make Kconfig symbol dependent
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/33440
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c52d596080360bf3fc25265749ced66ec44f5dc
Gerrit-Change-Number: 33440
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 21 Jun 2019 17:09:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33439 )
Change subject: mb/asrock/h110m: Correct Kconfig symbol selection
......................................................................
mb/asrock/h110m: Correct Kconfig symbol selection
The asrock/h110m has a NCT6791D, but is selecting the NCT6776-specific
SUPERIO_NUVOTON_NCT6776_COM_A symbol. Use the NCT6791D symbol instead.
Change-Id: I9f3fde161844f919b070f2b6ce7e106411439a9a
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33439
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Maxim Polyakov <m.poliakov(a)yahoo.com>
Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de>
---
M src/mainboard/asrock/h110m/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Felix Held: Looks good to me, approved
Maxim Polyakov: Looks good to me, but someone else must approve
diff --git a/src/mainboard/asrock/h110m/Kconfig b/src/mainboard/asrock/h110m/Kconfig
index 487c90e..eebce57 100644
--- a/src/mainboard/asrock/h110m/Kconfig
+++ b/src/mainboard/asrock/h110m/Kconfig
@@ -13,7 +13,7 @@
select SKYLAKE_SOC_PCH_H
select GENERIC_SPD_BIN
select SUPERIO_NUVOTON_NCT6791D
- select SUPERIO_NUVOTON_NCT6776_COM_A
+ select SUPERIO_NUVOTON_NCT6791D_COM_A
select REALTEK_8168_RESET
select RT8168_SET_LED_MODE
--
To view, visit https://review.coreboot.org/c/coreboot/+/33439
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f3fde161844f919b070f2b6ce7e106411439a9a
Gerrit-Change-Number: 33439
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Maxim Polyakov <m.poliakov(a)yahoo.com>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33640 )
Change subject: superio/nuvoton/nct6791d: Add symbol to select COM port
......................................................................
superio/nuvoton/nct6791d: Add symbol to select COM port
Like the NCT6776, the NCT6791D has muxed COMA/GPIO8 functions. Since it
requires setting different bits, add a new Kconfig symbol to do it.
Change-Id: I62dc18810026f9b1550da19950f66af605600ec8
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33640
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Maxim Polyakov <m.poliakov(a)yahoo.com>
Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de>
---
M src/superio/nuvoton/common/early_serial.c
M src/superio/nuvoton/nct6791d/Kconfig
2 files changed, 11 insertions(+), 0 deletions(-)
Approvals:
build bot (Jenkins): Verified
Felix Held: Looks good to me, approved
Maxim Polyakov: Looks good to me, but someone else must approve
diff --git a/src/superio/nuvoton/common/early_serial.c b/src/superio/nuvoton/common/early_serial.c
index b35ec9d..7f22993 100644
--- a/src/superio/nuvoton/common/early_serial.c
+++ b/src/superio/nuvoton/common/early_serial.c
@@ -64,9 +64,15 @@
void nuvoton_enable_serial(pnp_devfn_t dev, u16 iobase)
{
nuvoton_pnp_enter_conf_state(dev);
+
if (CONFIG(SUPERIO_NUVOTON_NCT6776_COM_A))
/* Route GPIO8 pin group to COM A */
pnp_write_config(dev, 0x2a, 0x40);
+
+ if (CONFIG(SUPERIO_NUVOTON_NCT6791D_COM_A))
+ /* Route GPIO8 pin group to COM A */
+ pnp_write_config(dev, 0x2a, 0x00);
+
pnp_set_logical_device(dev);
pnp_set_enable(dev, 0);
pnp_set_iobase(dev, PNP_IDX_IO0, iobase);
diff --git a/src/superio/nuvoton/nct6791d/Kconfig b/src/superio/nuvoton/nct6791d/Kconfig
index 6e39e46..55581fb 100644
--- a/src/superio/nuvoton/nct6791d/Kconfig
+++ b/src/superio/nuvoton/nct6791d/Kconfig
@@ -16,3 +16,8 @@
config SUPERIO_NUVOTON_NCT6791D
bool
select SUPERIO_NUVOTON_COMMON_PRE_RAM
+
+config SUPERIO_NUVOTON_NCT6791D_COM_A
+ bool
+ depends on SUPERIO_NUVOTON_NCT6791D
+ default n
--
To view, visit https://review.coreboot.org/c/coreboot/+/33640
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62dc18810026f9b1550da19950f66af605600ec8
Gerrit-Change-Number: 33640
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Maxim Polyakov <m.poliakov(a)yahoo.com>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33640 )
Change subject: superio/nuvoton/nct6791d: Add symbol to select COM port
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/33640
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62dc18810026f9b1550da19950f66af605600ec8
Gerrit-Change-Number: 33640
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Maxim Polyakov <m.poliakov(a)yahoo.com>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 21 Jun 2019 17:08:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment