Patrick Rudolph has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32374 )
Change subject: intel: Add functions to retrieve top of usable DRAM
......................................................................
Abandoned
not needed any more
--
To view, visit https://review.coreboot.org/c/coreboot/+/32374
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ae1f3540d13076469f73188351ae9f9d4b1c63b
Gerrit-Change-Number: 32374
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: abandon
Paul Menzel has uploaded a new patch set (#24) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/29667 )
Change subject: mb/emulation/qemu-q35: Add x86_64 support
......................................................................
mb/emulation/qemu-q35: Add x86_64 support
* Enable optional x86_64 romstage, postcar and ramstage
* Add Kconfig for x86_64 compilation
* Add documentation for x86 qemu mainboards
* Increase CAR stack as x86_64 uses more than 0x4000 bytes
* Always setup MTRRs even though qemu doesn't care about them
Working:
* Boots to Linux
* Boots to SeaBios
* Drops to protected mode at end of ramstage
* Enumerates PCI devices
* Relocateable ramstage
Broken:
* Entering SMM due to missing long mode setup
Signed-off-by: Patrick Rudolph <siro(a)das-labor.org>
Change-Id: If2f02a95b2f91ab51043d4e81054354f4a6eb5d5
---
M Documentation/arch/x86/index.md
A Documentation/mainboard/emulation/qemu-i440fx.md
A Documentation/mainboard/emulation/qemu-q35.md
M Documentation/mainboard/index.md
M src/arch/x86/Kconfig
M src/cpu/qemu-x86/Kconfig
M src/cpu/qemu-x86/Makefile.inc
M src/mainboard/emulation/qemu-i440fx/Kconfig
M src/mainboard/emulation/qemu-i440fx/romstage.c
M src/mainboard/emulation/qemu-q35/Kconfig
M src/mainboard/emulation/qemu-q35/romstage.c
11 files changed, 266 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/29667/24
--
To view, visit https://review.coreboot.org/c/coreboot/+/29667
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If2f02a95b2f91ab51043d4e81054354f4a6eb5d5
Gerrit-Change-Number: 29667
Gerrit-PatchSet: 24
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
Paul Menzel has uploaded a new patch set (#15) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/30118 )
Change subject: arch/x86/boot: Call payload in protected mode
......................................................................
arch/x86/boot: Call payload in protected mode
On ARCH_RAMSTAGE_X86_64 call the payload in protected mode.
Add a helper function to call arbitraty code in protected mode,
similar to the real mode call handler.
Tested on qemu using SeaBios as payload.
Untested for anything else.
Doesn't affect existing x86_32 code.
Change-Id: I6552ac30f1b6205e08e16d251328e01ce3fbfd14
Signed-off-by: Patrick Rudolph <siro(a)das-labor.org>
---
M Documentation/arch/x86/index.md
M src/arch/x86/boot.c
M src/arch/x86/c_start.S
M src/include/program_loading.h
4 files changed, 196 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/30118/15
--
To view, visit https://review.coreboot.org/c/coreboot/+/30118
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6552ac30f1b6205e08e16d251328e01ce3fbfd14
Gerrit-Change-Number: 30118
Gerrit-PatchSet: 15
Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
Paul Menzel has uploaded a new patch set (#13) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/30114 )
Change subject: arch/x86/assembly_entry: Enable long mode in romstage
......................................................................
arch/x86/assembly_entry: Enable long mode in romstage
* Install simple page tables for long mode
* Activate long mode
* Add new Kconfig for CPUs that have 1 GiB hugepage support
* Use a minimum of two pagetables if possible
* Autodetect 1 GiB hugepage support if not known at compile time
The same approach was done on AMD based platforms.
The main reason to have a 64bit romstage, is to support rmodules.
The existing code assumes that both stages (the loader and the one
that is being relocated) have the same architecture.
Tested on qemu using KVM.
Doesn't affect existing x86_32 code.
Change-Id: I57974a55f3b778c90b3587f39e86e4eb8692ad48
Signed-off-by: Patrick Rudolph <siro(a)das-labor.org>
---
M Documentation/arch/x86/index.md
M src/arch/x86/Kconfig
M src/arch/x86/assembly_entry.S
M src/cpu/Kconfig
M src/cpu/intel/fsp_model_406dx/Kconfig
M src/cpu/intel/haswell/Kconfig
M src/cpu/intel/model_2065x/Kconfig
M src/cpu/intel/model_206ax/Kconfig
M src/soc/intel/apollolake/Kconfig
M src/soc/intel/baytrail/Kconfig
M src/soc/intel/braswell/Kconfig
M src/soc/intel/broadwell/Kconfig
M src/soc/intel/cannonlake/Kconfig
M src/soc/intel/fsp_baytrail/Kconfig
M src/soc/intel/fsp_broadwell_de/Kconfig
M src/soc/intel/icelake/Kconfig
M src/soc/intel/skylake/Kconfig
17 files changed, 171 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/30114/13
--
To view, visit https://review.coreboot.org/c/coreboot/+/30114
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I57974a55f3b778c90b3587f39e86e4eb8692ad48
Gerrit-Change-Number: 30114
Gerrit-PatchSet: 13
Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: York Yang <yyang024(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-CC: Lijian Zhao <lijian.zhao(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
Paul Menzel has uploaded a new patch set (#15) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/30117 )
Change subject: arch/x86: Support x86_64 exceptions
......................................................................
arch/x86: Support x86_64 exceptions
Tested on qemu using division by zero.
Doesn't affect existing x86_32 code.
Signed-off-by: Patrick Rudolph <siro(a)das-labor.org>
Change-Id: Idd12c90a95cc2989eb9b2a718740a84222193f48
---
M Documentation/arch/x86/index.md
M src/arch/x86/exception.c
M src/arch/x86/idt.S
M src/arch/x86/include/arch/registers.h
4 files changed, 116 insertions(+), 27 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/30117/15
--
To view, visit https://review.coreboot.org/c/coreboot/+/30117
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd12c90a95cc2989eb9b2a718740a84222193f48
Gerrit-Change-Number: 30117
Gerrit-PatchSet: 15
Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
Paul Menzel has uploaded a new patch set (#11) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/30500 )
Change subject: [WIP]arch/x86/postcar: Add x86_64 support
......................................................................
[WIP]arch/x86/postcar: Add x86_64 support
* Add support for loading GDT on x86_64.
* Add x86_64 assembly code to do the same as the x86_32 code.
* Seperate x86_32 and x86_64 code.
Tested on qemu x86_32 and x86_64 using additional MTRRs.
Needs test on real hardware.
Change-Id: I1c190627f5f0ed6f82738cb99423892382899d7b
Signed-off-by: Patrick Rudolph <siro(a)das-labor.org>
---
M src/arch/x86/Makefile.inc
R src/arch/x86/exit_car_x86_32.S
A src/arch/x86/exit_car_x86_64.S
M src/arch/x86/gdt_init.S
4 files changed, 157 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/30500/11
--
To view, visit https://review.coreboot.org/c/coreboot/+/30500
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c190627f5f0ed6f82738cb99423892382899d7b
Gerrit-Change-Number: 30500
Gerrit-PatchSet: 11
Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
Paul Menzel has uploaded a new patch set (#5) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/32374 )
Change subject: intel: Add functions to retrieve top of usable DRAM
......................................................................
intel: Add functions to retrieve top of usable DRAM
Implement the following functions on all Intel platforms:
* sa_get_touud_base
Returns the memory address of usable DRAM beyond 4GiB or zero if not
available.
* sa_get_tolud_base
Returns the memory address of usable DRAM below 4GiB
Allows to use both functions in common code. It could be used to:
* clear DRAM as part of TEE
* set up page tables for x86_64
Change-Id: I9ae1f3540d13076469f73188351ae9f9d4b1c63b
Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com>
---
M src/mainboard/emulation/qemu-i440fx/Makefile.inc
M src/mainboard/emulation/qemu-i440fx/fw_cfg.c
M src/mainboard/emulation/qemu-i440fx/fw_cfg.h
A src/mainboard/emulation/qemu-i440fx/systemagent_early.c
M src/mainboard/emulation/qemu-q35/Makefile.inc
M src/northbridge/intel/e7505/Makefile.inc
A src/northbridge/intel/e7505/systemagent_early.c
M src/northbridge/intel/fsp_rangeley/Makefile.inc
A src/northbridge/intel/fsp_rangeley/systemagent_early.c
M src/northbridge/intel/gm45/Makefile.inc
A src/northbridge/intel/gm45/systemagent_early.c
M src/northbridge/intel/haswell/Makefile.inc
A src/northbridge/intel/haswell/systemagent_early.c
M src/northbridge/intel/i440bx/Makefile.inc
A src/northbridge/intel/i440bx/systemagent_early.c
M src/northbridge/intel/i945/Makefile.inc
A src/northbridge/intel/i945/systemagent_early.c
M src/northbridge/intel/nehalem/Makefile.inc
A src/northbridge/intel/nehalem/systemagent_early.c
M src/northbridge/intel/pineview/Makefile.inc
A src/northbridge/intel/pineview/systemagent_early.c
M src/northbridge/intel/sandybridge/Makefile.inc
A src/northbridge/intel/sandybridge/systemagent_early.c
M src/northbridge/intel/x4x/Makefile.inc
A src/northbridge/intel/x4x/systemagent_early.c
M src/soc/intel/baytrail/romstage/Makefile.inc
A src/soc/intel/baytrail/romstage/systemagent_early.c
M src/soc/intel/braswell/romstage/Makefile.inc
A src/soc/intel/braswell/romstage/systemagent_early.c
M src/soc/intel/broadwell/include/soc/systemagent.h
M src/soc/intel/broadwell/romstage/Makefile.inc
R src/soc/intel/broadwell/romstage/systemagent_early.c
M src/soc/intel/common/block/include/intelblocks/systemagent.h
A src/soc/intel/common/block/include/intelblocks/systemagent_memrange.h
M src/soc/intel/common/block/systemagent/systemagent_early.c
M src/soc/intel/fsp_baytrail/romstage/Makefile.inc
A src/soc/intel/fsp_baytrail/romstage/systemagent_early.c
M src/soc/intel/fsp_broadwell_de/include/soc/broadwell_de.h
M src/soc/intel/fsp_broadwell_de/romstage/Makefile.inc
A src/soc/intel/fsp_broadwell_de/romstage/systemagent_early.c
M src/soc/intel/quark/romstage/Makefile.inc
A src/soc/intel/quark/romstage/systemagent_early.c
42 files changed, 611 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/32374/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/32374
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ae1f3540d13076469f73188351ae9f9d4b1c63b
Gerrit-Change-Number: 32374
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com>
Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: newpatchset
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32823 )
Change subject: src/ec: Use 'include <stdlib.h>' when appropriate
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/32823
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifdb2dee08da45d698174583ee5ed44bf5a0243ff
Gerrit-Change-Number: 32823
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sat, 22 Jun 2019 17:54:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment