coreboot-gerrit May 2019

coreboot-gerrit@coreboot.org

1 participants
1485 discussions

Change in ...coreboot[master]: ec/lenovo/h8: Add function to query sense state
by Alexander Couzens (Code Review) 05 May '19

05 May '19

Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29204 ) Change subject: ec/lenovo/h8: Add function to query sense state ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/29204/2/src/ec/lenovo/h8/sense.c File src/ec/lenovo/h8/sense.c: https://review.coreboot.org/#/c/29204/2/src/ec/lenovo/h8/sense.c@25 PS2, Line 25: * Unlikely that all register will be zero after booting has : * finished. > What is "booting has finished" here? coreboot ready to jump to the […] So far I understood, the EC reboots when powering the laptop on. -- To view, visit https://review.coreboot.org/c/coreboot/+/29204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie27e2881a256c4efb3def11f05070c446db6e5fc Gerrit-Change-Number: 29204 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sun, 05 May 2019 15:00:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: sb/intel/common/smihandler: Hook up smmstore
by Patrick Rudolph (Code Review) 05 May '19

05 May '19

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30012 ) Change subject: sb/intel/common/smihandler: Hook up smmstore ...................................................................... Patch Set 14: (1 comment) https://review.coreboot.org/#/c/30012/14/src/southbridge/intel/common/smiha… File src/southbridge/intel/common/smihandler.c: https://review.coreboot.org/#/c/30012/14/src/southbridge/intel/common/smiha… PS14, Line 346: if (IS_ENABLED(CONFIG_SMMSTORE)) CONFIG( -- To view, visit https://review.coreboot.org/c/coreboot/+/30012 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20b87f3dcb898656ad31478820dd5153e4053cb2 Gerrit-Change-Number: 30012 Gerrit-PatchSet: 14 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matthew Garrett <mjg59(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Comment-Date: Sun, 05 May 2019 14:41:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: inteltool: Skylake GPIOs #2
by Felix Singer (Code Review) 05 May '19

05 May '19

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31660 Change subject: inteltool: Skylake GPIOs #2 ...................................................................... inteltool: Skylake GPIOs #2 Used Intel documents: - 332995-001EN - 332996-002EN Change-Id: Ic006d9c094f9fe1ad419cb0168ada45b7dd81732 Signed-off-by: Felix Singer <migy(a)darmstadt.ccc.de> --- M util/inteltool/gpio.c M util/inteltool/gpio_groups.c 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/31660/1 diff --git a/util/inteltool/gpio.c b/util/inteltool/gpio.c index a87ae35..52eae09 100644 --- a/util/inteltool/gpio.c +++ b/util/inteltool/gpio.c @@ -1027,6 +1027,9 @@ case PCI_DEVICE_ID_INTEL_B150: case PCI_DEVICE_ID_INTEL_CM236: case PCI_DEVICE_ID_INTEL_DNV_LPC: + case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_BASE_1: + case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_PREM_1: + case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_Y_PREM_1: case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_BASE_2: case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_PREM_2: case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_Y_PREM_2: diff --git a/util/inteltool/gpio_groups.c b/util/inteltool/gpio_groups.c index d61438b..5abb570 100644 --- a/util/inteltool/gpio_groups.c +++ b/util/inteltool/gpio_groups.c @@ -908,6 +908,9 @@ communities = sunrise_communities; pcr_init(sb); break; + case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_BASE_1: + case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_PREM_1: + case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_Y_PREM_1: case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_BASE_2: case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_PREM_2: case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_Y_PREM_2: -- To view, visit https://review.coreboot.org/c/coreboot/+/31660 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic006d9c094f9fe1ad419cb0168ada45b7dd81732 Gerrit-Change-Number: 31660 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <migy(a)darmstadt.ccc.de> Gerrit-MessageType: newchange

2 3

Change in ...coreboot[master]: sb/intel/bd82x6x: re-init SPI after lockdown if flashconsole is enabled
by Evgeny Zinoviev (Code Review) 05 May '19

05 May '19

Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25660 ) Change subject: sb/intel/bd82x6x: re-init SPI after lockdown if flashconsole is enabled ...................................................................... Patch Set 4: Are the comments for this patch going to be addressed? As an alternative, if the author don't mind, I'll push the updates to the patch. -- To view, visit https://review.coreboot.org/c/coreboot/+/25660 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib802d7ee32f1fb0a68a84b0280480dcaefa9831f Gerrit-Change-Number: 25660 Gerrit-PatchSet: 4 Gerrit-Owner: Dan Elkouby <streetwalkermc(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Dan Elkouby <streetwalkermc(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Comment-Date: Sun, 05 May 2019 13:03:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: ec/lenovo/h8: Add function to query sense state
by Patrick Rudolph (Code Review) 05 May '19

05 May '19

Patrick Rudolph has uploaded a new patch set (#3) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/29204 ) Change subject: ec/lenovo/h8: Add function to query sense state ...................................................................... ec/lenovo/h8: Add function to query sense state * Add function to wait for sense registers to become valid. * Add function to retrieve Fn-Key state. Tested on Lenovo T500: * It takes about 700msec for the registers to become valid. Tested on Lenovo T520: * It takes less than 150msec for the registers to become valid. Change-Id: Ie27e2881a256c4efb3def11f05070c446db6e5fc Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/ec/lenovo/h8/Makefile.inc M src/ec/lenovo/h8/h8.c M src/ec/lenovo/h8/h8.h A src/ec/lenovo/h8/sense.c 4 files changed, 66 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/29204/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/29204 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie27e2881a256c4efb3def11f05070c446db6e5fc Gerrit-Change-Number: 29204 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: mb/msi/ms7707: Remove MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID}
by HAOUAS Elyes (Code Review) 05 May '19

05 May '19

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32605 Change subject: mb/msi/ms7707: Remove MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID} ...................................................................... mb/msi/ms7707: Remove MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID} References to MAINBOARD_PCI_SUBSYSTEM_{DEVICE_ID,VENDOR_ID} were removed. Change-Id: I70ef22aac165a19663749f76449907482b761316 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/msi/ms7707/Kconfig 1 file changed, 0 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/32605/1 diff --git a/src/mainboard/msi/ms7707/Kconfig b/src/mainboard/msi/ms7707/Kconfig index 45ff73e..4923bbf 100644 --- a/src/mainboard/msi/ms7707/Kconfig +++ b/src/mainboard/msi/ms7707/Kconfig @@ -22,14 +22,6 @@ string default "MS-7707" -config MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID - hex - default 0x7707 - -config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID - hex - default 0x1462 - config DRAM_RESET_GATE_GPIO int default 60 -- To view, visit https://review.coreboot.org/c/coreboot/+/32605 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70ef22aac165a19663749f76449907482b761316 Gerrit-Change-Number: 32605 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

4 4

Change in ...coreboot[master]: soc/intel/common/block/cpu: Use core apic id to get cpu_index()
by Subrata Banik (Code Review) 05 May '19

05 May '19

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/26346 ) Change subject: soc/intel/common/block/cpu: Use core apic id to get cpu_index() ...................................................................... Patch Set 10: > > Patch Set 10: > > > > (1 comment) > > > > > Why is it needed? As far as I understand FSP 2.1, that > introduced > > > MP_SERVICES_PPI, also introduced shared stack when selecting > > > FSP_USES_CB_STACK. > > > Simply select FSP_USES_CB_STACK when using MP_SERVICES_PPI > should > > > fix the issue. > > > > The reason is that, on FSP2.0 platform also we might need to > enable MP PPI feature but same stack sharing concept might not > applied on FSP 2.0 enabled platform, hence we are looking for some > solution to bypass stack dependencies. > > Reading the commit message of https://review.coreboot.org/c/coreboot/+/30310 > it sounds like MP PPI feature is only available on FSP2.1. Is it > available on all FSP2.0 platforms as well? yes Patrick, we are getting push to enable this feature on few latest FSP 2.0 platform like WHL and CML as well. -- To view, visit https://review.coreboot.org/c/coreboot/+/26346 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I55023a3e0cf42f0496d45bc6af8ead447f402350 Gerrit-Change-Number: 26346 Gerrit-PatchSet: 10 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Comment-Date: Sun, 05 May 2019 03:13:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/bsw: Move memory init values into `romstage.h`
by Matt DeVillier (Code Review) 05 May '19

05 May '19

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32592 ) Change subject: soc/intel/bsw: Move memory init values into `romstage.h` ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/32592 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ied30927d68927b86758a84ccf3f5fbd8cce632f1 Gerrit-Change-Number: 32592 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 04 May 2019 22:14:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/intel/saddlebrook: Refactor to get rid of `pei_data`
by Matt DeVillier (Code Review) 05 May '19

05 May '19

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32591 ) Change subject: mb/intel/saddlebrook: Refactor to get rid of `pei_data` ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/32591 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I399dd89f85ccea43fdf90bd895e71324f4b409cc Gerrit-Change-Number: 32591 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 04 May 2019 22:14:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: src/Kconfig: remove duplicate entry for drivers/fsp1_0/Kconfig
by Matt DeVillier (Code Review) 04 May '19

04 May '19

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32565 Change subject: src/Kconfig: remove duplicate entry for drivers/fsp1_0/Kconfig ...................................................................... src/Kconfig: remove duplicate entry for drivers/fsp1_0/Kconfig The entry for drivers/intel/fsp1_0/Kconfig was added under the chipset menu before addtional FSP versions were added, and the drivers/*/*/Kconfig entry added to support them. This results in the fsp1_0 Kconfig items being duplicated in the Chipset and Generic Drivers menus. Remove the chipset entry since it's no longer needed. Test: select FSP 1.0 mainboard (e.g. intel/minnowmax) in menuconfig, observe FSP 1.0 Kconfig entries listed only under Generic Drivers menu. Signed-off-by: Matt DeVillier <matt.devillier(a)puri.sm> Change-Id: If1e78fb9259b1a46d308db829881eb3b3d17cf40 --- M src/Kconfig 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/32565/1 diff --git a/src/Kconfig b/src/Kconfig index 90c724e..05875b6 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -370,8 +370,6 @@ comment "Embedded Controllers" source "src/ec/acpi/Kconfig" source "src/ec/*/*/Kconfig" -# FIXME move to vendorcode -source "src/drivers/intel/fsp1_0/Kconfig" source "src/southbridge/intel/common/firmware/Kconfig" source "src/vendorcode/*/Kconfig" -- To view, visit https://review.coreboot.org/c/coreboot/+/32565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If1e78fb9259b1a46d308db829881eb3b3d17cf40 Gerrit-Change-Number: 32565 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newchange

3 3

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2019