Change in ...coreboot[master]: ec/lenovo/h8: Add function to query sense state - coreboot-gerrit

5 May 2019


      Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29204 )
Change subject: ec/lenovo/h8: Add function to query sense state
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/29204/2/src/ec/lenovo/h8/sense.c 
File src/ec/lenovo/h8/sense.c:
https://review.coreboot.org/#/c/29204/2/src/ec/lenovo/h8/sense.c@25 
PS2, Line 25:  * Unlikely that all register will be zero after booting has
            :  * finished.
...
What is "booting has finished" here? coreboot ready to jump to the […]
So far I understood, the EC reboots when powering the laptop on.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29204
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie27e2881a256c4efb3def11f05070c446db6e5fc
Gerrit-Change-Number: 29204
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.com
Gerrit-Reviewer: Jonathan Neuschäfer j.neuschaefer@gmx.net
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Sun, 05 May 2019 15:00:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment