coreboot-gerrit May 2019

coreboot-gerrit@coreboot.org

1 participants
1485 discussions

Change in ...coreboot[master]: soc/intel/broadwell: Use C_ENVIRONMENT_BOOTBLOCK
by Arthur Heymans (Code Review) 12 May '19

12 May '19

Hello Patrick Rudolph, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/30383 to look at the new patch set (#43). Change subject: soc/intel/broadwell: Use C_ENVIRONMENT_BOOTBLOCK ...................................................................... soc/intel/broadwell: Use C_ENVIRONMENT_BOOTBLOCK This puts the cache-as-ram init in the bootblock. Before setting up cache as ram the microcode updates are applied. This removes the possibility for a normal/fallback setup although implementing this should be quite easy. Setting up LPC in the bootblock to output console on SuperIOs is not done in this patch, therefore BOOTBLOCK_CONSOLE is not yet selected. Change-Id: I44eb6d380dea5b82e3f009a46381a0f611bb7935 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/intel/broadwell/Kconfig M src/soc/intel/broadwell/Makefile.inc M src/soc/intel/broadwell/bootblock/cpu.c M src/soc/intel/broadwell/bootblock/pch.c M src/soc/intel/broadwell/bootblock/systemagent.c M src/soc/intel/broadwell/romstage/Makefile.inc M src/soc/intel/broadwell/romstage/romstage.c 7 files changed, 26 insertions(+), 78 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/30383/43 -- To view, visit https://review.coreboot.org/c/coreboot/+/30383 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I44eb6d380dea5b82e3f009a46381a0f611bb7935 Gerrit-Change-Number: 30383 Gerrit-PatchSet: 43 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: mb/{lenovo/x201,packardbell/ms2290}: Remove superfluous TS init
by Alexander Couzens (Code Review) 12 May '19

12 May '19

Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32758 ) Change subject: mb/{lenovo/x201,packardbell/ms2290}: Remove superfluous TS init ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/32758 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia2b762667be17aa5b482cd585dd6f6198cf50d9e Gerrit-Change-Number: 32758 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 12 May 2019 13:20:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/broadwell: Move GPIO init to a common place
by Nico Huber (Code Review) 12 May '19

12 May '19

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32759 ) Change subject: soc/intel/broadwell: Move GPIO init to a common place ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/32759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9309d2b842495f6cff33fdab18aa139a82c1959c Gerrit-Change-Number: 32759 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 12 May 2019 13:10:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/broadwell: Move GPIO init to a common place
by Arthur Heymans (Code Review) 12 May '19

12 May '19

Hello Patrick Rudolph, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32759 to look at the new patch set (#3). Change subject: soc/intel/broadwell: Move GPIO init to a common place ...................................................................... soc/intel/broadwell: Move GPIO init to a common place This also links the gpio configuration instead of including it as a header. Change-Id: I9309d2b842495f6cff33fdab18aa139a82c1959c Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/google/auron/Makefile.inc M src/mainboard/google/auron/romstage.c R src/mainboard/google/auron/variants/auron_paine/gpio.c D src/mainboard/google/auron/variants/auron_paine/include/variant/gpio.h M src/mainboard/google/auron/variants/auron_paine/spd/spd.c C src/mainboard/google/auron/variants/auron_yuna/gpio.c M src/mainboard/google/auron/variants/auron_yuna/spd/spd.c R src/mainboard/google/auron/variants/buddy/gpio.c R src/mainboard/google/auron/variants/gandof/gpio.c M src/mainboard/google/auron/variants/gandof/spd/spd.c R src/mainboard/google/auron/variants/lulu/gpio.c M src/mainboard/google/auron/variants/lulu/spd/spd.c R src/mainboard/google/auron/variants/samus/gpio.c M src/mainboard/google/auron/variants/samus/spd/spd.c M src/mainboard/google/jecht/Makefile.inc M src/mainboard/google/jecht/romstage.c R src/mainboard/google/jecht/variants/guado/gpio.c R src/mainboard/google/jecht/variants/jecht/gpio.c R src/mainboard/google/jecht/variants/rikku/gpio.c R src/mainboard/google/jecht/variants/tidus/gpio.c M src/mainboard/intel/wtm2/Makefile.inc R src/mainboard/intel/wtm2/gpio.c M src/mainboard/intel/wtm2/romstage.c M src/mainboard/purism/librem_bdw/Makefile.inc R src/mainboard/purism/librem_bdw/gpio.c M src/mainboard/purism/librem_bdw/romstage.c M src/soc/intel/broadwell/include/soc/gpio.h M src/soc/intel/broadwell/romstage/romstage.c 28 files changed, 25 insertions(+), 216 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/32759/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/32759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9309d2b842495f6cff33fdab18aa139a82c1959c Gerrit-Change-Number: 32759 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: soc/intel/broadwell: Move GPIO init to a common place
by Nico Huber (Code Review) 12 May '19

12 May '19

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32759 ) Change subject: soc/intel/broadwell: Move GPIO init to a common place ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/32759/1/src/mainboard/google/auron/Makefile… File src/mainboard/google/auron/Makefile.inc: https://review.coreboot.org/#/c/32759/1/src/mainboard/google/auron/Makefile… PS1, Line 36: romstage-y += variants/$(VARIANT_DIR)/gpio.c > Missing linebreak. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/32759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9309d2b842495f6cff33fdab18aa139a82c1959c Gerrit-Change-Number: 32759 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 12 May 2019 12:58:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/broadwell: Move GPIO init to a common place
by Arthur Heymans (Code Review) 12 May '19

12 May '19

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32759 ) Change subject: soc/intel/broadwell: Move GPIO init to a common place ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/32759/2/src/mainboard/google/auron/variants… File src/mainboard/google/auron/variants/auron_paine/include/variant/gpio.h: https://review.coreboot.org/#/c/32759/2/src/mainboard/google/auron/variants… PS2, Line 1: : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : : auron_yuna and auron_paine are the same. It's weird that it gets messed up like this in gerrit. -- To view, visit https://review.coreboot.org/c/coreboot/+/32759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9309d2b842495f6cff33fdab18aa139a82c1959c Gerrit-Change-Number: 32759 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 12 May 2019 12:56:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/broadwell: Move GPIO init to a common place
by Nico Huber (Code Review) 12 May '19

12 May '19

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32759 ) Change subject: soc/intel/broadwell: Move GPIO init to a common place ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://review.coreboot.org/#/c/32759/1/src/mainboard/google/auron/Makefile… File src/mainboard/google/auron/Makefile.inc: https://review.coreboot.org/#/c/32759/1/src/mainboard/google/auron/Makefile… PS1, Line 36: romstage-y += variants/$(VARIANT_DIR)/gpio.c Missing linebreak. (how did you do that?) -- To view, visit https://review.coreboot.org/c/coreboot/+/32759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9309d2b842495f6cff33fdab18aa139a82c1959c Gerrit-Change-Number: 32759 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 12 May 2019 12:55:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/broadwell: Move GPIO init to a common place
by Arthur Heymans (Code Review) 12 May '19

12 May '19

Hello Patrick Rudolph, build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/32759 to look at the new patch set (#2). Change subject: soc/intel/broadwell: Move GPIO init to a common place ...................................................................... soc/intel/broadwell: Move GPIO init to a common place This also links the gpio configuration instead of including it as a header. Change-Id: I9309d2b842495f6cff33fdab18aa139a82c1959c Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/google/auron/Makefile.inc M src/mainboard/google/auron/romstage.c R src/mainboard/google/auron/variants/auron_paine/gpio.c D src/mainboard/google/auron/variants/auron_paine/include/variant/gpio.h C src/mainboard/google/auron/variants/auron_yuna/gpio.c R src/mainboard/google/auron/variants/buddy/gpio.c R src/mainboard/google/auron/variants/gandof/gpio.c R src/mainboard/google/auron/variants/lulu/gpio.c R src/mainboard/google/auron/variants/samus/gpio.c M src/mainboard/google/jecht/Makefile.inc M src/mainboard/google/jecht/romstage.c R src/mainboard/google/jecht/variants/guado/gpio.c R src/mainboard/google/jecht/variants/jecht/gpio.c R src/mainboard/google/jecht/variants/rikku/gpio.c R src/mainboard/google/jecht/variants/tidus/gpio.c M src/mainboard/intel/wtm2/Makefile.inc R src/mainboard/intel/wtm2/gpio.c M src/mainboard/intel/wtm2/romstage.c M src/mainboard/purism/librem_bdw/Makefile.inc R src/mainboard/purism/librem_bdw/gpio.c M src/mainboard/purism/librem_bdw/romstage.c M src/soc/intel/broadwell/include/soc/gpio.h M src/soc/intel/broadwell/romstage/romstage.c 23 files changed, 25 insertions(+), 211 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/32759/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/32759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9309d2b842495f6cff33fdab18aa139a82c1959c Gerrit-Change-Number: 32759 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: mb/{lenovo/x201,packardbell/ms2290}: Remove superfluous TS init
by Nico Huber (Code Review) 12 May '19

12 May '19

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32758 ) Change subject: mb/{lenovo/x201,packardbell/ms2290}: Remove superfluous TS init ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/32758 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia2b762667be17aa5b482cd585dd6f6198cf50d9e Gerrit-Change-Number: 32758 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 12 May 2019 12:48:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel/broadwell: Use C_ENVIRONMENT_BOOTBLOCK
by Arthur Heymans (Code Review) 12 May '19

12 May '19

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30383 ) Change subject: soc/intel/broadwell: Use C_ENVIRONMENT_BOOTBLOCK ...................................................................... Patch Set 40: (1 comment) https://review.coreboot.org/#/c/30383/37/src/soc/intel/broadwell/Kconfig File src/soc/intel/broadwell/Kconfig: https://review.coreboot.org/#/c/30383/37/src/soc/intel/broadwell/Kconfig@117 PS37, Line 117: default 0x2000 > Well, I don't really think that we could get into trouble […] I pushed a patch for it to use the common cpu/intel/car/romstage.c which sets up some stack guard which can detect it during runtime. -- To view, visit https://review.coreboot.org/c/coreboot/+/30383 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I44eb6d380dea5b82e3f009a46381a0f611bb7935 Gerrit-Change-Number: 30383 Gerrit-PatchSet: 40 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Sun, 12 May 2019 12:47:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2019