Hello Patrick Rudolph, Duncan Laurie, Bora Guvendik, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32328
to look at the new patch set (#4).
Change subject: acpi: Upgrade acpi generate header
......................................................................
acpi: Upgrade acpi generate header
Sync acpigen.h content to match with laetst acpica, the link is
https://github.com/acpica/acpica/blob/master/source/include/amlcode.h,
and revision is 20190405. The purspose of the change is just make spec
up to date.
Signed-off-by: Lijian Zhao <lijian.zhao(a)intel.com>
Change-Id: If5f5da70eb66472ddf5df0d72ca85de41faac128
---
M src/arch/x86/include/arch/acpigen.h
1 file changed, 84 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/32328/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/32328
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If5f5da70eb66472ddf5df0d72ca85de41faac128
Gerrit-Change-Number: 32328
Gerrit-PatchSet: 4
Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
mturney mturney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25213 )
Change subject: sdm845: Add USB support on cheza platform
......................................................................
Patch Set 67:
(2 comments)
https://review.coreboot.org/#/c/25213/66/src/soc/qualcomm/sdm845/usb.c
File src/soc/qualcomm/sdm845/usb.c:
https://review.coreboot.org/#/c/25213/66/src/soc/qualcomm/sdm845/usb.c@646
PS66, Line 646: printk(BIOS_INFO, "Starting DWC3 and PHY resets for USB\n");
> nit: should move this into reset_usb0()/reset_usb1() to be able to print the right controller name
Ack
https://review.coreboot.org/#/c/25213/66/src/soc/qualcomm/sdm845/usb.c@788
PS66, Line 788: /* DEBUG_STAT5: wait for 160uS for PLL lock;
> Correct multi-line comment style is either […]
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/25213
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I475a7757239acb8ef22a4d61afd59b304a7f0acc
Gerrit-Change-Number: 25213
Gerrit-PatchSet: 67
Gerrit-Owner: T.Michael Turney <tturne(a)codeaurora.org>
Gerrit-Reviewer: Ciluveru chandana kishori <cchiluve(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: T.Michael Turney <tturne(a)codeaurora.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Chandana Kishori Chiluveru <cchiluve(a)qualcomm.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 18 Apr 2019 22:27:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30892
Change subject: mb/ibase/mb899: Set HD Audio to off
......................................................................
mb/ibase/mb899: Set HD Audio to off
As AC'97 audio is ON in devicetree, HD audio should be OFF
Change-Id: I22af68ab92f76bf3ddcea10faa40a3c6fd934c04
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M src/mainboard/ibase/mb899/devicetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/30892/1
diff --git a/src/mainboard/ibase/mb899/devicetree.cb b/src/mainboard/ibase/mb899/devicetree.cb
index 3544c96..05f48d8 100644
--- a/src/mainboard/ibase/mb899/devicetree.cb
+++ b/src/mainboard/ibase/mb899/devicetree.cb
@@ -41,7 +41,7 @@
register "c3_latency" = "85"
register "p_cnt_throttling_supported" = "0"
- #device pci 1b.0 on end # High Definition Audio
+ device pci 1b.0 off end # High Definition Audio
device pci 1c.0 on end # PCIe
device pci 1c.1 on end # PCIe
device pci 1c.2 on end # PCIe
--
To view, visit https://review.coreboot.org/c/coreboot/+/30892
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I22af68ab92f76bf3ddcea10faa40a3c6fd934c04
Gerrit-Change-Number: 30892
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-MessageType: newchange