coreboot-gerrit February 2019

coreboot-gerrit@coreboot.org

1 participants
1249 discussions

Change in ...coreboot[master]: qcs405: Add GPIO API
by build bot (Jenkins) (Code Review) 18 Feb '19

18 Feb '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29955 ) Change subject: qcs405: Add GPIO API ...................................................................... Patch Set 12: (1 comment) https://review.coreboot.org/#/c/29955/12/src/soc/qualcomm/qcs405/include/so… File src/soc/qualcomm/qcs405/include/soc/gpio.h: https://review.coreboot.org/#/c/29955/12/src/soc/qualcomm/qcs405/include/so… PS12, Line 90: #define PIN(index, tlmm, func1, func2, func3, func4, func5, func6, func7) \ Macros with complex values should be enclosed in parentheses -- To view, visit https://review.coreboot.org/c/coreboot/+/29955 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85ce9007c545b44371c4704a0456774d0eff12a8 Gerrit-Change-Number: 29955 Gerrit-PatchSet: 12 Gerrit-Owner: nsekar(a)codeaurora.org Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: nsekar(a)codeaurora.org Gerrit-Comment-Date: Mon, 18 Feb 2019 17:03:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/qualcomm/qcs405: Add MMU support
by build bot (Jenkins) (Code Review) 18 Feb '19

18 Feb '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29950 ) Change subject: soc/qualcomm/qcs405: Add MMU support ...................................................................... Patch Set 12: (1 comment) https://review.coreboot.org/#/c/29950/12/src/soc/qualcomm/qcs405/mmu.c File src/soc/qualcomm/qcs405/mmu.c: https://review.coreboot.org/#/c/29950/12/src/soc/qualcomm/qcs405/mmu.c@22 PS12, Line 22: void qcs405_mmu_init() Bad function definition - void qcs405_mmu_init() should probably be void qcs405_mmu_init(void) -- To view, visit https://review.coreboot.org/c/coreboot/+/29950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8c6353be2c0379ec94f91223805762a2286de06d Gerrit-Change-Number: 29950 Gerrit-PatchSet: 12 Gerrit-Owner: nsekar(a)codeaurora.org Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: nsekar(a)codeaurora.org Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Mon, 18 Feb 2019 17:02:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...libgfxinit[master]: gma: Add Kaby Lake support
by Thomas Heijligen (Code Review) 18 Feb '19

18 Feb '19

Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/28763 ) Change subject: gma: Add Kaby Lake support ...................................................................... Patch Set 4: Code-Review+1 Working on with <Linear "high-resolution" framebuffer> mode on Clevo n130bu (i7-7500U Kabylake) (clevo/kbl-u in gerrit) -- To view, visit https://review.coreboot.org/c/libgfxinit/+/28763 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Ice05e07b016cebc7258a9790e38e079e63227a4b Gerrit-Change-Number: 28763 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Mon, 18 Feb 2019 16:13:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: Documentation: add Skulls to the list of distributions
by Martin Kepplinger (Code Review) 18 Feb '19

18 Feb '19

Martin Kepplinger has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31463 Change subject: Documentation: add Skulls to the list of distributions ...................................................................... Documentation: add Skulls to the list of distributions There seem to be enough users of the Skulls images to have the project listed in our docs. Change-Id: I5a8f24005fec87d53af7ad53370cb6a704378622 Signed-off-by: Martin Kepplinger <martink(a)posteo.de> --- M Documentation/distributions.md 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/31463/1 diff --git a/Documentation/distributions.md b/Documentation/distributions.md index c533a1b..e1a6961 100644 --- a/Documentation/distributions.md +++ b/Documentation/distributions.md @@ -80,3 +80,11 @@ Heads is not just another Linux distribution – it combines physical hardening of specific hardware platforms and flash security features with custom coreboot firmware and a Linux boot loader in ROM. + +### Skulls + +[Skulls](https://github.com/merge/skulls) provides firmware images for +Laptops like the Lenovo Thinkpad X230. It uses upstream coreboot, an easy +to use payload like SeaBIOS and Intel's latest microcode update. +It simplifies installation and includes compact documentation. Skulls also +enables easy switching to [Heads](#heads) and back. -- To view, visit https://review.coreboot.org/c/coreboot/+/31463 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a8f24005fec87d53af7ad53370cb6a704378622 Gerrit-Change-Number: 31463 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Kepplinger <martink(a)posteo.de> Gerrit-MessageType: newchange

4 5

Change in ...libgfxinit[master]: gma config: Introduce Is_ULT
by Nico Huber (Code Review) 18 Feb '19

18 Feb '19

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/libgfxinit/+/27053 ) Change subject: gma config: Introduce Is_ULT ...................................................................... gma config: Introduce Is_ULT Change-Id: I545d74ba6cadb06479b29b85aa9dc2af2be564d6 Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/c/27053 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M common/hw-gfx-gma-config.ads.template M common/skylake/hw-gfx-gma-connectors-ddi-buffers.adb 2 files changed, 14 insertions(+), 18 deletions(-) Approvals: Nico Huber: Verified Angel Pons: Looks good to me, approved diff --git a/common/hw-gfx-gma-config.ads.template b/common/hw-gfx-gma-config.ads.template index 968ccc7..a922b05 100644 --- a/common/hw-gfx-gma-config.ads.template +++ b/common/hw-gfx-gma-config.ads.template @@ -41,6 +41,7 @@ Internal_Is_EDP : constant Boolean := Internal_Display = DP; Have_DVI_I : constant Boolean := Analog_I2C_Port /= PCH_DAC; Has_Presence_Straps : constant Boolean := CPU /= Broxton; + Is_ULT : constant Boolean := CPU_Var = ULT; ----- CPU pipe: -------- Has_Tertiary_Pipe : constant Boolean := CPU >= Ivybridge; @@ -73,7 +74,7 @@ Has_PCH : constant Boolean := CPU /= Broxton and CPU /= G45; Has_PCH_DAC : constant Boolean := CPU in Ironlake .. Ivybridge or (CPU in Haswell .. Broadwell - and CPU_Var = Normal); + and not Is_ULT); Has_PCH_Aux_Channels : constant Boolean := CPU in Ironlake .. Broadwell; @@ -97,13 +98,13 @@ Has_Per_DDI_Clock_Sel : constant Boolean := CPU in Haswell .. Broadwell; Has_HOTPLUG_CTL : constant Boolean := CPU in Haswell .. Broadwell; Has_SHOTPLUG_CTL_A : constant Boolean := (CPU in Haswell .. Broadwell - and CPU_Var = ULT) or + and Is_ULT) or CPU >= Skylake; Has_DDI_PHYs : constant Boolean := CPU = Broxton; Has_DDI_D : constant Boolean := CPU >= Haswell and - CPU_Var = Normal and + not Is_ULT and not Has_DDI_PHYs; Has_DDI_E : constant Boolean := -- might be disabled by x4 eDP Has_DDI_D; @@ -121,8 +122,7 @@ Has_PCH_GMBUS : constant Boolean := CPU >= Ironlake; ----- Power: ----------- - Has_IPS : constant Boolean := (CPU = Haswell and - CPU_Var = ULT) or + Has_IPS : constant Boolean := (CPU = Haswell and Is_ULT) or CPU = Broadwell; Has_IPS_CTL_Mailbox : constant Boolean := CPU = Broadwell; @@ -248,10 +248,7 @@ Sandybridge | Ivybridge => 125_000_000, when Haswell | - Broadwell => (if CPU_Var = Normal then - 125_000_000 - else - 24_000_000), + Broadwell => (if Is_ULT then 24_000_000 else 125_000_000), when Broxton => Frequency_Type'First, -- none needed when Skylake => 24_000_000); diff --git a/common/skylake/hw-gfx-gma-connectors-ddi-buffers.adb b/common/skylake/hw-gfx-gma-connectors-ddi-buffers.adb index 34ee980..5e72a3b 100644 --- a/common/skylake/hw-gfx-gma-connectors-ddi-buffers.adb +++ b/common/skylake/hw-gfx-gma-connectors-ddi-buffers.adb @@ -101,15 +101,14 @@ else Config.Default_DDI_HDMI_Buffer_Translation); begin Trans := - (case Config.CPU_Var is - when Normal => - (if DDIA_Low_Voltage_Swing - then Skylake_Trans_EDP - else Skylake_Trans_DP), - when ULT => - (if DDIA_Low_Voltage_Swing - then Skylake_U_Trans_EDP - else Skylake_U_Trans_DP)); + (if not Config.Is_ULT then + (if DDIA_Low_Voltage_Swing + then Skylake_Trans_EDP + else Skylake_Trans_DP) + else + (if DDIA_Low_Voltage_Swing + then Skylake_U_Trans_EDP + else Skylake_U_Trans_DP)); if not DDIA_Low_Voltage_Swing then Trans (18) := Skylake_Trans_HDMI (HDMI_Trans).Trans1; Trans (19) := Skylake_Trans_HDMI (HDMI_Trans).Trans2; -- To view, visit https://review.coreboot.org/c/libgfxinit/+/27053 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: I545d74ba6cadb06479b29b85aa9dc2af2be564d6 Gerrit-Change-Number: 27053 Gerrit-PatchSet: 8 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: merged

1 0

Change in ...coreboot[master]: Documentation/lesson1: Update references to compiler packages
by Nico Huber (Code Review) 18 Feb '19

18 Feb '19

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31447 Change subject: Documentation/lesson1: Update references to compiler packages ...................................................................... Documentation/lesson1: Update references to compiler packages Change-Id: Ie9daa70c56552cccfe28e9a4903f87d43221375e Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M Documentation/lessons/lesson1.md 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/31447/1 diff --git a/Documentation/lessons/lesson1.md b/Documentation/lessons/lesson1.md index e6ff237..2ca25b3 100644 --- a/Documentation/lessons/lesson1.md +++ b/Documentation/lessons/lesson1.md @@ -8,7 +8,7 @@ --------------------------------------- ### Step 1 - Install tools and libraries needed for coreboot - $ sudo apt-get install -y bison build-essential curl flex git gnat-5 libncurses5-dev m4 zlib1g-dev + $ sudo apt-get install -y bison build-essential curl flex git gnat libncurses5-dev m4 zlib1g-dev ### Step 2 - Download coreboot source tree $ git clone https://review.coreboot.org/coreboot @@ -99,8 +99,9 @@ on some Ubuntu flavors, and not on others. * `git` is needed to download coreboot from the coreboot git repository. * `libncurses5-dev` is needed to build the menu for 'make menuconfig' -* `m4, bison, curl, flex, gnat-5, zlib1g-dev` are needed to build the coreboot -toolchain. +* `m4, bison, curl, flex, zlib1g-dev, gcc, gnat` and `g++` or `clang` +are needed to build the coreboot toolchain. `gcc` and `gnat` have to be +of the same version. If you started with a different distribution, you might need to install many other items which vary by distribution. -- To view, visit https://review.coreboot.org/c/coreboot/+/31447 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9daa70c56552cccfe28e9a4903f87d43221375e Gerrit-Change-Number: 31447 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

4 3

Change in ...libgfxinit[master]: gma: Add Kaby Lake support
by Nico Huber (Code Review) 18 Feb '19

18 Feb '19

Hello Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/libgfxinit/+/28763 to look at the new patch set (#4). Change subject: gma: Add Kaby Lake support ...................................................................... gma: Add Kaby Lake support Including some weird Amber Lake Y parts that are treated like Kaby Lake in Linux' i915. Only differences to Skylake in the DDI output buffer tuning. Change-Id: Ice05e07b016cebc7258a9790e38e079e63227a4b Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/Makefile.inc M common/hw-gfx-gma-config.ads.template M common/hw-gfx-gma-config_helpers.adb M common/hw-gfx-gma.adb M common/hw-gfx-gma.ads M common/skylake/hw-gfx-gma-connectors-ddi-buffers.adb A configs/kabylake A configs/kabylake_ulx 8 files changed, 106 insertions(+), 33 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/63/28763/4 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/28763 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Ice05e07b016cebc7258a9790e38e079e63227a4b Gerrit-Change-Number: 28763 Gerrit-PatchSet: 4 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in ...libgfxinit[master]: gma: Add Kaby Lake support
by Nico Huber (Code Review) 18 Feb '19

18 Feb '19

Hello Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/libgfxinit/+/28763 to look at the new patch set (#3). Change subject: gma: Add Kaby Lake support ...................................................................... gma: Add Kaby Lake support Including some weird Amber Lake Y parts that are treated like Kaby Lake in Linux' i915. Only differences to Skylake in the DDI output buffer tuning. Change-Id: Ice05e07b016cebc7258a9790e38e079e63227a4b Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/Makefile.inc M common/hw-gfx-gma-config.ads.template M common/hw-gfx-gma-config_helpers.adb M common/hw-gfx-gma.adb M common/hw-gfx-gma.ads M common/skylake/hw-gfx-gma-connectors-ddi-buffers.adb A configs/kabylake A configs/kabylake_ulx 8 files changed, 104 insertions(+), 32 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/63/28763/3 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/28763 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Ice05e07b016cebc7258a9790e38e079e63227a4b Gerrit-Change-Number: 28763 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in ...libgfxinit[master]: gma: Add Kaby Lake support
by Nico Huber (Code Review) 17 Feb '19

17 Feb '19

Nico Huber has uploaded a new patch set (#2). ( https://review.coreboot.org/c/libgfxinit/+/28763 ) Change subject: gma: Add Kaby Lake support ...................................................................... gma: Add Kaby Lake support Including some weird Amber Lake Y parts that are treated like Kaby Lake in Linux' i915. Only differences to Skylake in the DDI output buffer tuning. Change-Id: Ice05e07b016cebc7258a9790e38e079e63227a4b Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M common/Makefile.inc M common/hw-gfx-gma-config.ads.template M common/hw-gfx-gma-config_helpers.adb M common/hw-gfx-gma.adb M common/hw-gfx-gma.ads M common/skylake/hw-gfx-gma-connectors-ddi-buffers.adb 6 files changed, 94 insertions(+), 32 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/63/28763/2 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/28763 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Ice05e07b016cebc7258a9790e38e079e63227a4b Gerrit-Change-Number: 28763 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: Documentation: Add broader payload coverage to project ideas
by Patrick Georgi (Code Review) 17 Feb '19

17 Feb '19

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31415 Change subject: Documentation: Add broader payload coverage to project ideas ...................................................................... Documentation: Add broader payload coverage to project ideas A couple people discussed recently how it's a shame that on some architectures we can bring up a device but then have nothing to do with it afterwards. Having payloads to choose from would help a lot there. Change-Id: Ia66f22947d09afe3076cc2ee12f5b652fe80fc3a Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M Documentation/contributing/project_ideas.md 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/31415/1 diff --git a/Documentation/contributing/project_ideas.md b/Documentation/contributing/project_ideas.md index 0a39a88..7bcf2c7 100644 --- a/Documentation/contributing/project_ideas.md +++ b/Documentation/contributing/project_ideas.md @@ -72,3 +72,21 @@ hardware is available. ### Mentors + +## Port payloads to ARM, AArch64, MIPS or RISC-V +While we have a rather big set of payloads for x86 based platforms, all other +architectures are rather limited. Improve the situation by porting a payload +to one of the platforms, for example GRUB2, U-Boot (the UI part), Tianocore, +yabits, FILO, or Linux-as-Payload. + +Since this is a bit of a catch-all idea, an application to GSoC should pick a +combination of payload and architecture to support. + +### Requirements +* coreboot knowledge: Should konw the general boot flow in coreboot +* other knowledge: It helps to be familiar with the architecture you want to + work on. +* hardware requirements: Much of this can be done in QEMU or other emulators, + but the ability to test on real hardware is a plus. + +### Mentors -- To view, visit https://review.coreboot.org/c/coreboot/+/31415 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia66f22947d09afe3076cc2ee12f5b652fe80fc3a Gerrit-Change-Number: 31415 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

4 6

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2019