coreboot-gerrit February 2019

coreboot-gerrit@coreboot.org

1 participants
1249 discussions

Change in ...coreboot[master]: mb/google/hatch: Configure GPIOs again after FSP-S is done
by Furquan Shaikh (Code Review) 06 Feb '19

06 Feb '19

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31236 Change subject: mb/google/hatch: Configure GPIOs again after FSP-S is done ...................................................................... mb/google/hatch: Configure GPIOs again after FSP-S is done FSP-S is currently configuring GPIOs that it should not. This results in issues like host unable to receive TPM interrupts as the pad for the interrupt is re-configured as something else. Until FSP-S is fixed, this change adds a workaround by reconfiguring GPIOs after FSP-S is run. BUG=b:123721147 BRANCH=None TEST=Verified that there are no TPM IRQ timeouts in boot log. Change-Id: Ib197529a730f0142152c94ddf4a2b005bae123f5 Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/mainboard/google/hatch/ramstage.c 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/31236/1 diff --git a/src/mainboard/google/hatch/ramstage.c b/src/mainboard/google/hatch/ramstage.c index b8e80e7..e2fe048 100644 --- a/src/mainboard/google/hatch/ramstage.c +++ b/src/mainboard/google/hatch/ramstage.c @@ -20,7 +20,7 @@ #include <variant/gpio.h> #include <vendorcode/google/chromeos/chromeos.h> -void mainboard_silicon_init_params(FSP_S_CONFIG *params) +static void mainboard_configure_gpios(void) { const struct pad_config *gpio_table; size_t num_gpios; @@ -29,10 +29,22 @@ gpio_configure_pads(gpio_table, num_gpios); } +void mainboard_silicon_init_params(FSP_S_CONFIG *params) +{ + mainboard_configure_gpios(); +} + +static void mainboard_init(struct device *dev) +{ + /* Workaround FSP issue by reprogramming GPIOs after FSP-S */ + mainboard_configure_gpios(); +} + static void mainboard_enable(struct device *dev) { mainboard_ec_init(); + dev->ops->init = mainboard_init; dev->ops->acpi_inject_dsdt_generator = chromeos_dsdt_generator; } -- To view, visit https://review.coreboot.org/c/coreboot/+/31236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib197529a730f0142152c94ddf4a2b005bae123f5 Gerrit-Change-Number: 31236 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-MessageType: newchange

4 8

Change in ...coreboot[master]: libgfxinit: Add options to limit framebuffer size
by Nico Huber (Code Review) 06 Feb '19

06 Feb '19

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30585 Change subject: libgfxinit: Add options to limit framebuffer size ...................................................................... libgfxinit: Add options to limit framebuffer size Change-Id: I47fba063629260c3a2854caf7a73f1a1e933d063 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/device/Kconfig M src/drivers/intel/gma/hires_fb/gma.adb 2 files changed, 16 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/30585/1 diff --git a/src/device/Kconfig b/src/device/Kconfig index 85f1d65..f868d2f 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -445,6 +445,16 @@ def_bool y depends on VBE_LINEAR_FRAMEBUFFER || GENERIC_LINEAR_FRAMEBUFFER +config LINEAR_FRAMEBUFFER_MAX_WIDTH + int "Maximum width in pixels" + depends on MAINBOARD_USE_LIBGFXINIT && LINEAR_FRAMEBUFFER + default 4096 + +config LINEAR_FRAMEBUFFER_MAX_HEIGHT + int "Maximum height in pixels" + depends on MAINBOARD_USE_LIBGFXINIT && LINEAR_FRAMEBUFFER + default 4096 + endmenu # "Display" config SMBUS_HAS_AUX_CHANNELS diff --git a/src/drivers/intel/gma/hires_fb/gma.adb b/src/drivers/intel/gma/hires_fb/gma.adb index bd14132..1437ce2 100644 --- a/src/drivers/intel/gma/hires_fb/gma.adb +++ b/src/drivers/intel/gma/hires_fb/gma.adb @@ -1,3 +1,7 @@ +with CB.Config; + +use CB.Config; + with HW.GFX; with HW.GFX.Framebuffer_Filler; with HW.GFX.GMA; @@ -60,8 +64,8 @@ success : boolean; - min_h : pos32 := pos32'last; - min_v : pos32 := pos32'last; + min_h : pos32 := LINEAR_FRAMEBUFFER_MAX_WIDTH; + min_v : pos32 := LINEAR_FRAMEBUFFER_MAX_HEIGHT; begin lightup_ok := 0; -- To view, visit https://review.coreboot.org/c/coreboot/+/30585 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I47fba063629260c3a2854caf7a73f1a1e933d063 Gerrit-Change-Number: 30585 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

4 7

Change in ...coreboot[master]: Hook up Kconfig Ada spec file
by Nico Huber (Code Review) 06 Feb '19

06 Feb '19

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30584 Change subject: Hook up Kconfig Ada spec file ...................................................................... Hook up Kconfig Ada spec file We generate a $(obj)/cb-config.ads once and copy it per stage that uses it to $(obj)/<stage>/cb-config.ads (to simplify the gnat-bind step). The Ada package is called `CB.Config`. As there was no `CB` package yet, add that too. Change-Id: I963a6517ef4bcf84f2c8e9ae8d24a0d6b971d2b0 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M Makefile M Makefile.inc M src/lib/Makefile.inc A src/lib/cb.ads 4 files changed, 22 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/30584/1 diff --git a/Makefile b/Makefile index f12b616..3acb97d 100644 --- a/Makefile +++ b/Makefile @@ -44,6 +44,7 @@ DOTCONFIG ?= $(top)/.config KCONFIG_CONFIG = $(DOTCONFIG) +KCONFIG_AUTOADS := $(obj)/cb-config.ads KCONFIG_AUTOHEADER := $(obj)/config.h KCONFIG_AUTOCONFIG := $(obj)/auto.conf KCONFIG_DEPENDENCIES := $(obj)/auto.conf.cmd @@ -51,10 +52,12 @@ KCONFIG_TRISTATE := $(obj)/tristate.conf KCONFIG_NEGATIVES := 1 KCONFIG_STRICT := 1 +KCONFIG_PACKAGE := CB.Config COREBOOT_EXPORTS += KCONFIG_CONFIG KCONFIG_AUTOHEADER KCONFIG_AUTOCONFIG COREBOOT_EXPORTS += KCONFIG_DEPENDENCIES KCONFIG_SPLITCONFIG KCONFIG_TRISTATE COREBOOT_EXPORTS += KCONFIG_NEGATIVES KCONFIG_STRICT +COREBOOT_EXPORTS += KCONFIG_AUTOADS KCONFIG_PACKAGE # directory containing the toplevel Makefile.inc TOPLEVEL := . @@ -179,6 +182,12 @@ $(KCONFIG_AUTOHEADER): $(KCONFIG_CONFIG) $(objutil)/kconfig/conf +$(MAKE) oldconfig +$(KCONFIG_AUTOADS): $(KCONFIG_AUTOHEADER) + true + +$(obj)/%/$(notdir $(KCONFIG_AUTOADS)): $(KCONFIG_AUTOADS) + cp $< $@ + # Add a new class of source/object files to the build system add-class= \ $(eval $(1)-srcs:=) \ @@ -263,6 +272,11 @@ # Eliminate duplicate mentions of source files in a class $(foreach class,$(classes),$(eval $(class)-srcs:=$(sort $($(class)-srcs)))) +# Build Kconfig .ads if necessary +ifeq ($(CONFIG_RAMSTAGE_ADA),y) +ramstage-srcs += $(obj)/ramstage/$(notdir $(KCONFIG_AUTOADS)) +endif + # To track dependencies, we need all Ada specification (.ads) files in # *-srcs. Extract / filter all specification files that have a matching # body (.adb) file here (specifications without a body are valid sources @@ -311,7 +325,7 @@ ifn$(EMPTY)def $(1)-objs_$(2)_template de$(EMPTY)fine $(1)-objs_$(2)_template ifn$(EMPTY)eq ($(filter ads adb,$(2)),) -$$(call src-to-obj,$1,$$(1).$2): $$(1).$2 $$(call create_ada_deps,$1,$$(call src-to-ali,$1,$$(1).$2)) $(KCONFIG_AUTOHEADER) $(4) +$$(call src-to-obj,$1,$$(1).$2): $$(1).$2 $$(call create_ada_deps,$1,$$(call src-to-ali,$1,$$(1).$2)) $(4) @printf " GCC $$$$(subst $$$$(obj)/,,$$$$(@))\n" $(GCC_$(1)) \ $$$$(ADAFLAGS_$(1)) $$$$(addprefix -I,$$$$($(1)-ada-dirs)) \ diff --git a/Makefile.inc b/Makefile.inc index b25ac6b..4292e79 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -210,7 +210,9 @@ bootblock-c-deps:=$$(OPTION_TABLE_H) $(foreach type,ads adb, \ $(foreach stage,$(COREBOOT_STANDARD_STAGES), \ - $(eval $(stage)-$(type)-deps := $(obj)/libgnat-$(ARCH-$(stage)-y)/libgnat.a))) + $(eval $(stage)-$(type)-deps := \ + $(obj)/$(stage)/$(notdir $(KCONFIG_AUTOADS)) \ + $(obj)/libgnat-$(ARCH-$(stage)-y)/libgnat.a))) # Add handler to copy linker scripts define generic-objs_ld_template_gen diff --git a/src/lib/Makefile.inc b/src/lib/Makefile.inc index 2fd4e4c..1bfe9cd 100644 --- a/src/lib/Makefile.inc +++ b/src/lib/Makefile.inc @@ -295,6 +295,8 @@ $(obj)/%.elf.rmod: $(obj)/%.elf | $(RMODTOOL) $(RMODTOOL) -i $< -o $@ +ramstage-$(CONFIG_RAMSTAGE_ADA) += cb.ads + ifeq ($(CONFIG_RAMSTAGE_LIBHWBASE),y) to-ada-hex = $(eval $(1) := 16\\\#$(patsubst 0x%,%,$($(1)))\\\#) diff --git a/src/lib/cb.ads b/src/lib/cb.ads new file mode 100644 index 0000000..41a2a42 --- /dev/null +++ b/src/lib/cb.ads @@ -0,0 +1,2 @@ +package CB is +end CB; -- To view, visit https://review.coreboot.org/c/coreboot/+/30584 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I963a6517ef4bcf84f2c8e9ae8d24a0d6b971d2b0 Gerrit-Change-Number: 30584 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

4 6

Change in ...coreboot[master]: WIP: update blobs repository submodule pointer
by Martin Kepplinger (Code Review) 06 Feb '19

06 Feb '19

Martin Kepplinger has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/30308 ) Change subject: WIP: update blobs repository submodule pointer ...................................................................... Abandoned deprecated. don't use this. -- To view, visit https://review.coreboot.org/c/coreboot/+/30308 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If041acfea7954af0877a4467f023f366cea1b712 Gerrit-Change-Number: 30308 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Kepplinger <martink(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in ...coreboot[master]: sb/intel/i82801ix/dmi_setup: Fix shift overflow issue
by HAOUAS Elyes (Code Review) 06 Feb '19

06 Feb '19

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23395 ) Change subject: sb/intel/i82801ix/dmi_setup: Fix shift overflow issue ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/23395 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36643654935b7b3f8a3d0a0a3a4e433ffb3496df Gerrit-Change-Number: 23395 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Feb 2019 15:42:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: cpu/amd/model_fxx/fidvid: Use big enough type for left shift
by HAOUAS Elyes (Code Review) 06 Feb '19

06 Feb '19

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23394 ) Change subject: cpu/amd/model_fxx/fidvid: Use big enough type for left shift ...................................................................... Patch Set 1: if I'm not wrong, this is removed. -- To view, visit https://review.coreboot.org/c/coreboot/+/23394 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc8ca1ae430d9382663d34f118b7eb16bf694732 Gerrit-Change-Number: 23394 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 06 Feb 2019 15:41:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: util/cbmem: Use big enough type for left-shift
by HAOUAS Elyes (Code Review) 06 Feb '19

06 Feb '19

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23379 ) Change subject: util/cbmem: Use big enough type for left-shift ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/23379 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia913c6589a6a35be88308b561ffde227ebca2e0e Gerrit-Change-Number: 23379 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Feb 2019 15:37:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: include/device/pciexp.h: Use big enough type for left shift
by HAOUAS Elyes (Code Review) 06 Feb '19

06 Feb '19

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23378 ) Change subject: include/device/pciexp.h: Use big enough type for left shift ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/23378 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If524affc03860e33038e36a5f8dd0fb0d33bd847 Gerrit-Change-Number: 23378 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Feb 2019 15:37:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/mediatek/mt8173/include/soc/wdt.h: Use big enough type for left-s...
by HAOUAS Elyes (Code Review) 06 Feb '19

06 Feb '19

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23377 ) Change subject: soc/mediatek/mt8173/include/soc/wdt.h: Use big enough type for left-shift ...................................................................... Patch Set 1: the file is here now: src/soc/mediatek/common/include/soc/wdt.h -- To view, visit https://review.coreboot.org/c/coreboot/+/23377 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I01de1886ec0912d060de4f9bd9dc0fdc9913c2e0 Gerrit-Change-Number: 23377 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 06 Feb 2019 15:37:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: nb/intel/sandybridge: Fix shift error
by HAOUAS Elyes (Code Review) 06 Feb '19

06 Feb '19

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23362 ) Change subject: nb/intel/sandybridge: Fix shift error ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/23362 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1fa0a2b3645e5ecdbd685efdc948c65544a35075 Gerrit-Change-Number: 23362 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 06 Feb 2019 15:34:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2019