Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33914
Change subject: src/mainboard/asus/am1i-a/buildOpts.c: detailed paths to the include files
......................................................................
src/mainboard/asus/am1i-a/buildOpts.c: detailed paths to the include files
Make it clear which include files are being used, by using the detailed paths.
Signed-off-by: Mike Banon <mikebdp2(a)gmail.com>
Change-Id: Ic096848f23910e2ad9183e44d882450ab8d4fdf1
---
M src/mainboard/asus/am1i-a/buildOpts.c
1 file changed, 15 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/33914/1
diff --git a/src/mainboard/asus/am1i-a/buildOpts.c b/src/mainboard/asus/am1i-a/buildOpts.c
index 93d7738..b5b06d3 100644
--- a/src/mainboard/asus/am1i-a/buildOpts.c
+++ b/src/mainboard/asus/am1i-a/buildOpts.c
@@ -26,7 +26,21 @@
*/
#include <stdlib.h>
-#include <AGESA.h>
+#include <vendorcode/amd/agesa/f16kb/AGESA.h>
+
+/* Include the files that instantiate the configuration definitions. */
+#include <vendorcode/amd/agesa/f16kb/Include/AdvancedApi.h>
+#include <vendorcode/amd/agesa/f16kb/Include/GnbInterface.h>
+#include <vendorcode/amd/agesa/f16kb/Proc/CPU/cpuFamilyTranslation.h>
+#include <vendorcode/amd/agesa/f16kb/Proc/CPU/cpuRegisters.h>
+#include <vendorcode/amd/agesa/f16kb/Proc/CPU/Family/cpuFamRegisters.h>
+#include <vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuFeatures.h>
+#include <vendorcode/amd/agesa/f16kb/Proc/CPU/Table.h>
+#include <vendorcode/amd/agesa/f16kb/Proc/CPU/heapManager.h>
+/* AGESA nonesense: the next three headers depend on heapManager.h */
+#include <vendorcode/amd/agesa/f16kb/Proc/Common/CreateStruct.h>
+#include <vendorcode/amd/agesa/f16kb/Proc/CPU/cpuEarlyInit.h>
+#include <vendorcode/amd/agesa/f16kb/Proc/CPU/cpuLateInit.h>
#define INSTALL_FAMILY_16_MODEL_0x_SUPPORT TRUE
@@ -232,20 +246,6 @@
#define BLDCFG_AP_MTRR_SETTINGS_LIST &KabiniApMtrrSettingsList
-
-/* Include the files that instantiate the configuration definitions. */
-#include "cpuRegisters.h"
-#include "cpuFamRegisters.h"
-#include "cpuFamilyTranslation.h"
-#include "AdvancedApi.h"
-#include "heapManager.h"
-#include "CreateStruct.h"
-#include "cpuFeatures.h"
-#include "Table.h"
-#include "cpuEarlyInit.h"
-#include "cpuLateInit.h"
-#include "GnbInterface.h"
-
// This is the delivery package title, "BrazosPI"
// This string MUST be exactly 8 characters long
#define AGESA_PACKAGE_STRING {'c', 'b', '_', 'A', 'g', 'e', 's', 'a'}
--
To view, visit https://review.coreboot.org/c/coreboot/+/33914
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic096848f23910e2ad9183e44d882450ab8d4fdf1
Gerrit-Change-Number: 33914
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-MessageType: newchange
Hello Mike Banon,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/31325
to review the following change.
Change subject: lenovo/g505s/Kconfig: Set framebuffer graphics mode to VESA 118h mode
......................................................................
lenovo/g505s/Kconfig: Set framebuffer graphics mode to VESA 118h mode
Set VESA/native framebuffer mode (needed for bootsplash and graphical
framebuffer console) to 118h VESA (1024x768 16.8M-color (8:8:8)) mode
because it's the closest to this laptop's 1366x768 screen resolution.
This provides console output even if e.g. GRUB is the payload.
Signed-off-by: Mike Banon <mikebdp2(a)gmail.com>
Change-Id: I0b4eacf61d905f1160531a988e192c3b626dca68
---
M src/mainboard/lenovo/g505s/Kconfig
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/31325/1
diff --git a/src/mainboard/lenovo/g505s/Kconfig b/src/mainboard/lenovo/g505s/Kconfig
index 883ef27..2d1eac7 100644
--- a/src/mainboard/lenovo/g505s/Kconfig
+++ b/src/mainboard/lenovo/g505s/Kconfig
@@ -55,4 +55,12 @@
string
default "1002,990b"
+config FRAMEBUFFER_SET_VESA_MODE
+ bool
+ default y
+
+config FRAMEBUFFER_VESA_DEFAULT_118
+ bool
+ default y
+
endif # BOARD_LENOVO_G505S
--
To view, visit https://review.coreboot.org/c/coreboot/+/31325
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b4eacf61d905f1160531a988e192c3b626dca68
Gerrit-Change-Number: 31325
Gerrit-PatchSet: 1
Gerrit-Owner: mikeb mikeb <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-MessageType: newchange
Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33917
Change subject: src/mainboard/asus/am1i-a/buildOpts.c: add includes for adjusting RAM timings
......................................................................
src/mainboard/asus/am1i-a/buildOpts.c: add includes for adjusting RAM timings
These tables may be used to adjust memory timing settings.
Signed-off-by: Mike Banon <mikebdp2(a)gmail.com>
Change-Id: I782f76119c5ce9a3cc4bc07596d27dd42b615b6d
---
M src/mainboard/asus/am1i-a/buildOpts.c
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/33917/1
diff --git a/src/mainboard/asus/am1i-a/buildOpts.c b/src/mainboard/asus/am1i-a/buildOpts.c
index dfd27cd..643b306 100644
--- a/src/mainboard/asus/am1i-a/buildOpts.c
+++ b/src/mainboard/asus/am1i-a/buildOpts.c
@@ -42,6 +42,9 @@
#include <vendorcode/amd/agesa/f16kb/Proc/Common/CreateStruct.h>
#include <vendorcode/amd/agesa/f16kb/Proc/CPU/cpuEarlyInit.h>
#include <vendorcode/amd/agesa/f16kb/Proc/CPU/cpuLateInit.h>
+/* These tables are optional and may be used to adjust memory timing settings */
+#include <vendorcode/amd/agesa/f16kb/Proc/Mem/mm.h>
+#include <vendorcode/amd/agesa/f16kb/Proc/Mem/mn.h>
/* Select the CPU family. */
#define INSTALL_FAMILY_16_MODEL_0x_SUPPORT TRUE
--
To view, visit https://review.coreboot.org/c/coreboot/+/33917
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I782f76119c5ce9a3cc4bc07596d27dd42b615b6d
Gerrit-Change-Number: 33917
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-MessageType: newchange
DaLao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36371 )
Change subject: Signed-off-by: dalao <dalao(a)tutanota.com>
......................................................................
Signed-off-by: dalao <dalao(a)tutanota.com>
src/mainboard/lenovo: Use the original lenovo hardware id for touchpad
Currently the coreboot's touchpad hardware id is different from the original lenovo ones, and this causes some problems. On Windows, the touchpad driver can't automatically be matched and installed through Windows Update. On Linux, there also maybe some strange issues (https://bugzilla.kernel.org/show_bug.cgi?id=91541). So it's better to use the original lenovo hardware id for each model than the PNP-id. By searching for dmesg logs, I found the following hardware ids for these thinkpad models:
LEN0015
T510: https://bbs.archlinux.org/viewtopic.php?id=120287
T410: ?
T420: ?
T420s: https://bbs.archlinux.org/viewtopic.php?id=191510
T520: ?
T430: https://github.com/farjump/fwtr/blob/master/lenovo/thinkpad-t430/2347ds2/le…
T430s: ?
T530: ?
LEN0020
X220: https://bbs.archlinux.org/viewtopic.php?id=237669
X230: https://forums.bunsenlabs.org/viewtopic.php?id=2460
LEN0036
T540: https://bugzilla.kernel.org/show_bug.cgi?id=91541
Then I made several copies of the ps2_controller.asl changed the superio.asl to include their correct ones. Then reboot to Windows and the touchpad driver is automatically installed. Done. But I still have some querstions:
1, Is making copies of the ps2_controller.asl a good way? Are there any better methods for doing this?
2, Is there any website that collect dmesg logs so I can search the hardware ids?
3, The keyboard's hardware id maybe different like the touchpad as well. But they are working ok, so I haven't looked into it.
Change-Id: Ifb635da99c5e05f987aaf4f172108d788dcc2932
---
A src/drivers/pc80/pc/ps2_controller_len0015.asl
A src/drivers/pc80/pc/ps2_controller_len0020.asl
A src/drivers/pc80/pc/ps2_controller_len0036.asl
M src/mainboard/lenovo/t410/acpi/superio.asl
M src/mainboard/lenovo/t420/acpi/superio.asl
M src/mainboard/lenovo/t420s/acpi/superio.asl
M src/mainboard/lenovo/t430/acpi/superio.asl
M src/mainboard/lenovo/t430s/acpi/superio.asl
M src/mainboard/lenovo/t520/acpi/superio.asl
M src/mainboard/lenovo/t530/acpi/superio.asl
M src/mainboard/lenovo/x220/acpi/superio.asl
M src/mainboard/lenovo/x230/acpi/superio.asl
12 files changed, 145 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/36371/1
diff --git a/src/drivers/pc80/pc/ps2_controller_len0015.asl b/src/drivers/pc80/pc/ps2_controller_len0015.asl
new file mode 100644
index 0000000..750b24f
--- /dev/null
+++ b/src/drivers/pc80/pc/ps2_controller_len0015.asl
@@ -0,0 +1,46 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; version 2 of
+ * the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+ Device (PS2K) // Keyboard
+ {
+ Name(_HID, EISAID("PNP0303"))
+ Name(_CID, EISAID("PNP030B"))
+
+ Name(_CRS, ResourceTemplate()
+ {
+ IO (Decode16, 0x60, 0x60, 0x01, 0x01)
+ IO (Decode16, 0x64, 0x64, 0x01, 0x01)
+ IRQ (Edge, ActiveHigh, Exclusive) { 0x01 } // IRQ 1
+ })
+
+ Method (_STA, 0)
+ {
+ Return (0xf)
+ }
+ }
+
+ Device (PS2M) // Mouse
+ {
+ Name(_HID, EISAID("LEN0015"))
+ Name(_CID, EISAID("PNP0F13"))
+
+ Name(_CRS, ResourceTemplate()
+ {
+ IRQ (Edge, ActiveHigh, Exclusive) { 0x0c } // IRQ 12
+ })
+
+ Method(_STA, 0)
+ {
+ Return (0xf)
+ }
+ }
diff --git a/src/drivers/pc80/pc/ps2_controller_len0020.asl b/src/drivers/pc80/pc/ps2_controller_len0020.asl
new file mode 100644
index 0000000..ba476a6
--- /dev/null
+++ b/src/drivers/pc80/pc/ps2_controller_len0020.asl
@@ -0,0 +1,45 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; version 2 of
+ * the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+ Device (PS2K) // Keyboard
+ {
+ Name(_HID, EISAID("PNP0303"))
+ Name(_CID, EISAID("PNP030B"))
+
+ Name(_CRS, ResourceTemplate()
+ {
+ IO (Decode16, 0x60, 0x60, 0x01, 0x01)
+ IO (Decode16, 0x64, 0x64, 0x01, 0x01)
+ IRQ (Edge, ActiveHigh, Exclusive) { 0x01 } // IRQ 1
+ })
+
+ Method (_STA, 0)
+ {
+ Return (0xf)
+ }
+ }
+
+ Device (PS2M) // Mouse
+ {
+ Name(_HID, EISAID("LEN0020"))
+ Name(_CID, EISAID("PNP0F13"))
+ Name(_CRS, ResourceTemplate()
+ {
+ IRQ (Edge, ActiveHigh, Exclusive) { 0x0c } // IRQ 12
+ })
+
+ Method(_STA, 0)
+ {
+ Return (0xf)
+ }
+ }
diff --git a/src/drivers/pc80/pc/ps2_controller_len0036.asl b/src/drivers/pc80/pc/ps2_controller_len0036.asl
new file mode 100644
index 0000000..4b10381
--- /dev/null
+++ b/src/drivers/pc80/pc/ps2_controller_len0036.asl
@@ -0,0 +1,45 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; version 2 of
+ * the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+ Device (PS2K) // Keyboard
+ {
+ Name(_HID, EISAID("PNP0303"))
+ Name(_CID, EISAID("PNP030B"))
+
+ Name(_CRS, ResourceTemplate()
+ {
+ IO (Decode16, 0x60, 0x60, 0x01, 0x01)
+ IO (Decode16, 0x64, 0x64, 0x01, 0x01)
+ IRQ (Edge, ActiveHigh, Exclusive) { 0x01 } // IRQ 1
+ })
+
+ Method (_STA, 0)
+ {
+ Return (0xf)
+ }
+ }
+
+ Device (PS2M) // Mouse
+ {
+ Name(_HID, EISAID("LEN0036"))
+ Name(_CID, EISAID("PNP0F13"))
+ Name(_CRS, ResourceTemplate()
+ {
+ IRQ (Edge, ActiveHigh, Exclusive) { 0x0c } // IRQ 12
+ })
+
+ Method(_STA, 0)
+ {
+ Return (0xf)
+ }
+ }
diff --git a/src/mainboard/lenovo/t410/acpi/superio.asl b/src/mainboard/lenovo/t410/acpi/superio.asl
index f2b35ba..24afccc 100644
--- a/src/mainboard/lenovo/t410/acpi/superio.asl
+++ b/src/mainboard/lenovo/t410/acpi/superio.asl
@@ -1 +1 @@
-#include <drivers/pc80/pc/ps2_controller.asl>
+#include <drivers/pc80/pc/ps2_controller_len0015.asl>
diff --git a/src/mainboard/lenovo/t420/acpi/superio.asl b/src/mainboard/lenovo/t420/acpi/superio.asl
index f2b35ba..24afccc 100644
--- a/src/mainboard/lenovo/t420/acpi/superio.asl
+++ b/src/mainboard/lenovo/t420/acpi/superio.asl
@@ -1 +1 @@
-#include <drivers/pc80/pc/ps2_controller.asl>
+#include <drivers/pc80/pc/ps2_controller_len0015.asl>
diff --git a/src/mainboard/lenovo/t420s/acpi/superio.asl b/src/mainboard/lenovo/t420s/acpi/superio.asl
index f2b35ba..24afccc 100644
--- a/src/mainboard/lenovo/t420s/acpi/superio.asl
+++ b/src/mainboard/lenovo/t420s/acpi/superio.asl
@@ -1 +1 @@
-#include <drivers/pc80/pc/ps2_controller.asl>
+#include <drivers/pc80/pc/ps2_controller_len0015.asl>
diff --git a/src/mainboard/lenovo/t430/acpi/superio.asl b/src/mainboard/lenovo/t430/acpi/superio.asl
index 8964c36..4ba8af3 100644
--- a/src/mainboard/lenovo/t430/acpi/superio.asl
+++ b/src/mainboard/lenovo/t430/acpi/superio.asl
@@ -13,4 +13,4 @@
* GNU General Public License for more details.
*/
-#include <drivers/pc80/pc/ps2_controller.asl>
+#include <drivers/pc80/pc/ps2_controller_len0015.asl>
diff --git a/src/mainboard/lenovo/t430s/acpi/superio.asl b/src/mainboard/lenovo/t430s/acpi/superio.asl
index f2b35ba..24afccc 100644
--- a/src/mainboard/lenovo/t430s/acpi/superio.asl
+++ b/src/mainboard/lenovo/t430s/acpi/superio.asl
@@ -1 +1 @@
-#include <drivers/pc80/pc/ps2_controller.asl>
+#include <drivers/pc80/pc/ps2_controller_len0015.asl>
diff --git a/src/mainboard/lenovo/t520/acpi/superio.asl b/src/mainboard/lenovo/t520/acpi/superio.asl
index f2b35ba..24afccc 100644
--- a/src/mainboard/lenovo/t520/acpi/superio.asl
+++ b/src/mainboard/lenovo/t520/acpi/superio.asl
@@ -1 +1 @@
-#include <drivers/pc80/pc/ps2_controller.asl>
+#include <drivers/pc80/pc/ps2_controller_len0015.asl>
diff --git a/src/mainboard/lenovo/t530/acpi/superio.asl b/src/mainboard/lenovo/t530/acpi/superio.asl
index f2b35ba..24afccc 100644
--- a/src/mainboard/lenovo/t530/acpi/superio.asl
+++ b/src/mainboard/lenovo/t530/acpi/superio.asl
@@ -1 +1 @@
-#include <drivers/pc80/pc/ps2_controller.asl>
+#include <drivers/pc80/pc/ps2_controller_len0015.asl>
diff --git a/src/mainboard/lenovo/x220/acpi/superio.asl b/src/mainboard/lenovo/x220/acpi/superio.asl
index f2b35ba..069cdea 100644
--- a/src/mainboard/lenovo/x220/acpi/superio.asl
+++ b/src/mainboard/lenovo/x220/acpi/superio.asl
@@ -1 +1 @@
-#include <drivers/pc80/pc/ps2_controller.asl>
+#include <drivers/pc80/pc/ps2_controller_len0020.asl>
diff --git a/src/mainboard/lenovo/x230/acpi/superio.asl b/src/mainboard/lenovo/x230/acpi/superio.asl
index f2b35ba..069cdea 100644
--- a/src/mainboard/lenovo/x230/acpi/superio.asl
+++ b/src/mainboard/lenovo/x230/acpi/superio.asl
@@ -1 +1 @@
-#include <drivers/pc80/pc/ps2_controller.asl>
+#include <drivers/pc80/pc/ps2_controller_len0020.asl>
--
To view, visit https://review.coreboot.org/c/coreboot/+/36371
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb635da99c5e05f987aaf4f172108d788dcc2932
Gerrit-Change-Number: 36371
Gerrit-PatchSet: 1
Gerrit-Owner: DaLao <dalao(a)tutanota.com>
Gerrit-MessageType: newchange