Change in ...coreboot[master]: src/mainboard/asus/am1i-a/buildOpts.c: detailed paths to the include ...

[Mike Banon (Code Review)]

Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33914

Change subject: src/mainboard/asus/am1i-a/buildOpts.c: detailed paths to the include files
......................................................................

src/mainboard/asus/am1i-a/buildOpts.c: detailed paths to the include files

Make it clear which include files are being used, by using the detailed paths.

Signed-off-by: Mike Banon 
Change-Id: Ic096848f23910e2ad9183e44d882450ab8d4fdf1
---
M src/mainboard/asus/am1i-a/buildOpts.c
1 file changed, 15 insertions(+), 15 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/33914/1

diff --git a/src/mainboard/asus/am1i-a/buildOpts.c b/src/mainboard/asus/am1i-a/buildOpts.c
index 93d7738..b5b06d3 100644
--- a/src/mainboard/asus/am1i-a/buildOpts.c
+++ b/src/mainboard/asus/am1i-a/buildOpts.c
@@ -26,7 +26,21 @@
  */

#include <stdlib.h>
-#include <AGESA.h>
+#include <vendorcode/amd/agesa/f16kb/AGESA.h>
+
+/*  Include the files that instantiate the configuration definitions.  */
+#include <vendorcode/amd/agesa/f16kb/Include/AdvancedApi.h>
+#include <vendorcode/amd/agesa/f16kb/Include/GnbInterface.h>
+#include <vendorcode/amd/agesa/f16kb/Proc/CPU/cpuFamilyTranslation.h>
+#include <vendorcode/amd/agesa/f16kb/Proc/CPU/cpuRegisters.h>
+#include <vendorcode/amd/agesa/f16kb/Proc/CPU/Family/cpuFamRegisters.h>
+#include <vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuFeatures.h>
+#include <vendorcode/amd/agesa/f16kb/Proc/CPU/Table.h>
+#include <vendorcode/amd/agesa/f16kb/Proc/CPU/heapManager.h>
+/* AGESA nonesense: the next three headers depend on heapManager.h */
+#include <vendorcode/amd/agesa/f16kb/Proc/Common/CreateStruct.h>
+#include <vendorcode/amd/agesa/f16kb/Proc/CPU/cpuEarlyInit.h>
+#include <vendorcode/amd/agesa/f16kb/Proc/CPU/cpuLateInit.h>

#define INSTALL_FAMILY_16_MODEL_0x_SUPPORT   TRUE

@@ -232,20 +246,6 @@

#define BLDCFG_AP_MTRR_SETTINGS_LIST &KabiniApMtrrSettingsList

-
-/*  Include the files that instantiate the configuration definitions.  */
-#include "cpuRegisters.h"
-#include "cpuFamRegisters.h"
-#include "cpuFamilyTranslation.h"
-#include "AdvancedApi.h"
-#include "heapManager.h"
-#include "CreateStruct.h"
-#include "cpuFeatures.h"
-#include "Table.h"
-#include "cpuEarlyInit.h"
-#include "cpuLateInit.h"
-#include "GnbInterface.h"
-
                   // This is the delivery package title, "BrazosPI"
                   // This string MUST be exactly 8 characters long
 #define AGESA_PACKAGE_STRING  {'c', 'b', '_', 'A', 'g', 'e', 's', 'a'}

[Mike Banon (Code Review)]

Mike Banon has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/33914 )

Change subject: src/mainboard/asus/am1i-a/buildOpts.c: detailed paths to the include files
......................................................................

src/mainboard/asus/am1i-a/buildOpts.c: detailed paths to the include files

Make it clear which include files are being used, by using the detailed paths.

Signed-off-by: Mike Banon 
Change-Id: Ic096848f23910e2ad9183e44d882450ab8d4fdf1
---
M src/mainboard/asus/am1i-a/buildOpts.c
1 file changed, 16 insertions(+), 15 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/33914/2

[Mike Banon (Code Review)]

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33914 )

Change subject: src/mainboard/asus/am1i-a/buildOpts.c: detailed paths to the include files
......................................................................

Patch Set 2:

am1i-a/buildOpts.c patch series [2/8] : 1st = CB:33913 ; 2nd = CB:33914 <-- you are here ; 3rd = CB:33915 , 4th = CB:33916 , 5th = CB:33917 , 6th = CB:33918 , 7th = CB:33919 , 8th = CB:33920

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33914 )

Change subject: src/mainboard/asus/am1i-a/buildOpts.c: detailed paths to the include files
......................................................................

Patch Set 2:

not sure if this is needed 
(maybe I'm wrong, but see src/vendorcode/amd/agesa/Makefile.inc )

[Mike Banon (Code Review)]

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33914 )

Change subject: src/mainboard/asus/am1i-a/buildOpts.c: detailed paths to the include files
......................................................................

Patch Set 2:
> Patch Set 2:
>
> not sure if this is needed 
> (maybe I'm wrong, but see src/vendorcode/amd/agesa/Makefile.inc )

Perhaps indifferent to a compiler, but it could help a person to quickly find the used includes.

Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: detailed paths to the include files

[Mike Banon (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33914

to look at the new patch set (#7).

Change subject: mb/asus/am1i-a/buildOpts.c: detailed paths to the include files
......................................................................

mb/asus/am1i-a/buildOpts.c: detailed paths to the include files

Make it clear which include files are being used, by using the detailed paths.

Signed-off-by: Mike Banon 
Change-Id: Ic096848f23910e2ad9183e44d882450ab8d4fdf1
---
M src/mainboard/asus/am1i-a/buildOpts.c
1 file changed, 16 insertions(+), 15 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/33914/7

Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: detailed paths to the include files

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33914 )

Change subject: mb/asus/am1i-a/buildOpts.c: detailed paths to the include files
......................................................................

Patch Set 7: Code-Review+1

(3 comments)

https://review.coreboot.org/c/coreboot/+/33914/7//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/33914/7//COMMIT_MSG@7 
PS7, Line 7: detailed paths to the include files
Use fully-qualified paths on includes

https://review.coreboot.org/c/coreboot/+/33914/7//COMMIT_MSG@9 
PS7, Line 9: Make it clear which include files are being used, by using the detailed paths.
This makes it easier to know which files are being included.

https://review.coreboot.org/c/coreboot/+/33914/7/src/mainboard/asus/am1i-a/b... 
File src/mainboard/asus/am1i-a/buildOpts.c:

https://review.coreboot.org/c/coreboot/+/33914/7/src/mainboard/asus/am1i-a/b... 
PS7, Line 20: /*  Include the files that instantiate the configuration definitions.  */
Do these files depend on the #defines that originally preceded them?

Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: detailed paths to the include files

[Mike Banon (Code Review)]

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33914 )

Change subject: mb/asus/am1i-a/buildOpts.c: detailed paths to the include files
......................................................................

Patch Set 7:

(3 comments)

https://review.coreboot.org/c/coreboot/+/33914/7//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/33914/7//COMMIT_MSG@7 
PS7, Line 7: detailed paths to the include files
> Use fully-qualified paths on includes

Done.

https://review.coreboot.org/c/coreboot/+/33914/7//COMMIT_MSG@9 
PS7, Line 9: Make it clear which include files are being used, by using the detailed paths.
> This makes it easier to know which files are being included.

Done.

https://review.coreboot.org/c/coreboot/+/33914/7/src/mainboard/asus/am1i-a/b... 
File src/mainboard/asus/am1i-a/buildOpts.c:

https://review.coreboot.org/c/coreboot/+/33914/7/src/mainboard/asus/am1i-a/b... 
PS7, Line 20: /*  Include the files that instantiate the configuration definitions.  */
> Do these files depend on the #defines that originally preceded them?

Just checked, luckily there aren't such dependencies.

Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: Use fully-qualified paths on includes

[Mike Banon (Code Review)]

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33914

to look at the new patch set (#8).

Change subject: mb/asus/am1i-a/buildOpts.c: Use fully-qualified paths on includes
......................................................................

mb/asus/am1i-a/buildOpts.c: Use fully-qualified paths on includes

This makes it easier to know which files are being included.

Signed-off-by: Mike Banon 
Change-Id: Ic096848f23910e2ad9183e44d882450ab8d4fdf1
---
M src/mainboard/asus/am1i-a/buildOpts.c
1 file changed, 16 insertions(+), 15 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/33914/8

Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: Use fully-qualified paths on includes

[Mike Banon (Code Review)]

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33914 )

Change subject: mb/asus/am1i-a/buildOpts.c: Use fully-qualified paths on includes
......................................................................

Patch Set 8:

Same SHA256 when built with "make BUILD_TIMELESS=1"

Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: Use fully-qualified paths on includes

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33914 )

Change subject: mb/asus/am1i-a/buildOpts.c: Use fully-qualified paths on includes
......................................................................

Patch Set 8:
> Patch Set 8:
>
> Same SHA256 when built with "make BUILD_TIMELESS=1"

Alright, please mention this in the commit message:

Tested with BUILD_TIMELESS=1, hashes do not change.

Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: Use fully-qualified paths on includes

[Mike Banon (Code Review)]

Hello build bot (Jenkins), Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33914

to look at the new patch set (#10).

Change subject: mb/asus/am1i-a/buildOpts.c: Use fully-qualified paths on includes
......................................................................

mb/asus/am1i-a/buildOpts.c: Use fully-qualified paths on includes

This makes it easier to know which files are being included.
Tested with BUILD_TIMELESS=1, hashes do not change.

Signed-off-by: Mike Banon 
Change-Id: Ic096848f23910e2ad9183e44d882450ab8d4fdf1
---
M src/mainboard/asus/am1i-a/buildOpts.c
1 file changed, 16 insertions(+), 15 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/33914/10

Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: Use fully-qualified paths on includes

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33914 )

Change subject: mb/asus/am1i-a/buildOpts.c: Use fully-qualified paths on includes
......................................................................

Patch Set 10:

Pease see cpu/amd/agesa/Kconfig and cpu/amd/agesa/Makefile.inc

Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: Use fully-qualified paths on includes

[Michał Żygowski (Code Review)]

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33914 )

Change subject: mb/asus/am1i-a/buildOpts.c: Use fully-qualified paths on includes
......................................................................

Patch Set 10: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/33914/10/src/mainboard/asus/am1i-a/... 
File src/mainboard/asus/am1i-a/buildOpts.c:

https://review.coreboot.org/c/coreboot/+/33914/10/src/mainboard/asus/am1i-a/... 
PS10, Line 29: /* AGESA nonesense: the next three headers depend on heapManager.h */
Many of the headers contributes to a mess. Some of the headers use pragmas that pack the structures etc., ugh...

Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: Use fully-qualified paths on includes

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/33914 )

Change subject: mb/asus/am1i-a/buildOpts.c: Use fully-qualified paths on includes
......................................................................

mb/asus/am1i-a/buildOpts.c: Use fully-qualified paths on includes

This makes it easier to know which files are being included.
Tested with BUILD_TIMELESS=1, hashes do not change.

Signed-off-by: Mike Banon 
Change-Id: Ic096848f23910e2ad9183e44d882450ab8d4fdf1
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33914
Tested-by: build bot (Jenkins) 
Reviewed-by: Michał Żygowski 
Reviewed-by: Angel Pons 
---
M src/mainboard/asus/am1i-a/buildOpts.c
1 file changed, 16 insertions(+), 15 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, but someone else must approve
  Michał Żygowski: Looks good to me, approved

diff --git a/src/mainboard/asus/am1i-a/buildOpts.c b/src/mainboard/asus/am1i-a/buildOpts.c
index 5889592..28e502e 100644
--- a/src/mainboard/asus/am1i-a/buildOpts.c
+++ b/src/mainboard/asus/am1i-a/buildOpts.c
@@ -14,7 +14,22 @@
  */

#include <stdlib.h>
-#include <AGESA.h>
+
+#include <vendorcode/amd/agesa/f16kb/AGESA.h>
+
+/*  Include the files that instantiate the configuration definitions.  */
+#include <vendorcode/amd/agesa/f16kb/Include/AdvancedApi.h>
+#include <vendorcode/amd/agesa/f16kb/Include/GnbInterface.h>
+#include <vendorcode/amd/agesa/f16kb/Proc/CPU/cpuFamilyTranslation.h>
+#include <vendorcode/amd/agesa/f16kb/Proc/CPU/cpuRegisters.h>
+#include <vendorcode/amd/agesa/f16kb/Proc/CPU/Family/cpuFamRegisters.h>
+#include <vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuFeatures.h>
+#include <vendorcode/amd/agesa/f16kb/Proc/CPU/Table.h>
+#include <vendorcode/amd/agesa/f16kb/Proc/CPU/heapManager.h>
+/* AGESA nonesense: the next three headers depend on heapManager.h */
+#include <vendorcode/amd/agesa/f16kb/Proc/Common/CreateStruct.h>
+#include <vendorcode/amd/agesa/f16kb/Proc/CPU/cpuEarlyInit.h>
+#include <vendorcode/amd/agesa/f16kb/Proc/CPU/cpuLateInit.h>

#define INSTALL_FAMILY_16_MODEL_0x_SUPPORT   TRUE

@@ -219,20 +234,6 @@

#define BLDCFG_AP_MTRR_SETTINGS_LIST &KabiniApMtrrSettingsList

-
-/*  Include the files that instantiate the configuration definitions.  */
-#include "cpuRegisters.h"
-#include "cpuFamRegisters.h"
-#include "cpuFamilyTranslation.h"
-#include "AdvancedApi.h"
-#include "heapManager.h"
-#include "CreateStruct.h"
-#include "cpuFeatures.h"
-#include "Table.h"
-#include "cpuEarlyInit.h"
-#include "cpuLateInit.h"
-#include "GnbInterface.h"
-
                   // This is the delivery package title, "BrazosPI"
                   // This string MUST be exactly 8 characters long
 #define AGESA_PACKAGE_STRING  {'c', 'b', '_', 'A', 'g', 'e', 's', 'a'}