coreboot-gerrit October 2019

coreboot-gerrit@coreboot.org

1 participants
1921 discussions

Change in coreboot[master]: nb/intel/nehalem: Don't run graphic init on S3 resume
by Arthur Heymans (Code Review) 03 Oct '19

03 Oct '19

Hello Patrick Rudolph, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/35773 to look at the new patch set (#3). Change subject: nb/intel/nehalem: Don't run graphic init on S3 resume ...................................................................... nb/intel/nehalem: Don't run graphic init on S3 resume The assumption is made that an ACPI aware an OS does not rely on firmware to initialize the display. TESTED on a Lenovo Thinkpad X201 with Linux 5.2, display still works after S3, more than 200ms in time saved (dropped from 411ms to 182ms in total in one test). Change-Id: I36219e6d04db561d4f2ddb6e962166c598d5bc4f Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/nehalem/gma.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/35773/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/35773 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36219e6d04db561d4f2ddb6e962166c598d5bc4f Gerrit-Change-Number: 35773 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: nb/intel/nehalem: Don't run graphic init on S3 resume
by Arthur Heymans (Code Review) 03 Oct '19

03 Oct '19

Hello Patrick Rudolph, Paul Menzel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/35773 to look at the new patch set (#2). Change subject: nb/intel/nehalem: Don't run graphic init on S3 resume ...................................................................... nb/intel/nehalem: Don't run graphic init on S3 resume The assumption is made that ACPI aware an OS does not rely on firmware to initialize the display. TESTED on Thinkpda X201 with Linux 5.2, display still works after S3, more than 200ms in time saved (dropped from 411ms to 182ms in total in one test). Change-Id: I36219e6d04db561d4f2ddb6e962166c598d5bc4f Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/nehalem/gma.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/35773/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/35773 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36219e6d04db561d4f2ddb6e962166c598d5bc4f Gerrit-Change-Number: 35773 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: nb/intel/nehalem: Don't run graphic init on S3 resume
by Paul Menzel (Code Review) 03 Oct '19

03 Oct '19

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35773 ) Change subject: nb/intel/nehalem: Don't run graphic init on S3 resume ...................................................................... Patch Set 1: Code-Review+1 (3 comments) https://review.coreboot.org/c/coreboot/+/35773/1//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/35773/1//COMMIT_MSG@9 PS1, Line 9: ACPI aware an OS an ACPI aware OS https://review.coreboot.org/c/coreboot/+/35773/1//COMMIT_MSG@12 PS1, Line 12: Thinkpda Thinkpad https://review.coreboot.org/c/coreboot/+/35773/1//COMMIT_MSG@13 PS1, Line 13: more than 200ms in time saved. Woot! What is the current resume time of coreboot? -- To view, visit https://review.coreboot.org/c/coreboot/+/35773 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36219e6d04db561d4f2ddb6e962166c598d5bc4f Gerrit-Change-Number: 35773 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 03 Oct 2019 08:13:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: chromeec: PS2K node can't be under SIO node
by Patrick Georgi (Code Review) 03 Oct '19

03 Oct '19

Patrick Georgi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/27328 ) Change subject: chromeec: PS2K node can't be under SIO node ...................................................................... Abandoned was already upstreamed through CB:28386 -- To view, visit https://review.coreboot.org/c/coreboot/+/27328 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I76b1ca9bf9243ffa861bed9c356a45377e7f43ef Gerrit-Change-Number: 27328 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <reinauer(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: 3rdparty/opensbi: update to latest master
by Patrick Georgi (Code Review) 03 Oct '19

03 Oct '19

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35314 ) Change subject: 3rdparty/opensbi: update to latest master ...................................................................... 3rdparty/opensbi: update to latest master This includes various fixes to issues found by Coverity Scan. Change-Id: Ide6e3c2bb98e79750b40a9b8ca9f2f1d2c123628 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M 3rdparty/opensbi 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/35314/1 diff --git a/3rdparty/opensbi b/3rdparty/opensbi index ce228ee..98ee15c 160000 --- a/3rdparty/opensbi +++ b/3rdparty/opensbi @@ -1 +1 @@ -Subproject commit ce228ee0919deb9957192d723eecc8aaae2697c6 +Subproject commit 98ee15ca3adcf7bc22695897cd63a3ce8c5c53ff -- To view, visit https://review.coreboot.org/c/coreboot/+/35314 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ide6e3c2bb98e79750b40a9b8ca9f2f1d2c123628 Gerrit-Change-Number: 35314 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

3 5

Change in coreboot[master]: 3rdparty/vboot: update to latest master
by Patrick Georgi (Code Review) 03 Oct '19

03 Oct '19

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35315 ) Change subject: 3rdparty/vboot: update to latest master ...................................................................... 3rdparty/vboot: update to latest master This includes several fixes to issues found by Coverity Scan. Change-Id: Id7cefa3ad5b30c955d18e469494fec32f6f58a48 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M 3rdparty/vboot 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/35315/1 diff --git a/3rdparty/vboot b/3rdparty/vboot index e6700f4..5cb2e84 160000 --- a/3rdparty/vboot +++ b/3rdparty/vboot @@ -1 +1 @@ -Subproject commit e6700f4c70fe72850ae4f3f5df19c9281ebcefc8 +Subproject commit 5cb2e84a191583f0e4d01ee6077404f85531f6c7 -- To view, visit https://review.coreboot.org/c/coreboot/+/35315 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id7cefa3ad5b30c955d18e469494fec32f6f58a48 Gerrit-Change-Number: 35315 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

4 8

Change in coreboot[master]: nvramtool: Change binary install directory from sbin to bin
by Patrick Georgi (Code Review) 03 Oct '19

03 Oct '19

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/17573 ) Change subject: nvramtool: Change binary install directory from sbin to bin ...................................................................... Patch Set 3: I think we pretty much expect $(INSTALL) to be gnu, so maybe use -D instead of mkdir? -- To view, visit https://review.coreboot.org/c/coreboot/+/17573 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia5febccf07c0313ed2f1f60142fc76e9c9a4dc27 Gerrit-Change-Number: 17573 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Kocialkowski <contact(a)paulk.fr> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Kocialkowski <contact(a)paulk.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Denis 'GNUtoo' Carikli <GNUtoo(a)cyberdimension.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Comment-Date: Thu, 03 Oct 2019 04:04:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: intel/fsp_baytrail: Drop early timestamp scratchpads
by Kyösti Mälkki (Code Review) 03 Oct '19

03 Oct '19

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35731 ) Change subject: intel/fsp_baytrail: Drop early timestamp scratchpads ...................................................................... intel/fsp_baytrail: Drop early timestamp scratchpads These were unused and cryptic. Change-Id: I074294446501d49a9bd3c823a2a794c33f443168 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/soc/intel/fsp_baytrail/include/soc/pci_devs.h 1 file changed, 0 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/35731/1 diff --git a/src/soc/intel/fsp_baytrail/include/soc/pci_devs.h b/src/soc/intel/fsp_baytrail/include/soc/pci_devs.h index 5cca5ca..5d70879 100644 --- a/src/soc/intel/fsp_baytrail/include/soc/pci_devs.h +++ b/src/soc/intel/fsp_baytrail/include/soc/pci_devs.h @@ -76,10 +76,6 @@ # define SATA_BIST2 0xE8 # define SATA_DEV_FUNC PCI_DEVFN(SATA_DEV,SATA_FUNC) -#define SATA_MA_BDFO PCI_DEV(BUS0, SATA_DEV, SATA_FUNC), SATA_MA -#define SATA_SP_BDFO PCI_DEV(BUS0, SATA_DEV, SATA_FUNC), SATA_SP -#define SATA_BIST1_BDFO PCI_DEV(BUS0, SATA_DEV, SATA_FUNC), SATA_BIST1 -#define SATA_BIST2_BDFO PCI_DEV(BUS0, SATA_DEV, SATA_FUNC), SATA_BIST2 /* xHCI */ #define XHCI_DEV 0x14 @@ -157,9 +153,6 @@ # define HDA_AZUBAR 0x14 # define HDA_MMLA 0x64 # define HDA_MMUA 0x68 -#define HDA_AZUBAR_BDFO PCI_DEV(BUS0, HDA_DEV, HDA_FUNC), HDA_AZUBAR -#define HDA_MMLA_BDFO PCI_DEV(BUS0, HDA_DEV, HDA_FUNC), HDA_MMLA -#define HDA_MMUA_BDFO PCI_DEV(BUS0, HDA_DEV, HDA_FUNC), HDA_MMUA /* PCIe Ports */ #define PCIE_DEV 0x1c @@ -226,12 +219,4 @@ # define LPC_BDF PCI_DEV(0, LPC_DEV, LPC_FUNC) # define SMBUS_DEV_FUNC PCI_DEVFN(SMBUS_DEV,SMBUS_FUNC) -#define INITIAL_TIMESTAMP_LOCATION HDA_MMUA_BDFO -#define BEFORE_CAR_TIMESTAMP_LOCATION SATA_BIST1_BDFO -#define ASM_BEFORE_CAR_TSC_LOC (0x80 << 24 | SATA_DEV_FUNC << 8 | SATA_BIST1) -#define AFTER_CAR_TIMESTAMP_LOCATION SATA_BIST2_BDFO -#define ASM_AFTER_CAR_TSC_LOC (0x80 << 24 | SATA_DEV_FUNC << 8 | SATA_BIST2) -#define START_ROMSTAGE_TIMESTAMP_LOCATION HDA_MMLA_BDFO -#define BEFORE_RAMINIT_TIMESTAMP_LOCATION SATA_MA_BDFO - #endif /* _BAYTRAIL_PCI_DEVS_H_ */ -- To view, visit https://review.coreboot.org/c/coreboot/+/35731 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I074294446501d49a9bd3c823a2a794c33f443168 Gerrit-Change-Number: 35731 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newchange

4 9

Change in coreboot[master]: chromeec: PS2K node can't be under SIO node
by Stefan Reinauer (Code Review) 03 Oct '19

03 Oct '19

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27328 ) Change subject: chromeec: PS2K node can't be under SIO node ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/27328 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I76b1ca9bf9243ffa861bed9c356a45377e7f43ef Gerrit-Change-Number: 27328 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <reinauer(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Oct 2019 02:44:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Add proposal for a comprehensive image assembly stage
by Stefan Reinauer (Code Review) 03 Oct '19

03 Oct '19

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32687 ) Change subject: Documentation: Add proposal for a comprehensive image assembly stage ...................................................................... Patch Set 1: Code-Review+2 This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/32687 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib40d286e2c9b817f55e58ecc5c9bc8b832ac5783 Gerrit-Change-Number: 32687 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Thu, 03 Oct 2019 02:41:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2019