coreboot-gerrit October 2019

coreboot-gerrit@coreboot.org

1 participants
1921 discussions

Change in libgfxinit[master]: [TEST]Transcoder setup: Increase timeout on PIPExCONF status read
by Arthur Heymans (Code Review) 13 Oct '19

13 Oct '19

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/libgfxinit/+/21066 ) Change subject: [TEST]Transcoder setup: Increase timeout on PIPExCONF status read ...................................................................... Abandoned Might resume this later, but abandoning for now. It didn't fix anything iirc. -- To view, visit https://review.coreboot.org/c/libgfxinit/+/21066 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-Change-Id: Ia670e18cd2bfd6d7aee99c980b89d2747c3b21df Gerrit-Change-Number: 21066 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: payload/external/Linux: capitalize directory
by Marcello Sylvester Bauer (Code Review) 13 Oct '19

13 Oct '19

Marcello Sylvester Bauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/29512 ) Change subject: payload/external/Linux: capitalize directory ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/29512 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaae8dbde30028355c2f0194cf309abb565c4be54 Gerrit-Change-Number: 29512 Gerrit-PatchSet: 2 Gerrit-Owner: Marcello Sylvester Bauer <sylvblck(a)sylv.io> Gerrit-Assignee: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Marcello Sylvester Bauer <sylvblck(a)sylv.io> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: arch/x86/Kconfig: move MAX_REBOOT_CNT option
by Marcello Sylvester Bauer (Code Review) 13 Oct '19

13 Oct '19

Marcello Sylvester Bauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/29979 ) Change subject: arch/x86/Kconfig: move MAX_REBOOT_CNT option ...................................................................... Abandoned not relevant anymore -- To view, visit https://review.coreboot.org/c/coreboot/+/29979 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice26e2ef349f1172b564edc14f1012c33546a93c Gerrit-Change-Number: 29979 Gerrit-PatchSet: 2 Gerrit-Owner: Marcello Sylvester Bauer <sylvblck(a)sylv.io> Gerrit-Reviewer: Marcello Sylvester Bauer <sylvblck(a)sylv.io> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: superio/common: Remove unused include 'pnp_def.h'
by HAOUAS Elyes (Code Review) 13 Oct '19

13 Oct '19

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35987 ) Change subject: superio/common: Remove unused include 'pnp_def.h' ...................................................................... superio/common: Remove unused include 'pnp_def.h' Change-Id: I2d0b3d73d646fc43f2562aa5af2358398eaf28b0 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/superio/common/generic.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/35987/1 diff --git a/src/superio/common/generic.c b/src/superio/common/generic.c index 76122a1..429ee51 100644 --- a/src/superio/common/generic.c +++ b/src/superio/common/generic.c @@ -15,7 +15,6 @@ #include <device/device.h> #include <device/pnp.h> #include <arch/acpigen.h> -#include <device/pnp_def.h> #include <console/console.h> static void generic_set_resources(struct device *dev) -- To view, visit https://review.coreboot.org/c/coreboot/+/35987 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d0b3d73d646fc43f2562aa5af2358398eaf28b0 Gerrit-Change-Number: 35987 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

2 2

Change in coreboot[master]: mb/hp/z220_sff_workstation: Remove unused include 'pnp_def.h'
by HAOUAS Elyes (Code Review) 13 Oct '19

13 Oct '19

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35986 ) Change subject: mb/hp/z220_sff_workstation: Remove unused include 'pnp_def.h' ...................................................................... mb/hp/z220_sff_workstation: Remove unused include 'pnp_def.h' Change-Id: Id8e25caf2868c37c9d7c7717dd908152dfc583a3 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/hp/z220_sff_workstation/romstage.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/35986/1 diff --git a/src/mainboard/hp/z220_sff_workstation/romstage.c b/src/mainboard/hp/z220_sff_workstation/romstage.c index 9883879..0a73694 100644 --- a/src/mainboard/hp/z220_sff_workstation/romstage.c +++ b/src/mainboard/hp/z220_sff_workstation/romstage.c @@ -20,7 +20,6 @@ #include <arch/io.h> #include <device/pci_ops.h> #include <device/pci_def.h> -#include <device/pnp_def.h> #include <superio/nuvoton/npcd378/npcd378.h> #include <superio/nuvoton/common/nuvoton.h> #include <northbridge/intel/sandybridge/sandybridge.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/35986 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id8e25caf2868c37c9d7c7717dd908152dfc583a3 Gerrit-Change-Number: 35986 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

2 2

Change in coreboot[master]: cpu/intel/core2: Cache XIP romstage with C_ENVIRONMENT_BOOTBLOCK.
by Arthur Heymans (Code Review) 13 Oct '19

13 Oct '19

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/35994 to look at the new patch set (#10). Change subject: cpu/intel/core2: Cache XIP romstage with C_ENVIRONMENT_BOOTBLOCK. ...................................................................... cpu/intel/core2: Cache XIP romstage with C_ENVIRONMENT_BOOTBLOCK. Tested on Thinkpad X200: the romstage execution speeds are back to pre-C_ENVIRONMENT_BOOTBLOCK levels. Change-Id: Id0b50d2f56e7cc0e055cdc8b9aa28794327eca28 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/intel/model_1067x/Kconfig M src/cpu/intel/model_6fx/Kconfig 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/35994/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/35994 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0b50d2f56e7cc0e055cdc8b9aa28794327eca28 Gerrit-Change-Number: 35994 Gerrit-PatchSet: 10 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: nb/intel/gm45: Don't run graphics init on s3 resume
by Nico Huber (Code Review) 13 Oct '19

13 Oct '19

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35995 ) Change subject: nb/intel/gm45: Don't run graphics init on s3 resume ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/35995 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2dcd399fee8e2d1cd1b70e60e1669a49c7aa8cb4 Gerrit-Change-Number: 35995 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 13 Oct 2019 13:14:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/intel/core2: Cache XIP romstage with C_ENVIRONMENT_BOOTBLOCK.
by build bot (Jenkins) (Code Review) 13 Oct '19

13 Oct '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35994 ) Change subject: cpu/intel/core2: Cache XIP romstage with C_ENVIRONMENT_BOOTBLOCK. ...................................................................... Patch Set 9: (1 comment) https://review.coreboot.org/c/coreboot/+/35994/9/src/cpu/x86/mtrr/xip_cache… File src/cpu/x86/mtrr/xip_cache.c: https://review.coreboot.org/c/coreboot/+/35994/9/src/cpu/x86/mtrr/xip_cache… PS9, Line 58: if (end < ALIGN_UP(base, mtrr_mask_size) && trailing statements should be on next line -- To view, visit https://review.coreboot.org/c/coreboot/+/35994 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0b50d2f56e7cc0e055cdc8b9aa28794327eca28 Gerrit-Change-Number: 35994 Gerrit-PatchSet: 9 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 13 Oct 2019 13:12:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/intel/core2: Cache XIP romstage with C_ENVIRONMENT_BOOTBLOCK.
by build bot (Jenkins) (Code Review) 13 Oct '19

13 Oct '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35994 ) Change subject: cpu/intel/core2: Cache XIP romstage with C_ENVIRONMENT_BOOTBLOCK. ...................................................................... Patch Set 7: (1 comment) https://review.coreboot.org/c/coreboot/+/35994/7/src/cpu/x86/mtrr/xip_cache… File src/cpu/x86/mtrr/xip_cache.c: https://review.coreboot.org/c/coreboot/+/35994/7/src/cpu/x86/mtrr/xip_cache… PS7, Line 58: if (end < ALIGN_UP(base, mtrr_mask_size) && trailing statements should be on next line -- To view, visit https://review.coreboot.org/c/coreboot/+/35994 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0b50d2f56e7cc0e055cdc8b9aa28794327eca28 Gerrit-Change-Number: 35994 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 13 Oct 2019 12:50:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/intel/core2: Cache XIP romstage with C_ENVIRONMENT_BOOTBLOCK.
by Arthur Heymans (Code Review) 13 Oct '19

13 Oct '19

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/35994 to look at the new patch set (#7). Change subject: cpu/intel/core2: Cache XIP romstage with C_ENVIRONMENT_BOOTBLOCK. ...................................................................... cpu/intel/core2: Cache XIP romstage with C_ENVIRONMENT_BOOTBLOCK. Tested on Thinkpad X200: the romstage execution speeds are back to pre-C_ENVIRONMENT_BOOTBLOCK levels. Change-Id: Id0b50d2f56e7cc0e055cdc8b9aa28794327eca28 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/intel/model_1067x/Kconfig M src/cpu/intel/model_6fx/Kconfig M src/cpu/x86/mtrr/xip_cache.c 3 files changed, 10 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/35994/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/35994 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0b50d2f56e7cc0e055cdc8b9aa28794327eca28 Gerrit-Change-Number: 35994 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2019