coreboot-gerrit October 2019

coreboot-gerrit@coreboot.org

1 participants
1921 discussions

Change in coreboot[master]: postcar: Fix linking error with disabled postcar console
by Patrick Rudolph (Code Review) 16 Oct '19

16 Oct '19

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36053 ) Change subject: postcar: Fix linking error with disabled postcar console ...................................................................... postcar: Fix linking error with disabled postcar console Link files to provide snprintf used by VBOOT code. Change-Id: I040c3952c22893da5aae11b20a618aa4006c6c58 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/console/Makefile.inc 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/36053/1 diff --git a/src/console/Makefile.inc b/src/console/Makefile.inc index 3311849..2154eb9 100644 --- a/src/console/Makefile.inc +++ b/src/console/Makefile.inc @@ -23,7 +23,8 @@ romstage-y += post.c romstage-y += die.c -postcar-$(CONFIG_POSTCAR_CONSOLE) += vtxprintf.c printk.c vsprintf.c +postcar-y += vtxprintf.c vsprintf.c +postcar-$(CONFIG_POSTCAR_CONSOLE) += printk.c postcar-$(CONFIG_POSTCAR_CONSOLE) += init.c console.c postcar-y += post.c postcar-y += die.c -- To view, visit https://review.coreboot.org/c/coreboot/+/36053 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I040c3952c22893da5aae11b20a618aa4006c6c58 Gerrit-Change-Number: 36053 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: newchange

4 3

Change in coreboot[master]: mb/lenovo/x201: Add VBOOT support
by Patrick Rudolph (Code Review) 16 Oct '19

16 Oct '19

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35959 ) Change subject: mb/lenovo/x201: Add VBOOT support ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/35959 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d524988e991457032f63a947606d1b3581de5e7 Gerrit-Change-Number: 35959 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 16 Oct 2019 10:34:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8183: Adjust DRAM voltages for each DRAM frequency
by Yu-Ping Wu (Code Review) 16 Oct '19

16 Oct '19

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35017 ) Change subject: soc/mediatek/mt8183: Adjust DRAM voltages for each DRAM frequency ...................................................................... Patch Set 15: (1 comment) https://review.coreboot.org/c/coreboot/+/35017/11/src/soc/mediatek/mt8183/e… File src/soc/mediatek/mt8183/emi.c: https://review.coreboot.org/c/coreboot/+/35017/11/src/soc/mediatek/mt8183/e… PS11, Line 51: enum { > (or delete this enum since only VCORE is needed? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/35017 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9539473ff708f9d0d39eb17bd3fdcb916265d33e Gerrit-Change-Number: 35017 Gerrit-PatchSet: 15 Gerrit-Owner: huayang duan <huayangduan(a)gmail.com> Gerrit-Reviewer: Huayang Duan <huayang.duan(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: hsin-hsiung wang <hsin-hsiung.wang(a)mediatek.com> Gerrit-Reviewer: huayang duan <huayangduan(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Wed, 16 Oct 2019 09:27:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8183: Adjust DRAM voltages for each DRAM frequency
by Yu-Ping Wu (Code Review) 16 Oct '19

16 Oct '19

Yu-Ping Wu has uploaded a new patch set (#15) to the change originally created by huayang duan. ( https://review.coreboot.org/c/coreboot/+/35017 ) Change subject: soc/mediatek/mt8183: Adjust DRAM voltages for each DRAM frequency ...................................................................... soc/mediatek/mt8183: Adjust DRAM voltages for each DRAM frequency This patch supports voltage adjustment for each DRAM frequency, which is neccesary to support DVFS switch. BUG=b:80501386,b:142358843 BRANCH=none TEST=Boots correctly and stress test pass on Kukui. Change-Id: I9539473ff708f9d0d39eb17bd3fdcb916265d33e Signed-off-by: Huayang Duan <huayang.duan(a)mediatek.com> --- M src/soc/mediatek/mt8183/emi.c 1 file changed, 44 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/35017/15 -- To view, visit https://review.coreboot.org/c/coreboot/+/35017 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9539473ff708f9d0d39eb17bd3fdcb916265d33e Gerrit-Change-Number: 35017 Gerrit-PatchSet: 15 Gerrit-Owner: huayang duan <huayangduan(a)gmail.com> Gerrit-Reviewer: Huayang Duan <huayang.duan(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: hsin-hsiung wang <hsin-hsiung.wang(a)mediatek.com> Gerrit-Reviewer: huayang duan <huayangduan(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Documentation/mainboard/facebook: Add rev 1.3
by Wim Vervoorn (Code Review) 16 Oct '19

16 Oct '19

Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35955 ) Change subject: Documentation/mainboard/facebook: Add rev 1.3 ...................................................................... Patch Set 2: (2 comments) Paul, addressed your comments. https://review.coreboot.org/c/coreboot/+/35955/1//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/35955/1//COMMIT_MSG@9 PS1, Line 9: Added > Add Done https://review.coreboot.org/c/coreboot/+/35955/1//COMMIT_MSG@12 PS1, Line 12: > Please fix typos in separate commits in the future. Will do that in the future. -- To view, visit https://review.coreboot.org/c/coreboot/+/35955 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaba6f28368e2e4ca412122b5fa28ed93c705f4df Gerrit-Change-Number: 35955 Gerrit-PatchSet: 2 Gerrit-Owner: Wim Vervoorn Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Wim Vervoorn Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 16 Oct 2019 09:06:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation/mainboard/facebook: Add rev 1.3
by Wim Vervoorn (Code Review) 16 Oct '19

16 Oct '19

Hello Frans Hendriks, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/35955 to look at the new patch set (#2). Change subject: Documentation/mainboard/facebook: Add rev 1.3 ...................................................................... Documentation/mainboard/facebook: Add rev 1.3 Add rev 1.3 of the fbg1701 board. This adds Kingston memory. BUG=none TEST=none Change-Id: Iaba6f28368e2e4ca412122b5fa28ed93c705f4df Signed-off-by: Wim Vervoorn <wvervoorn(a)eltan.com> --- M Documentation/mainboard/facebook/fbg1701.md 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/35955/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/35955 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaba6f28368e2e4ca412122b5fa28ed93c705f4df Gerrit-Change-Number: 35955 Gerrit-PatchSet: 2 Gerrit-Owner: Wim Vervoorn Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Wim Vervoorn Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/mediatek/mt8183: Adjust DRAM voltages for each DRAM frequency
by Yu-Ping Wu (Code Review) 16 Oct '19

16 Oct '19

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35017 ) Change subject: soc/mediatek/mt8183: Adjust DRAM voltages for each DRAM frequency ...................................................................... Patch Set 14: (2 comments) https://review.coreboot.org/c/coreboot/+/35017/2/src/soc/mediatek/mt8183/em… File src/soc/mediatek/mt8183/emi.c: https://review.coreboot.org/c/coreboot/+/35017/2/src/soc/mediatek/mt8183/em… PS2, Line 389: #if DUAL_FREQ_K > Can you implement this without preprocessor statements? Done https://review.coreboot.org/c/coreboot/+/35017/5/src/soc/mediatek/mt8183/em… File src/soc/mediatek/mt8183/emi.c: https://review.coreboot.org/c/coreboot/+/35017/5/src/soc/mediatek/mt8183/em… PS5, Line 47: voltage_LP4X > Use lower case variable names. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/35017 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9539473ff708f9d0d39eb17bd3fdcb916265d33e Gerrit-Change-Number: 35017 Gerrit-PatchSet: 14 Gerrit-Owner: huayang duan <huayangduan(a)gmail.com> Gerrit-Reviewer: Huayang Duan <huayang.duan(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: hsin-hsiung wang <hsin-hsiung.wang(a)mediatek.com> Gerrit-Reviewer: huayang duan <huayangduan(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Wed, 16 Oct 2019 08:59:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8183: Adjust DRAM voltages for each DRAM frequency
by Hung-Te Lin (Code Review) 16 Oct '19

16 Oct '19

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35017 ) Change subject: soc/mediatek/mt8183: Adjust DRAM voltages for each DRAM frequency ...................................................................... Patch Set 14: -Code-Review (4 comments) https://review.coreboot.org/c/coreboot/+/35017/11/src/soc/mediatek/mt8183/e… File src/soc/mediatek/mt8183/emi.c: https://review.coreboot.org/c/coreboot/+/35017/11/src/soc/mediatek/mt8183/e… PS11, Line 51: enum { > Rather than this and a raw uint array, please define a struct with three members. (or delete this enum since only VCORE is needed? https://review.coreboot.org/c/coreboot/+/35017/11/src/soc/mediatek/mt8183/e… PS11, Line 59: 1125000, 600000 > If the latter two values are always constant, do they really need to be in here? Agree with Julius - can we delete them? https://review.coreboot.org/c/coreboot/+/35017/11/src/soc/mediatek/mt8183/e… PS11, Line 400: #if DUAL_FREQ_K > This seems to be like a very complicated way to write […] Ack https://review.coreboot.org/c/coreboot/+/35017/11/src/soc/mediatek/mt8183/i… File src/soc/mediatek/mt8183/include/soc/dramc_pi_api.h: https://review.coreboot.org/c/coreboot/+/35017/11/src/soc/mediatek/mt8183/i… PS11, Line 41: #define DUAL_FREQ_K 0 > What is this? If you want configurable code paths, use Kconfig. Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/35017 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9539473ff708f9d0d39eb17bd3fdcb916265d33e Gerrit-Change-Number: 35017 Gerrit-PatchSet: 14 Gerrit-Owner: huayang duan <huayangduan(a)gmail.com> Gerrit-Reviewer: Huayang Duan <huayang.duan(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: hsin-hsiung wang <hsin-hsiung.wang(a)mediatek.com> Gerrit-Reviewer: huayang duan <huayangduan(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Wed, 16 Oct 2019 08:56:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8183: Adjust DRAM voltages for each DRAM frequency
by Hung-Te Lin (Code Review) 16 Oct '19

16 Oct '19

1 0

Change in coreboot[master]: soc/mediatek/mt8183: Adjust DRAM voltages for each DRAM frequency
by Yu-Ping Wu (Code Review) 16 Oct '19

16 Oct '19

Yu-Ping Wu has uploaded a new patch set (#14) to the change originally created by huayang duan. ( https://review.coreboot.org/c/coreboot/+/35017 ) Change subject: soc/mediatek/mt8183: Adjust DRAM voltages for each DRAM frequency ...................................................................... soc/mediatek/mt8183: Adjust DRAM voltages for each DRAM frequency This patch supports voltage adjustment for each DRAM frequency, which is neccesary to support DVFS switch. BUG=b:80501386,b:142358843 BRANCH=none TEST=Boots correctly and stress test pass on Kukui. Change-Id: I9539473ff708f9d0d39eb17bd3fdcb916265d33e Signed-off-by: Huayang Duan <huayang.duan(a)mediatek.com> --- M src/soc/mediatek/mt8183/emi.c 1 file changed, 31 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/35017/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/35017 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9539473ff708f9d0d39eb17bd3fdcb916265d33e Gerrit-Change-Number: 35017 Gerrit-PatchSet: 14 Gerrit-Owner: huayang duan <huayangduan(a)gmail.com> Gerrit-Reviewer: Huayang Duan <huayang.duan(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: hsin-hsiung wang <hsin-hsiung.wang(a)mediatek.com> Gerrit-Reviewer: huayang duan <huayangduan(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2019