coreboot-gerrit January 2019

coreboot-gerrit@coreboot.org

1 participants
1296 discussions

Change in ...coreboot[master]: soc/intel/braswell: Add C_ENVIRONMENT_BOOTBLOCK support
by Frans Hendriks (Code Review) 11 Jan '19

11 Jan '19

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29662 ) Change subject: soc/intel/braswell: Add C_ENVIRONMENT_BOOTBLOCK support ...................................................................... Patch Set 7: > Patch Set 7: Code-Review-2 > > (1 comment) > > select C_ENVIRONMENT_BOOTBLOCK is the braswell Kconfig and drop the romcc bootblock option and add console init in the bootblock. > Also drop things that get unused in drivers/intel/fsp1_1 > This patch is not even build tested... This patch is to support C_ENVIRONMENT_BOOTBLOCK for Braswell. To be backward compatible this support has made optional. This patch has been build and tested. I will check if I made mistake by uploading. Can you clarify your comment? -- To view, visit https://review.coreboot.org/c/coreboot/+/29662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab48ad72f1514c93f20d70db5ef4fd8fa2383e8c Gerrit-Change-Number: 29662 Gerrit-PatchSet: 7 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com> Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: York Yang <york.yang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Fri, 11 Jan 2019 14:56:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: util/crossgcc: derive date and version from latest commit
by Patrick Georgi (Code Review) 11 Jan '19

11 Jan '19

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30804 Change subject: util/crossgcc: derive date and version from latest commit ...................................................................... util/crossgcc: derive date and version from latest commit This way date and version are automatically updated when util/crossgcc was changed, the version contains the commit ID and we have less churn on these variables. Change-Id: I475ba9578a8bb421d7c342d2569d7de7fcf4161d Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/crossgcc/buildgcc 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/30804/1 diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 3828d12..2d40f35 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -30,8 +30,8 @@ cd "$(dirname "$0")" || exit 1 -CROSSGCC_DATE="January 9th, 2019" -CROSSGCC_VERSION="1.56" +CROSSGCC_DATE="$(git log -n 1 --pretty=%ad .)" +CROSSGCC_VERSION="$(git describe $(git log -n 1 --pretty=%h .))" CROSSGCC_COMMIT=$( git describe ) # default settings -- To view, visit https://review.coreboot.org/c/coreboot/+/30804 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I475ba9578a8bb421d7c342d2569d7de7fcf4161d Gerrit-Change-Number: 30804 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

1 1

Change in ...coreboot[master]: Revert "cpu/amd: Use `get_option()`"
by Paul Menzel (Code Review) 11 Jan '19

11 Jan '19

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30830 Change subject: Revert "cpu/amd: Use `get_option()`" ...................................................................... Revert "cpu/amd: Use `get_option()`" This reverts commit 6fffd70435084fb1d3237fcb1a11f11849721e8f. Doing more tests on the Asus KGPE-D16, it seems to cause a reboot loop quite often. Therefore, revert the commit. The problem might be caused by the spinlocks used by `get_option()`, and which are not used by `read_option()`. Change-Id: Ic25129aa71c8e8e40a65bb2658de78005766fea8 Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> --- M src/cpu/amd/family_10h-family_15h/init_cpus.c 1 file changed, 6 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/30830/1 diff --git a/src/cpu/amd/family_10h-family_15h/init_cpus.c b/src/cpu/amd/family_10h-family_15h/init_cpus.c index b8e11e4..2ddbc43 100644 --- a/src/cpu/amd/family_10h-family_15h/init_cpus.c +++ b/src/cpu/amd/family_10h-family_15h/init_cpus.c @@ -147,9 +147,6 @@ // here assume the OS don't change our apicid u32 ap_apicid; - u8 nvram; - bool multicore; - u32 nodes; u32 disable_siblings; u32 cores_found; @@ -158,13 +155,12 @@ /* get_nodes define in ht_wrapper.c */ nodes = get_nodes(); - multicore = true; - if (get_option(&nvram, "multi_core") == CB_SUCCESS) - multicore = !!nvram; - - disable_siblings = 0; - if (!IS_ENABLED(CONFIG_LOGICAL_CPUS) || !multicore) + if (!IS_ENABLED(CONFIG_LOGICAL_CPUS) || + read_option(multi_core, 0) != 0) { // 0 means multi core disable_siblings = 1; + } else { + disable_siblings = 0; + } for (i = 0; i < nodes; i++) { if ((node >= 0) && (i != node)) @@ -639,17 +635,11 @@ //it is running on core0 of node0 void start_other_cores(uint32_t bsp_apicid) { - u8 nvram; u32 nodes; u32 nodeid; - bool multicore; // disable multi_core - multicore = true; - if (get_option(&nvram, "multi_core") == CB_SUCCESS) - multicore = !!nvram; - - if (!multicore) { + if (read_option(multi_core, 0) != 0) { printk(BIOS_DEBUG, "Skip additional core init\n"); return; } -- To view, visit https://review.coreboot.org/c/coreboot/+/30830 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic25129aa71c8e8e40a65bb2658de78005766fea8 Gerrit-Change-Number: 30830 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newchange

2 1

Change in ...coreboot[master]: soc/intel/braswell: Add C_ENVIRONMENT_BOOTBLOCK support
by Frans Hendriks (Code Review) 11 Jan '19

11 Jan '19

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29662 ) Change subject: soc/intel/braswell: Add C_ENVIRONMENT_BOOTBLOCK support ...................................................................... Patch Set 7: (1 comment) https://review.coreboot.org/#/c/29662/7/src/soc/intel/braswell/Makefile.inc File src/soc/intel/braswell/Makefile.inc: https://review.coreboot.org/#/c/29662/7/src/soc/intel/braswell/Makefile.inc… PS7, Line 29: $(CONFIG_C_ENVIRONMENT_BOOTBLOCK) > any reason to not link it inconditionally. To avoid conflicts with boards have C_ENVIRONMENT_BOOTBLOCK disabled. Might create duplicate labels/functions. -- To view, visit https://review.coreboot.org/c/coreboot/+/29662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab48ad72f1514c93f20d70db5ef4fd8fa2383e8c Gerrit-Change-Number: 29662 Gerrit-PatchSet: 7 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com> Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: York Yang <york.yang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Fri, 11 Jan 2019 14:28:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: lenovo/x230: introduce FHD variant
by Felix Held (Code Review) 11 Jan '19

11 Jan '19

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... Patch Set 4: Code-Review+1 looks good to me, but should be tested before it gets merged -- To view, visit https://review.coreboot.org/c/coreboot/+/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 4 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kilian Neuner <cb(a)9-r.net> Gerrit-CC: Richard Slindee Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com> Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com> Gerrit-Comment-Date: Fri, 11 Jan 2019 14:27:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: util/superiotool: Add ITE8528
by Felix Held (Code Review) 11 Jan '19

11 Jan '19

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30801 ) Change subject: util/superiotool: Add ITE8528 ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/#/c/30801/4/util/superiotool/ite.c File util/superiotool/ite.c: https://review.coreboot.org/#/c/30801/4/util/superiotool/ite.c@302 PS4, Line 302: {0x00,0x00,0x00,0x00,0x00,0x0C,0x01,EOT}}, > It does not have IO 60/64 as default? it's in the keyboard ldn (6) -- To view, visit https://review.coreboot.org/c/coreboot/+/30801 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I24b12c0032157a4959336f8b51dadbe7b2e09d66 Gerrit-Change-Number: 30801 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Fri, 11 Jan 2019 14:25:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: console/Kconfig: Fix dependency of FIXED_UART_FOR_CONSOLE
by Nico Huber (Code Review) 11 Jan '19

11 Jan '19

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30829 Change subject: console/Kconfig: Fix dependency of FIXED_UART_FOR_CONSOLE ...................................................................... console/Kconfig: Fix dependency of FIXED_UART_FOR_CONSOLE The Kconfig declaration for FIXED_UART_FOR_CONSOLE was accidentally placed inside an `if CONSOLE_SERIAL` in a96e66a (soc/intel: Clean mess around UART_DEBUG). TEST=Start a clean config, select intel/leafhill and disable serial console. Confirm that config can be saved without error. Change-Id: Ie41687e91af11a13697cbe25938dada2c74b40fb Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/console/Kconfig 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/30829/1 diff --git a/src/console/Kconfig b/src/console/Kconfig index 3db7005..9cacab0 100644 --- a/src/console/Kconfig +++ b/src/console/Kconfig @@ -37,6 +37,13 @@ shown on the following menu line. Supporting multiple different types of UARTs in one build is not supported. +config FIXED_UART_FOR_CONSOLE + bool + help + Select to remove the prompt from UART_FOR_CONSOLE in case a + specific UART has to be used (e.g. when the platform code + performs dangerous configurations). + if CONSOLE_SERIAL comment "I/O mapped, 8250-compatible" @@ -48,13 +55,6 @@ comment "device-specific UART" depends on HAVE_UART_SPECIAL -config FIXED_UART_FOR_CONSOLE - bool - help - Select to remove the prompt from UART_FOR_CONSOLE in case a - specific UART has to be used (e.g. when the platform code - performs dangerous configurations). - config UART_FOR_CONSOLE int prompt "Index for UART port to use for console" if !FIXED_UART_FOR_CONSOLE -- To view, visit https://review.coreboot.org/c/coreboot/+/30829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie41687e91af11a13697cbe25938dada2c74b40fb Gerrit-Change-Number: 30829 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: soc/intel/fsp_broadwell_de: Drop MICROCODE_BLOB_NOT_HOOKED_UP
by Nico Huber (Code Review) 10 Jan '19

10 Jan '19

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30812 Change subject: soc/intel/fsp_broadwell_de: Drop MICROCODE_BLOB_NOT_HOOKED_UP ...................................................................... soc/intel/fsp_broadwell_de: Drop MICROCODE_BLOB_NOT_HOOKED_UP It's been hooked up in the meantime. Change-Id: I64176b09e375034189000ea4308c58771f0019a1 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M src/soc/intel/fsp_broadwell_de/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/30812/1 diff --git a/src/soc/intel/fsp_broadwell_de/Kconfig b/src/soc/intel/fsp_broadwell_de/Kconfig index 051cd42..197e365 100644 --- a/src/soc/intel/fsp_broadwell_de/Kconfig +++ b/src/soc/intel/fsp_broadwell_de/Kconfig @@ -20,7 +20,6 @@ select IOAPIC select UDELAY_TSC select SUPPORT_CPU_UCODE_IN_CBFS - select MICROCODE_BLOB_NOT_HOOKED_UP # Microcode header files are delivered in FSP package select USES_MICROCODE_HEADER_FILES if HAVE_FSP_BIN select INTEL_DESCRIPTOR_MODE_CAPABLE -- To view, visit https://review.coreboot.org/c/coreboot/+/30812 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64176b09e375034189000ea4308c58771f0019a1 Gerrit-Change-Number: 30812 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: soc/intel/cannonlake: complete rename of TCO2_STS_SECOND_TO
by Patrick Georgi (Code Review) 10 Jan '19

10 Jan '19

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30805 Change subject: soc/intel/cannonlake: complete rename of TCO2_STS_SECOND_TO ...................................................................... soc/intel/cannonlake: complete rename of TCO2_STS_SECOND_TO TCO2_STS_SECOND_TO was renamed to TCO_STS_SECOND_TO but one use slipped through. Change-Id: I9e3b1cc5cb2f319db35416edf6cea612d755d40a Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M src/soc/intel/cannonlake/elog.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/30805/1 diff --git a/src/soc/intel/cannonlake/elog.c b/src/soc/intel/cannonlake/elog.c index e669772..e5541e3 100644 --- a/src/soc/intel/cannonlake/elog.c +++ b/src/soc/intel/cannonlake/elog.c @@ -85,7 +85,7 @@ /* TCO Timeout */ if (ps->prev_sleep_state != ACPI_S3 && - ps->tco2_sts & TCO2_STS_SECOND_TO) + ps->tco2_sts & TCO_STS_SECOND_TO) elog_add_event(ELOG_TYPE_TCO_RESET); /* Power Button Override */ -- To view, visit https://review.coreboot.org/c/coreboot/+/30805 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9e3b1cc5cb2f319db35416edf6cea612d755d40a Gerrit-Change-Number: 30805 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: without message
by junaid (Code Review) 10 Jan '19

10 Jan '19

junaid has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30797 Change subject: without message ...................................................................... without message Change-Id: I07e674b04fe85aa5b29bc36169edb7083e47fa50 Signed-off-by: junaid <junaidimpex(a)gmail.com> --- M COPYING 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/30797/1 diff --git a/COPYING b/COPYING index d511905..37128d2 100644 --- a/COPYING +++ b/COPYING @@ -1,4 +1,4 @@ - GNU GENERAL PUBLIC LICENSE + GNU2 GENERAL PUBLIC LICENSE Version 2, June 1991 Copyright (C) 1989, 1991 Free Software Foundation, Inc., -- To view, visit https://review.coreboot.org/c/coreboot/+/30797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I07e674b04fe85aa5b29bc36169edb7083e47fa50 Gerrit-Change-Number: 30797 Gerrit-PatchSet: 1 Gerrit-Owner: junaid <junaidimpex(a)gmail.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2019