coreboot-gerrit January 2019

coreboot-gerrit@coreboot.org

1 participants
1296 discussions

Change in ...coreboot[master]: google/butterfly: correct northbridge selection
by Matt DeVillier (Code Review) 13 Jan '19

13 Jan '19

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30820 Change subject: google/butterfly: correct northbridge selection ...................................................................... google/butterfly: correct northbridge selection butterfly is a Sandybridge device, and selecting Ivybridge breaks libgfxinit currently due to CPI mismatch Test: build/boot butterfly w/libgfxinit Change-Id: I1a7f5a3681d21a256834b11b545855c4365f5f78 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/butterfly/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/30820/1 diff --git a/src/mainboard/google/butterfly/Kconfig b/src/mainboard/google/butterfly/Kconfig index dc4b968..6b60d5f 100644 --- a/src/mainboard/google/butterfly/Kconfig +++ b/src/mainboard/google/butterfly/Kconfig @@ -4,7 +4,7 @@ def_bool y select SYSTEM_TYPE_LAPTOP select CPU_INTEL_SOCKET_RPGA989 - select NORTHBRIDGE_INTEL_IVYBRIDGE + select NORTHBRIDGE_INTEL_SANDYBRIDGE select SOUTHBRIDGE_INTEL_C216 select EC_QUANTA_ENE_KB3940Q select BOARD_ROMSIZE_KB_8192 -- To view, visit https://review.coreboot.org/c/coreboot/+/30820 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1a7f5a3681d21a256834b11b545855c4365f5f78 Gerrit-Change-Number: 30820 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newchange

1 1

Change in ...coreboot[master]: google/butterfly: add cpu/gpu pwm backlight register values
by Matt DeVillier (Code Review) 13 Jan '19

13 Jan '19

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30819 Change subject: google/butterfly: add cpu/gpu pwm backlight register values ...................................................................... google/butterfly: add cpu/gpu pwm backlight register values Required for functional internal display on lumpy using libgfxinit. Test: boot/build butterfly, verify internal display functional prior to OS driver loading. Change-Id: Ib8060f2d1ad0694f0886d35c83763907f61b47b1 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/butterfly/devicetree.cb 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/30819/1 diff --git a/src/mainboard/google/butterfly/devicetree.cb b/src/mainboard/google/butterfly/devicetree.cb index 692414c..8f88c24 100644 --- a/src/mainboard/google/butterfly/devicetree.cb +++ b/src/mainboard/google/butterfly/devicetree.cb @@ -15,6 +15,10 @@ register "gpu_panel_power_backlight_on_delay" = "2100" # T3: 210ms register "gpu_panel_power_backlight_off_delay" = "2100" # T4: 210ms + # Set backlight PWM values + register "gpu_cpu_backlight" = "0x000001e8" + register "gpu_pch_backlight" = "0x03d00000" + register "max_mem_clock_mhz" = "666" # DDR3-1333 device cpu_cluster 0 on -- To view, visit https://review.coreboot.org/c/coreboot/+/30819 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib8060f2d1ad0694f0886d35c83763907f61b47b1 Gerrit-Change-Number: 30819 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newchange

1 1

Change in ...coreboot[master]: sb/intel/i82801gx: Implement PCIe coalescing
by Kyösti Mälkki (Code Review) 13 Jan '19

13 Jan '19

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30320 ) Change subject: sb/intel/i82801gx: Implement PCIe coalescing ...................................................................... Patch Set 12: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/30320 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6d7ddef96e4f45e163f7017175398a0938a18273 Gerrit-Change-Number: 30320 Gerrit-PatchSet: 12 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Comment-Date: Sun, 13 Jan 2019 18:15:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/asus/p5qpl-am: Add p5g41t-m_lx as a variant
by Kyösti Mälkki (Code Review) 13 Jan '19

13 Jan '19

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27089 ) Change subject: mb/asus/p5qpl-am: Add p5g41t-m_lx as a variant ...................................................................... Patch Set 11: Code-Review+2 Much more readable. -- To view, visit https://review.coreboot.org/c/coreboot/+/27089 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I92cd15a245c4f1d8f57b304c9c3a37ba29c35431 Gerrit-Change-Number: 27089 Gerrit-PatchSet: 11 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 13 Jan 2019 17:59:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/asus/p5qpl-am: Add p5g41t-m_lx as a variant
by Angel Pons (Code Review) 13 Jan '19

13 Jan '19

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27089 ) Change subject: mb/asus/p5qpl-am: Add p5g41t-m_lx as a variant ...................................................................... Patch Set 11: (1 comment) https://review.coreboot.org/#/c/27089/10/src/mainboard/asus/p5qpl-am/romsta… File src/mainboard/asus/p5qpl-am/romstage.c: https://review.coreboot.org/#/c/27089/10/src/mainboard/asus/p5qpl-am/romsta… PS10, Line 76: old_reg = pnp_read_config(GPIO_DEV, 0x2c); > Even if repeated, I would prefer this next to the write of same register. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/27089 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I92cd15a245c4f1d8f57b304c9c3a37ba29c35431 Gerrit-Change-Number: 27089 Gerrit-PatchSet: 11 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sun, 13 Jan 2019 17:58:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/asus/p5qpl-am: Add p5g41t-m_lx as a variant
by Angel Pons (Code Review) 13 Jan '19

13 Jan '19

Hello Arthur Heymans, Paul Menzel, build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/27089 to look at the new patch set (#11). Change subject: mb/asus/p5qpl-am: Add p5g41t-m_lx as a variant ...................................................................... mb/asus/p5qpl-am: Add p5g41t-m_lx as a variant This board has more or less the same as the p5qpl-am except for DDR3 memory and different colors on the ports. Tested with Arch Linux with kernel 4.20.0-arch1-1-ARCH. What is tested and works: - 800/1066/1333 MHz CPUs and DDR3 sticks at 800/1066 MHz Some bugs are still present in the DDR3 raminit code though. - Ethernet - Internal programmer with both coreboot and stock firmware. - PCI and PCIe x1 slots - All USB ports - S3 resume - SATA ports - PEG - Rear audio output Change-Id: I92cd15a245c4f1d8f57b304c9c3a37ba29c35431 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/asus/p5qpl-am/Kconfig M src/mainboard/asus/p5qpl-am/Kconfig.name M src/mainboard/asus/p5qpl-am/Makefile.inc M src/mainboard/asus/p5qpl-am/devicetree.cb M src/mainboard/asus/p5qpl-am/romstage.c A src/mainboard/asus/p5qpl-am/variants/p5g41t-m_lx/gpio.c A src/mainboard/asus/p5qpl-am/variants/p5g41t-m_lx/overridetree.cb R src/mainboard/asus/p5qpl-am/variants/p5qpl-am/gpio.c A src/mainboard/asus/p5qpl-am/variants/p5qpl-am/overridetree.cb 9 files changed, 395 insertions(+), 91 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/27089/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/27089 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I92cd15a245c4f1d8f57b304c9c3a37ba29c35431 Gerrit-Change-Number: 27089 Gerrit-PatchSet: 11 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in ...coreboot[master]: mb/asus/p5qpl-am: Add p5g41t-m_lx as a variant
by Kyösti Mälkki (Code Review) 13 Jan '19

13 Jan '19

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27089 ) Change subject: mb/asus/p5qpl-am: Add p5g41t-m_lx as a variant ...................................................................... Patch Set 10: (1 comment) https://review.coreboot.org/#/c/27089/10/src/mainboard/asus/p5qpl-am/romsta… File src/mainboard/asus/p5qpl-am/romstage.c: https://review.coreboot.org/#/c/27089/10/src/mainboard/asus/p5qpl-am/romsta… PS10, Line 76: old_reg = pnp_read_config(GPIO_DEV, 0x2c); Even if repeated, I would prefer this next to the write of same register. -- To view, visit https://review.coreboot.org/c/coreboot/+/27089 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I92cd15a245c4f1d8f57b304c9c3a37ba29c35431 Gerrit-Change-Number: 27089 Gerrit-PatchSet: 10 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sun, 13 Jan 2019 17:43:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/intel: Enable console in bootblock
by Lijian Zhao (Code Review) 13 Jan '19

13 Jan '19

Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30886 Change subject: soc/intel: Enable console in bootblock ...................................................................... soc/intel: Enable console in bootblock In debug build, the serial printing in bootblock stage is critical, so enable that by default. BUG=N/A TEST=Check generated .config file to see CONFIG_BOOTBLOCK_CONSOLE get set. Signed-off-by: Lijian Zhao <lijian.zhao(a)intel.com> Change-Id: I0aa98575eeb14d4c5387415d3fde4677a6b7ffe6 --- M src/soc/intel/cannonlake/Kconfig M src/soc/intel/icelake/Kconfig 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/30886/1 diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index a3390d8..6347f03 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -26,6 +26,7 @@ select ARCH_RAMSTAGE_X86_32 select ARCH_ROMSTAGE_X86_32 select ARCH_VERSTAGE_X86_32 + select BOOTBLOCK_CONSOLE select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY if BOOT_DEVICE_SPI_FLASH select BOOT_DEVICE_SUPPORTS_WRITES select C_ENVIRONMENT_BOOTBLOCK diff --git a/src/soc/intel/icelake/Kconfig b/src/soc/intel/icelake/Kconfig index 34af339..ff284cd 100644 --- a/src/soc/intel/icelake/Kconfig +++ b/src/soc/intel/icelake/Kconfig @@ -12,6 +12,7 @@ select ARCH_RAMSTAGE_X86_32 select ARCH_ROMSTAGE_X86_32 select ARCH_VERSTAGE_X86_32 + select BOOTBLOCK_CONSOLE select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY if BOOT_DEVICE_SPI_FLASH select BOOT_DEVICE_SUPPORTS_WRITES select C_ENVIRONMENT_BOOTBLOCK -- To view, visit https://review.coreboot.org/c/coreboot/+/30886 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0aa98575eeb14d4c5387415d3fde4677a6b7ffe6 Gerrit-Change-Number: 30886 Gerrit-PatchSet: 1 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-MessageType: newchange

3 5

Change in ...coreboot[master]: mb/asus/p5qpl-am: Add p5g41t-m_lx as a variant
by Angel Pons (Code Review) 13 Jan '19

13 Jan '19

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27089 ) Change subject: mb/asus/p5qpl-am: Add p5g41t-m_lx as a variant ...................................................................... Patch Set 10: (1 comment) https://review.coreboot.org/#/c/27089/9/src/mainboard/asus/p5qpl-am/romstag… File src/mainboard/asus/p5qpl-am/romstage.c: https://review.coreboot.org/#/c/27089/9/src/mainboard/asus/p5qpl-am/romstag… PS9, Line 70: static int setup_sio_gpio(void) > After trying to use a proper variant romstage. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/27089 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I92cd15a245c4f1d8f57b304c9c3a37ba29c35431 Gerrit-Change-Number: 27089 Gerrit-PatchSet: 10 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sun, 13 Jan 2019 17:16:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/asus/p5qpl-am: Add p5g41t-m_lx as a variant
by Angel Pons (Code Review) 13 Jan '19

13 Jan '19

Hello Arthur Heymans, Paul Menzel, build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/27089 to look at the new patch set (#10). Change subject: mb/asus/p5qpl-am: Add p5g41t-m_lx as a variant ...................................................................... mb/asus/p5qpl-am: Add p5g41t-m_lx as a variant This board has more or less the same as the p5qpl-am except for DDR3 memory and different colors on the ports. Tested with Arch Linux with kernel 4.20.0-arch1-1-ARCH. What is tested and works: - 800/1066/1333 MHz CPUs and DDR3 sticks at 800/1066 MHz Some bugs are still present in the DDR3 raminit code though. - Ethernet - Internal programmer with both coreboot and stock firmware. - PCI and PCIe x1 slots - All USB ports - S3 resume - SATA ports - PEG - Rear audio output Change-Id: I92cd15a245c4f1d8f57b304c9c3a37ba29c35431 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/asus/p5qpl-am/Kconfig M src/mainboard/asus/p5qpl-am/Kconfig.name M src/mainboard/asus/p5qpl-am/Makefile.inc M src/mainboard/asus/p5qpl-am/devicetree.cb M src/mainboard/asus/p5qpl-am/romstage.c A src/mainboard/asus/p5qpl-am/variants/p5g41t-m_lx/gpio.c A src/mainboard/asus/p5qpl-am/variants/p5g41t-m_lx/overridetree.cb R src/mainboard/asus/p5qpl-am/variants/p5qpl-am/gpio.c A src/mainboard/asus/p5qpl-am/variants/p5qpl-am/overridetree.cb 9 files changed, 394 insertions(+), 91 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/27089/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/27089 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I92cd15a245c4f1d8f57b304c9c3a37ba29c35431 Gerrit-Change-Number: 27089 Gerrit-PatchSet: 10 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2019