coreboot-gerrit September 2018

coreboot-gerrit@coreboot.org

1 participants
886 discussions

Change in coreboot[master]: util/lint: update whitespace checking rules
by Werner Zeh (Code Review) 04 Sep '18

04 Sep '18

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/28431 ) Change subject: util/lint: update whitespace checking rules ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/28431 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4a1709224604b36362d82e249c2916fca0336a2 Gerrit-Change-Number: 28431 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 04 Sep 2018 04:17:38 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/lint: update whitespace checking rules
by Jonathan Neuschäfer (Code Review) 04 Sep '18

04 Sep '18

Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/28431 ) Change subject: util/lint: update whitespace checking rules ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/28431 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4a1709224604b36362d82e249c2916fca0336a2 Gerrit-Change-Number: 28431 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Mon, 03 Sep 2018 23:52:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/common/block/psp/psp.c: Remove use of PspBaseLib
by build bot (Jenkins) (Code Review) 03 Sep '18

03 Sep '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27619 ) Change subject: soc/amd/common/block/psp/psp.c: Remove use of PspBaseLib ...................................................................... Patch Set 4: (14 comments) https://review.coreboot.org/#/c/27619/4/src/soc/amd/common/block/psp/psp.c File src/soc/amd/common/block/psp/psp.c: https://review.coreboot.org/#/c/27619/4/src/soc/amd/common/block/psp/psp.c@… PS4, Line 20: <<<<<<< HEAD spaces required around that '<' (ctx:OxW) https://review.coreboot.org/#/c/27619/4/src/soc/amd/common/block/psp/psp.c@… PS4, Line 22: ======= spaces required around that '==' (ctx:ExO) https://review.coreboot.org/#/c/27619/4/src/soc/amd/common/block/psp/psp.c@… PS4, Line 22: ======= spaces required around that '==' (ctx:OxO) https://review.coreboot.org/#/c/27619/4/src/soc/amd/common/block/psp/psp.c@… PS4, Line 22: ======= spaces required around that '==' (ctx:OxO) https://review.coreboot.org/#/c/27619/4/src/soc/amd/common/block/psp/psp.c@… PS4, Line 22: ======= spaces required around that '=' (ctx:OxE) https://review.coreboot.org/#/c/27619/4/src/soc/amd/common/block/psp/psp.c@… PS4, Line 26: >>>>>>> 3c733bc... soc/amd/common/block/psp/psp.c: Remove use of PspBaseLib spaces required around that '>' (ctx:OxW) https://review.coreboot.org/#/c/27619/4/src/soc/amd/common/block/psp/psp.c@… PS4, Line 26: >>>>>>> 3c733bc... soc/amd/common/block/psp/psp.c: Remove use of PspBaseLib spaces required around that ':' (ctx:VxW) https://review.coreboot.org/#/c/27619/4/src/soc/amd/common/block/psp/psp.c@… PS4, Line 37: <<<<<<< HEAD spaces required around that '<' (ctx:OxW) https://review.coreboot.org/#/c/27619/4/src/soc/amd/common/block/psp/psp.c@… PS4, Line 38: ======= spaces required around that '==' (ctx:ExO) https://review.coreboot.org/#/c/27619/4/src/soc/amd/common/block/psp/psp.c@… PS4, Line 38: ======= spaces required around that '==' (ctx:OxO) https://review.coreboot.org/#/c/27619/4/src/soc/amd/common/block/psp/psp.c@… PS4, Line 38: ======= spaces required around that '==' (ctx:OxO) https://review.coreboot.org/#/c/27619/4/src/soc/amd/common/block/psp/psp.c@… PS4, Line 38: ======= spaces required around that '=' (ctx:OxE) https://review.coreboot.org/#/c/27619/4/src/soc/amd/common/block/psp/psp.c@… PS4, Line 143: >>>>>>> 3c733bc... soc/amd/common/block/psp/psp.c: Remove use of PspBaseLib spaces required around that '>' (ctx:OxW) https://review.coreboot.org/#/c/27619/4/src/soc/amd/common/block/psp/psp.c@… PS4, Line 143: >>>>>>> 3c733bc... soc/amd/common/block/psp/psp.c: Remove use of PspBaseLib spaces required around that ':' (ctx:VxW) -- To view, visit https://review.coreboot.org/27619 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2740ceb945736c6e413f7d0bd0c41a19e19c7d5a Gerrit-Change-Number: 27619 Gerrit-PatchSet: 4 Gerrit-Owner: Charles Marslett <charles.marslett(a)amd.corp-partner.google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Charles Marslett <charles.marslett(a)amd.corp-partner.google.com> Gerrit-Reviewer: Charles Marslett <charles.marslett(a)silverbackltd.com> Gerrit-Reviewer: Marshall Dawson <marshall.dawson(a)se-eng.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Comment-Date: Mon, 03 Sep 2018 19:42:13 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/lint: update non-ascii linter checking rules
by Martin Roth (Code Review) 03 Sep '18

03 Sep '18

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/28449 Change subject: util/lint: update non-ascii linter checking rules ...................................................................... util/lint: update non-ascii linter checking rules - Check non-external payloads - Remove directories that aren't in the coreboot git repo. - Remove non-phrase rule from list of excluded phrases Change-Id: I9e056e8b43af567f102dfc0db76f60328aa1ed04 Signed-off-by: Martin Roth <martinr(a)coreboot.org> --- M util/lint/lint-stable-016-non-ascii 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/28449/1 diff --git a/util/lint/lint-stable-016-non-ascii b/util/lint/lint-stable-016-non-ascii index 3c22900..fbb830d 100755 --- a/util/lint/lint-stable-016-non-ascii +++ b/util/lint/lint-stable-016-non-ascii @@ -17,9 +17,9 @@ LC_ALL=C export LC_ALL INCLUDED_FILES='\.[chsS]$\|\.asl$\|\.cb$\|\.inc$\|Kconfig\|\.ld$|\.txt\|\.hex' -EXCLUDED_DIRS='^payloads/\|^src/vendorcode/\|^Documentation/\|^build/\|^3rdparty/\|^\.git/\|^coreboot-builds/\|^util/nvidia/cbootimage' +EXCLUDED_DIRS='^payloads/external/\|^src/vendorcode/\|^Documentation/' EXCLUDED_FILES='to-wiki/towiki\.sh$\|vga/vga_font\|video/font\|PDCurses.*x11' -EXCLUDED_PHRASES='Copyright\|Ported to\|Intel®\|°C\|°F\|Athlon™\|Copyright.*©\|A-Za-zÀ-ÿ' +EXCLUDED_PHRASES='Copyright\|Ported to\|Intel®\|°C\|°F\|Athlon™\|Copyright.*©' # Exit if git isn't present or the code isn't in a git repo if [ -z "$(command -v git)" ] || \ -- To view, visit https://review.coreboot.org/28449 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9e056e8b43af567f102dfc0db76f60328aa1ed04 Gerrit-Change-Number: 28449 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: util/lint: Update non-ascii linter for FreeBSD
by Martin Roth (Code Review) 03 Sep '18

03 Sep '18

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/28448 Change subject: util/lint: Update non-ascii linter for FreeBSD ...................................................................... util/lint: Update non-ascii linter for FreeBSD On FreeBSD, this test was failing with the error: "grep: Argument list too long" - Remove support for testing coreboot not in a git repo. Many of the other linters already don't support this. - Use git grep to find offending files, then xargs to print out the lines. Change-Id: Ic017dc3465fd9a46ff4e6ec5ef16396e963483cd Signed-off-by: Martin Roth <martinr(a)coreboot.org> --- M util/lint/lint-stable-016-non-ascii 1 file changed, 13 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/28448/1 diff --git a/util/lint/lint-stable-016-non-ascii b/util/lint/lint-stable-016-non-ascii index beffd83..3c22900 100755 --- a/util/lint/lint-stable-016-non-ascii +++ b/util/lint/lint-stable-016-non-ascii @@ -21,13 +21,11 @@ EXCLUDED_FILES='to-wiki/towiki\.sh$\|vga/vga_font\|video/font\|PDCurses.*x11' EXCLUDED_PHRASES='Copyright\|Ported to\|Intel®\|°C\|°F\|Athlon™\|Copyright.*©\|A-Za-zÀ-ÿ' -# Use git ls-files if the code is in a git repo, otherwise use find. -if [ -n "$(command -v git)" ] && \ - [ "$(git rev-parse --is-inside-work-tree 2>/dev/null)" = "true" ] +# Exit if git isn't present or the code isn't in a git repo +if [ -z "$(command -v git)" ] || \ + [ "$(git rev-parse --is-inside-work-tree 2>/dev/null)" != "true" ] then - FIND_FILES="git ls-files" -else - FIND_FILES="find . " + exit fi # 1. Get the list of files to parse and send them through grep @@ -36,10 +34,12 @@ # 3. Remove common phrases and names that have been found # 4. Run the result through grep again to highlight the issues that were # found. Without this step, the characters can be difficult to see. -grep -n "[^ -~]" \ - $(${FIND_FILES} | sed 's|^\./||' | sort | \ - grep "$INCLUDED_FILES" | \ - grep -v "$EXCLUDED_DIRS" | \ - grep -v "$EXCLUDED_FILES") | \ - grep -iv "$EXCLUDED_PHRASES" | \ - grep --color='auto' "[^ -~]" +# shellcheck disable=SC2046 +git grep -lP "[^\t-~]" | \ + grep "$INCLUDED_FILES" | \ + grep -v "$EXCLUDED_DIRS" | \ + grep -v "$EXCLUDED_FILES" | \ + xargs -I % \ + grep -n "[^ -~]" % | \ + grep -iv "$EXCLUDED_PHRASES" | \ + grep --color='auto' "[^ -~]" -- To view, visit https://review.coreboot.org/28448 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic017dc3465fd9a46ff4e6ec5ef16396e963483cd Gerrit-Change-Number: 28448 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: util/lint: update whitespace checking rules
by Martin Roth (Code Review) 03 Sep '18

03 Sep '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28431 to look at the new patch set (#2). Change subject: util/lint: update whitespace checking rules ...................................................................... util/lint: update whitespace checking rules - Check payloads, the root Makefiles and toolchain.inc - 3rdparty is already not checked, so remove - The marks around COPYING, LICENSE, and README were not needed - Skip checking .ico files Change-Id: Ic4a1709224604b36362d82e249c2916fca0336a2 Signed-off-by: Martin Roth <martinr(a)coreboot.org> --- M util/lint/lint-stable-003-whitespace 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/28431/2 -- To view, visit https://review.coreboot.org/28431 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic4a1709224604b36362d82e249c2916fca0336a2 Gerrit-Change-Number: 28431 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com>

1 0

Change in coreboot[master]: util/lint: update whitespace checking rules
by Martin Roth (Code Review) 03 Sep '18

03 Sep '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28431 ) Change subject: util/lint: update whitespace checking rules ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/28431/1/util/lint/lint-stable-003-whitespace File util/lint/lint-stable-003-whitespace: https://review.coreboot.org/#/c/28431/1/util/lint/lint-stable-003-whitespac… PS1, Line 19: Make* > Do you plan to have something else than Makefile*? No. This is to pick up Makefile and Makefile.inc. I'll update to Makefile* -- To view, visit https://review.coreboot.org/28431 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4a1709224604b36362d82e249c2916fca0336a2 Gerrit-Change-Number: 28431 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Mon, 03 Sep 2018 18:56:44 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: lib/gpio.c: Check num_gpio
by Richard Spiegel (Code Review) 03 Sep '18

03 Sep '18

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/28446 Change subject: lib/gpio.c: Check num_gpio ...................................................................... lib/gpio.c: Check num_gpio Several functions in src/lib/gpio.c don't check for valid number of gpio, which must be at least 1 and at most 32 (due to returning int). Create a function to execute the test, and call it from wherever needed. BUG=b:113788440 TEST=Add a fake code to southbridge_final calling the functions with and without valid num_gpio, printing the result. Build and boot grunt, check results. Change-Id: I08c47fcd784e14e25ec1409571c1e59cb2e50ed8 Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/lib/gpio.c 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/28446/1 diff --git a/src/lib/gpio.c b/src/lib/gpio.c index 4549166..001994a 100644 --- a/src/lib/gpio.c +++ b/src/lib/gpio.c @@ -20,6 +20,13 @@ #include <delay.h> #include <gpio.h> +static void _check_num(const char *name, int num) +{ + if ((num > 32) && (num < 1)) { + printk(BIOS_WARNING, "%s: %d ", name, num); + die("is an invalid number of GPIOs"); + } +} static uint32_t _gpio_base2_value(const gpio_t gpio[], int num_gpio) { uint32_t result = 0; @@ -38,6 +45,7 @@ { int i; + _check_num(__func__, num_gpio); for (i = 0; i < num_gpio; i++) gpio_input(gpio[i]); @@ -48,6 +56,7 @@ { int i; + _check_num(__func__, num_gpio); for (i = 0; i < num_gpio; i++) gpio_input_pulldown(gpio[i]); @@ -58,6 +67,7 @@ { int i; + _check_num(__func__, num_gpio); for (i = 0; i < num_gpio; i++) gpio_input_pullup(gpio[i]); @@ -82,8 +92,8 @@ int index; int temp; char value[32]; - if ((num_gpio > 32) && (num_gpio < 1)) - die("gpio_base3_value: Invalid number of GPIOs"); + + _check_num(__func__, num_gpio); /* Enable internal pull up */ for (index = 0; index < num_gpio; ++index) -- To view, visit https://review.coreboot.org/28446 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I08c47fcd784e14e25ec1409571c1e59cb2e50ed8 Gerrit-Change-Number: 28446 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: lib/gpio.c: Fix _gpio_base3_value invalid shift
by Richard Spiegel (Code Review) 03 Sep '18

03 Sep '18

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/28445 Change subject: lib/gpio.c: Fix _gpio_base3_value invalid shift ...................................................................... lib/gpio.c: Fix _gpio_base3_value invalid shift In function _gpio_base3_value(), if gpio_num is 32 and gpio[31] is floating, the end result is 1 << 32, which does not fit into a int. To avoid a possible error, in this condition set value to 0xffffffff. Add a comment explaining why and the work around. BUG=b:113788440 TEST=Add a fake code to southbridge_final calling the function and printing the result. Build and boot grunt, check result. Change-Id: I0b79725bcbaf120587c7440e176643aaa7a1d5bb Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/lib/gpio.c 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/28445/1 diff --git a/src/lib/gpio.c b/src/lib/gpio.c index da74849..4549166 100644 --- a/src/lib/gpio.c +++ b/src/lib/gpio.c @@ -75,7 +75,7 @@ * internally pulled to. */ - static const char tristate_char[] = {[0] = '0', [1] = '1', [Z] = 'Z'}; + static const char tristate_char[] = {[0] = '0', [1] = '1', [2] = 'Z'}; uint32_t result = 0; int has_z = 0; int binary_below = 0; @@ -138,6 +138,14 @@ * '2' at 3^1: Add 2^(1+1) = 4 to account for binaries 1000-1011 * Stop adding for lower digits (3^0), all already accounted * now. We know that there can be no binary numbers 1020-102X. + * + * If gpio_num is 32 and gpio[31] is floating, the end result is + * 1 << 32, which does not fit into a int. To avoid a possible + * error, in this condition the value will be set to 0xffffffff. + * There's a second condition which would set this value, to + * have all inputs as 1. To differentiate between these results, + * the caller needs to test if gpio[31] is floating. If gpio_num + * is less than 32, no care is needed. */ if (binary_first && !has_z) { switch (temp) { @@ -147,7 +155,10 @@ binary_below += 1 << index; break; case 2: /* Account for binaries 0 to 2^(index+1) - 1. */ - binary_below += 1 << (index + 1); + if (index >= 31) + binary_below = 0xffffffff; + else + binary_below += 1 << (index + 1); has_z = 1; } } -- To view, visit https://review.coreboot.org/28445 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0b79725bcbaf120587c7440e176643aaa7a1d5bb Gerrit-Change-Number: 28445 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: cpu/intel/model_206ax: detect number of MCE banks
by Dan Elkouby (Code Review) 03 Sep '18

03 Sep '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28443 to look at the new patch set (#2). Change subject: cpu/intel/model_206ax: detect number of MCE banks ...................................................................... cpu/intel/model_206ax: detect number of MCE banks My CPU (3770k) supports 9 MCE banks, but the code is hardcoded to reset only 7. This causes Linux to spuriously log errors during boot and S3 resume. Fix this by reading the real value from the right MSR. Change-Id: Id05645009259fd77b4de49bde518361eeae46617 Signed-off-by: Dan Elkouby <streetwalkermc(a)gmail.com> --- M src/cpu/intel/model_206ax/model_206ax.h M src/cpu/intel/model_206ax/model_206ax_init.c 2 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/28443/2 -- To view, visit https://review.coreboot.org/28443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id05645009259fd77b4de49bde518361eeae46617 Gerrit-Change-Number: 28443 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Elkouby <streetwalkermc(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

← Newer
1
...
80
81
82
83
84
85
86
...
89
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2018