coreboot-gerrit September 2018

coreboot-gerrit@coreboot.org

1 participants
886 discussions

Change in coreboot[master]: [Please test]nb/intel/i945/raminit: "Correct" DRTST
by Elyes HAOUAS (Code Review) 02 Sep '18

02 Sep '18

Elyes HAOUAS has abandoned this change. ( https://review.coreboot.org/28396 ) Change subject: [Please test]nb/intel/i945/raminit: "Correct" DRTST ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/28396 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: … [View More]

1 0

Change in coreboot[master]: mb/google/poppy/variants/nocturne: Enable DMIC CLK0/DATA0
by Sathyanarayana Nujella (Code Review) 02 Sep '18

02 Sep '18

Hello HARSHAPRIYA N, I'd like you to do a code review. Please visit https://review.coreboot.org/28433 to review the following change. Change subject: mb/google/poppy/variants/nocturne: Enable DMIC CLK0/DATA0 ...................................................................... mb/google/poppy/variants/nocturne: Enable DMIC CLK0/DATA0 DMIC's are now connected to DMIC_CLK0/DMIC_DATA0. So, enable the pins accordingly. BUG=b:113744731 BRANCH=none TEST='emerge-nocturne coreboot chromeos-… [View More]

1 0

Change in coreboot[master]: libpayload/curses/PDCurses/doc/intro.txt: Remove unneeded whitespace
by Elyes HAOUAS (Code Review) 02 Sep '18

02 Sep '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/28432 Change subject: libpayload/curses/PDCurses/doc/intro.txt: Remove unneeded whitespace ...................................................................... libpayload/curses/PDCurses/doc/intro.txt: Remove unneeded whitespace Change-Id: Ib5a0f193d54d1b6f2431f7b801678f2a983c7941 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M payloads/libpayload/curses/PDCurses/doc/intro.txt 1 file changed, 57 … [View More]insertions(+), 57 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/28432/1 diff --git a/payloads/libpayload/curses/PDCurses/doc/intro.txt b/payloads/libpayload/curses/PDCurses/doc/intro.txt index c0f80fe..d965328 100644 --- a/payloads/libpayload/curses/PDCurses/doc/intro.txt +++ b/payloads/libpayload/curses/PDCurses/doc/intro.txt @@ -129,7 +129,7 @@ A_INVIS invisible A_ITALIC italic A_LEFTLINE line along the left edge - A_PROTECT protected (?) -- PDCurses renders this as a + A_PROTECT protected (?) -- PDCurses renders this as a combination of the *LINE attributes A_REVERSE reverse video A_RIGHTLINE line along the right edge @@ -291,62 +291,62 @@ KEY_C1 lower left of virtual keypad KEY_C3 lower right of virtual keypad - KEY_BTAB Back tab key - KEY_BEG Beginning key - KEY_CANCEL Cancel key - KEY_CLOSE Close key - KEY_COMMAND Cmd (command) key - KEY_COPY Copy key - KEY_CREATE Create key - KEY_END End key - KEY_EXIT Exit key - KEY_FIND Find key - KEY_HELP Help key - KEY_MARK Mark key - KEY_MESSAGE Message key - KEY_MOVE Move key - KEY_NEXT Next object key - KEY_OPEN Open key - KEY_OPTIONS Options key - KEY_PREVIOUS Previous object key - KEY_REDO Redo key - KEY_REFERENCE Reference key - KEY_REFRESH Refresh key - KEY_REPLACE Replace key - KEY_RESTART Restart key - KEY_RESUME Resume key - KEY_SAVE Save key - KEY_SBEG Shifted beginning key - KEY_SCANCEL Shifted cancel key - KEY_SCOMMAND Shifted command key - KEY_SCOPY Shifted copy key - KEY_SCREATE Shifted create key - KEY_SDC Shifted delete char key - KEY_SDL Shifted delete line key - KEY_SELECT Select key - KEY_SEND Shifted end key - KEY_SEOL Shifted clear line key - KEY_SEXIT Shifted exit key - KEY_SFIND Shifted find key - KEY_SHELP Shifted help key - KEY_SHOME Shifted home key - KEY_SIC Shifted input key - KEY_SLEFT Shifted left arrow key - KEY_SMESSAGE Shifted message key - KEY_SMOVE Shifted move key - KEY_SNEXT Shifted next key - KEY_SOPTIONS Shifted options key - KEY_SPREVIOUS Shifted prev key - KEY_SPRINT Shifted print key - KEY_SREDO Shifted redo key - KEY_SREPLACE Shifted replace key - KEY_SRIGHT Shifted right arrow - KEY_SRSUME Shifted resume key - KEY_SSAVE Shifted save key - KEY_SSUSPEND Shifted suspend key - KEY_SUNDO Shifted undo key - KEY_SUSPEND Suspend key - KEY_UNDO Undo key + KEY_BTAB Back tab key + KEY_BEG Beginning key + KEY_CANCEL Cancel key + KEY_CLOSE Close key + KEY_COMMAND Cmd (command) key + KEY_COPY Copy key + KEY_CREATE Create key + KEY_END End key + KEY_EXIT Exit key + KEY_FIND Find key + KEY_HELP Help key + KEY_MARK Mark key + KEY_MESSAGE Message key + KEY_MOVE Move key + KEY_NEXT Next object key + KEY_OPEN Open key + KEY_OPTIONS Options key + KEY_PREVIOUS Previous object key + KEY_REDO Redo key + KEY_REFERENCE Reference key + KEY_REFRESH Refresh key + KEY_REPLACE Replace key + KEY_RESTART Restart key + KEY_RESUME Resume key + KEY_SAVE Save key + KEY_SBEG Shifted beginning key + KEY_SCANCEL Shifted cancel key + KEY_SCOMMAND Shifted command key + KEY_SCOPY Shifted copy key + KEY_SCREATE Shifted create key + KEY_SDC Shifted delete char key + KEY_SDL Shifted delete line key + KEY_SELECT Select key + KEY_SEND Shifted end key + KEY_SEOL Shifted clear line key + KEY_SEXIT Shifted exit key + KEY_SFIND Shifted find key + KEY_SHELP Shifted help key + KEY_SHOME Shifted home key + KEY_SIC Shifted input key + KEY_SLEFT Shifted left arrow key + KEY_SMESSAGE Shifted message key + KEY_SMOVE Shifted move key + KEY_SNEXT Shifted next key + KEY_SOPTIONS Shifted options key + KEY_SPREVIOUS Shifted prev key + KEY_SPRINT Shifted print key + KEY_SREDO Shifted redo key + KEY_SREPLACE Shifted replace key + KEY_SRIGHT Shifted right arrow + KEY_SRSUME Shifted resume key + KEY_SSAVE Shifted save key + KEY_SSUSPEND Shifted suspend key + KEY_SUNDO Shifted undo key + KEY_SUSPEND Suspend key + KEY_UNDO Undo key The virtual keypad is arranged like this: -- To view, visit https://review.coreboot.org/28432 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib5a0f193d54d1b6f2431f7b801678f2a983c7941 Gerrit-Change-Number: 28432 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> [View Less]

1 0

Change in coreboot[master]: util/lint: update whitespace checking rules
by Werner Zeh (Code Review) 02 Sep '18

02 Sep '18

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/28431 ) Change subject: util/lint: update whitespace checking rules ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/28431/1/util/lint/lint-stable-003-whitespace File util/lint/lint-stable-003-whitespace: https://review.coreboot.org/#/c/28431/1/util/lint/lint-stable-003-whitespac… PS1, Line 19: Make* Do you plan to have something else … [View More]

1 0

Change in coreboot[master]: payloads: Remove/fix trailing whitespace
by Werner Zeh (Code Review) 02 Sep '18

02 Sep '18

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/28430 ) Change subject: payloads: Remove/fix trailing whitespace ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28430 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: … [View More]

1 0

Change in coreboot[master]: util/lint: Update whitespace linter for FreeBSD
by Werner Zeh (Code Review) 02 Sep '18

02 Sep '18

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/28429 ) Change subject: util/lint: Update whitespace linter for FreeBSD ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28429 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: … [View More]

1 0

Change in coreboot[master]: mb/google/poppy/variants/rammus: add sku info into smbios table
by Furquan Shaikh (Code Review) 02 Sep '18

02 Sep '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/28426 ) Change subject: mb/google/poppy/variants/rammus: add sku info into smbios table ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/28426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment … [View More]

1 0

Change in coreboot[master]: mb/google/poppy/variants/rammus: add sku info into smbios table
by Zhuohao Lee (Code Review) 02 Sep '18

02 Sep '18

Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/28426 ) Change subject: mb/google/poppy/variants/rammus: add sku info into smbios table ...................................................................... Patch Set 2: (2 comments) https://review.coreboot.org/#/c/28426/1/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/rammus/include/variant/sku.h: https://review.coreboot.org/#/c/28426/1/src/mainboard/google/poppy/variants… PS1,… [View More]

1 0

Change in coreboot[master]: mb/google/poppy/variants/rammus: add sku info into smbios table
by Zhuohao Lee (Code Review) 02 Sep '18

02 Sep '18

Hello build bot (Jenkins), Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/28426 to look at the new patch set (#2). Change subject: mb/google/poppy/variants/rammus: add sku info into smbios table ...................................................................... mb/google/poppy/variants/rammus: add sku info into smbios table This patch adds the mainboard.c in order to support the sku id in smbios table where the sku id is queried from … [View More]

1 0

Change in coreboot[master]: mb/lenovo: dGPU power handling on T430, T530
by Martin Roth (Code Review) 02 Sep '18

02 Sep '18

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/28392 ) Change subject: mb/lenovo: dGPU power handling on T430, T530 ...................................................................... mb/lenovo: dGPU power handling on T430, T530 Enable dGPU power handling on Lenovo ThinkPad T430, T530 via PMH7 register 0x50. Although there's no Thinker-1 chip on these models according to schematics, dGPU power control via PMH7 works the same as on T420/T520, so … [View More]they can be considered Thinker-1-compatible. It can be tested from linux userspace using util/pmh7tool. To turn dGPU power off: pmh7tool -c 0x50 7 pmh7tool -c 0x50 3 To turn it on: pmh7tool -s 0x50 3 pmh7tool -s 0x50 7 To check whether it is on (bash): reg=0x$(pmh7tool -r 0x50) echo "$(( (( reg & 0x08 )) >> 3 ))" or just `pmh7tool -b 0x50 3` with https://review.coreboot.org/#/c/coreboot/+/28388/ Tested on ThinkPad W530. Change-Id: Ieab1a33b3c680c757cc0999660b5cb7e122474cc Signed-off-by: Evgeny Zinoviev <me(a)ch1p.com> Reviewed-on: https://review.coreboot.org/28392 Reviewed-by: Patrick Rudolph <siro(a)das-labor.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/lenovo/t430/devicetree.cb M src/mainboard/lenovo/t530/variants/t530/devicetree.cb M src/mainboard/lenovo/t530/variants/w530/devicetree.cb 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved diff --git a/src/mainboard/lenovo/t430/devicetree.cb b/src/mainboard/lenovo/t430/devicetree.cb index d466b36..5eb92bc 100644 --- a/src/mainboard/lenovo/t430/devicetree.cb +++ b/src/mainboard/lenovo/t430/devicetree.cb @@ -167,7 +167,7 @@ register "has_backlight_gpio" = "0" register "has_dgpu_power_gpio" = "0" - register "has_thinker1" = "0" + register "has_thinker1" = "1" end chip drivers/pc80/tpm device pnp 0c31.0 on end diff --git a/src/mainboard/lenovo/t530/variants/t530/devicetree.cb b/src/mainboard/lenovo/t530/variants/t530/devicetree.cb index 0da05e0..4dcdc9d 100644 --- a/src/mainboard/lenovo/t530/variants/t530/devicetree.cb +++ b/src/mainboard/lenovo/t530/variants/t530/devicetree.cb @@ -157,7 +157,7 @@ register "has_backlight_gpio" = "0" register "has_dgpu_power_gpio" = "0" - register "has_thinker1" = "0" + register "has_thinker1" = "1" end end # LPC bridge device pci 1f.2 on end # SATA Controller 1 diff --git a/src/mainboard/lenovo/t530/variants/w530/devicetree.cb b/src/mainboard/lenovo/t530/variants/w530/devicetree.cb index d9d9df5..7a72b26 100644 --- a/src/mainboard/lenovo/t530/variants/w530/devicetree.cb +++ b/src/mainboard/lenovo/t530/variants/w530/devicetree.cb @@ -179,7 +179,7 @@ register "has_backlight_gpio" = "0" register "has_dgpu_power_gpio" = "0" - register "has_thinker1" = "0" + register "has_thinker1" = "1" end end device pci 1f.2 on # SATA Controller 1 -- To view, visit https://review.coreboot.org/28392 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ieab1a33b3c680c757cc0999660b5cb7e122474cc Gerrit-Change-Number: 28392 Gerrit-PatchSet: 4 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> [View Less]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2018