coreboot-gerrit September 2018

coreboot-gerrit@coreboot.org

1 participants
886 discussions

Change in coreboot[master]: Add TPM support for wedge100s
by Mikołaj Walczak (Code Review) 06 Sep '18

06 Sep '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28529 to look at the new patch set (#2). Change subject: Add TPM support for wedge100s ...................................................................... Add TPM support for wedge100s Change-Id: Id7e8ad63de2a6094c66cbd47ae9b7707a9af4e81 Signed-off-by: Mikolaj Walczak <mwalczak(a)fb.com> --- M src/mainboard/ocp/wedge100s/Kconfig M src/mainboard/ocp/wedge100s/devicetree.cb 2 files changed, 7 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/28529/2 -- To view, visit https://review.coreboot.org/28529 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id7e8ad63de2a6094c66cbd47ae9b7707a9af4e81 Gerrit-Change-Number: 28529 Gerrit-PatchSet: 2 Gerrit-Owner: Mikołaj Walczak (1002108) Gerrit-Assignee: Andrea Barberio <insomniac(a)slackware.it> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Andrea Barberio <insomniac(a)slackware.it>

1 0

Change in coreboot[master]: Add TPM support for wedge100s
by Mikołaj Walczak (Code Review) 06 Sep '18

06 Sep '18

Mikołaj Walczak has uploaded this change for review. ( https://review.coreboot.org/28529 Change subject: Add TPM support for wedge100s ...................................................................... Add TPM support for wedge100s Change-Id: Id7e8ad63de2a6094c66cbd47ae9b7707a9af4e81 --- M src/mainboard/ocp/wedge100s/Kconfig M src/mainboard/ocp/wedge100s/devicetree.cb 2 files changed, 7 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/28529/1 diff --git a/src/mainboard/ocp/wedge100s/Kconfig b/src/mainboard/ocp/wedge100s/Kconfig index 6a33edb..c4a1503 100644 --- a/src/mainboard/ocp/wedge100s/Kconfig +++ b/src/mainboard/ocp/wedge100s/Kconfig @@ -11,6 +11,8 @@ select SERIRQ_CONTINUOUS_MODE select SUPERIO_ITE_COMMON_ROMSTAGE select FSP_EHCI1_ENABLE + select MAINBOARD_HAS_LPC_TPM + select MAINBOARD_HAS_TPM1 config MAINBOARD_DIR string diff --git a/src/mainboard/ocp/wedge100s/devicetree.cb b/src/mainboard/ocp/wedge100s/devicetree.cb index 30d99c2..3d66d0d 100644 --- a/src/mainboard/ocp/wedge100s/devicetree.cb +++ b/src/mainboard/ocp/wedge100s/devicetree.cb @@ -7,7 +7,11 @@ device pci 14.0 on end # xHCI Controller device pci 19.0 on end # Gigabit LAN Controller device pci 1d.0 on end # EHCI Controller - device pci 1f.0 on end # LPC Bridge + device pci 1f.0 on + chip drivers/pc80/tpm + device pnp 0c31.0 on end + end + end # LPC Bridge device pci 1f.2 on end # SATA Controller device pci 1f.3 on end # SMBus Controller device pci 1f.5 on end # SATA Controller -- To view, visit https://review.coreboot.org/28529 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id7e8ad63de2a6094c66cbd47ae9b7707a9af4e81 Gerrit-Change-Number: 28529 Gerrit-PatchSet: 1 Gerrit-Owner: Mikołaj Walczak (1002108)

1 0

Change in coreboot[master]: fsp_broadwell_de: enable spi console
by Okash Khawaja (Code Review) 06 Sep '18

06 Sep '18

Okash Khawaja has posted comments on this change. ( https://review.coreboot.org/28528 ) Change subject: fsp_broadwell_de: enable spi console ...................................................................... Patch Set 1: could you review this please, thanks -- To view, visit https://review.coreboot.org/28528 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib925c5aee88b65c46a81534405c364dd5649f8e8 Gerrit-Change-Number: 28528 Gerrit-PatchSet: 1 Gerrit-Owner: Okash Khawaja <okash.khawaja(a)gmail.com> Gerrit-Reviewer: Okash Khawaja <okash.khawaja(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 06 Sep 2018 13:46:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: fsp_broadwell_de: enable spi console
by Okash Khawaja (Code Review) 06 Sep '18

06 Sep '18

Okash Khawaja has uploaded this change for review. ( https://review.coreboot.org/28528 Change subject: fsp_broadwell_de: enable spi console ...................................................................... fsp_broadwell_de: enable spi console this enables spi console for wedge100s which broadwell_de. the console size is 64kb. Change-Id: Ib925c5aee88b65c46a81534405c364dd5649f8e8 Signed-off-by: Okash Khawaja <okash.khawaja(a)gmail.com> --- M src/mainboard/ocp/wedge100s/board.fmd M src/soc/intel/fsp_broadwell_de/Kconfig M src/soc/intel/fsp_broadwell_de/Makefile.inc M src/soc/intel/fsp_broadwell_de/spi.c 4 files changed, 8 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/28528/1 diff --git a/src/mainboard/ocp/wedge100s/board.fmd b/src/mainboard/ocp/wedge100s/board.fmd index da6e3e3..8e44081 100644 --- a/src/mainboard/ocp/wedge100s/board.fmd +++ b/src/mainboard/ocp/wedge100s/board.fmd @@ -21,6 +21,7 @@ RO_VPD@0x0 0x1000 } RW_MRC_CACHE@0x10000 0x10000 - COREBOOT(CBFS)@0x20000 0x7e0000 + CONSOLE@0x20000 0x10000 + COREBOOT(CBFS)@0x30000 0x7d0000 } } diff --git a/src/soc/intel/fsp_broadwell_de/Kconfig b/src/soc/intel/fsp_broadwell_de/Kconfig index cc3e6e2..37876b5 100644 --- a/src/soc/intel/fsp_broadwell_de/Kconfig +++ b/src/soc/intel/fsp_broadwell_de/Kconfig @@ -26,6 +26,7 @@ select SMM_TSEG select HAVE_SMI_HANDLER select TSC_MONOTONIC_TIMER + select TSC_CONSTANT_RATE config CBFS_SIZE hex diff --git a/src/soc/intel/fsp_broadwell_de/Makefile.inc b/src/soc/intel/fsp_broadwell_de/Makefile.inc index 024035c..386adc1 100644 --- a/src/soc/intel/fsp_broadwell_de/Makefile.inc +++ b/src/soc/intel/fsp_broadwell_de/Makefile.inc @@ -12,6 +12,7 @@ subdirs-y += fsp romstage-y += gpio.c +romstage-y += spi.c ramstage-y += spi.c ramstage-y += cpu.c diff --git a/src/soc/intel/fsp_broadwell_de/spi.c b/src/soc/intel/fsp_broadwell_de/spi.c index f602491..1b1589d 100644 --- a/src/soc/intel/fsp_broadwell_de/spi.c +++ b/src/soc/intel/fsp_broadwell_de/spi.c @@ -26,6 +26,7 @@ #include <device/pci_ids.h> #include <spi_flash.h> #include <spi-generic.h> +#include <arch/early_variables.h> #ifdef __SMM__ #define pci_read_config_byte(dev, reg, targ)\ @@ -59,7 +60,7 @@ typedef struct spi_slave ich_spi_slave; -static int ichspi_lock = 0; +static int ichspi_lock CAR_GLOBAL = 0; typedef struct ich9_spi_regs { uint32_t bfpr; @@ -109,7 +110,7 @@ uint32_t *bbar; } ich_spi_controller; -static ich_spi_controller cntlr; +static ich_spi_controller cntlr CAR_GLOBAL; enum { SPIS_SCIP = 0x0001, @@ -268,7 +269,7 @@ uint8_t bios_cntl; ich9_spi_regs *ich9_spi; -#ifdef __SMM__ +#if defined(__SIMPLE_DEVICE__) pci_devfn_t dev = PCI_DEV(0, 31, 0); #else struct device *dev; -- To view, visit https://review.coreboot.org/28528 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib925c5aee88b65c46a81534405c364dd5649f8e8 Gerrit-Change-Number: 28528 Gerrit-PatchSet: 1 Gerrit-Owner: Okash Khawaja <okash.khawaja(a)gmail.com>

1 0

Change in coreboot[master]: wedge100s: enable mrc cache in fmap
by Patrick Rudolph (Code Review) 06 Sep '18

06 Sep '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28527 ) Change subject: wedge100s: enable mrc cache in fmap ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/28527/3/src/mainboard/ocp/wedge100s/Kconfig File src/mainboard/ocp/wedge100s/Kconfig: https://review.coreboot.org/#/c/28527/3/src/mainboard/ocp/wedge100s/Kconfig… PS3, Line 15: select ENABLE_FSP_FAST_BOOT that wont allow the user to change the option any more -- To view, visit https://review.coreboot.org/28527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27cd236f67a6500b40fc3eb731397d408402f041 Gerrit-Change-Number: 28527 Gerrit-PatchSet: 3 Gerrit-Owner: Okash Khawaja <okash.khawaja(a)gmail.com> Gerrit-Reviewer: Okash Khawaja <okash.khawaja(a)gmail.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 06 Sep 2018 13:28:30 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: wedge100s: enable mrc cache in fmap
by Patrick Rudolph (Code Review) 06 Sep '18

06 Sep '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28527 ) Change subject: wedge100s: enable mrc cache in fmap ...................................................................... Patch Set 3: config MRC_CACHE_FMAP default y in mainboard kconfig ? -- To view, visit https://review.coreboot.org/28527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27cd236f67a6500b40fc3eb731397d408402f041 Gerrit-Change-Number: 28527 Gerrit-PatchSet: 3 Gerrit-Owner: Okash Khawaja <okash.khawaja(a)gmail.com> Gerrit-Reviewer: Okash Khawaja <okash.khawaja(a)gmail.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 06 Sep 2018 13:26:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: wedge100s: enable mrc cache in fmap
by Philipp Deppenwiese (Code Review) 06 Sep '18

06 Sep '18

Philipp Deppenwiese has uploaded a new patch set (#3) to the change originally created by Okash Khawaja. ( https://review.coreboot.org/28527 ) Change subject: wedge100s: enable mrc cache in fmap ...................................................................... wedge100s: enable mrc cache in fmap this enables mrc cache in fmap for wedge100s and enables it in Kconfig as default. Change-Id: I27cd236f67a6500b40fc3eb731397d408402f041 Signed-off-by: Okash Khawaja <okash.khawaja(a)gmail.com> --- M src/mainboard/ocp/wedge100s/Kconfig M src/mainboard/ocp/wedge100s/board.fmd 2 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/28527/3 -- To view, visit https://review.coreboot.org/28527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I27cd236f67a6500b40fc3eb731397d408402f041 Gerrit-Change-Number: 28527 Gerrit-PatchSet: 3 Gerrit-Owner: Okash Khawaja <okash.khawaja(a)gmail.com> Gerrit-Reviewer: Okash Khawaja <okash.khawaja(a)gmail.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: wedge100s: enable mrc cache in fmap
by Okash Khawaja (Code Review) 06 Sep '18

06 Sep '18

Okash Khawaja has posted comments on this change. ( https://review.coreboot.org/28527 ) Change subject: wedge100s: enable mrc cache in fmap ...................................................................... Patch Set 2: > Patch Set 2: Verified-1 > > Build Unstable > > https://qa.coreboot.org/job/coreboot-gerrit/79020/ : UNSTABLE > > https://qa.coreboot.org/job/coreboot-checkpatch/32792/ : SUCCESS it's a warning as error: warning: (BOARD_SPECIFIC_OPTIONS && VBOOT) selects MRC_CACHE_FMAP which has unmet direct dependencies (PLATFORM_USES_FSP1_0 && ENABLE_MRC_CACHE || PLATFORM_USES_FSP1_0 && ENABLE_MRC_CACHE) do we need to update this? -- To view, visit https://review.coreboot.org/28527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27cd236f67a6500b40fc3eb731397d408402f041 Gerrit-Change-Number: 28527 Gerrit-PatchSet: 2 Gerrit-Owner: Okash Khawaja <okash.khawaja(a)gmail.com> Gerrit-Reviewer: Okash Khawaja <okash.khawaja(a)gmail.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 06 Sep 2018 12:12:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: wedge100s: enable mrc cache in fmap
by Okash Khawaja (Code Review) 06 Sep '18

06 Sep '18

Hello Philipp Deppenwiese, I'd like you to reexamine a change. Please visit https://review.coreboot.org/28527 to look at the new patch set (#2). Change subject: wedge100s: enable mrc cache in fmap ...................................................................... wedge100s: enable mrc cache in fmap this enables mrc cache in fmap for wedge100s and enables it in Kconfig as default. Change-Id: I27cd236f67a6500b40fc3eb731397d408402f041 Signed-off-by: Okash Khawaja <okash.khawaja(a)gmail.com> --- M src/mainboard/ocp/wedge100s/Kconfig M src/mainboard/ocp/wedge100s/board.fmd 2 files changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/28527/2 -- To view, visit https://review.coreboot.org/28527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I27cd236f67a6500b40fc3eb731397d408402f041 Gerrit-Change-Number: 28527 Gerrit-PatchSet: 2 Gerrit-Owner: Okash Khawaja <okash.khawaja(a)gmail.com> Gerrit-Reviewer: Okash Khawaja <okash.khawaja(a)gmail.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>

1 0

Change in coreboot[master]: wedge100s: enable mrc cache in fmap
by Philipp Deppenwiese (Code Review) 06 Sep '18

06 Sep '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/28527 ) Change subject: wedge100s: enable mrc cache in fmap ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/28527/1/src/mainboard/ocp/wedge100s/board.f… File src/mainboard/ocp/wedge100s/board.fmd: https://review.coreboot.org/#/c/28527/1/src/mainboard/ocp/wedge100s/board.f… PS1, Line 24: COREBOOT(CBFS)@0x20000 0x7f0000 Reduce 0x7f0000-10000 -- To view, visit https://review.coreboot.org/28527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27cd236f67a6500b40fc3eb731397d408402f041 Gerrit-Change-Number: 28527 Gerrit-PatchSet: 1 Gerrit-Owner: Okash Khawaja <okash.khawaja(a)gmail.com> Gerrit-Reviewer: Okash Khawaja <okash.khawaja(a)gmail.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Comment-Date: Thu, 06 Sep 2018 11:58:51 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

← Newer
1
...
71
72
73
74
75
76
77
...
89
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2018