coreboot-gerrit September 2018

coreboot-gerrit@coreboot.org

1 participants
886 discussions

Change in coreboot[master]: wedge100s: Add TPM support
by Philipp Deppenwiese (Code Review) 07 Sep '18

07 Sep '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/28529 ) Change subject: wedge100s: Add TPM support ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/28529 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7e8ad63de2a6094c66cbd47ae9b7707a9af4e81 Gerrit-Change-Number: 28529 Gerrit-PatchSet: 4 Gerrit-Owner: Mikołaj Walczak (1002108) Gerrit-Reviewer: Mikołaj Walczak (1002108) Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Andrea Barberio <insomniac(a)slackware.it> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Fri, 07 Sep 2018 10:54:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/poppy/variants/rammus: Enable DA7219
by Zhuohao Lee (Code Review) 07 Sep '18

07 Sep '18

Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/28537 ) Change subject: mainboard/google/poppy/variants/rammus: Enable DA7219 ...................................................................... Patch Set 3: Code-Review+1 okay, thanks Marx -- To view, visit https://review.coreboot.org/28537 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92dd412374d007aab264661e698fbbbbcf1eae45 Gerrit-Change-Number: 28537 Gerrit-PatchSet: 3 Gerrit-Owner: Marx Wang <marx.wang(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Marx Wang <marx.wang(a)intel.com> Gerrit-Reviewer: YanRu Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Sep 2018 10:36:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: wedge100s: Add TPM support
by Philipp Deppenwiese (Code Review) 07 Sep '18

07 Sep '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/28529 ) Change subject: wedge100s: Add TPM support ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/28529 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7e8ad63de2a6094c66cbd47ae9b7707a9af4e81 Gerrit-Change-Number: 28529 Gerrit-PatchSet: 3 Gerrit-Owner: Mikołaj Walczak (1002108) Gerrit-Reviewer: Mikołaj Walczak (1002108) Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Andrea Barberio <insomniac(a)slackware.it> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Fri, 07 Sep 2018 10:26:39 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: fsp_broadwell_de: enable spi console
by Philipp Deppenwiese (Code Review) 07 Sep '18

07 Sep '18

Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/28528 ) Change subject: fsp_broadwell_de: enable spi console ...................................................................... fsp_broadwell_de: enable spi console this enables spi console for wedge100s with broadwell_de. the console size is 64kb. enabling spi console in `board.fmd` enables code which calls into `timer_monotonic_get` (from `spi_flash_cmd_poll_bit`) and `udelay` (from `ich_status_poll`). this patch selects `TSC_CONSTANT_RATE` in fsp_broadwell_de's Kconfig to satisfy that. Change-Id: Ib925c5aee88b65c46a81534405c364dd5649f8e8 Signed-off-by: Okash Khawaja <okash.khawaja(a)gmail.com> Reviewed-on: https://review.coreboot.org/28528 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> --- M src/mainboard/ocp/wedge100s/board.fmd M src/soc/intel/fsp_broadwell_de/Kconfig M src/soc/intel/fsp_broadwell_de/Makefile.inc M src/soc/intel/fsp_broadwell_de/spi.c 4 files changed, 8 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Philipp Deppenwiese: Looks good to me, approved diff --git a/src/mainboard/ocp/wedge100s/board.fmd b/src/mainboard/ocp/wedge100s/board.fmd index da6e3e3..8e44081 100644 --- a/src/mainboard/ocp/wedge100s/board.fmd +++ b/src/mainboard/ocp/wedge100s/board.fmd @@ -21,6 +21,7 @@ RO_VPD@0x0 0x1000 } RW_MRC_CACHE@0x10000 0x10000 - COREBOOT(CBFS)@0x20000 0x7e0000 + CONSOLE@0x20000 0x10000 + COREBOOT(CBFS)@0x30000 0x7d0000 } } diff --git a/src/soc/intel/fsp_broadwell_de/Kconfig b/src/soc/intel/fsp_broadwell_de/Kconfig index cc3e6e2..37876b5 100644 --- a/src/soc/intel/fsp_broadwell_de/Kconfig +++ b/src/soc/intel/fsp_broadwell_de/Kconfig @@ -26,6 +26,7 @@ select SMM_TSEG select HAVE_SMI_HANDLER select TSC_MONOTONIC_TIMER + select TSC_CONSTANT_RATE config CBFS_SIZE hex diff --git a/src/soc/intel/fsp_broadwell_de/Makefile.inc b/src/soc/intel/fsp_broadwell_de/Makefile.inc index 024035c..386adc1 100644 --- a/src/soc/intel/fsp_broadwell_de/Makefile.inc +++ b/src/soc/intel/fsp_broadwell_de/Makefile.inc @@ -12,6 +12,7 @@ subdirs-y += fsp romstage-y += gpio.c +romstage-y += spi.c ramstage-y += spi.c ramstage-y += cpu.c diff --git a/src/soc/intel/fsp_broadwell_de/spi.c b/src/soc/intel/fsp_broadwell_de/spi.c index f602491..1b1589d 100644 --- a/src/soc/intel/fsp_broadwell_de/spi.c +++ b/src/soc/intel/fsp_broadwell_de/spi.c @@ -26,6 +26,7 @@ #include <device/pci_ids.h> #include <spi_flash.h> #include <spi-generic.h> +#include <arch/early_variables.h> #ifdef __SMM__ #define pci_read_config_byte(dev, reg, targ)\ @@ -59,7 +60,7 @@ typedef struct spi_slave ich_spi_slave; -static int ichspi_lock = 0; +static int ichspi_lock CAR_GLOBAL = 0; typedef struct ich9_spi_regs { uint32_t bfpr; @@ -109,7 +110,7 @@ uint32_t *bbar; } ich_spi_controller; -static ich_spi_controller cntlr; +static ich_spi_controller cntlr CAR_GLOBAL; enum { SPIS_SCIP = 0x0001, @@ -268,7 +269,7 @@ uint8_t bios_cntl; ich9_spi_regs *ich9_spi; -#ifdef __SMM__ +#if defined(__SIMPLE_DEVICE__) pci_devfn_t dev = PCI_DEV(0, 31, 0); #else struct device *dev; -- To view, visit https://review.coreboot.org/28528 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib925c5aee88b65c46a81534405c364dd5649f8e8 Gerrit-Change-Number: 28528 Gerrit-PatchSet: 5 Gerrit-Owner: Okash Khawaja <okash.khawaja(a)gmail.com> Gerrit-Reviewer: Okash Khawaja <okash.khawaja(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mainboard/google/poppy/variants/rammus: Enable DA7219
by Marx Wang (Code Review) 07 Sep '18

07 Sep '18

Marx Wang has posted comments on this change. ( https://review.coreboot.org/28537 ) Change subject: mainboard/google/poppy/variants/rammus: Enable DA7219 ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/28537/3/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/rammus/devicetree.cb: https://review.coreboot.org/#/c/28537/3/src/mainboard/google/poppy/variants… PS3, Line 296: GPP_D9_IRQ > Could you please help to check this pin setting in the gpio. […] As I checked the schematics(GPP_D9/HP_IRQ_GPIO), we don't need to modify gpio.c. will double check the IRQ function after DA7219 driver is ready by using "evtest". Thanks. -- To view, visit https://review.coreboot.org/28537 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92dd412374d007aab264661e698fbbbbcf1eae45 Gerrit-Change-Number: 28537 Gerrit-PatchSet: 3 Gerrit-Owner: Marx Wang <marx.wang(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Marx Wang <marx.wang(a)intel.com> Gerrit-Reviewer: YanRu Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Sep 2018 09:38:20 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/google/poppy/variants/rammus: Enable DA7219
by Marx Wang (Code Review) 07 Sep '18

07 Sep '18

Marx Wang has posted comments on this change. ( https://review.coreboot.org/28537 ) Change subject: mainboard/google/poppy/variants/rammus: Enable DA7219 ...................................................................... Patch Set 3: > Patch Set 3: > > (1 comment) As I checked the schematics(GPP_D9/HP_IRQ_GPIO), we don't need to modify gpio.c. will double check the IRQ function after DA7219 driver is ready by using "evtest". Thanks. -- To view, visit https://review.coreboot.org/28537 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92dd412374d007aab264661e698fbbbbcf1eae45 Gerrit-Change-Number: 28537 Gerrit-PatchSet: 3 Gerrit-Owner: Marx Wang <marx.wang(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Marx Wang <marx.wang(a)intel.com> Gerrit-Reviewer: YanRu Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Sep 2018 09:32:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/google/poppy/variants/rammus: Enable DA7219
by Zhuohao Lee (Code Review) 07 Sep '18

07 Sep '18

Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/28537 ) Change subject: mainboard/google/poppy/variants/rammus: Enable DA7219 ...................................................................... Patch Set 3: (1 comment) https://review.coreboot.org/#/c/28537/3/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/rammus/devicetree.cb: https://review.coreboot.org/#/c/28537/3/src/mainboard/google/poppy/variants… PS3, Line 296: GPP_D9_IRQ Could you please help to check this pin setting in the gpio.c? Do we need to change it? -- To view, visit https://review.coreboot.org/28537 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92dd412374d007aab264661e698fbbbbcf1eae45 Gerrit-Change-Number: 28537 Gerrit-PatchSet: 3 Gerrit-Owner: Marx Wang <marx.wang(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Marx Wang <marx.wang(a)intel.com> Gerrit-Reviewer: YanRu Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 07 Sep 2018 08:03:14 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/google/poppy/variants/rammus: Enable DA7219
by Marx Wang (Code Review) 07 Sep '18

07 Sep '18

Hello Zhuohao Lee, YanRu Chen, build bot (Jenkins), Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/28537 to look at the new patch set (#3). Change subject: mainboard/google/poppy/variants/rammus: Enable DA7219 ...................................................................... mainboard/google/poppy/variants/rammus: Enable DA7219 On rammus, headset uses DA7219 so that we need to enable it. BUG=b:112945714 BRANCH=master TEST=emerge-rammus coreboot chromeos-bootimage Flash FW and check in kernel to see if DA7219 is up. Change-Id: I92dd412374d007aab264661e698fbbbbcf1eae45 Signed-off-by: marxwang <marx.wang(a)intel.com> --- M src/mainboard/google/poppy/variants/rammus/devicetree.cb 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/28537/3 -- To view, visit https://review.coreboot.org/28537 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I92dd412374d007aab264661e698fbbbbcf1eae45 Gerrit-Change-Number: 28537 Gerrit-PatchSet: 3 Gerrit-Owner: Marx Wang <marx.wang(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Marx Wang <marx.wang(a)intel.com> Gerrit-Reviewer: YanRu Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mainboard/google/poppy/variants/rammus: Enable DA7219
by Marx Wang (Code Review) 07 Sep '18

07 Sep '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28537 to look at the new patch set (#2). Change subject: mainboard/google/poppy/variants/rammus: Enable DA7219 ...................................................................... mainboard/google/poppy/variants/rammus: Enable DA7219 On rammus, headset uses DA7219 so that we need to enable it. BUG=none BRANCH=master TEST=emerge-rammus coreboot chromeos-bootimage Flash FW and check in kernel to see if DA7219 is up. Change-Id: I92dd412374d007aab264661e698fbbbbcf1eae45 Signed-off-by: marxwang <marx.wang(a)intel.com> --- M src/mainboard/google/poppy/variants/rammus/devicetree.cb 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/28537/2 -- To view, visit https://review.coreboot.org/28537 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I92dd412374d007aab264661e698fbbbbcf1eae45 Gerrit-Change-Number: 28537 Gerrit-PatchSet: 2 Gerrit-Owner: Marx Wang <marx.wang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: mb/google/poppy/variants/atlas: enable NVMe
by Furquan Shaikh (Code Review) 07 Sep '18

07 Sep '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/28535 ) Change subject: mb/google/poppy/variants/atlas: enable NVMe ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28535 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08e7c4d65662ddbb7d936915c896eb1fcb240ba8 Gerrit-Change-Number: 28535 Gerrit-PatchSet: 1 Gerrit-Owner: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org> Gerrit-Comment-Date: Fri, 07 Sep 2018 06:37:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

← Newer
1
...
68
69
70
71
72
73
74
...
89
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2018