coreboot-gerrit September 2018

coreboot-gerrit@coreboot.org

1 participants
886 discussions

Change in coreboot[master]: util/board_status: Add support of CMOS values dump
by build bot (Jenkins) (Code Review) 10 Sep '18

10 Sep '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28565 ) Change subject: util/board_status: Add support of CMOS values dump ...................................................................... Patch Set 2: (5 comments) https://review.coreboot.org/#/c/28565/2/util/board_status/board_status.sh File util/board_status/board_status.sh: https://review.coreboot.org/#/c/28565/2/util/board_status/board_status.sh@30 PS2, Line 30: # Used if nvramtool is not in default $PATH, e.g. not installed or when using `sudo` line over 80 characters https://review.coreboot.org/#/c/28565/2/util/board_status/board_status.sh@3… PS2, Line 383: if grep -q "CONFIG_USE_OPTION_TABLE=y" "${tmpdir}/${results}/config.short.txt" > /dev/null; then line over 80 characters https://review.coreboot.org/#/c/28565/2/util/board_status/board_status.sh@4… PS2, Line 407: cmd $REMOTE "$nvramtool_cmd -a" "${tmpdir}/${results}/cmos_values.txt" line over 80 characters https://review.coreboot.org/#/c/28565/2/util/board_status/board_status.sh@4… PS2, Line 437: echo "Failed to run $nvramtool_cmd. Check \$PATH or" \ line over 80 characters https://review.coreboot.org/#/c/28565/2/util/board_status/board_status.sh@4… PS2, Line 448: cmd $LOCAL "$nvramtool_cmd -a" "${tmpdir}/${results}/cmos_values.txt" line over 80 characters -- To view, visit https://review.coreboot.org/28565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89f9a0e9622557b01dda52378f8f1323777bce39 Gerrit-Change-Number: 28565 Gerrit-PatchSet: 2 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 10 Sep 2018 21:21:33 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/board_status: Add support of CMOS values dump
by Evgeny Zinoviev (Code Review) 10 Sep '18

10 Sep '18

Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/28565 ) Change subject: util/board_status: Add support of CMOS values dump ...................................................................... Patch Set 1: Lines over 80 characters are all over this script, I'm not sure if I should fix it in this commit. -- To view, visit https://review.coreboot.org/28565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89f9a0e9622557b01dda52378f8f1323777bce39 Gerrit-Change-Number: 28565 Gerrit-PatchSet: 1 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 10 Sep 2018 21:08:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/board_status: Add support of CMOS values dump
by build bot (Jenkins) (Code Review) 10 Sep '18

10 Sep '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28565 ) Change subject: util/board_status: Add support of CMOS values dump ...................................................................... Patch Set 1: (5 comments) https://review.coreboot.org/#/c/28565/1/util/board_status/board_status.sh File util/board_status/board_status.sh: https://review.coreboot.org/#/c/28565/1/util/board_status/board_status.sh@30 PS1, Line 30: # Used if nvramtool is not in default $PATH, e.g. not installed or when using `sudo` line over 80 characters https://review.coreboot.org/#/c/28565/1/util/board_status/board_status.sh@3… PS1, Line 383: if grep -q "CONFIG_USE_OPTION_TABLE=y" "${tmpdir}/${results}/config.short.txt" > /dev/null; then line over 80 characters https://review.coreboot.org/#/c/28565/1/util/board_status/board_status.sh@4… PS1, Line 407: cmd $REMOTE "$nvramtool_cmd -a" "${tmpdir}/${results}/cmos_values.txt" line over 80 characters https://review.coreboot.org/#/c/28565/1/util/board_status/board_status.sh@4… PS1, Line 437: echo "Failed to run $nvramtool_cmd. Check \$PATH or" \ line over 80 characters https://review.coreboot.org/#/c/28565/1/util/board_status/board_status.sh@4… PS1, Line 448: cmd $LOCAL "$nvramtool_cmd -a" "${tmpdir}/${results}/cmos_values.txt" line over 80 characters -- To view, visit https://review.coreboot.org/28565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89f9a0e9622557b01dda52378f8f1323777bce39 Gerrit-Change-Number: 28565 Gerrit-PatchSet: 1 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 10 Sep 2018 21:06:21 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/board_status: Add support of CMOS values dump
by Evgeny Zinoviev (Code Review) 10 Sep '18

10 Sep '18

Evgeny Zinoviev has uploaded this change for review. ( https://review.coreboot.org/28565 Change subject: util/board_status: Add support of CMOS values dump ...................................................................... util/board_status: Add support of CMOS values dump Change-Id: I89f9a0e9622557b01dda52378f8f1323777bce39 Signed-off-by: Evgeny Zinoviev <me(a)ch1p.com> --- M util/board_status/board_status.sh 1 file changed, 47 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/28565/1 diff --git a/util/board_status/board_status.sh b/util/board_status/board_status.sh index 13c58e1..132056d 100755 --- a/util/board_status/board_status.sh +++ b/util/board_status/board_status.sh @@ -27,6 +27,9 @@ # Used if cbmem is not in default $PATH, e.g. not installed or when using `sudo` CBMEM_PATH="" +# Used if nvramtool is not in default $PATH, e.g. not installed or when using `sudo` +NVRAMTOOL_PATH="" + # test a command # # $1: 0 ($LOCAL) to run command locally, @@ -176,6 +179,8 @@ Options -c, --cbmem Path to cbmem on device under test (DUT). + -n, --nvramtool + Path to nvramtool on device under test (DUT). -C, --clobber Clobber temporary output when finished. Useful for debugging. -h, --help @@ -207,7 +212,7 @@ LONGOPTS="${LONGOPTS},serial-device:,serial-speed:" LONGOPTS="${LONGOPTS},ssh-port:" -ARGS=$(getopt -o c:Chi:r:s:S:u -l "$LONGOPTS" -n "$0" -- "$@"); +ARGS=$(getopt -o c:n:Chi:r:s:S:u -l "$LONGOPTS" -n "$0" -- "$@"); if [ $? != 0 ] ; then echo "Terminating..." >&2 ; exit 1 ; fi eval set -- "$ARGS" while true ; do @@ -217,6 +222,10 @@ shift CBMEM_PATH="$1" ;; + -n|--nvramtool) + shift + NVRAMTOOL_PATH="$1" + ;; -C|--clobber) CLOBBER_OUTPUT=1 ;; @@ -370,6 +379,17 @@ cbmem_cmd="cbmem" fi +cmos_enabled=0 +if grep -q "CONFIG_USE_OPTION_TABLE=y" "${tmpdir}/${results}/config.short.txt" > /dev/null; then + cmos_enabled=1 +fi + +if [ -n "$NVRAMTOOL_PATH" ]; then + nvramtool_cmd="$NVRAMTOOL_PATH" +else + nvramtool_cmd="nvramtool" +fi + if [ -n "$SERIAL_DEVICE" ]; then get_serial_bootlog "$SERIAL_DEVICE" "$SERIAL_PORT_SPEED" "${tmpdir}/${results}/coreboot_console.txt" elif [ -n "$REMOTE_HOST" ]; then @@ -380,6 +400,13 @@ echo "Getting timestamp data" cmd_nonfatal $REMOTE "$cbmem_cmd -t" "${tmpdir}/${results}/coreboot_timestamps.txt" + if [ "$cmos_enabled" -eq 1 ]; then + echo "Verifying that nvramtool is available on remote device" + test_cmd $REMOTE "$nvramtool_cmd" + echo "Getting all CMOS values" + cmd $REMOTE "$nvramtool_cmd -a" "${tmpdir}/${results}/cmos_values.txt" + fi + echo "Getting remote dmesg" cmd $REMOTE dmesg "${tmpdir}/${results}/kernel_log.txt" else @@ -402,6 +429,25 @@ echo "Getting timestamp data" cmd_nonfatal $LOCAL "$cbmem_cmd -t" "${tmpdir}/${results}/coreboot_timestamps.txt" + if [ "$cmos_enabled" -eq 1 ]; then + echo "Verifying that nvramtool is available" + if [ $(id -u) -ne 0 ]; then + command -v "$nvramtool_cmd" >/dev/null + if [ $? -ne 0 ]; then + echo "Failed to run $nvramtool_cmd. Check \$PATH or" \ + "use -n to specify path to nvramtool binary." + exit $EXIT_FAILURE + else + nvramtool_cmd="sudo $nvramtool_cmd" + fi + else + test_cmd $LOCAL "$nvramtool_cmd" + fi + + echo "Getting all CMOS values" + cmd $LOCAL "$nvramtool_cmd -a" "${tmpdir}/${results}/cmos_values.txt" + fi + echo "Getting local dmesg" cmd $LOCAL dmesg "${tmpdir}/${results}/kernel_log.txt" fi -- To view, visit https://review.coreboot.org/28565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I89f9a0e9622557b01dda52378f8f1323777bce39 Gerrit-Change-Number: 28565 Gerrit-PatchSet: 1 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.com>

1 0

Change in coreboot[master]: mb/google/kahlee/variants/baseboard: Set STAPM percentage
by Richard Spiegel (Code Review) 10 Sep '18

10 Sep '18

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/28564 Change subject: mb/google/kahlee/variants/baseboard: Set STAPM percentage ...................................................................... mb/google/kahlee/variants/baseboard: Set STAPM percentage Default STAPM percentage is 68%, which causes a lot of thermal throttling. AMD experimented with 80%, it works for grunt. This is initial code to provide easy change path for other grunt based platforms. BUG=b:111608748 TEST=build and boot grunt. Change-Id: I22863f6ed76152bf872fce3e275f8a7fd8077504 Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/mainboard/google/kahlee/Kconfig M src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/28564/1 diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig index 9180906..6f05fb8 100644 --- a/src/mainboard/google/kahlee/Kconfig +++ b/src/mainboard/google/kahlee/Kconfig @@ -88,6 +88,10 @@ int default 4 +config STAPM_PERCENT + int + default 80 + config IRQ_SLOT_COUNT int default 11 diff --git a/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c b/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c index 4c5a294..c125af6 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c +++ b/src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c @@ -151,4 +151,6 @@ InitEarly->GnbConfig.PsppPolicy = PsppBalanceLow; InitEarly->PlatformConfig.GnbAzI2sBusSelect = GnbAcpI2sBus; InitEarly->PlatformConfig.GnbAzI2sBusPinConfig = GnbAcp2Tx4RxBluetooth; + InitEarly->PlatformConfig.PlatStapmConfig.CfgStapmScalar = + CONFIG_STAPM_PERCENT; } -- To view, visit https://review.coreboot.org/28564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I22863f6ed76152bf872fce3e275f8a7fd8077504 Gerrit-Change-Number: 28564 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: amd/stoneyridge: Set BERT region size when no TSEG used
by Marc Jones (Code Review) 10 Sep '18

10 Sep '18

Marc Jones has posted comments on this change. ( https://review.coreboot.org/28554 ) Change subject: amd/stoneyridge: Set BERT region size when no TSEG used ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28554 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90753fa408cfac4de38aff08979c45349bb62a66 Gerrit-Change-Number: 28554 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 10 Sep 2018 20:40:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/sifive: fix compiler warning
by Patrick Georgi (Code Review) 10 Sep '18

10 Sep '18

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/28553 ) Change subject: soc/sifive: fix compiler warning ...................................................................... soc/sifive: fix compiler warning Fix the following compiler warning on the latest toolchain: src/soc/sifive/fu540/otp.c:48:1: error: useless storage class specifier in empty declaration [-Werror] } __packed; ^ Change-Id: Ice87c821de7650ac547394efa2a4bcc5ae1ea668 Signed-off-by: Philipp Hug <philipp(a)hug.cx> Reviewed-on: https://review.coreboot.org/28553 Tested-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M src/soc/sifive/fu540/otp.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Patrick Georgi: Verified; Looks good to me, approved diff --git a/src/soc/sifive/fu540/otp.c b/src/soc/sifive/fu540/otp.c index e6900fe..73a5573 100644 --- a/src/soc/sifive/fu540/otp.c +++ b/src/soc/sifive/fu540/otp.c @@ -29,7 +29,7 @@ * https://www.sifive.com/documentation/chips/freedom-u540-c000-manual/ */ -typedef struct sifive_otp_registers { +struct sifive_otp_registers { u32 pa; /* Address input */ u32 paio; /* Program address input */ u32 pas; /* Program redundancy cell selection input */ -- To view, visit https://review.coreboot.org/28553 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ice87c821de7650ac547394efa2a4bcc5ae1ea668 Gerrit-Change-Number: 28553 Gerrit-PatchSet: 2 Gerrit-Owner: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/sifive/fu540: Makefile: include mtime_init in ramstage
by Patrick Georgi (Code Review) 10 Sep '18

10 Sep '18

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/28551 ) Change subject: soc/sifive/fu540: Makefile: include mtime_init in ramstage ...................................................................... soc/sifive/fu540: Makefile: include mtime_init in ramstage Fix compilation issue clint.c/mtime.c is needed as well in ramstage due to CR 28372 and 28355 Change-Id: I7c7768744a165b97978bb8f7f95acf7b32ca4aa4 Signed-off-by: Philipp Hug <philipp(a)hug.cx> Reviewed-on: https://review.coreboot.org/28551 Tested-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M src/soc/lowrisc/lowrisc/Makefile.inc M src/soc/sifive/fu540/Makefile.inc M src/soc/ucb/riscv/Makefile.inc 3 files changed, 3 insertions(+), 0 deletions(-) Approvals: Patrick Georgi: Verified; Looks good to me, approved diff --git a/src/soc/lowrisc/lowrisc/Makefile.inc b/src/soc/lowrisc/lowrisc/Makefile.inc index 9fc52da..ccd9a16 100644 --- a/src/soc/lowrisc/lowrisc/Makefile.inc +++ b/src/soc/lowrisc/lowrisc/Makefile.inc @@ -3,5 +3,6 @@ bootblock-y += mtime.c romstage-y += cbmem.c ramstage-y += cbmem.c +ramstage-y += mtime.c endif diff --git a/src/soc/sifive/fu540/Makefile.inc b/src/soc/sifive/fu540/Makefile.inc index 12b814a..b991783 100644 --- a/src/soc/sifive/fu540/Makefile.inc +++ b/src/soc/sifive/fu540/Makefile.inc @@ -24,6 +24,7 @@ romstage-y += otp.c ramstage-y += uart.c +ramstage-y += clint.c ramstage-y += media.c ramstage-y += sdram.c ramstage-y += cbmem.c diff --git a/src/soc/ucb/riscv/Makefile.inc b/src/soc/ucb/riscv/Makefile.inc index 16225c0..a10f3aa 100644 --- a/src/soc/ucb/riscv/Makefile.inc +++ b/src/soc/ucb/riscv/Makefile.inc @@ -3,5 +3,6 @@ bootblock-y += mtime.c romstage-y += cbmem.c ramstage-y += cbmem.c +ramstage-y += mtime.c endif -- To view, visit https://review.coreboot.org/28551 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7c7768744a165b97978bb8f7f95acf7b32ca4aa4 Gerrit-Change-Number: 28551 Gerrit-PatchSet: 5 Gerrit-Owner: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/sifive/fu540: Makefile: include mtime_init in ramstage
by Patrick Georgi (Code Review) 10 Sep '18

10 Sep '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/28551 ) Change subject: soc/sifive/fu540: Makefile: include mtime_init in ramstage ...................................................................... Patch Set 4: Verified+1 Code-Review+2 -- To view, visit https://review.coreboot.org/28551 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c7768744a165b97978bb8f7f95acf7b32ca4aa4 Gerrit-Change-Number: 28551 Gerrit-PatchSet: 4 Gerrit-Owner: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 10 Sep 2018 20:36:44 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/sifive/fu540: Makefile: include mtime_init in ramstage
by Patrick Georgi (Code Review) 10 Sep '18

10 Sep '18

Patrick Georgi has removed a vote on this change. Change subject: soc/sifive/fu540: Makefile: include mtime_init in ramstage ...................................................................... Removed Verified-1 by build bot (Jenkins) <no-reply(a)coreboot.org> -- To view, visit https://review.coreboot.org/28551 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I7c7768744a165b97978bb8f7f95acf7b32ca4aa4 Gerrit-Change-Number: 28551 Gerrit-PatchSet: 4 Gerrit-Owner: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>

1 0

← Newer
1
...
63
64
65
66
67
68
69
...
89
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2018