coreboot-gerrit September 2018

coreboot-gerrit@coreboot.org

1 participants
886 discussions

Change in coreboot[master]: src/lib/edid: avoid buffer overflow
by Patrick Georgi (Code Review) 18 Sep '18

18 Sep '18

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/28659 Change subject: src/lib/edid: avoid buffer overflow ...................................................................... src/lib/edid: avoid buffer overflow It's more theoretical, but lest somebody calls extract_string() with too large a length... Change-Id: I3934bd6965318cdffe5c636b01b3e0c4426e8d1d Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> Found-by: Coverity Scan #1374795 --- M src/lib/edid.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/28659/1 diff --git a/src/lib/edid.c b/src/lib/edid.c index 9cf9b8a..0bfd20f 100644 --- a/src/lib/edid.c +++ b/src/lib/edid.c @@ -175,12 +175,12 @@ static char * extract_string(unsigned char *x, int *valid_termination, int len) { - static char ret[128]; + static char ret[EDID_ASCII_STRING_LENGTH + 1]; int i, seen_newline = 0; memset(ret, 0, sizeof(ret)); - for (i = 0; i < len; i++) { + for (i = 0; i < min(len, EDID_ASCII_STRING_LENGTH); i++) { if (seen_newline) { if (x[i] != 0x20) { *valid_termination = 0; @@ -284,7 +284,7 @@ printk(BIOS_SPEW, "Monitor name: %s\n", extract_string(x + 5, &c->has_valid_string_termination, - 13)); + EDID_ASCII_STRING_LENGTH)); return 1; case 0xFD: { @@ -476,7 +476,7 @@ case 0xFF: printk(BIOS_SPEW, "Serial number: %s\n", extract_string(x + 5, - &c->has_valid_string_termination, 13)); + &c->has_valid_string_termination, EDID_ASCII_STRING_LENGTH)); return 1; default: printk(BIOS_SPEW, -- To view, visit https://review.coreboot.org/28659 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3934bd6965318cdffe5c636b01b3e0c4426e8d1d Gerrit-Change-Number: 28659 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: nb/via/vx900: Get rid of device_t
by Patrick Georgi (Code Review) 18 Sep '18

18 Sep '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/28655 ) Change subject: nb/via/vx900: Get rid of device_t ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/28655 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70dcefd5bc9864931f66bece1f044f806f5d7ae0 Gerrit-Change-Number: 28655 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 18 Sep 2018 13:27:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: amd/common/psp: Remove use of PspBaseLib
by build bot (Jenkins) (Code Review) 18 Sep '18

18 Sep '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27619 ) Change subject: amd/common/psp: Remove use of PspBaseLib ...................................................................... Patch Set 13: (13 comments) https://review.coreboot.org/#/c/27619/13/src/soc/amd/common/block/include/a… File src/soc/amd/common/block/include/amdblocks/psp.h: https://review.coreboot.org/#/c/27619/13/src/soc/amd/common/block/include/a… PS13, Line 26: #define PSP_PCI_MIRRORCTRL1_REG 0x44 /* PSP Mirror Reg Ctrl */ line over 80 characters https://review.coreboot.org/#/c/27619/13/src/soc/amd/common/block/include/a… PS13, Line 27: #define PSP_PCI_EXTRAPCIHDR_REG 0x48 /* Extra PCI Header Ctrl */ line over 80 characters https://review.coreboot.org/#/c/27619/13/src/soc/amd/common/block/include/a… PS13, Line 29: #define PCI_CONFIG_SMU_INDIRECT_INDEX 0xb8 /* GNB index for SMU mbox */ line over 80 characters https://review.coreboot.org/#/c/27619/13/src/soc/amd/common/block/include/a… PS13, Line 30: #define PCI_CONFIG_SMU_INDIRECT_DATA 0xbc /* GNB data for SMU mbox */ line over 80 characters https://review.coreboot.org/#/c/27619/13/src/soc/amd/common/block/include/a… PS13, Line 32: #define PCI_MAGIC_REG1 0xb8 /* PSP Mailbox MMIO control */ line over 80 characters https://review.coreboot.org/#/c/27619/13/src/soc/amd/common/block/include/a… PS13, Line 33: #define PCI_MAGIC_REG2 0xbc /* PSP Mailbox MMIO control */ line over 80 characters https://review.coreboot.org/#/c/27619/13/src/soc/amd/common/block/include/a… PS13, Line 35: #define MAGIC_ENABLE_BITS 0x34 /* Extra PCI HDR Ctl Enables */ line over 80 characters https://review.coreboot.org/#/c/27619/13/src/soc/amd/common/block/include/a… PS13, Line 41: #define PMNXTPTRW_MASK 0xff /* PCI ACR MASK */ line over 80 characters https://review.coreboot.org/#/c/27619/13/src/soc/amd/common/block/include/a… PS13, Line 42: #define PMNXTPTRW_EXPOSE 0xa4 /* Control val to expose the ACR */ line over 80 characters https://review.coreboot.org/#/c/27619/13/src/soc/amd/common/block/include/a… PS13, Line 46: #define SMU_CC_PSP_FUSES_STATUS 0xc0018000ul /* GNB offset for PSP fusing */ line over 80 characters https://review.coreboot.org/#/c/27619/13/src/soc/amd/common/block/include/a… PS13, Line 50: #define PSP_MAILBOX_BASE 0x70 /* Mailbox offset from PCIe BAR */ line over 80 characters https://review.coreboot.org/#/c/27619/13/src/soc/amd/common/block/include/a… PS13, Line 52: #define MSR_CU_CBBCFG 0xc00110a2ul /* PSP Private Blk Base Addr */ line over 80 characters https://review.coreboot.org/#/c/27619/13/src/soc/amd/common/block/include/a… PS13, Line 53: #define BAR3HIDEBIT BIT(12) /* Bit to hide BAR3 addr if set */ line over 80 characters -- To view, visit https://review.coreboot.org/27619 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2740ceb945736c6e413f7d0bd0c41a19e19c7d5a Gerrit-Change-Number: 27619 Gerrit-PatchSet: 13 Gerrit-Owner: Charles Marslett <charles.marslett(a)amd.corp-partner.google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Charles Marslett <charles.marslett(a)amd.corp-partner.google.com> Gerrit-Reviewer: Charles Marslett <charles.marslett(a)silverbackltd.com> Gerrit-Reviewer: Marshall Dawson <marshall.dawson(a)se-eng.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Comment-Date: Tue, 18 Sep 2018 12:28:36 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: sb/intel/bd82x6x: Don't use device_t
by build bot (Jenkins) (Code Review) 18 Sep '18

18 Sep '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28657 ) Change subject: sb/intel/bd82x6x: Don't use device_t ...................................................................... Patch Set 5: (2 comments) https://review.coreboot.org/#/c/28657/5/src/southbridge/intel/bd82x6x/me_8.… File src/southbridge/intel/bd82x6x/me_8.x.c: https://review.coreboot.org/#/c/28657/5/src/southbridge/intel/bd82x6x/me_8.… PS5, Line 742: static void set_subsystem(struct device *dev, unsigned vendor, unsigned device) Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/28657/5/src/southbridge/intel/bd82x6x/me_8.… PS5, Line 742: static void set_subsystem(struct device *dev, unsigned vendor, unsigned device) Prefer 'unsigned int' to bare use of 'unsigned' -- To view, visit https://review.coreboot.org/28657 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4909ebffc978f537bbf6269d9e27dbaca43daa10 Gerrit-Change-Number: 28657 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 18 Sep 2018 11:56:39 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: sb/intel/bd82x6x: Don't use device_t
by Elyes HAOUAS (Code Review) 18 Sep '18

18 Sep '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28657 to look at the new patch set (#5). Change subject: sb/intel/bd82x6x: Don't use device_t ...................................................................... sb/intel/bd82x6x: Don't use device_t Use of device_t is deprecated. Change-Id: I4909ebffc978f537bbf6269d9e27dbaca43daa10 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/southbridge/intel/bd82x6x/me_8.x.c M src/southbridge/intel/bd82x6x/pch.c M src/southbridge/intel/bd82x6x/pch.h 3 files changed, 13 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/28657/5 -- To view, visit https://review.coreboot.org/28657 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4909ebffc978f537bbf6269d9e27dbaca43daa10 Gerrit-Change-Number: 28657 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/octopus: Enable DRAM_PART_NUM_IN_CBI feature for meep
by Wisley Chen (Code Review) 18 Sep '18

18 Sep '18

Hello Wisley Chen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28658 to look at the new patch set (#2). Change subject: mb/google/octopus: Enable DRAM_PART_NUM_IN_CBI feature for meep ...................................................................... mb/google/octopus: Enable DRAM_PART_NUM_IN_CBI feature for meep Enable DRAM_PART_NUM_IN_CBI feature to get DRAM part number from CBI and set DRAM_PART_IN_CBI_BOARD_ID_MIN to 1 for EVT. BUG=b:115965629 TEST=verified it in meep proto board which rework ram id. Signed-off-by: Wisley Chen <wisley.chen(a)quantatw.com> Change-Id: I962b099d5b9fbe0ca29708be1e9c6ed60b10d363 --- M src/mainboard/google/octopus/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/28658/2 -- To view, visit https://review.coreboot.org/28658 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I962b099d5b9fbe0ca29708be1e9c6ed60b10d363 Gerrit-Change-Number: 28658 Gerrit-PatchSet: 2 Gerrit-Owner: Wisley Chen <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: sb/intel/bd82x6x: Don't use device_t
by build bot (Jenkins) (Code Review) 18 Sep '18

18 Sep '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28657 ) Change subject: sb/intel/bd82x6x: Don't use device_t ...................................................................... Patch Set 4: (2 comments) https://review.coreboot.org/#/c/28657/4/src/southbridge/intel/bd82x6x/me_8.… File src/southbridge/intel/bd82x6x/me_8.x.c: https://review.coreboot.org/#/c/28657/4/src/southbridge/intel/bd82x6x/me_8.… PS4, Line 742: static void set_subsystem(struct device *dev, unsigned vendor, unsigned device) Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/28657/4/src/southbridge/intel/bd82x6x/me_8.… PS4, Line 742: static void set_subsystem(struct device *dev, unsigned vendor, unsigned device) Prefer 'unsigned int' to bare use of 'unsigned' -- To view, visit https://review.coreboot.org/28657 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4909ebffc978f537bbf6269d9e27dbaca43daa10 Gerrit-Change-Number: 28657 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 18 Sep 2018 11:45:29 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: sb/intel/bd82x6x: Don't use device_t
by Elyes HAOUAS (Code Review) 18 Sep '18

18 Sep '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28657 to look at the new patch set (#4). Change subject: sb/intel/bd82x6x: Don't use device_t ...................................................................... sb/intel/bd82x6x: Don't use device_t Use of device_t is deprecated. Change-Id: I4909ebffc978f537bbf6269d9e27dbaca43daa10 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/southbridge/intel/bd82x6x/me.c M src/southbridge/intel/bd82x6x/me_8.x.c M src/southbridge/intel/bd82x6x/pch.c M src/southbridge/intel/bd82x6x/pch.h 4 files changed, 14 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/28657/4 -- To view, visit https://review.coreboot.org/28657 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4909ebffc978f537bbf6269d9e27dbaca43daa10 Gerrit-Change-Number: 28657 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: sb/intel/bd82x6x: Don't use device_t
by build bot (Jenkins) (Code Review) 18 Sep '18

18 Sep '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28657 ) Change subject: sb/intel/bd82x6x: Don't use device_t ...................................................................... Patch Set 3: (2 comments) https://review.coreboot.org/#/c/28657/3/src/southbridge/intel/bd82x6x/me_8.… File src/southbridge/intel/bd82x6x/me_8.x.c: https://review.coreboot.org/#/c/28657/3/src/southbridge/intel/bd82x6x/me_8.… PS3, Line 742: static void set_subsystem(struct device *dev, unsigned vendor, unsigned device) Prefer 'unsigned int' to bare use of 'unsigned' https://review.coreboot.org/#/c/28657/3/src/southbridge/intel/bd82x6x/me_8.… PS3, Line 742: static void set_subsystem(struct device *dev, unsigned vendor, unsigned device) Prefer 'unsigned int' to bare use of 'unsigned' -- To view, visit https://review.coreboot.org/28657 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4909ebffc978f537bbf6269d9e27dbaca43daa10 Gerrit-Change-Number: 28657 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 18 Sep 2018 11:42:40 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: sb/intel/bd82x6x: Don't use device_t
by Elyes HAOUAS (Code Review) 18 Sep '18

18 Sep '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28657 to look at the new patch set (#3). Change subject: sb/intel/bd82x6x: Don't use device_t ...................................................................... sb/intel/bd82x6x: Don't use device_t Use of device_t is deprecated. Change-Id: I4909ebffc978f537bbf6269d9e27dbaca43daa10 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/southbridge/intel/bd82x6x/me_8.x.c M src/southbridge/intel/bd82x6x/pch.c M src/southbridge/intel/bd82x6x/pch.h 3 files changed, 13 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/28657/3 -- To view, visit https://review.coreboot.org/28657 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4909ebffc978f537bbf6269d9e27dbaca43daa10 Gerrit-Change-Number: 28657 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

← Newer
1
...
38
39
40
41
42
43
44
...
89
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2018