coreboot-gerrit September 2018

coreboot-gerrit@coreboot.org

1 participants
886 discussions

Change in coreboot[master]: google/cheza: Read MAC addresses from the VPD
by Matthias Kaehlcke (Code Review) 21 Sep '18

21 Sep '18

Matthias Kaehlcke has uploaded this change for review. ( https://review.coreboot.org/28712 Change subject: google/cheza: Read MAC addresses from the VPD ...................................................................... google/cheza: Read MAC addresses from the VPD The Bluetooth/WiFi module on cheza isn't pre-programmed with MAC addresses. Read the MAC addresses from the VPD and add them the coreboot tables. BUG=b:113114217 Change-Id: I35a6c343e60d3ff76610a7e1eec38b8e53644eec Signed-off-by: Matthias Kaehlcke <mka(a)chromium.org> --- M src/mainboard/google/cheza/mainboard.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/28712/1 diff --git a/src/mainboard/google/cheza/mainboard.c b/src/mainboard/google/cheza/mainboard.c index fdec3fb..e2c7ecb 100644 --- a/src/mainboard/google/cheza/mainboard.c +++ b/src/mainboard/google/cheza/mainboard.c @@ -13,6 +13,7 @@ * GNU General Public License for more details. */ +#include <boot/coreboot_tables.h> #include <device/device.h> #include <bootblock_common.h> #include <gpio.h> @@ -37,3 +38,11 @@ .name = CONFIG_MAINBOARD_PART_NUMBER, .enable_dev = mainboard_enable, }; + +void lb_board(struct lb_header *header) +{ +#if IS_ENABLED(CONFIG_CHROMEOS) + /* Retrieve WiFi and Bluetooth MAC addresses. */ + lb_table_add_macs_from_vpd(header); +#endif +} -- To view, visit https://review.coreboot.org/28712 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I35a6c343e60d3ff76610a7e1eec38b8e53644eec Gerrit-Change-Number: 28712 Gerrit-PatchSet: 1 Gerrit-Owner: Matthias Kaehlcke <mka(a)chromium.org>

1 0

Change in coreboot[master]: vpd: Add support for reading BD addreses from the VPD
by Matthias Kaehlcke (Code Review) 21 Sep '18

21 Sep '18

Matthias Kaehlcke has uploaded this change for review. ( https://review.coreboot.org/28711 Change subject: vpd: Add support for reading BD addreses from the VPD ...................................................................... vpd: Add support for reading BD addreses from the VPD Also scan the VPD for Bluetooth device addresses (BD_ADDR). Add them to the tables after Ethernet and WiFi MACs to avoid mismatches on existing systems that may have 'bluetooth_macX' set. BUG=b:113114217 Change-Id: Ib290fba2504f6ed80c3a95e24627ae5922e608af Signed-off-by: Matthias Kaehlcke <mka(a)chromium.org> --- M src/vendorcode/google/chromeos/vpd_mac.c 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/28711/1 diff --git a/src/vendorcode/google/chromeos/vpd_mac.c b/src/vendorcode/google/chromeos/vpd_mac.c index e3ef04b..08ca58c 100644 --- a/src/vendorcode/google/chromeos/vpd_mac.c +++ b/src/vendorcode/google/chromeos/vpd_mac.c @@ -59,10 +59,12 @@ void lb_table_add_macs_from_vpd(struct lb_header *header) { /* - * Mac addresses in the VPD can be stored in two groups, for ethernet - * and WiFi, with keys 'ethernet_macX and wifi_macX. + * Mac addresses in the VPD can be stored in three groups, for + * ethernet, WiFi and Bluetooh, with keys 'ethernet_macX, + * wifi_macX and bluetooth_macX */ - const char *mac_addr_key_bases[] = {"ethernet_mac0", "wifi_mac0"}; + const char *mac_addr_key_bases[] = {"ethernet_mac0", "wifi_mac0", + "bluetooth_mac0"}; char mac_addr_key[20]; /* large enough for either key */ char mac_addr_str[13]; /* 12 symbols and the trailing zero. */ int i, count; -- To view, visit https://review.coreboot.org/28711 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib290fba2504f6ed80c3a95e24627ae5922e608af Gerrit-Change-Number: 28711 Gerrit-PatchSet: 1 Gerrit-Owner: Matthias Kaehlcke <mka(a)chromium.org>

1 0

Change in coreboot[master]: mainboard/google/poppy/variants/rammus: Modify VR setting
by Gaggery Tsai (Code Review) 21 Sep '18

21 Sep '18

Gaggery Tsai has posted comments on this change. ( https://review.coreboot.org/28695 ) Change subject: mainboard/google/poppy/variants/rammus: Modify VR setting ...................................................................... Patch Set 2: (5 comments) Please follow the VRTT report from https://partnerissuetracker.corp.google.com/issues/112167318#comment14 https://review.coreboot.org/#/c/28695/2/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/rammus/devicetree.cb: https://review.coreboot.org/#/c/28695/2/src/mainboard/google/poppy/variants… PS2, Line 83: 14.9 14.4 https://review.coreboot.org/#/c/28695/2/src/mainboard/google/poppy/variants… PS2, Line 83: 4 4.2 https://review.coreboot.org/#/c/28695/2/src/mainboard/google/poppy/variants… PS2, Line 83: 4.57 4.47 https://review.coreboot.org/#/c/28695/2/src/mainboard/google/poppy/variants… PS2, Line 84: 4 4.17 https://review.coreboot.org/#/c/28695/2/src/mainboard/google/poppy/variants… PS2, Line 84: 14.2 14.0 -- To view, visit https://review.coreboot.org/28695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d83d835ec841ac4cc811a0a69f74d203d5ea173 Gerrit-Change-Number: 28695 Gerrit-PatchSet: 2 Gerrit-Owner: Statham Chu <statham_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Statham Chu <statham_chu(a)pegatron.corp-partner.google.com> Gerrit-CC: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-CC: Jerry Chou <jerry_chou(a)pegatron.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-CC: YanRu Chen <kane_chen(a)pegatron.corp-partner.google.com> Gerrit-Comment-Date: Fri, 21 Sep 2018 22:28:32 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: skylake, kabylake: Add support to set eMMC tuning param from dev tree
by Nick Vaccaro (Code Review) 21 Sep '18

21 Sep '18

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/28274 ) Change subject: skylake,kabylake: Add support to set eMMC tuning param from dev tree ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28274 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic71934dce9a1c380a057e579ca3fda41983b9385 Gerrit-Change-Number: 28274 Gerrit-PatchSet: 1 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 21 Sep 2018 20:57:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: amd/common/psp: Remove use of PspBaseLib
by build bot (Jenkins) (Code Review) 21 Sep '18

21 Sep '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27619 ) Change subject: amd/common/psp: Remove use of PspBaseLib ...................................................................... Patch Set 18: (2 comments) https://review.coreboot.org/#/c/27619/18/src/soc/amd/common/block/psp/psp.c File src/soc/amd/common/block/psp/psp.c: https://review.coreboot.org/#/c/27619/18/src/soc/amd/common/block/psp/psp.c… PS18, Line 70: pci_write_config32(SOC_PSP_DEV, PSP_PCI_EXT_HDR_CTRL, MAGIC_ENABLE_BITS); line over 80 characters https://review.coreboot.org/#/c/27619/18/src/soc/amd/common/block/psp/psp.c… PS18, Line 92: if (pci_read_config32(SOC_PSP_DEV, PSP_PCI_EXT_HDR_CTRL) & BAR3HIDEBIT) { line over 80 characters -- To view, visit https://review.coreboot.org/27619 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2740ceb945736c6e413f7d0bd0c41a19e19c7d5a Gerrit-Change-Number: 27619 Gerrit-PatchSet: 18 Gerrit-Owner: Charles Marslett <charles.marslett(a)amd.corp-partner.google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Charles Marslett <charles.marslett(a)amd.corp-partner.google.com> Gerrit-Reviewer: Charles Marslett <charles.marslett(a)silverbackltd.com> Gerrit-Reviewer: Marshall Dawson <marshall.dawson(a)se-eng.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Fri, 21 Sep 2018 17:42:46 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/octopus: Create ampton variant
by build bot (Jenkins) (Code Review) 21 Sep '18

21 Sep '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28663 ) Change subject: mb/google/octopus: Create ampton variant ...................................................................... Patch Set 8: (117 comments) https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… File src/mainboard/google/octopus/variants/ampton/gpio.c: https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 35: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_8, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_0_CLK_VNN */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 36: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_9, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_0_DATA0_VNN */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 37: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_10, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_0_DATA1_VNN */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 38: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_11, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_0_DATA2_VNN */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 39: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_12, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_0_DATA3_VNN */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 40: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_13, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_0_DATA4_VNN */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 41: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_14, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_0_DATA5_VNN */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 42: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_15, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_0_DATA6_VNN */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 43: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_16, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_0_DATA7_VNN */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 44: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_17, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DBG_PTI_CLK_1 */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 45: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_18, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DBG_PTI_DATA_8 */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 46: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_19, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DBG_PTI_DATA_9 */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 47: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_20, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DBG_PTI_DATA_10 */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 49: PAD_CFG_NF_IOSSTATE(GPIO_22, UP_20K, DEEP, NF2, TxDRxE), /* CNV_MFUART2_TXD */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 51: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_24, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_1_DATA6_VNN */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 52: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_25, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_1_DATA7_VNN */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 53: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_26, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_2_CLK_VNN */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 54: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_27, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_2_DATA0_VNN */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 55: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_28, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_2_DATA1_VNN 0*/ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 56: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_29, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_2_DATA2_VNN */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 57: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_30, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_2_DATA3_VNN */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 58: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_31, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_2_DATA4_VNN */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 59: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_32, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_2_DATA5_VNN */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 60: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_33, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_2_DATA6_VNN */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 61: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_34, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_2_DATA7_VNN */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 62: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_35, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_3_CLK_VNN */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 63: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_36, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_3_DATA0_VNN */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 64: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_37, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_3_DATA1_VNN */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 65: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_38, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_3_DATA2_VNN */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 70: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_43, DN_20K, DEEP, NF1, HIZCRx0, DISPUPD), /* GP_INTD_DSI_TE2 */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 71: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_44, UP_20K, DEEP, NF1, TxDRxE, ENPU), /* USB_OC0_B */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 72: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_45, UP_20K, DEEP, NF1, TxDRxE, ENPU), /* USB_OC1_B */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 79: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_50, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_I2C0_SDA */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 80: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_51, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_I2C0_SCL */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 81: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_52, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_I2C1_SDA */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 82: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_53, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_I2C1_SCL */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 85: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_56, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_I2C3_SDA */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 86: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_57, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_I2C2_SCL */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 89: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_60, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART0_RXD */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 90: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_61, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART0_TXD */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 92: PAD_CFG_GPI_APIC_IOS(GPIO_63, NONE, DEEP, LEVEL, INVERT, TxDRxE, DISPUPD), /* H1_PCH_INT_ODL */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 93: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_64, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART2_RXD */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 94: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_65, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD), /* LPSS_UART2_TXD */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 103: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_74, UP_20K, DEEP, NF1, TxDRxE, ENPU), /* THERMTRIP_B */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 104: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_75, NONE, DEEP, NF1, TxDRxE, DISPUPD), /* PROCHOT_B */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 106: PAD_CFG_GPI_APIC_IOS(GPIO_212, NONE, DEEP, LEVEL, INVERT, HIZCRx1, DISPUPD), /* Touch Panel Int */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 118: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_79, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* H1_SLAVE_SPI_CLK_R */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 119: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_80, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* H1_SLAVE_SPI_CS_L_R */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 120: PAD_CFG_GPIO_HI_Z(GPIO_81, UP_20K, DEEP, HIZCRx0, DISPUPD), /* GPIO_81_DEBUG (Boot halt) -- MIPI60 DEBUG */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 131: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_90, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_CS0_B */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 132: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_91, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD),/* FST_SPI_CS1_B -- SPK_PA_EN_R */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 133: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_92, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_MOSI_IO0 */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 134: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_93, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_MISO_IO1 */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 137: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_96, NATIVE, DEEP, NF1, HIZCRx0, SAME),/* FST_SPI_CLK */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 140: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_98, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* PMU_PLTRST_B */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 141: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_99, NONE, DEEP, NF1, TxDRxE, DISPUPD),/* PMU_PWRBTN_B */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 142: PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_100, NONE, DEEP, NF1),/* PMU_SLP_S0_B */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 143: PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_101, NONE, DEEP, NF1),/* PMU_SLP_S3_B */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 144: PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_102, NONE, DEEP, NF1),/* PMU_SLP_S4_B */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 147: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_105, 1, DEEP, NONE, Tx1RXDCRx0, DISPUPD),/* GPIO_105 -- TOUCHSCREEN_RST */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 148: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_106, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* PMU_BATLOW_B */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 149: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_107, NONE, DEEP, NF1, TxDRxE, DISPUPD),/* PMU_RESETBUTTON_B */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 151: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_109, 1, DEEP, NONE, Tx1RxDCRx1, DISPUPD),/* SUS_STAT_B -- BT_DISABLE_L */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 154: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_110, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* LPSS_I2C5_SDA */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 155: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_111, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* LPSS_I2C5_SCL */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 158: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_112, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* LPSS_I2C6_SDA */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 159: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_113, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* LPSS_I2C6_SCL */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 162: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_114, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* LPSS_I2C7_SDA */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 163: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_115, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* LPSS_I2C7_SCL */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 166: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_116, 1, DEEP, NONE, Tx1RxDCRx1, DISPUPD), /* PCIE_WAKE0_B -- WIFI_DISABLE_L */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 167: PAD_CFG_GPI_SCI_LOW(GPIO_117, NONE, DEEP, EDGE_SINGLE),/* PCIE_WAKE1_B -- LTE_WAKE_L */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 169: PAD_CFG_GPI_SCI_LOW(GPIO_119, NONE, DEEP, EDGE_SINGLE),/* PCIE_WAKE3_B */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 176: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_120, UP_20K, DEEP, NF1, HIZCRx1, ENPU),/* PCIE_CLKREQ0_B -- unused */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 177: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_121, UP_20K, DEEP, NF1, HIZCRx1, ENPU),/* PCIE_CLKREQ1_B -- unused */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 178: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_122, UP_20K, DEEP, NF1, HIZCRx1, ENPU),/* PCIE_CLKREQ2_B -- unused */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 179: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_123, NONE, DEEP, NF1, TxDRxE, DISPUPD), /* PCIE_CLKREQ3_B */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 188: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_128, NONE, DEEP, NF1, Tx0RxDCRx0, DISPUPD),/* PANEL0_VDDEN*/ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 189: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_129, NONE, DEEP, NF1, Tx0RxDCRx0, DISPUPD),/* PANEL0_BKLTEN */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 190: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_130, NONE, DEEP, NF1, Tx0RxDCRx0, DISPUPD),/* PANEL0_BKLTCTL */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 193: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_131, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* HV_DDI0_HPD */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 194: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_132, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* HV_DDI1_HPD */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 195: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_133, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* HV_EDP_HPD */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 198: PAD_CFG_GPI_APIC_IOS(GPIO_135, NONE, DEEP, LEVEL, INVERT, HIZCRx1, DISPUPD),/* GPIO_135 -- TRACKPAD_INT1_1V8_ODL */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 199: PAD_CFG_GPI_APIC_IOS(GPIO_136, NONE, DEEP, LEVEL, INVERT, TxDRxE, DISPUPD),/* GPIO_136 -- PMIC_PCH_INT_ODL */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 202: PAD_CFG_GPI_APIC_IOS(GPIO_138, NONE, DEEP, LEVEL, INVERT, HIZCRx1, DISPUPD),/* GPIO_138 -- PEN_PDCT_ODL */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 203: PAD_CFG_GPI_APIC_IOS(GPIO_139, NONE, DEEP, LEVEL, INVERT, HIZCRx1, DISPUPD),/* GPIO_139 -- PEN_INT_ODL */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 204: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_140, 0, DEEP, NONE, Tx1RXDCRx0, DISPUPD),/* GPIO_140 -- PEN_RESET */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 206: PAD_CFG_GPI_SCI_IOS(GPIO_141, NONE, DEEP, EDGE_SINGLE, INVERT, IGNORE, DISPUPD),/* GPIO_141 -- EC_PCH_WAKE_ODL */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 207: PAD_CFG_GPI_SCI_LOW(GPIO_142, NONE, DEEP, LEVEL),/* GPIO_142 -- TRACKPAD_INT2_1V8_ODL */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 211: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_146, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), /* EN_PP3300_TOUCHSCREEN */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 226: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_162, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* AVS_I2S1_BCLK */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 227: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_163, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* AVS_I2S1_WS_SYNC */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 229: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_165, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* AVS_I2S1_SDO */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 230: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_166, NONE, DEEP, NF2, HIZCRx0, DISPUPD), /* AVS_I2S2_BCLK */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 231: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_167, NONE, DEEP, NF2, HIZCRx0, DISPUPD), /* AVS_I2S2_WS_SYNC */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 232: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_168, NONE, DEEP, NF2, HIZCRx0, DISPUPD), /* AVS_I2S2_SDI */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 233: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_169, NONE, DEEP, NF2, HIZCRx0, DISPUPD), /* AVS_I2S2_SD0 */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 234: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_170, DN_20K, DEEP, NF2, HIZCRx0, DISPUPD), /* AVS_I2S1_MCLK */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 237: PAD_CFG_NF_IOSSTATE(GPIO_171, DN_20K, DEEP, NF1, HIZCRx0), /* AVS_M_CLK_A1 */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 238: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_172, DN_20K, DEEP, NF1, HIZCRx0, DISPUPD), /* AVS_M_CLK_B1 */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 239: PAD_CFG_NF_IOSSTATE(GPIO_173, DN_20K, DEEP, NF1, HIZCRx0), /* AVS_M_DATA_1 */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 241: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_175, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* AVS_M_DATA_2 */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 246: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 1, DEEP, NONE, Tx1RXDCRx0, DISPUPD), /* EN_PP3300_WLAN */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 265: PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_192, UP_20K, DEEP, NF1), /* CNV_BRI_RSP */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 267: PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_194, UP_20K, DEEP, NF1), /* CNV_RGI_RSP */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 268: PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_195, NONE, DEEP, NF1), /* CNV_RF_RESET_B */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 269: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_198, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* EMMC0_CLK */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 270: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_200, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* EMMC0_D0 */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 271: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_201, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* EMMC0_D1 */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 272: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_202, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* EMMC0_D2 */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 273: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_203, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* EMMC0_D3 */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 274: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_204, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* EMMC0_D4 */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 275: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_205, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* EMMC0_D5 */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 276: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_206, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* EMMC0_D6 */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 277: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_207, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* EMMC0_D7 */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 278: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_208, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* EMMC0_CMD */ line over 80 characters https://review.coreboot.org/#/c/28663/8/src/mainboard/google/octopus/varian… PS8, Line 279: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_209, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* EMMC0_STROBE */ line over 80 characters -- To view, visit https://review.coreboot.org/28663 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d6cf19c906df19115b1101e3d91c62f5f3f61e3 Gerrit-Change-Number: 28663 Gerrit-PatchSet: 8 Gerrit-Owner: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jett Rink <jettrink(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Fri, 21 Sep 2018 17:32:36 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/sifive/fu540: Remove PLL parameters from sdram.c
by Philipp Hug (Code Review) 21 Sep '18

21 Sep '18

Philipp Hug has posted comments on this change. ( https://review.coreboot.org/28710 ) Change subject: soc/sifive/fu540: Remove PLL parameters from sdram.c ...................................................................... Patch Set 1: Code-Review+1 Thanks! -- To view, visit https://review.coreboot.org/28710 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8060bd21e05765cedf7bdabc28052c32774f9ca1 Gerrit-Change-Number: 28710 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Comment-Date: Fri, 21 Sep 2018 15:56:29 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/sifive/fu540: Remove PLL parameters from sdram.c
by Jonathan Neuschäfer (Code Review) 21 Sep '18

21 Sep '18

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/28710 Change subject: soc/sifive/fu540: Remove PLL parameters from sdram.c ...................................................................... soc/sifive/fu540: Remove PLL parameters from sdram.c These parameters are not used and not necessary in sdram.c, because the DDR PLL is configured in clock.c. Change-Id: I8060bd21e05765cedf7bdabc28052c32774f9ca1 Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M src/soc/sifive/fu540/sdram.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/28710/1 diff --git a/src/soc/sifive/fu540/sdram.c b/src/soc/sifive/fu540/sdram.c index 6418b0d..bf549bf 100644 --- a/src/soc/sifive/fu540/sdram.c +++ b/src/soc/sifive/fu540/sdram.c @@ -25,8 +25,6 @@ #include "ddrregs.h" #define DDR_SIZE (8UL * 1024UL * 1024UL * 1024UL) -#define DDRCTLPLL_F 55 -#define DDRCTLPLL_Q 2 void sdram_init(void) { -- To view, visit https://review.coreboot.org/28710 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8060bd21e05765cedf7bdabc28052c32774f9ca1 Gerrit-Change-Number: 28710 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Change in coreboot[master]: Revert "mb/google/poppy/variants/nautilus: Set grip sensor threshold"
by Martin Roth (Code Review) 21 Sep '18

21 Sep '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28690 ) Change subject: Revert "mb/google/poppy/variants/nautilus: Set grip sensor threshold" ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/28690/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/28690/2//COMMIT_MSG@11 PS2, Line 11: Reason for revert: b:113303916 Please remember that this is an open source project and most people can't see this bug. A comment like this would be more appropriate: Use values from driver instead of hardcoding in firmware ( b:113303916) -- To view, visit https://review.coreboot.org/28690 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02d21803f38da227f1d85b00cb6b5274d81dbbb4 Gerrit-Change-Number: 28690 Gerrit-PatchSet: 2 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Enrico Granata <egranata(a)chromium.org> Gerrit-Reviewer: Enrico Granata <egranata(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 21 Sep 2018 14:26:10 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/denverton_ns/csme_ie_kt.c: Don't use device_t
by Martin Roth (Code Review) 21 Sep '18

21 Sep '18

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/28679 ) Change subject: soc/intel/denverton_ns/csme_ie_kt.c: Don't use device_t ...................................................................... soc/intel/denverton_ns/csme_ie_kt.c: Don't use device_t Use of device_t is deprecated. Change-Id: I9dde92314af8ef87a5acb550f0fb25b8ce875174 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/28679 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M src/soc/intel/denverton_ns/csme_ie_kt.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Jonathan Neuschäfer: Looks good to me, approved diff --git a/src/soc/intel/denverton_ns/csme_ie_kt.c b/src/soc/intel/denverton_ns/csme_ie_kt.c index 7de0976..5f90185 100644 --- a/src/soc/intel/denverton_ns/csme_ie_kt.c +++ b/src/soc/intel/denverton_ns/csme_ie_kt.c @@ -56,7 +56,7 @@ compact_resources(dev); } -static void pci_csme_ie_kt_read_resources(device_t dev) +static void pci_csme_ie_kt_read_resources(struct device *dev) { /** * CSME/IE KT has 2 BARs to check: -- To view, visit https://review.coreboot.org/28679 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9dde92314af8ef87a5acb550f0fb25b8ce875174 Gerrit-Change-Number: 28679 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

← Newer
1
...
25
26
27
28
29
30
31
...
89
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2018