coreboot-gerrit September 2018

coreboot-gerrit@coreboot.org

1 participants
886 discussions

Change in coreboot[master]: arch/riscv: Adjust compiler flags for scan-build
by Jonathan Neuschäfer (Code Review) 22 Sep '18

22 Sep '18

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/28713 Change subject: arch/riscv: Adjust compiler flags for scan-build ...................................................................... arch/riscv: Adjust compiler flags for scan-build Clang doesn't understand -march=riscv64imac and -mcmodel=medany, so don't use them when running the clang static analyzer. On the other hand, __riscv and __riscv_xlen need to be defined in order to select some macros in src/arch/riscv/include/arch/encoding.h. -mabi is moved -march for consistency. With this commit, scan-build produces a useful result on RISC-V. Change-Id: Ia2eb8c3c2f7eb5ddd47db24b8e5fcd6eaf6c5589 Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M src/arch/riscv/Makefile.inc 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/28713/1 diff --git a/src/arch/riscv/Makefile.inc b/src/arch/riscv/Makefile.inc index 50c1ae6..1728bfb 100644 --- a/src/arch/riscv/Makefile.inc +++ b/src/arch/riscv/Makefile.inc @@ -25,7 +25,12 @@ check-ramstage-overlap-regions += stack endif -riscv_flags = -I$(src)/arch/riscv/ -mcmodel=$(CONFIG_RISCV_CODEMODEL) -march=$(CONFIG_RISCV_ARCH) -mabi=$(CONFIG_RISCV_ABI) +riscv_flags = -I$(src)/arch/riscv/ +ifeq ($(CCC_ANALYZER_OUTPUT_FORMAT),) +riscv_flags += -march=$(CONFIG_RISCV_ARCH) -mabi=$(CONFIG_RISCV_ABI) -mcmodel=$(CONFIG_RISCV_CODEMODEL) +else +riscv_flags += -D__riscv -D__riscv_xlen=64 +endif riscv_asm_flags = -march=$(CONFIG_RISCV_ARCH) -mabi=$(CONFIG_RISCV_ABI) -- To view, visit https://review.coreboot.org/28713 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia2eb8c3c2f7eb5ddd47db24b8e5fcd6eaf6c5589 Gerrit-Change-Number: 28713 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Change in coreboot[master]: soc/intel/common/block: Don't use device_t
by Jonathan Neuschäfer (Code Review) 22 Sep '18

22 Sep '18

Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/28694 ) Change subject: soc/intel/common/block: Don't use device_t ...................................................................... Patch Set 2: Code-Review+2 Thanks -- To view, visit https://review.coreboot.org/28694 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id82059898844fbe20665250062b67652d6cc1f9e Gerrit-Change-Number: 28694 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 22 Sep 2018 10:00:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: amd/common/psp: Remove use of PspBaseLib
by build bot (Jenkins) (Code Review) 22 Sep '18

22 Sep '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27619 ) Change subject: amd/common/psp: Remove use of PspBaseLib ...................................................................... Patch Set 20: (3 comments) https://review.coreboot.org/#/c/27619/20/src/soc/amd/common/block/psp/psp.c File src/soc/amd/common/block/psp/psp.c: https://review.coreboot.org/#/c/27619/20/src/soc/amd/common/block/psp/psp.c… PS20, Line 78: } void function return statements are not generally useful https://review.coreboot.org/#/c/27619/20/src/soc/amd/common/block/psp/psp.c… PS20, Line 80: static uintptr_t get_psp_bar3_addr( void ) space prohibited after that open parenthesis '(' https://review.coreboot.org/#/c/27619/20/src/soc/amd/common/block/psp/psp.c… PS20, Line 80: static uintptr_t get_psp_bar3_addr( void ) space prohibited before that close parenthesis ')' -- To view, visit https://review.coreboot.org/27619 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2740ceb945736c6e413f7d0bd0c41a19e19c7d5a Gerrit-Change-Number: 27619 Gerrit-PatchSet: 20 Gerrit-Owner: Charles Marslett <charles.marslett(a)amd.corp-partner.google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Charles Marslett <charles.marslett(a)amd.corp-partner.google.com> Gerrit-Reviewer: Charles Marslett <charles.marslett(a)silverbackltd.com> Gerrit-Reviewer: Marshall Dawson <marshall.dawson(a)se-eng.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Sat, 22 Sep 2018 09:29:19 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/common/block: Don't use device_t
by Elyes HAOUAS (Code Review) 22 Sep '18

22 Sep '18

Hello Jonathan Neuschäfer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/28694 to look at the new patch set (#2). Change subject: soc/intel/common/block: Don't use device_t ...................................................................... soc/intel/common/block: Don't use device_t Use of device_t is deprecated. Change-Id: Id82059898844fbe20665250062b67652d6cc1f9e Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/intel/common/block/include/intelblocks/smihandler.h M src/soc/intel/common/block/smm/smihandler.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/28694/2 -- To view, visit https://review.coreboot.org/28694 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id82059898844fbe20665250062b67652d6cc1f9e Gerrit-Change-Number: 28694 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/common/block/smm/smihandler.c: Don't use device_t
by Elyes HAOUAS (Code Review) 22 Sep '18

22 Sep '18

Elyes HAOUAS has abandoned this change. ( https://review.coreboot.org/28678 ) Change subject: soc/intel/common/block/smm/smihandler.c: Don't use device_t ...................................................................... Abandoned see Change 28694. -- To view, visit https://review.coreboot.org/28678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I6679fc151c26607eaffdd4a8cdb3da8a1290fef7 Gerrit-Change-Number: 28678 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: skylake, kabylake: Add support to set eMMC tuning param from dev tree
by Duncan Laurie (Code Review) 22 Sep '18

22 Sep '18

Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/28274 ) Change subject: skylake,kabylake: Add support to set eMMC tuning param from dev tree ...................................................................... skylake,kabylake: Add support to set eMMC tuning param from dev tree Add support to set eMMC tuning params from the device tree so that it can be configured per board. BUG=b:112718426,b:112690628 BRANCH=none TEST=Build nocturne image and checked values passed in dev tree is set by FSP. Change-Id: Ic71934dce9a1c380a057e579ca3fda41983b9385 Signed-off-by: Pratik Prajapati <pratikkumar.v.prajapati(a)intel.com> Reviewed-on: https://review.coreboot.org/28274 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Lijian Zhao <lijian.zhao(a)intel.com> Reviewed-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Reviewed-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/soc/intel/skylake/chip.h M src/soc/intel/skylake/chip_fsp20.c 2 files changed, 12 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Philipp Deppenwiese: Looks good to me, but someone else must approve Lijian Zhao: Looks good to me, but someone else must approve Nick Vaccaro: Looks good to me, approved diff --git a/src/soc/intel/skylake/chip.h b/src/soc/intel/skylake/chip.h index 5bf3931..b1ffcb2 100644 --- a/src/soc/intel/skylake/chip.h +++ b/src/soc/intel/skylake/chip.h @@ -291,6 +291,9 @@ u8 ScsEmmcEnabled; u8 ScsEmmcHs400Enabled; u8 ScsSdCardEnabled; + u8 EmmcHs400DllNeed; + u8 ScsEmmcHs400RxStrobeDll1; + u8 ScsEmmcHs400TxDataDll; u8 PttSwitch; u8 HeciTimeouts; diff --git a/src/soc/intel/skylake/chip_fsp20.c b/src/soc/intel/skylake/chip_fsp20.c index d5f5433..c2c0745 100644 --- a/src/soc/intel/skylake/chip_fsp20.c +++ b/src/soc/intel/skylake/chip_fsp20.c @@ -336,6 +336,15 @@ params->ScsEmmcHs400Enabled = config->ScsEmmcHs400Enabled; params->ScsSdCardEnabled = config->ScsSdCardEnabled; + if (!!params->ScsEmmcHs400Enabled && !!config->EmmcHs400DllNeed) { + params->PchScsEmmcHs400DllDataValid = + !!config->EmmcHs400DllNeed; + params->PchScsEmmcHs400RxStrobeDll1 = + config->ScsEmmcHs400RxStrobeDll1; + params->PchScsEmmcHs400TxDataDll = + config->ScsEmmcHs400TxDataDll; + } + /* If ISH is enabled, enable ISH elements */ dev = dev_find_slot(0, PCH_DEVFN_ISH); if (dev) -- To view, visit https://review.coreboot.org/28274 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic71934dce9a1c380a057e579ca3fda41983b9385 Gerrit-Change-Number: 28274 Gerrit-PatchSet: 2 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/octopus: Close unused I2C bus 7 include SCL and SDA for Phaser
by build bot (Jenkins) (Code Review) 22 Sep '18

22 Sep '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28669 ) Change subject: mb/google/octopus: Close unused I2C bus 7 include SCL and SDA for Phaser ...................................................................... Patch Set 16: (1 comment) https://review.coreboot.org/#/c/28669/16/src/mainboard/google/octopus/varia… File src/mainboard/google/octopus/variants/phaser/gpio.c: https://review.coreboot.org/#/c/28669/16/src/mainboard/google/octopus/varia… PS16, Line 93: google_chromeec_cbi_get_sku_id(&sku_id); trailing whitespace -- To view, visit https://review.coreboot.org/28669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ad17761f2a053dc329bbec0a0a3284d47289666 Gerrit-Change-Number: 28669 Gerrit-PatchSet: 16 Gerrit-Owner: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jett Rink <jettrink(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Sat, 22 Sep 2018 00:40:59 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: vpd: Add support for reading BD addreses from the VPD
by Matthias Kaehlcke (Code Review) 21 Sep '18

21 Sep '18

Matthias Kaehlcke has posted comments on this change. ( https://review.coreboot.org/28711 ) Change subject: vpd: Add support for reading BD addreses from the VPD ...................................................................... Patch Set 1: Yeah, I was also surprised to find it spread over coreboot and depthcharge, took me a bit to figure out how things fit together. I agree the current mechanism is brittle and it would be preferable to have something more robust in a single place, if depthcharge has a VPD driver this seems feasible. I'll look into it and bother Julius with questions if needed ;-) -- To view, visit https://review.coreboot.org/28711 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib290fba2504f6ed80c3a95e24627ae5922e608af Gerrit-Change-Number: 28711 Gerrit-PatchSet: 1 Gerrit-Owner: Matthias Kaehlcke <mka(a)chromium.org> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Matthias Kaehlcke <mka(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 21 Sep 2018 23:51:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: vpd: Add support for reading BD addreses from the VPD
by Brian Norris (Code Review) 21 Sep '18

21 Sep '18

Brian Norris has posted comments on this change. ( https://review.coreboot.org/28711 ) Change subject: vpd: Add support for reading BD addreses from the VPD ...................................................................... Patch Set 1: FWIW, I had kinda assumed all the code for this was in depthcharge too. I guess I was wrong. But maybe it should be. -- To view, visit https://review.coreboot.org/28711 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib290fba2504f6ed80c3a95e24627ae5922e608af Gerrit-Change-Number: 28711 Gerrit-PatchSet: 1 Gerrit-Owner: Matthias Kaehlcke <mka(a)chromium.org> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Matthias Kaehlcke <mka(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 21 Sep 2018 23:45:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: vpd: Add support for reading BD addreses from the VPD
by Julius Werner (Code Review) 21 Sep '18

21 Sep '18

Julius Werner has posted comments on this change. ( https://review.coreboot.org/28711 ) Change subject: vpd: Add support for reading BD addreses from the VPD ...................................................................... Patch Set 1: Hmm... hmmm... how much of my yak would you be willing to shave? ;) I mean, we can take this, and it will work (you'll need a little depthcharge change as well, to call dt_set_mac_addresses()). But this code and the whole pass-MACs-through-coreboot-table mechanism is sort of deprecated, because we now have a VPD driver in depthcharge. You could really implement everything we need for this solely in depthcharge. (I've also never been a big fan of most of this code, honestly...) The other problem is that even though this can match multiple template strings, it was only ever used with one group per device. Cheza is the first one that will have both WiFi and Bluetooth MACs now, and for those this mechanism becomes very ugly. If you look at how it is matched (e.g. depthcharge/src/board/gale/board.c:mac_maps[]), things are only assigned by index, there is no matching back to the original VPD name. That means that you'll just have to happen to know that e.g. the first two MACs are WiFi MACs and the next three are Bluetooth MACs. It also means that an attacker with temporary root access can permanently hose your bluetooth by sneaking a couple of wifi_mac2, wifi_mac3 keys into your RW_VPD, in a way that recovery will not normally fix. I think it would be much better to design a new mechanism for Cheza that lives entirely within depthcharge and gets rid of all the weird design quirks of this legacy crap. I imagine something where you just do this in depthcharge/src/cheza/board.c: static const VpdDeviceTreeMap vpd_dt_map[] = { { "wifi_mac0", { "path_to", "WiFi_MAC0", "DTS_node", NULL } }, { "wifi_mac1", { "path_to", "WiFi_MAC1", "DTS_node", NULL } }, { "bluetooth_mac0", { "path_to", "BT_MAC0", "DTS_node", NULL } }, } static int board_setup(void) { ... install_vpd_dt_fixup(&vpd_dt_map, sizeof(vpd_dt_map)); ... } And then you have a fixup function that just looks up a single VPD entry directly (and you don't need all this "increase number to search for all entries" crap), runs depthcharge's vpd_gets() to find it, decode it and throw it in the DT if found. -- To view, visit https://review.coreboot.org/28711 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib290fba2504f6ed80c3a95e24627ae5922e608af Gerrit-Change-Number: 28711 Gerrit-PatchSet: 1 Gerrit-Owner: Matthias Kaehlcke <mka(a)chromium.org> Gerrit-Reviewer: Brian Norris <briannorris(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Matthias Kaehlcke <mka(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 21 Sep 2018 23:39:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

← Newer
1
...
24
25
26
27
28
29
30
...
89
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2018