coreboot-gerrit September 2018

coreboot-gerrit@coreboot.org

1 participants
886 discussions

Change in coreboot[master]: Revert "mb/google/poppy/variants/nautilus: Set grip sensor threshold"
by Furquan Shaikh (Code Review) 25 Sep '18

25 Sep '18

Furquan Shaikh has uploaded a new patch set (#3) to the change originally created by Seunghwan Kim. ( https://review.coreboot.org/28690 ) Change subject: Revert "mb/google/poppy/variants/nautilus: Set grip sensor threshold" ...................................................................... Revert "mb/google/poppy/variants/nautilus: Set grip sensor threshold" This reverts commit aef592d9b66aa18d83b0a211ead26013ff1f7d98. Reason for revert: Use values from driver instead of hardcoding in firmware (b:113303916) Change-Id: I02d21803f38da227f1d85b00cb6b5274d81dbbb4 Signed-off-by: Seunghwan Kim <sh_.kim(a)samsung.com> --- M src/mainboard/google/poppy/variants/nautilus/devicetree.cb 1 file changed, 0 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/28690/3 -- To view, visit https://review.coreboot.org/28690 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I02d21803f38da227f1d85b00cb6b5274d81dbbb4 Gerrit-Change-Number: 28690 Gerrit-PatchSet: 3 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Enrico Granata <egranata(a)chromium.org> Gerrit-Reviewer: Enrico Granata <egranata(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/cannonlake: Move the FSP related callbacks to separate files
by build bot (Jenkins) (Code Review) 25 Sep '18

25 Sep '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28661 ) Change subject: soc/intel/cannonlake: Move the FSP related callbacks to separate files ...................................................................... Patch Set 3: (2 comments) https://review.coreboot.org/#/c/28661/3/src/soc/intel/cannonlake/fsp_params… File src/soc/intel/cannonlake/fsp_params.c: https://review.coreboot.org/#/c/28661/3/src/soc/intel/cannonlake/fsp_params… PS3, Line 82: for (i = 0; i < ARRAY_SIZE(params->Usb2OverCurrentPin); i++) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/28661/3/src/soc/intel/cannonlake/fsp_params… PS3, Line 86: for (i = 0; i < ARRAY_SIZE(params->Usb3OverCurrentPin); i++) { braces {} are not necessary for single statement blocks -- To view, visit https://review.coreboot.org/28661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iffadc57f6986e688aa1bbe4e5444d105386ad92e Gerrit-Change-Number: 28661 Gerrit-PatchSet: 3 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 25 Sep 2018 04:14:23 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: payloads/tianocore: ignore whitespace change when applying patches
by Martin Roth (Code Review) 25 Sep '18

25 Sep '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/27616 ) Change subject: payloads/tianocore: ignore whitespace change when applying patches ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/27616 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38f7d46925cc00a2b5c5400e3fbf3579990f3fa5 Gerrit-Change-Number: 27616 Gerrit-PatchSet: 1 Gerrit-Owner: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel (1002088) Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 25 Sep 2018 03:04:44 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/kahlee/variants/liara: Disable NbP-state on Liara
by build bot (Jenkins) (Code Review) 25 Sep '18

25 Sep '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28726 ) Change subject: mb/google/kahlee/variants/liara: Disable NbP-state on Liara ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/#/c/28726/4/src/mainboard/google/kahlee/variant… File src/mainboard/google/kahlee/variants/baseboard/OemCustomize.c: https://review.coreboot.org/#/c/28726/4/src/mainboard/google/kahlee/variant… PS4, Line 161: InitEarly->PlatformConfig.PlatformProfile.NbPstatesSupported = FALSE; line over 80 characters -- To view, visit https://review.coreboot.org/28726 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec4f0355cb6eb1c2b0372e3d131cc5e6ba36635e Gerrit-Change-Number: 28726 Gerrit-PatchSet: 4 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 25 Sep 2018 02:00:28 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/octopus: Close unused I2C bus 7 include SCL and SDA for Phaser
by build bot (Jenkins) (Code Review) 25 Sep '18

25 Sep '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28669 ) Change subject: mb/google/octopus: Close unused I2C bus 7 include SCL and SDA for Phaser ...................................................................... Patch Set 19: (2 comments) https://review.coreboot.org/#/c/28669/19/src/mainboard/google/octopus/varia… File src/mainboard/google/octopus/variants/phaser/variant.c: https://review.coreboot.org/#/c/28669/19/src/mainboard/google/octopus/varia… PS19, Line 47: /* According to the sku id decide whether update touch trailing whitespace https://review.coreboot.org/#/c/28669/19/src/mainboard/google/octopus/varia… PS19, Line 65: /* Find all children on bus to trailing whitespace -- To view, visit https://review.coreboot.org/28669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ad17761f2a053dc329bbec0a0a3284d47289666 Gerrit-Change-Number: 28669 Gerrit-PatchSet: 19 Gerrit-Owner: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jett Rink <jettrink(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 25 Sep 2018 01:23:52 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/octopus: Close unused I2C bus 7 include SCL and SDA for Phaser
by build bot (Jenkins) (Code Review) 25 Sep '18

25 Sep '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28669 ) Change subject: mb/google/octopus: Close unused I2C bus 7 include SCL and SDA for Phaser ...................................................................... Patch Set 18: (4 comments) https://review.coreboot.org/#/c/28669/18/src/mainboard/google/octopus/varia… File src/mainboard/google/octopus/variants/phaser/variant.c: https://review.coreboot.org/#/c/28669/18/src/mainboard/google/octopus/varia… PS18, Line 47: /* According to the sku id decide whether update touch screen device information: line over 80 characters https://review.coreboot.org/#/c/28669/18/src/mainboard/google/octopus/varia… PS18, Line 49: * 2. sku id is other value then dev->enabled = 1. trailing whitespace https://review.coreboot.org/#/c/28669/18/src/mainboard/google/octopus/varia… PS18, Line 64: /* Find all children on bus to update touchscreen enable gpio. */ line over 80 characters https://review.coreboot.org/#/c/28669/18/src/mainboard/google/octopus/varia… PS18, Line 65: while ((child = dev_bus_each_child(children_bus, child)) != NULL) { line over 80 characters -- To view, visit https://review.coreboot.org/28669 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ad17761f2a053dc329bbec0a0a3284d47289666 Gerrit-Change-Number: 28669 Gerrit-PatchSet: 18 Gerrit-Owner: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jett Rink <jettrink(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Peichao Li <peichao.wang(a)bitland.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 25 Sep 2018 01:16:54 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/google/kahlee: Only read a single vendor from oem.bin
by Martin Roth (Code Review) 24 Sep '18

24 Sep '18

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/28729 Change subject: mainboard/google/kahlee: Only read a single vendor from oem.bin ...................................................................... mainboard/google/kahlee: Only read a single vendor from oem.bin Since each variant has a separate build, we don't need to support multiple manufacturers in a single file. BUG=b:79874904 TEST=Build, boot, see updated mainboard manufacturer Change-Id: I0ccf207ba8d5e5200aa4b19c46784bbda82f7b6e Signed-off-by: Martin Roth <martinroth(a)chromium.org> --- M src/mainboard/google/kahlee/variants/baseboard/mainboard.c 1 file changed, 5 insertions(+), 30 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/28729/1 diff --git a/src/mainboard/google/kahlee/variants/baseboard/mainboard.c b/src/mainboard/google/kahlee/variants/baseboard/mainboard.c index ad5fb2b..b963953 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/mainboard.c +++ b/src/mainboard/google/kahlee/variants/baseboard/mainboard.c @@ -76,26 +76,10 @@ write32((void *)(sdbar + BH720_MEM_ACCESS_EN), 0x80000000); } -static uint8_t calc_oem_id(void) -{ - return variant_board_sku() / 0x10; -} - -/* "oem.bin" in cbfs contains an array of records using the following structure. */ -struct oem_mapping { - uint8_t oem_id; - char oem_name[10]; -} __packed; - -/* Local buffer to read "oem.bin" */ -static char oem_bin_data[200]; const char *smbios_mainboard_manufacturer(void) { - uint8_t oem_id; - const struct oem_mapping *oem_entry = (void *)&oem_bin_data; - size_t oem_data_size; - unsigned int i, oem_entries_count; + static char oem_bin_data[10]; static const char *manuf; if (!IS_ENABLED(CONFIG_USE_OEM_BIN)) @@ -104,20 +88,11 @@ if (manuf) return manuf; - oem_data_size = cbfs_boot_load_file("oem.bin", oem_bin_data, + if (cbfs_boot_load_file("oem.bin", oem_bin_data, sizeof(oem_bin_data), - CBFS_TYPE_RAW); - oem_id = calc_oem_id(); - oem_entries_count = oem_data_size / sizeof(*oem_entry); - for (i = 0; i < oem_entries_count; i++) { - if (oem_id == oem_entry->oem_id) { - manuf = oem_entry->oem_name; - break; - } - oem_entry++; - } - - if (manuf == NULL) + CBFS_TYPE_RAW)) + manuf = &oem_bin_data[0]; + else manuf = CONFIG_MAINBOARD_SMBIOS_MANUFACTURER; return manuf; -- To view, visit https://review.coreboot.org/28729 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0ccf207ba8d5e5200aa4b19c46784bbda82f7b6e Gerrit-Change-Number: 28729 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: cpu/intel/model_206ax: detect number of MCE banks
by Dan Elkouby (Code Review) 24 Sep '18

24 Sep '18

Dan Elkouby has posted comments on this change. ( https://review.coreboot.org/28443 ) Change subject: cpu/intel/model_206ax: detect number of MCE banks ...................................................................... Patch Set 2: That sounds reasonable to me. -- To view, visit https://review.coreboot.org/28443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id05645009259fd77b4de49bde518361eeae46617 Gerrit-Change-Number: 28443 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Elkouby <streetwalkermc(a)gmail.com> Gerrit-Reviewer: Dan Elkouby <streetwalkermc(a)gmail.com> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 24 Sep 2018 19:56:02 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/kahlee/variants/liara: Disable NbP-state on Liara
by build bot (Jenkins) (Code Review) 24 Sep '18

24 Sep '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28726 ) Change subject: mb/google/kahlee/variants/liara: Disable NbP-state on Liara ...................................................................... Patch Set 3: (2 comments) https://review.coreboot.org/#/c/28726/3/src/mainboard/google/kahlee/variant… File src/mainboard/google/kahlee/variants/liara/OemCustomize.c: https://review.coreboot.org/#/c/28726/3/src/mainboard/google/kahlee/variant… PS3, Line 149: VOID OemCustomizeInitEarly(IN OUT AMD_EARLY_PARAMS *InitEarly) need consistent spacing around '*' (ctx:WxV) https://review.coreboot.org/#/c/28726/3/src/mainboard/google/kahlee/variant… PS3, Line 156: InitEarly->PlatformConfig.PlatformProfile.NbPstatesSupported = FALSE; line over 80 characters -- To view, visit https://review.coreboot.org/28726 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec4f0355cb6eb1c2b0372e3d131cc5e6ba36635e Gerrit-Change-Number: 28726 Gerrit-PatchSet: 3 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 24 Sep 2018 17:08:28 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: [for test]soc/intel/fsp_broadwell_de: Fix IA32_MC0_STATUS clear and I...
by Elyes HAOUAS (Code Review) 24 Sep '18

24 Sep '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/28727 Change subject: [for test]soc/intel/fsp_broadwell_de: Fix IA32_MC0_STATUS clear and IA32_MC0_CTL init ...................................................................... [for test]soc/intel/fsp_broadwell_de: Fix IA32_MC0_STATUS clear and IA32_MC0_CTL init Change-Id: I0c08844f3b9732195be65e8dc8a382df57c09bc1 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/intel/fsp_broadwell_de/cpu.c M src/soc/intel/fsp_broadwell_de/include/soc/msr.h 2 files changed, 10 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/28727/1 diff --git a/src/soc/intel/fsp_broadwell_de/cpu.c b/src/soc/intel/fsp_broadwell_de/cpu.c index a50c839..c11ccd3 100644 --- a/src/soc/intel/fsp_broadwell_de/cpu.c +++ b/src/soc/intel/fsp_broadwell_de/cpu.c @@ -128,11 +128,10 @@ static void configure_mca(void) { msr_t msr; - const unsigned int mcg_cap_msr = 0x179; int i; int num_banks; - msr = rdmsr(mcg_cap_msr); + msr = rdmsr(IA32_MCG_CAP); num_banks = msr.lo & 0xff; /* TODO(adurbin): This should only be done on a cold boot. Also, some @@ -140,14 +139,15 @@ every bank. */ msr.lo = msr.hi = 0; for (i = 0; i < num_banks; i++) { - wrmsr(MSR_IA32_MC0_STATUS + (i * 4) + 1, msr); - wrmsr(MSR_IA32_MC0_STATUS + (i * 4) + 2, msr); - wrmsr(MSR_IA32_MC0_STATUS + (i * 4) + 3, msr); + /* Clear the machine check status */ + wrmsr(IA32_MC0_STATUS + (i * 4), msr); } msr.lo = msr.hi = 0xffffffff; - for (i = 0; i < num_banks; i++) - wrmsr(MSR_IA32_MC0_STATUS + (i * 4), msr); + for (i = 0; i < num_banks; i++) { + /* Initialize machine checks */ + wrmsr(IA32_MC0_CTL + (i * 4), msr); + } } static void broadwell_de_core_init(struct device *cpu) diff --git a/src/soc/intel/fsp_broadwell_de/include/soc/msr.h b/src/soc/intel/fsp_broadwell_de/include/soc/msr.h index 6b87061..ffa33da 100644 --- a/src/soc/intel/fsp_broadwell_de/include/soc/msr.h +++ b/src/soc/intel/fsp_broadwell_de/include/soc/msr.h @@ -21,9 +21,11 @@ #define MSR_IA32_PLATFORM_ID 0x17 #define MSR_CORE_THREAD_COUNT 0x35 #define MSR_PLATFORM_INFO 0xce +#define IA32_MCG_CAP 0x179 #define IA32_PERF_CTL 0x199 #define MSR_TURBO_RATIO_LIMIT 0x1ad -#define MSR_IA32_MC0_STATUS 0x400 +#define IA32_MC0_CTL 0x400 +#define IA32_MC0_STATUS 0x401 #define MSR_PKG_POWER_SKU_UNIT 0x606 #define MSR_PKG_POWER_LIMIT 0x610 #define MSR_CONFIG_TDP_NOMINAL 0x648 -- To view, visit https://review.coreboot.org/28727 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0c08844f3b9732195be65e8dc8a382df57c09bc1 Gerrit-Change-Number: 28727 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

← Newer
1
...
20
21
22
23
24
25
26
...
89
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2018